131132 2014-04-02 15:12:12 -0700 [webkitpy] perf profiler does not understand --call-graph argument 2014-04-03 02:55:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego rego commit-queue glenn rniwa zan oldest_to_newest 996870 0 rego 2014-04-02 15:12:12 -0700 New version of perf profiler (3.13.6 in Debian testing) do not understand --call-graph argument. So when running perf-tests enabling the profiler you get the following error: callchain: Unknown --call-graph option value: --output usage: perf record [<options>] [<command>] or: perf record [<options>] -- <command> [<options>] --call-graph <mode[,dump_size]> setup and enables call-graph (stack chain/backtrace) recording: fp dwarf Using -g seems enough (from the manual): -g Enables call-graph (stack chain/backtrace) recording. 996871 1 228433 rego 2014-04-02 15:14:59 -0700 Created attachment 228433 Patch 997052 2 zan 2014-04-03 00:26:25 -0700 Looks OK. Ryosuke, can you please give this a look? 997084 3 228433 rniwa 2014-04-03 01:37:46 -0700 Comment on attachment 228433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228433&action=review > Tools/ChangeLog:8 > + New versions of perf profiler have changed the argument from --call-graph to -g. Should we check the version? Or is -g backward compatible? 997102 4 rego 2014-04-03 02:25:10 -0700 (In reply to comment #3) > (From update of attachment 228433 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228433&action=review > > > Tools/ChangeLog:8 > > + New versions of perf profiler have changed the argument from --call-graph to -g. > > Should we check the version? Or is -g backward compatible? -g has been there since a while ago, for example in previous versions you have: -g, --call-graph Do call-graph (stack chain/backtrace) recording. So I hope it doesn't cause any issue. 997111 5 228433 commit-queue 2014-04-03 02:55:26 -0700 Comment on attachment 228433 Patch Clearing flags on attachment: 228433 Committed r166711: <http://trac.webkit.org/changeset/166711> 997112 6 commit-queue 2014-04-03 02:55:29 -0700 All reviewed patches have been landed. Closing bug. 228433 2014-04-02 15:14:59 -0700 2014-04-03 02:55:26 -0700 Patch bug-131132-20140403001438.patch text/plain 2633 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU5OWZhOWZkYWY4ZWEzMmY1MmZjMTA2MWRhZWU4MDlk OGZmNTE4Yi4uZTdmNDFlODdjNTMzNTExM2Q5MTBmZWVkOTViMDQ5MWRlOGVhMWJlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTA0LTAyICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFt3ZWJraXRweV0gcGVyZiBwcm9maWxlciBkb2VzIG5vdCB1bmRlcnN0YW5k IC0tY2FsbC1ncmFwaCBhcmd1bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMxMTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTmV3IHZlcnNpb25zIG9mIHBlcmYgcHJvZmlsZXIgaGF2ZSBjaGFuZ2Vk IHRoZSBhcmd1bWVudCBmcm9tIC0tY2FsbC1ncmFwaCB0byAtZy4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wcm9maWxlci5weToKKyAgICAgICAgKFBlcmYud3Jh cHBlcl9hcmd1bWVudHMpOiBVc2UgLWcgaW5zdGVhZCBvZiAtLWNhbGwtZ3JhcGguCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0dGVzdC5weToKKyAgICAgICAgKERy aXZlclRlc3QudGVzdF9wcm9maWxlcl9hc193cmFwcGVyKTogVXBkYXRlIHRlc3QgYWNjb3JkaW5n bHkuCisKIDIwMTQtMDQtMDEgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIGxhc3QgcmVmZXJlbmNlIHRvIEdUSysgV0sxIEVX UwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3Byb2Zp bGVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3Byb2ZpbGVyLnB5 CmluZGV4IDljMDlmMDc4MzcwNzMwNGMyNjgzZGY0YTgwNDEzYzE0NzMxZjc5NDAuLjY5ZWYyMDUx MzBkYWNjOTMyNDFlNzFiMGQyZTJjYjhhYjJlNjgyNWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wcm9maWxlci5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcHJvZmlsZXIucHkKQEAgLTE0OCw3ICsxNDgsNyBAQCBj bGFzcyBQZXJmKFNpbmdsZUZpbGVPdXRwdXRQcm9maWxlcik6CiAgICAgICAgIHNlbGYuX3dhaXRf cHJvY2VzcyA9IHNlbGYuX2hvc3QuZXhlY3V0aXZlLnBvcGVuKFsid2FpdCIsICIlZCIgJSBwaWRd LCBzaGVsbD1UcnVlKQogCiAgICAgZGVmIHdyYXBwZXJfYXJndW1lbnRzKHNlbGYpOgotICAgICAg ICByZXR1cm4gW3NlbGYuX3BlcmZfcGF0aCgpLCAicmVjb3JkIiwgIi0tY2FsbC1ncmFwaCIsICIt LW91dHB1dCIsIHNlbGYuX291dHB1dF9wYXRoXQorICAgICAgICByZXR1cm4gW3NlbGYuX3BlcmZf cGF0aCgpLCAicmVjb3JkIiwgIi1nIiwgIi0tb3V0cHV0Iiwgc2VsZi5fb3V0cHV0X3BhdGhdCiAK ICAgICBkZWYgX2ZpcnN0X3Rlbl9saW5lc19vZl9wcm9maWxlKHNlbGYsIHBlcmZfb3V0cHV0KToK ICAgICAgICAgb3V0cHV0X2xpbmVzID0gcmUuZmluZGl0ZXIociJeKD86KCBbXlxuXSo/KVxzKlxu KSIsIHBlcmZfb3V0cHV0LCByZS5NVUxUSUxJTkUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvZHJpdmVyX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L2RyaXZlcl91bml0dGVzdC5weQppbmRleCA3ODdmMmRjZjUwOGE2NDNiZDg2M2Y0MmRl ZThjNzhkMjJmMWM0YmVmLi5iMmZjM2ZlNDZlYjA4NTE1MDZmMzU5NGQyN2VmNDk5ODIwMWExOTYz IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyX3VuaXR0ZXN0 LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXJfdW5pdHRlc3QucHkK QEAgLTEwMSw3ICsxMDEsNyBAQCBjbGFzcyBEcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK IAogICAgIGRlZiB0ZXN0X3Byb2ZpbGVyX2FzX3dyYXBwZXIoc2VsZik6CiAgICAgICAgIGRyaXZl ciA9IERyaXZlcihzZWxmLm1ha2VfcG9ydChNb2NrU3lzdGVtSG9zdChvc19uYW1lPSdsaW51eCcp LCBNb2NrT3B0aW9ucyhwcm9maWxlPVRydWUsIHByb2ZpbGVyPSdwZXJmJykpLCBOb25lLCBGYWxz ZSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChkcml2ZXIuX2NvbW1hbmRfd3JhcHBlcigpLCBb J3BlcmYnLCAncmVjb3JkJywgJy0tY2FsbC1ncmFwaCcsICctLW91dHB1dCcsICcvbW9jay1idWls ZC9sYXlvdXQtdGVzdC1yZXN1bHRzL3Rlc3QuZGF0YSddKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFsKGRyaXZlci5fY29tbWFuZF93cmFwcGVyKCksIFsncGVyZicsICdyZWNvcmQnLCAnLWcnLCAn LS1vdXRwdXQnLCAnL21vY2stYnVpbGQvbGF5b3V0LXRlc3QtcmVzdWx0cy90ZXN0LmRhdGEnXSkK IAogICAgIGRlZiB0ZXN0X3Rlc3RfdG9fdXJpKHNlbGYpOgogICAgICAgICBwb3J0ID0gc2VsZi5t YWtlX3BvcnQoKQo=