131129 2014-04-02 14:16:31 -0700 Refactor the function call generator to take the arguments by value 2014-04-02 14:28:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 996854 0 benjamin 2014-04-02 14:16:31 -0700 Refactor the function call generator to take the arguments by value 996855 1 228429 benjamin 2014-04-02 14:18:26 -0700 Created attachment 228429 Patch 996856 2 228429 kling 2014-04-02 14:22:51 -0700 Comment on attachment 228429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228429&action=review r=me > Source/WebCore/cssjit/RegisterAllocator.h:121 > +#error RegisterAllocator does not define the valid register for the current architecture. the valid register... range? 996860 3 benjamin 2014-04-02 14:28:02 -0700 Committed r166666: <http://trac.webkit.org/changeset/166666> 228429 2014-04-02 14:18:26 -0700 2014-04-02 14:22:51 -0700 Patch bug-131129-20140402141806.patch text/plain 7541 benjamin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjY2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA0LTAyICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWZhY3RvciB0aGUg ZnVuY3Rpb24gY2FsbCBnZW5lcmF0b3IgdG8gdGFrZSB0aGUgYXJndW1lbnRzIGJ5IHZhbHVlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzExMjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3RoaW5nIGZv cmNlcyB0aGUgcG9pbnRlZCBhZGRyZXNzIHRvIHN0YXkgYWxpdmUgYmV0d2VlbiBzZXRPbmVBcmd1 bWVudC9zZXRUd29Bcmd1bWVudHMKKyAgICAgICAgYW5kIHByZXBhcmVBbmRDYWxsLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyBGdW5jdGlvbkNhbGwgdG86CisgICAgICAgIC1LZWVwIHRo ZSByZWdpc3RlciBieSB2YWx1ZSBpbnN0ZWFkIG9mIHVzaW5nIHBvaW50ZXJzLgorICAgICAgICAt Q3Jhc2ggYXQgY29tcGlsZSB0aW1lIGlmIGEgcmVnaXN0ZXIgaXMgaW52YWxpZC4KKworICAgICAg ICAqIGNzc2ppdC9GdW5jdGlvbkNhbGwuaDoKKyAgICAgICAgKFdlYkNvcmU6OkZ1bmN0aW9uQ2Fs bDo6RnVuY3Rpb25DYWxsKToKKyAgICAgICAgKFdlYkNvcmU6OkZ1bmN0aW9uQ2FsbDo6c2V0T25l QXJndW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6RnVuY3Rpb25DYWxsOjpzZXRUd29Bcmd1bWVu dHMpOgorICAgICAgICAoV2ViQ29yZTo6RnVuY3Rpb25DYWxsOjpzd2FwQXJndW1lbnRzKToKKyAg ICAgICAgKFdlYkNvcmU6OkZ1bmN0aW9uQ2FsbDo6cHJlcGFyZUFuZENhbGwpOgorICAgICAgICAq IGNzc2ppdC9SZWdpc3RlckFsbG9jYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6UmVnaXN0ZXJB bGxvY2F0b3I6OmlzVmFsaWRSZWdpc3Rlcik6CisKIDIwMTQtMDQtMDIgIERhbmllbCBCYXRlcyAg PGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTZXR0aW5nczo6bWF4aW11bURl Y29kZWRJbWFnZVNpemUoKQpJbmRleDogU291cmNlL1dlYkNvcmUvY3Nzaml0L0Z1bmN0aW9uQ2Fs bC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzc2ppdC9GdW5jdGlvbkNhbGwuaAko cmV2aXNpb24gMTY2NjYxKQorKysgU291cmNlL1dlYkNvcmUvY3Nzaml0L0Z1bmN0aW9uQ2FsbC5o CSh3b3JraW5nIGNvcHkpCkBAIC00Miw4ICs0Miw5IEBAIHB1YmxpYzoKICAgICAgICAgLCBtX3Jl Z2lzdGVyQWxsb2NhdG9yKHJlZ2lzdGVyQWxsb2NhdG9yKQogICAgICAgICAsIG1fc3RhY2tBbGxv Y2F0b3Ioc3RhY2tBbGxvY2F0b3IpCiAgICAgICAgICwgbV9jYWxsUmVnaXN0cnkoY2FsbFJlZ2lz dHJ5KQotICAgICAgICAsIG1fZmlyc3RBcmd1bWVudChudWxscHRyKQotICAgICAgICAsIG1fc2Vj b25kQXJndW1lbnQobnVsbHB0cikKKyAgICAgICAgLCBtX2FyZ3VtZW50Q291bnQoMCkKKyAgICAg ICAgLCBtX2ZpcnN0QXJndW1lbnQoSW52YWxpZEdQUlJlZykKKyAgICAgICAgLCBtX3NlY29uZEFy Z3VtZW50KEludmFsaWRHUFJSZWcpCiAgICAgewogICAgIH0KIApAQCAtNTQsMTMgKzU1LDE1IEBA IHB1YmxpYzoKIAogICAgIHZvaWQgc2V0T25lQXJndW1lbnQoY29uc3QgSlNDOjpNYWNyb0Fzc2Vt Ymxlcjo6UmVnaXN0ZXJJRCYgcmVnaXN0ZXJJRCkKICAgICB7Ci0gICAgICAgIG1fZmlyc3RBcmd1 bWVudCA9ICZyZWdpc3RlcklEOworICAgICAgICBtX2FyZ3VtZW50Q291bnQgPSAxOworICAgICAg ICBtX2ZpcnN0QXJndW1lbnQgPSByZWdpc3RlcklEOwogICAgIH0KIAogICAgIHZvaWQgc2V0VHdv QXJndW1lbnRzKGNvbnN0IEpTQzo6TWFjcm9Bc3NlbWJsZXI6OlJlZ2lzdGVySUQmIGZpcnN0UmVn aXN0ZXJJRCwgY29uc3QgSlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCYgc2Vjb25kUmVn aXN0ZXJJRCkKICAgICB7Ci0gICAgICAgIG1fZmlyc3RBcmd1bWVudCA9ICZmaXJzdFJlZ2lzdGVy SUQ7Ci0gICAgICAgIG1fc2Vjb25kQXJndW1lbnQgPSAmc2Vjb25kUmVnaXN0ZXJJRDsKKyAgICAg ICAgbV9hcmd1bWVudENvdW50ID0gMjsKKyAgICAgICAgbV9maXJzdEFyZ3VtZW50ID0gZmlyc3RS ZWdpc3RlcklEOworICAgICAgICBtX3NlY29uZEFyZ3VtZW50ID0gc2Vjb25kUmVnaXN0ZXJJRDsK ICAgICB9CiAKICAgICB2b2lkIGNhbGwoKQpAQCAtODAsOCArODMsOCBAQCBwdWJsaWM6CiBwcml2 YXRlOgogICAgIHZvaWQgc3dhcEFyZ3VtZW50cygpCiAgICAgewotICAgICAgICBKU0M6Ok1hY3Jv QXNzZW1ibGVyOjpSZWdpc3RlcklEIGEgPSAqbV9maXJzdEFyZ3VtZW50OwotICAgICAgICBKU0M6 Ok1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklEIGIgPSAqbV9zZWNvbmRBcmd1bWVudDsKKyAgICAg ICAgSlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBhID0gbV9maXJzdEFyZ3VtZW50Owor ICAgICAgICBKU0M6Ok1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklEIGIgPSBtX3NlY29uZEFyZ3Vt ZW50OwogICAgICAgICAvLyB4ODYgY2FuIHN3YXAgd2l0aG91dCBhIHRlbXBvcmFyeSByZWdpc3Rl ci4gT24gb3RoZXIgYXJjaGl0ZWN0dXJlcywgd2UgbmVlZCBhbGxvY2F0ZSBhIHRlbXBvcmFyeSBy ZWdpc3RlciB0byBzd2l0Y2ggdGhlIHZhbHVlcy4KICNpZiBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0 KQogICAgICAgICBtX2Fzc2VtYmxlci5zd2FwKGEsIGIpOwpAQCAtMTE3LDMxICsxMjAsMzcgQEAg cHJpdmF0ZToKICAgICAgICAgc2F2ZUFsbG9jYXRlZFJlZ2lzdGVycygpOwogICAgICAgICBtX3N0 YWNrQWxsb2NhdG9yLmFsaWduU3RhY2tQcmVGdW5jdGlvbkNhbGwoKTsKIAotICAgICAgICBpZiAo bV9zZWNvbmRBcmd1bWVudCkgewotICAgICAgICAgICAgaWYgKCptX2ZpcnN0QXJndW1lbnQgIT0g SlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjApIHsKKyAgICAgICAgaWYgKG1fYXJndW1lbnRDb3Vu dCA9PSAyKSB7CisgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChSZWdpc3RlckFsbG9jYXRvcjo6 aXNWYWxpZFJlZ2lzdGVyKG1fZmlyc3RBcmd1bWVudCkpOworICAgICAgICAgICAgUkVMRUFTRV9B U1NFUlQoUmVnaXN0ZXJBbGxvY2F0b3I6OmlzVmFsaWRSZWdpc3RlcihtX3NlY29uZEFyZ3VtZW50 KSk7CisKKyAgICAgICAgICAgIGlmIChtX2ZpcnN0QXJndW1lbnQgIT0gSlNDOjpHUFJJbmZvOjph cmd1bWVudEdQUjApIHsKICAgICAgICAgICAgICAgICAvLyBJZiBmaXJzdEFyZ3VtZW50IGlzIG5v dCBpbiBhcmd1bWVudEdQUjAsIHdlIG5lZWQgdG8gaGFuZGxlIHBvdGVudGlhbCBjb25mbGljdHM6 CiAgICAgICAgICAgICAgICAgLy8gLWlmIHNlY29uZEFyZ3VtZW50IGFuZCBmaXJzdEFyZ3VtZW50 IGFyZSBpbiBpbnZlcnN0ZWQgcmVnaXN0ZXJzLCBqdXN0IHN3YXAgdGhlIHZhbHVlcy4KICAgICAg ICAgICAgICAgICAvLyAtaWYgc2Vjb25kQXJndW1lbnQgaXMgaW4gYXJndW1lbnRHUFIwIGJ1dCBm aXJzdEFyZ3VtZW50IGlzIG5vdCB0YWtpbmcgYXJndW1lbnRHUFIxLCB3ZSBjYW4gbW92ZSBpbiBv cmRlciBzZWNvbmRBcmd1bWVudC0+YXJndW1lbnRHUFIxLCBmaXJzdEFyZ3VtZW50LT5hcmd1bWVu dEdQUjAKICAgICAgICAgICAgICAgICAvLyAtaWYgc2Vjb25kQXJndW1lbnQgZG9lcyBub3QgdGFr ZSBhcmd1bWVudEdQUjAsIGZpcnN0QXJndW1lbnQgYW5kIHNlY29uZEFyZ3VtZW50IGNhbiBiZSBt b3ZlZCBzYWZlbHkgdG8gZGVzdGluYXRpb24uCi0gICAgICAgICAgICAgICAgaWYgKCptX3NlY29u ZEFyZ3VtZW50ID09IEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIwKSB7Ci0gICAgICAgICAgICAg ICAgICAgIGlmICgqbV9maXJzdEFyZ3VtZW50ID09IEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIx KQorICAgICAgICAgICAgICAgIGlmIChtX3NlY29uZEFyZ3VtZW50ID09IEpTQzo6R1BSSW5mbzo6 YXJndW1lbnRHUFIwKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChtX2ZpcnN0QXJndW1lbnQg PT0gSlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjEpCiAgICAgICAgICAgICAgICAgICAgICAgICBz d2FwQXJndW1lbnRzKCk7CiAgICAgICAgICAgICAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg ICAgICAgICAgICAgbV9hc3NlbWJsZXIubW92ZShKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BSMCwg SlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjEpOwotICAgICAgICAgICAgICAgICAgICAgICAgbV9h c3NlbWJsZXIubW92ZSgqbV9maXJzdEFyZ3VtZW50LCBKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BS MCk7CisgICAgICAgICAgICAgICAgICAgICAgICBtX2Fzc2VtYmxlci5tb3ZlKG1fZmlyc3RBcmd1 bWVudCwgSlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjApOwogICAgICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgbV9hc3NlbWJs ZXIubW92ZSgqbV9maXJzdEFyZ3VtZW50LCBKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BSMCk7Ci0g ICAgICAgICAgICAgICAgICAgIGlmICgqbV9zZWNvbmRBcmd1bWVudCAhPSBKU0M6OkdQUkluZm86 OmFyZ3VtZW50R1BSMSkKLSAgICAgICAgICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLm1vdmUo Km1fc2Vjb25kQXJndW1lbnQsIEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIxKTsKKyAgICAgICAg ICAgICAgICAgICAgbV9hc3NlbWJsZXIubW92ZShtX2ZpcnN0QXJndW1lbnQsIEpTQzo6R1BSSW5m bzo6YXJndW1lbnRHUFIwKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKG1fc2Vjb25kQXJndW1l bnQgIT0gSlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjEpCisgICAgICAgICAgICAgICAgICAgICAg ICBtX2Fzc2VtYmxlci5tb3ZlKG1fc2Vjb25kQXJndW1lbnQsIEpTQzo6R1BSSW5mbzo6YXJndW1l bnRHUFIxKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAg ICAgICAgICAgIC8vIFdlIGtub3cgZmlyc3RBcmd1bWVudCBpcyBhbHJlYWR5IGluIHBsYWNlLCB3 ZSBjYW4gc2FmZWx5IG1vdmUgc2Vjb25kQXJndW1lbnQuCi0gICAgICAgICAgICAgICAgaWYgKCpt X3NlY29uZEFyZ3VtZW50ICE9IEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIxKQotICAgICAgICAg ICAgICAgICAgICBtX2Fzc2VtYmxlci5tb3ZlKCptX3NlY29uZEFyZ3VtZW50LCBKU0M6OkdQUklu Zm86OmFyZ3VtZW50R1BSMSk7CisgICAgICAgICAgICAgICAgaWYgKG1fc2Vjb25kQXJndW1lbnQg IT0gSlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjEpCisgICAgICAgICAgICAgICAgICAgIG1fYXNz ZW1ibGVyLm1vdmUobV9zZWNvbmRBcmd1bWVudCwgSlNDOjpHUFJJbmZvOjphcmd1bWVudEdQUjEp OwogICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2UgaWYgKG1fZmlyc3RBcmd1bWVudCAmJiAq bV9maXJzdEFyZ3VtZW50ICE9IEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIwKQotICAgICAgICAg ICAgbV9hc3NlbWJsZXIubW92ZSgqbV9maXJzdEFyZ3VtZW50LCBKU0M6OkdQUkluZm86OmFyZ3Vt ZW50R1BSMCk7CisgICAgICAgIH0gZWxzZSBpZiAobV9hcmd1bWVudENvdW50ID09IDEpIHsKKyAg ICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKFJlZ2lzdGVyQWxsb2NhdG9yOjppc1ZhbGlkUmVnaXN0 ZXIobV9maXJzdEFyZ3VtZW50KSk7CisgICAgICAgICAgICBpZiAobV9maXJzdEFyZ3VtZW50ICE9 IEpTQzo6R1BSSW5mbzo6YXJndW1lbnRHUFIwKQorICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVy Lm1vdmUobV9maXJzdEFyZ3VtZW50LCBKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAg ICAgIH0KIAogICAgICAgICBKU0M6Ok1hY3JvQXNzZW1ibGVyOjpDYWxsIGNhbGwgPSBtX2Fzc2Vt Ymxlci5jYWxsKCk7CiAgICAgICAgIG1fY2FsbFJlZ2lzdHJ5LmFwcGVuZChzdGQ6Om1ha2VfcGFp cihjYWxsLCBtX2Z1bmN0aW9uQWRkcmVzcykpOwpAQCAtMTgxLDggKzE5MCw5IEBAIHByaXZhdGU6 CiAgICAgVmVjdG9yPFN0YWNrQWxsb2NhdG9yOjpTdGFja1JlZmVyZW5jZT4gbV9zYXZlZFJlZ2lz dGVyU3RhY2tSZWZlcmVuY2VzOwogCiAgICAgSlNDOjpGdW5jdGlvblB0ciBtX2Z1bmN0aW9uQWRk cmVzczsKLSAgICBjb25zdCBKU0M6Ok1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklEKiBtX2ZpcnN0 QXJndW1lbnQ7Ci0gICAgY29uc3QgSlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCogbV9z ZWNvbmRBcmd1bWVudDsKKyAgICB1bnNpZ25lZCBtX2FyZ3VtZW50Q291bnQ7CisgICAgSlNDOjpN YWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBtX2ZpcnN0QXJndW1lbnQ7CisgICAgSlNDOjpNYWNy b0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBtX3NlY29uZEFyZ3VtZW50OwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvY3Nzaml0L1JlZ2lzdGVyQWxsb2Nh dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3Nzaml0L1JlZ2lzdGVyQWxsb2Nh dG9yLmgJKHJldmlzaW9uIDE2NjY2MSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzc2ppdC9SZWdpc3Rl ckFsbG9jYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTMsNiArMTEzLDE1IEBAIHB1YmxpYzoK IAogICAgIGNvbnN0IFZlY3RvcjxKU0M6Ok1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklELCByZWdp c3RlckNvdW50PiYgYWxsb2NhdGVkUmVnaXN0ZXJzKCkgY29uc3QgeyByZXR1cm4gbV9hbGxvY2F0 ZWRSZWdpc3RlcnM7IH0KIAorICAgIHN0YXRpYyBib29sIGlzVmFsaWRSZWdpc3RlcihKU0M6Ok1h Y3JvQXNzZW1ibGVyOjpSZWdpc3RlcklEIHJlZ2lzdGVySUQpCisgICAgeworI2lmIENQVShYODZf NjQpCisgICAgICAgIHJldHVybiByZWdpc3RlcklEID49IEpTQzo6WDg2UmVnaXN0ZXJzOjplYXgg JiYgcmVnaXN0ZXJJRCA8PSBKU0M6Olg4NlJlZ2lzdGVyczo6cjE1OworI2Vsc2UKKyNlcnJvciBS ZWdpc3RlckFsbG9jYXRvciBkb2VzIG5vdCBkZWZpbmUgdGhlIHZhbGlkIHJlZ2lzdGVyIGZvciB0 aGUgY3VycmVudCBhcmNoaXRlY3R1cmUuCisjZW5kaWYKKyAgICB9CisKIHByaXZhdGU6CiAgICAg SGFzaFNldDx1bnNpZ25lZCwgRGVmYXVsdEhhc2g8dW5zaWduZWQ+OjpIYXNoLCBXVEY6OlVuc2ln bmVkV2l0aFplcm9LZXlIYXNoVHJhaXRzPHVuc2lnbmVkPj4gbV9yZWdpc3RlcnM7CiAgICAgVmVj dG9yPEpTQzo6TWFjcm9Bc3NlbWJsZXI6OlJlZ2lzdGVySUQsIHJlZ2lzdGVyQ291bnQ+IG1fYWxs b2NhdGVkUmVnaXN0ZXJzOwo=