131125 2014-04-02 13:55:00 -0700 [iOS] Expose geolocation provider on the process pool 2014-04-02 16:43:37 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 996833 0 dino 2014-04-02 13:55:00 -0700 WKProcessPool does not expose a WKGeolocationProviderIOS, which means the WKContentView never triggers the policy request. <rdar://problem/16101582> 996836 1 228426 dino 2014-04-02 13:58:31 -0700 Created attachment 228426 Patch 996838 2 dino 2014-04-02 14:00:20 -0700 Committed r166663: <http://trac.webkit.org/changeset/166663> 996901 3 dino 2014-04-02 16:24:28 -0700 Reopening to attach new patch. 996902 4 228442 dino 2014-04-02 16:24:32 -0700 Created attachment 228442 Patch 996909 5 228442 mitz 2014-04-02 16:33:33 -0700 Comment on attachment 228442 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228442&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolInternal.h:57 > +@interface WKProcessPool () > @property(readonly) WKGeolocationProviderIOS *_geolocationProvider; I think this can just go into the existing class extension up the file (guarded with TARGET_OS_IPHONE). 996910 6 dino 2014-04-02 16:43:26 -0700 Followup commit r166677 228426 2014-04-02 13:58:31 -0700 2014-04-02 16:24:20 -0700 Patch bug-131125-20140403075810.patch text/plain 4328 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzNkMWRhNDI0ODhiMTlm NjA1NWNkNmQ4MDQzMjlmZTRjNGNlYzRjNy4uNzA0NzIzNjE1MGZiOWNkZjgxMTUzYjFlYWRmMjQz ZGQwNWU1NmE2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBFeHBvc2UgZ2VvbG9j YXRpb24gcHJvdmlkZXIgb24gdGhlIHByb2Nlc3MgcG9vbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTI1CisKKyAgICAgICAgUGF0Y2ggYnkgU2Ft IFdlaW5pZy4KKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBKYWNrc29uLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tOgorICAgICAgICAoLVtXS1Byb2Nl c3NQb29sIF9nZW9sb2NhdGlvblByb3ZpZGVyXSk6IENyZWF0ZSBhbmQgaW5pdGlhbGl6ZSBXS0dl b2xvY2F0aW9uUHJvdmlkZXJJT1MgaWYgbmVjZXNzYXJ5LgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQ29jb2EvV0tQcm9jZXNzUG9vbEludGVybmFsLmg6IEV4cG9zZSBfZ2VvbG9jYXRpb25Qcm92 aWRlci4KKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgX2RlY2lkZVBvbGljeUZvckdlb2xvY2F0aW9uUmVxdWVzdEZyb21P cmlnaW46ZnJhbWU6cmVxdWVzdDpdKTogQ2FsbCBpbnRvIFdLUHJvY2Vzc1Bvb2wuCisKIDIwMTQt MDMtMzEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBX RUJfQU5JTUFUSU9OUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1Byb2Nlc3NQb29sLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1Byb2Nlc3NQb29sLm1tCmluZGV4IDliYTQ3MThhNzMzNTk1NzNiODFkZDk4ZDJhNzg4ODU3 NDExNDBlMjMuLjk4ZDMzMzQzMzU5ZGY3NjYxMDg2NzQ2MjVhYThjNjZmZDA4MjIzMTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wu bW0KQEAgLTQ1LDYgKzQ1LDcgQEAKIAogI2lmIFBMQVRGT1JNKElPUykKICNpbXBvcnQgPFdlYkNv cmUvV2ViQ29yZVRocmVhZFN5c3RlbUludGVyZmFjZS5oPgorI2ltcG9ydCAiV0tHZW9sb2NhdGlv blByb3ZpZGVySU9TLmgiCiAjZW5kaWYKIAogI2lmIF9faGFzX2luY2x1ZGUoPENGTmV0d29yay9D Rk5TVVJMQ29ubmVjdGlvbi5oPikKQEAgLTYzLDYgKzY0LDEwIEBAIGVudW0gOiBOU1VJbnRlZ2Vy IHsKIAogQGltcGxlbWVudGF0aW9uIFdLUHJvY2Vzc1Bvb2wgewogICAgIFdlYktpdDo6V2Vha09i akNQdHI8aWQgPF9XS0Rvd25sb2FkRGVsZWdhdGU+PiBfZG93bmxvYWREZWxlZ2F0ZTsKKworI2lm IFBMQVRGT1JNKElPUykKKyAgICBSZXRhaW5QdHI8V0tHZW9sb2NhdGlvblByb3ZpZGVySU9TPiBf Z2VvbG9jYXRpb25Qcm92aWRlcjsKKyNlbmRpZiAvLyBQTEFURk9STShJT1MpCiB9CiAKIC0gKGlu c3RhbmNldHlwZSlpbml0CkBAIC0xOTEsNCArMTk2LDE3IEBAIHN0YXRpYyBXZWJLaXQ6OkhUVFBD b29raWVBY2NlcHRQb2xpY3kgdG9IVFRQQ29va2llQWNjZXB0UG9saWN5KE5TSFRUUENvb2tpZUFj Y2VwCiAKIEBlbmQKIAorI2lmIFBMQVRGT1JNKElPUykKK0BpbXBsZW1lbnRhdGlvbiBXS1Byb2Nl c3NQb29sIChXS0ludGVybmFsKQorCistIChXS0dlb2xvY2F0aW9uUHJvdmlkZXJJT1MgKilfZ2Vv bG9jYXRpb25Qcm92aWRlcgoreworICAgIGlmICghX2dlb2xvY2F0aW9uUHJvdmlkZXIpCisgICAg ICAgIF9nZW9sb2NhdGlvblByb3ZpZGVyID0gYWRvcHROUyhbW1dLR2VvbG9jYXRpb25Qcm92aWRl cklPUyBhbGxvY10gaW5pdFdpdGhDb250ZXh0Ol9jb250ZXh0LmdldCgpXSk7CisgICAgcmV0dXJu IF9nZW9sb2NhdGlvblByb3ZpZGVyLmdldCgpOworfQorCitAZW5kCisjZW5kaWYgLy8gUExBVEZP Uk0oSU9TKQorCiAjZW5kaWYgLy8gV0tfQVBJX0VOQUJMRUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbEludGVybmFsLmggYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2xJbnRlcm5hbC5oCmlu ZGV4IGU2OWY2ZWI5NzFiOGRiOTk3MzQ5YzI5MjA2Mzc5ODA2MjUzODYwYmUuLjFmMzRhMTA4MGMx ZTA3MjI2ZjM2Yjk0NmQ2Zjc1N2Q0YWVkNDg3ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbEludGVybmFsLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sSW50ZXJuYWwuaApAQCAt MzAsNiArMzAsMTAgQEAKICNpbXBvcnQgIldLT2JqZWN0LmgiCiAjaW1wb3J0ICJXZWJDb250ZXh0 LmgiCiAKKyNpZiBUQVJHRVRfT1NfSVBIT05FCitAY2xhc3MgV0tHZW9sb2NhdGlvblByb3ZpZGVy SU9TOworI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBpbmxpbmUgV0tQcm9jZXNzUG9v bCAqd3JhcHBlcihXZWJDb250ZXh0JiBjb250ZXh0KQpAQCAtNDgsNCArNTIsMTAgQEAgaW5saW5l IFdLUHJvY2Vzc1Bvb2wgKndyYXBwZXIoV2ViQ29udGV4dCYgY29udGV4dCkKIH0KIEBlbmQKIAor I2lmIFRBUkdFVF9PU19JUEhPTkUKK0BpbnRlcmZhY2UgV0tQcm9jZXNzUG9vbCAoV0tJbnRlcm5h bCkKK0Bwcm9wZXJ0eShyZWFkb25seSkgV0tHZW9sb2NhdGlvblByb3ZpZGVySU9TICpfZ2VvbG9j YXRpb25Qcm92aWRlcjsKK0BlbmQKKyNlbmRpZgorCiAjZW5kaWYgLy8gV0tfQVBJX0VOQUJMRUQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5t bSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQppbmRleCBl NTE5ZTZkNjkxNjYzZjNkMjU1YTFkNzg3MGZlOGU1ZGI0NDQ5MDhhLi5lN2FiM2VhMTkwM2Q0MzVm ZjZiZTY3YTgxNGRkZjkwZWQ0YTdkOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3Lm1tCkBAIC00NDQsOSArNDQ0LDcgQEAgc3RhdGljIGlubGluZSBG bG9hdFJlY3QgZml4ZWRQb3NpdGlvblJlY3RGcm9tRXhwb3NlZFJlY3QoQ0dSZWN0IHVub2JzY3Vy ZWRSZWN0LAogCiAtICh2b2lkKV9kZWNpZGVQb2xpY3lGb3JHZW9sb2NhdGlvblJlcXVlc3RGcm9t T3JpZ2luOihXZWJTZWN1cml0eU9yaWdpbiYpb3JpZ2luIGZyYW1lOihXZWJGcmFtZVByb3h5Jilm cmFtZSByZXF1ZXN0OihHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0UHJveHkmKXBlcm1pc3Np b25SZXF1ZXN0CiB7Ci0gICAgLy8gRklYTUU6IFRoZSBsaW5lIGJlbG93IGlzIGNvbW1lbnRlZCBv dXQgc2luY2Ugd3JhcHBlcihXZWJDb250ZXh0Jikgbm93IHJldHVybnMgYSBXS1Byb2Nlc3NQb29s LgotICAgIC8vIEFzIHBhcnQgb2YgdGhlIG5ldyBBUEkgd2Ugc2hvdWxkIGZpZ3VyZSBvdXQgd2hl cmUgZ2VvbG9jYXRpb24gZml0cyBpbiwgc2VlIDxyZGFyOi8vcHJvYmxlbS8xNTg4NTU0ND4uCi0g ICAgLy8gW1t3cmFwcGVyKF9wYWdlLT5wcm9jZXNzKCkuY29udGV4dCgpKSBfZ2VvbG9jYXRpb25Q cm92aWRlcl0gZGVjaWRlUG9saWN5Rm9yR2VvbG9jYXRpb25SZXF1ZXN0RnJvbU9yaWdpbjp0b0FQ SSgmb3JpZ2luKSBmcmFtZTp0b0FQSSgmZnJhbWUpIHJlcXVlc3Q6dG9BUEkoJnBlcm1pc3Npb25S ZXF1ZXN0KSB3aW5kb3c6W3NlbGYgd2luZG93XV07CisgICAgW1t3cmFwcGVyKF9wYWdlLT5wcm9j ZXNzKCkuY29udGV4dCgpKSBfZ2VvbG9jYXRpb25Qcm92aWRlcl0gZGVjaWRlUG9saWN5Rm9yR2Vv bG9jYXRpb25SZXF1ZXN0RnJvbU9yaWdpbjp0b0FQSSgmb3JpZ2luKSBmcmFtZTp0b0FQSSgmZnJh bWUpIHJlcXVlc3Q6dG9BUEkoJnBlcm1pc3Npb25SZXF1ZXN0KSB3aW5kb3c6W3NlbGYgd2luZG93 XV07CiB9CiAKIC0gKFJldGFpblB0cjxDR0ltYWdlUmVmPilfdGFrZVZpZXdTbmFwc2hvdAo= 228442 2014-04-02 16:24:32 -0700 2014-04-02 16:33:33 -0700 Patch bug-131125-20140403102410.patch text/plain 2662 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmVkMzkxOTA0OTVlY2Y3 ZTExMWNiNDA3ZDYwNGFkMGIyMDdkOWFjYS4uYmU5ZTdhNjQ0Yjc3MWZjZTgyODY1NWQ5ODZjNTgw NDU4ZjljMjkxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBFeHBvc2UgZ2VvbG9j YXRpb24gcHJvdmlkZXIgb24gdGhlIHByb2Nlc3MgcG9vbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9sbG93dXAgY29tbWVudHMgZnJvbSBEYW4gQmVy bnN0ZWluLiBVc2UgYSBjbGFzcworICAgICAgICBleHRlbnNpb24gcmF0aGVyIHRoYW4gYSBuZXcg Y2F0ZWdvcnkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wu bW06CisgICAgICAgICgtW1dLUHJvY2Vzc1Bvb2wgX2dlb2xvY2F0aW9uUHJvdmlkZXJdKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2xJbnRlcm5hbC5oOgorCiAy MDE0LTA0LTAyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAg ICAgRG9jdW1lbnQgV0tVSURlbGVnYXRlIGFuZCBXS1dpbmRvd0ZlYXR1cmVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0gYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0KaW5kZXgg OThkMzMzNDMzNTlkZjc2NjEwODY3NDYyNWFhOGM2NmZkMDgyMjMxMC4uNDIwODY4NzNiZGQ2NDcz YjNkOTUxMjJkMTljMDhjYzI5ZDhlYTUyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbQpAQCAtOTcsNiArOTcsMTUgQEAgZW51 bSA6IE5TVUludGVnZXIgewogICAgIHJldHVybiAqX2NvbnRleHQ7CiB9CiAKKyNpZiBQTEFURk9S TShJT1MpCistIChXS0dlb2xvY2F0aW9uUHJvdmlkZXJJT1MgKilfZ2VvbG9jYXRpb25Qcm92aWRl cgoreworICAgIGlmICghX2dlb2xvY2F0aW9uUHJvdmlkZXIpCisgICAgICAgIF9nZW9sb2NhdGlv blByb3ZpZGVyID0gYWRvcHROUyhbW1dLR2VvbG9jYXRpb25Qcm92aWRlcklPUyBhbGxvY10gaW5p dFdpdGhDb250ZXh0Ol9jb250ZXh0LmdldCgpXSk7CisgICAgcmV0dXJuIF9nZW9sb2NhdGlvblBy b3ZpZGVyLmdldCgpOworfQorI2VuZGlmIC8vIFBMQVRGT1JNKElPUykKKwogQGVuZAogCiBAaW1w bGVtZW50YXRpb24gV0tQcm9jZXNzUG9vbCAoV0tQcml2YXRlKQpAQCAtMTk2LDE3ICsyMDUsNCBA QCBzdGF0aWMgV2ViS2l0OjpIVFRQQ29va2llQWNjZXB0UG9saWN5IHRvSFRUUENvb2tpZUFjY2Vw dFBvbGljeShOU0hUVFBDb29raWVBY2NlcAogCiBAZW5kCiAKLSNpZiBQTEFURk9STShJT1MpCi1A aW1wbGVtZW50YXRpb24gV0tQcm9jZXNzUG9vbCAoV0tJbnRlcm5hbCkKLQotLSAoV0tHZW9sb2Nh dGlvblByb3ZpZGVySU9TICopX2dlb2xvY2F0aW9uUHJvdmlkZXIKLXsKLSAgICBpZiAoIV9nZW9s b2NhdGlvblByb3ZpZGVyKQotICAgICAgICBfZ2VvbG9jYXRpb25Qcm92aWRlciA9IGFkb3B0TlMo W1tXS0dlb2xvY2F0aW9uUHJvdmlkZXJJT1MgYWxsb2NdIGluaXRXaXRoQ29udGV4dDpfY29udGV4 dC5nZXQoKV0pOwotICAgIHJldHVybiBfZ2VvbG9jYXRpb25Qcm92aWRlci5nZXQoKTsKLX0KLQot QGVuZAotI2VuZGlmIC8vIFBMQVRGT1JNKElPUykKLQogI2VuZGlmIC8vIFdLX0FQSV9FTkFCTEVE CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vz c1Bvb2xJbnRlcm5hbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1By b2Nlc3NQb29sSW50ZXJuYWwuaAppbmRleCAxZjM0YTEwODBjMWUwNzIyNmYzNmI5NDZkNmY3NTdk NGFlZDQ4N2YxLi42YjlkNWQyOWQ4ZmM2NDY5YmQ1ODBiMWZjNWEyYWMxZWJiNTIxNGNjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2xJ bnRlcm5hbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9j ZXNzUG9vbEludGVybmFsLmgKQEAgLTUzLDcgKzUzLDcgQEAgaW5saW5lIFdLUHJvY2Vzc1Bvb2wg KndyYXBwZXIoV2ViQ29udGV4dCYgY29udGV4dCkKIEBlbmQKIAogI2lmIFRBUkdFVF9PU19JUEhP TkUKLUBpbnRlcmZhY2UgV0tQcm9jZXNzUG9vbCAoV0tJbnRlcm5hbCkKK0BpbnRlcmZhY2UgV0tQ cm9jZXNzUG9vbCAoKQogQHByb3BlcnR5KHJlYWRvbmx5KSBXS0dlb2xvY2F0aW9uUHJvdmlkZXJJ T1MgKl9nZW9sb2NhdGlvblByb3ZpZGVyOwogQGVuZAogI2VuZGlmCg==