131120 2014-04-02 13:09:26 -0700 Added some more dataLog info for OSR exits 2014-04-02 13:50:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 996809 0 mark.lam 2014-04-02 13:09:26 -0700 Adding info about the OSR exit index, the bytecode index of the bytecode that is OSR exiting, and the reason for the OSR exit. This change is for debugging code which only comes into play when we use the --printEachOSRExit option. 996810 1 228418 mark.lam 2014-04-02 13:13:36 -0700 Created attachment 228418 the patch 996821 2 228418 msaboff 2014-04-02 13:25:43 -0700 Comment on attachment 228418 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228418&action=review r=me > Source/JavaScriptCore/dfg/DFGOperations.cpp:1044 > + dataLogF(" @ exit #%u (bc#%u, %s) with ", vm->osrExitIndex, debugInfo->bytecodeOffset, exitKindToString(debugInfo->kind)); Don't mix dataLogF and dataLog. Use dataLog. 996830 3 228418 mark.lam 2014-04-02 13:49:34 -0700 Comment on attachment 228418 the patch Will land manually with Michael's suggested changes. 996832 4 mark.lam 2014-04-02 13:50:28 -0700 Thanks for the review. Landed in r166662: <http://trac.webkit.org/r166662>. 228418 2014-04-02 13:13:36 -0700 2014-04-02 13:49:33 -0700 the patch bug-131120.patch text/plain 3809 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2NjYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE0LTA0LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGRlZCBzb21lIG1vcmUgZGF0YUxvZyBpbmZvIGZvciBPU1IgZXhpdHMuCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8xMzExMjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkaW5nIGluZm8gYWJvdXQgdGhlIE9TUiBleGl0IGluZGV4LCB0 aGUgYnl0ZWNvZGUgaW5kZXggb2YgdGhlIGJ5dGVjb2RlCisgICAgICAgIHRoYXQgaXMgT1NSIGV4 aXRpbmcsIGFuZCB0aGUgcmVhc29uIGZvciB0aGUgT1NSIGV4aXQuICBUaGlzIGNoYW5nZSBpcwor ICAgICAgICBmb3IgZGVidWdnaW5nIGNvZGUgd2hpY2ggb25seSBjb21lcyBpbnRvIHBsYXkgd2hl biB3ZSB1c2UgdGhlCisgICAgICAgIC0tcHJpbnRFYWNoT1NSRXhpdCBvcHRpb24uCisKKyAgICAg ICAgKiBkZmcvREZHT1NSRXhpdC5oOgorICAgICAgICAqIGRmZy9ERkdPU1JFeGl0Q29tcGlsZXIz Ml82NC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6T1NSRXhpdENvbXBpbGVyOjpjb21waWxlRXhp dCk6CisgICAgICAgICogZGZnL0RGR09TUkV4aXRDb21waWxlcjY0LmNwcDoKKyAgICAgICAgKEpT Qzo6REZHOjpPU1JFeGl0Q29tcGlsZXI6OmNvbXBpbGVFeGl0KToKKyAgICAgICAgKiBkZmcvREZH T3BlcmF0aW9ucy5jcHA6CisKIDIwMTQtMDQtMDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNv bkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE2NTcwNCk6IFtHVEtdIEluc3Bl Y3RvciByZXNvdXJjZXMgbm90IGNvcnJlY3RseSBnZW5lcmF0ZWQKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT1NSRXhpdC5oCShyZXZpc2lvbiAxNjY2NjApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuaAkod29ya2luZyBjb3B5KQpAQCAtMTEyLDYgKzEx Miw4IEBAIHN0cnVjdCBPU1JFeGl0IDogcHVibGljIE9TUkV4aXRCYXNlIHsKIAogc3RydWN0IFNw ZWN1bGF0aW9uRmFpbHVyZURlYnVnSW5mbyB7CiAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2s7Cisg ICAgRXhpdEtpbmQga2luZDsKKyAgICB1bnNpZ25lZCBieXRlY29kZU9mZnNldDsKIH07CiAKIH0g fSAvLyBuYW1lc3BhY2UgSlNDOjpERkcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT1NSRXhpdENvbXBpbGVyMzJfNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyMzJfNjQuY3BwCShyZXZpc2lvbiAxNjY2NjAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlcjMyXzY0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsOCBAQCB2b2lkIE9TUkV4aXRDb21waWxlcjo6 Y29tcGlsZUV4aXQoY29uc3QgCiAgICAgaWYgKE9wdGlvbnM6OnByaW50RWFjaE9TUkV4aXQoKSkg ewogICAgICAgICBTcGVjdWxhdGlvbkZhaWx1cmVEZWJ1Z0luZm8qIGRlYnVnSW5mbyA9IG5ldyBT cGVjdWxhdGlvbkZhaWx1cmVEZWJ1Z0luZm87CiAgICAgICAgIGRlYnVnSW5mby0+Y29kZUJsb2Nr ID0gbV9qaXQuY29kZUJsb2NrKCk7CisgICAgICAgIGRlYnVnSW5mby0+a2luZCA9IGV4aXQubV9r aW5kOworICAgICAgICBkZWJ1Z0luZm8tPmJ5dGVjb2RlT2Zmc2V0ID0gZXhpdC5tX2NvZGVPcmln aW4uYnl0ZWNvZGVJbmRleDsKICAgICAgICAgCiAgICAgICAgIG1faml0LmRlYnVnQ2FsbChkZWJ1 Z09wZXJhdGlvblByaW50U3BlY3VsYXRpb25GYWlsdXJlLCBkZWJ1Z0luZm8pOwogICAgIH0KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVyNjQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdENvbXBpbGVy NjQuY3BwCShyZXZpc2lvbiAxNjY2NjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R09TUkV4aXRDb21waWxlcjY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsOCBAQCB2 b2lkIE9TUkV4aXRDb21waWxlcjo6Y29tcGlsZUV4aXQoY29uc3QgCiAgICAgaWYgKE9wdGlvbnM6 OnByaW50RWFjaE9TUkV4aXQoKSkgewogICAgICAgICBTcGVjdWxhdGlvbkZhaWx1cmVEZWJ1Z0lu Zm8qIGRlYnVnSW5mbyA9IG5ldyBTcGVjdWxhdGlvbkZhaWx1cmVEZWJ1Z0luZm87CiAgICAgICAg IGRlYnVnSW5mby0+Y29kZUJsb2NrID0gbV9qaXQuY29kZUJsb2NrKCk7CisgICAgICAgIGRlYnVn SW5mby0+a2luZCA9IGV4aXQubV9raW5kOworICAgICAgICBkZWJ1Z0luZm8tPmJ5dGVjb2RlT2Zm c2V0ID0gZXhpdC5tX2NvZGVPcmlnaW4uYnl0ZWNvZGVJbmRleDsKICAgICAgICAgCiAgICAgICAg IG1faml0LmRlYnVnQ2FsbChkZWJ1Z09wZXJhdGlvblByaW50U3BlY3VsYXRpb25GYWlsdXJlLCBk ZWJ1Z0luZm8pOwogICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3Bl cmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP cGVyYXRpb25zLmNwcAkocmV2aXNpb24gMTY2NjYwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdPcGVyYXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA0MCw4ICsxMDQwLDgg QEAgdm9pZCBKSVRfT1BFUkFUSU9OIGRlYnVnT3BlcmF0aW9uUHJpbnRTcAogICAgIFNwZWN1bGF0 aW9uRmFpbHVyZURlYnVnSW5mbyogZGVidWdJbmZvID0gc3RhdGljX2Nhc3Q8U3BlY3VsYXRpb25G YWlsdXJlRGVidWdJbmZvKj4oZGVidWdJbmZvUmF3KTsKICAgICBDb2RlQmxvY2sqIGNvZGVCbG9j ayA9IGRlYnVnSW5mby0+Y29kZUJsb2NrOwogICAgIENvZGVCbG9jayogYWx0ZXJuYXRpdmUgPSBj b2RlQmxvY2stPmFsdGVybmF0aXZlKCk7Ci0gICAgZGF0YUxvZygKLSAgICAgICAgIlNwZWN1bGF0 aW9uIGZhaWx1cmUgaW4gIiwgKmNvZGVCbG9jaywgIiB3aXRoICIpOworICAgIGRhdGFMb2coIlNw ZWN1bGF0aW9uIGZhaWx1cmUgaW4gIiwgKmNvZGVCbG9jayk7CisgICAgZGF0YUxvZ0YoIiBAIGV4 aXQgIyV1IChiYyMldSwgJXMpIHdpdGggIiwgdm0tPm9zckV4aXRJbmRleCwgZGVidWdJbmZvLT5i eXRlY29kZU9mZnNldCwgZXhpdEtpbmRUb1N0cmluZyhkZWJ1Z0luZm8tPmtpbmQpKTsKICAgICBp ZiAoYWx0ZXJuYXRpdmUpIHsKICAgICAgICAgZGF0YUxvZygKICAgICAgICAgICAgICJleGVjdXRl Q291bnRlciA9ICIsIGFsdGVybmF0aXZlLT5qaXRFeGVjdXRlQ291bnRlcigpLAo=