131110 2014-04-02 09:02:05 -0700 [WinCairo] Compile error. 2014-04-02 10:55:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue ossy simon.fraser oldest_to_newest 996726 0 peavo 2014-04-02 09:02:05 -0700 There's a compilation error in DragImageCairoWin.cpp, since Image::size() now returns a FloatSize instead of an IntSize. 996727 1 228400 peavo 2014-04-02 09:06:17 -0700 Created attachment 228400 Patch 996731 2 alex.christensen 2014-04-02 09:28:10 -0700 I was going to do something similar, but I don't have my windows machine to test it. This seems good to me if it works. I'm not following all this float/int stuff too closely, though. 996748 3 peavo 2014-04-02 10:52:51 -0700 Thanks for looking into this, guys :) 996749 4 228400 commit-queue 2014-04-02 10:55:17 -0700 Comment on attachment 228400 Patch Clearing flags on attachment: 228400 Committed r166652: <http://trac.webkit.org/changeset/166652> 996750 5 commit-queue 2014-04-02 10:55:20 -0700 All reviewed patches have been landed. Closing bug. 228400 2014-04-02 09:06:17 -0700 2014-04-02 10:55:17 -0700 Patch bug-131110-20140402180524.patch text/plain 1296 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjY0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTAyICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMTExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEltYWdlOjpzaXplKCkgbm93IHJldHVybnMgYSBGbG9hdFNpemUgaW5zdGVhZCBvZiBhbiBJ bnRTaXplLgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0RyYWdJbWFnZUNhaXJvV2luLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZSk6CisKIDIwMTQtMDQt MDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjE2NTcwNCk6IFtHVEtdIEluc3BlY3RvciByZXNvdXJjZXMgbm90IGNvcnJlY3Rs eSBnZW5lcmF0ZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9EcmFnSW1hZ2VD YWlyb1dpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0Ry YWdJbWFnZUNhaXJvV2luLmNwcAkocmV2aXNpb24gMTY2NTEyKQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vd2luL0RyYWdJbWFnZUNhaXJvV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0 LDcgKzE1NCw3IEBAIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoSW0KICAg ICAgICAgcmV0dXJuIDA7CiAKICAgICBQbGF0Zm9ybUNvbnRleHRDYWlybyogZHJhd0NvbnRleHQg PSAwOwotICAgIGF1dG8gaGJtcCA9IGFsbG9jSW1hZ2Uod29ya2luZ0RDLmdldCgpLCBpbWctPnNp emUoKSwgJmRyYXdDb250ZXh0KTsKKyAgICBhdXRvIGhibXAgPSBhbGxvY0ltYWdlKHdvcmtpbmdE Qy5nZXQoKSwgSW50U2l6ZShpbWctPnNpemUoKSksICZkcmF3Q29udGV4dCk7CiAgICAgaWYgKCFo Ym1wIHx8ICFkcmF3Q29udGV4dCkKICAgICAgICAgcmV0dXJuIDA7CiAK