13111 2007-03-18 13:59:48 -0700 Partially-loaded images change to error image when loading is stopped 2007-03-18 17:52:21 -0700 1 1 1 Unclassified WebKit Page Loading 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://flickr.com/explore/interesting/7days/? P2 Normal --- 1 mitz beidson beidson oldest_to_newest 18490 0 mitz 2007-03-18 13:59:48 -0700 When you open the URL in Safari with TOT WebKit and hit Command-. before it's finished loading but after images have started loading(*), all partially-loaded images change to the error image. This is a (recent) regression from shipping WebKit. * - You need to be quick or have a slow connection or find a page served from a slower server. 18491 1 mitz 2007-03-18 14:16:17 -0700 Regressed in <http://trac.webkit.org/projects/webkit/changeset/20178>. 18494 2 mitz 2007-03-18 14:21:23 -0700 I was wrong, this is not a regression from Safari 2.0! I had forgotten it because TOT behaved differently for so long. 18314 3 beidson 2007-03-18 17:35:22 -0700 Regression or not, Hyatt reccomended an easy fix I'm putting a patch together for right now 18313 4 13699 beidson 2007-03-18 17:45:46 -0700 Created attachment 13699 Proposed fix - don't error the resource when its cancelled Proposed fix - don't error the resource when its cancelled 18312 5 13699 hyatt 2007-03-18 17:47:16 -0700 Comment on attachment 13699 Proposed fix - don't error the resource when its cancelled r=me 18310 6 beidson 2007-03-18 17:52:21 -0700 Committed in r20299 13699 2007-03-18 17:45:46 -0700 2007-03-18 17:47:16 -0700 Proposed fix - don't error the resource when its cancelled patch.txt text/plain 2613 beidson SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjk4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMDMt MTggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMTExCisgICAgICAgIFdoZW4gc3RvcHBlZCBhIGxvYWQgYmVmb3JlIGl0 IGNvbXBsZXRlcywgcGFydGlhbCBpbWFnZXMgYmVjb21lIHRoZSAKKyAgICAgICAgYnJva2VuIGlt YWdlIGljb24KKworICAgICAgICAqIGxvYWRlci9sb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TG9hZGVyOjpkaWRGYWlsKTogU3BsaXQgb2ZmIGludG8gYSBtZXRob2QgdGhhdCBrbm93cyB0 aGUgCisgICAgICAgICAgZGlmZmVyZW5jZSBiZXR3ZWVuIGZhaWxlZCBhbmQgY2FuY2VsbGVkLiAg SWYgYSBsb2FkIGlzIGNhbmNlbGxlZCwKKyAgICAgICAgICBkb24ndCBjYWxsIGVycm9yKCkgb24g dGhlIG9iamVjdCAtIG9ubHkgcmVtb3ZlIGl0IGZyb20gdGhlIGNhY2hlCisgICAgICAgIChXZWJD b3JlOjpMb2FkZXI6OmNhbmNlbFJlcXVlc3RzKTogQ2FsbCBkaWRGYWlsKGxvYWRlciwgdHJ1ZSkK KyAgICAgICAgKiBsb2FkZXIvbG9hZGVyLmg6IEFkZGVkIGRpZEZhaWwoU3VicmVzb3VyY2VMb2Fk ZXIqLCBib29sIGNhbmNlbGxlZCkKKwogMjAwNy0wMy0xOCAgTWl0eiBQZXR0ZWwgIDxtaXR6QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRlbGUuCkluZGV4OiBsb2FkZXIvbG9h ZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gbG9hZGVyL2xvYWRlci5oCShyZXZpc2lvbiAyMDI5OCkKKysr IGxvYWRlci9sb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTksNiArNTksNyBAQAogICAgICAg ICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZURhdGEoU3VicmVzb3VyY2VMb2FkZXIqLCBjb25zdCBj aGFyKiwgaW50KTsKICAgICAgICAgdmlydHVhbCB2b2lkIGRpZEZpbmlzaExvYWRpbmcoU3VicmVz b3VyY2VMb2FkZXIqKTsKICAgICAgICAgdmlydHVhbCB2b2lkIGRpZEZhaWwoU3VicmVzb3VyY2VM b2FkZXIqLCBjb25zdCBSZXNvdXJjZUVycm9yJik7CisgICAgICAgIHZvaWQgZGlkRmFpbChTdWJy ZXNvdXJjZUxvYWRlciosIGJvb2wgY2FuY2VsbGVkID0gZmFsc2UpOwogCiAgICAgICAgIHZvaWQg c2VydmVQZW5kaW5nUmVxdWVzdHMoYm9vbCBza2lwQ2FuTG9hZENoZWNrID0gZmFsc2UpOwogCklu ZGV4OiBsb2FkZXIvbG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsb2FkZXIvbG9hZGVyLmNwcAko cmV2aXNpb24gMjAyOTgpCisrKyBsb2FkZXIvbG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTEzLDggKzExMywxMyBAQAogICAgIHNlcnZlUGVuZGluZ1JlcXVlc3RzKCk7CiB9CiAKLXZvaWQg TG9hZGVyOjpkaWRGYWlsKFN1YnJlc291cmNlTG9hZGVyKiBsb2FkZXIsIGNvbnN0IFJlc291cmNl RXJyb3ImIGVycm9yKQordm9pZCBMb2FkZXI6OmRpZEZhaWwoU3VicmVzb3VyY2VMb2FkZXIqIGxv YWRlciwgY29uc3QgUmVzb3VyY2VFcnJvciYpCiB7CisgICAgZGlkRmFpbChsb2FkZXIpOworfQor Cit2b2lkIExvYWRlcjo6ZGlkRmFpbChTdWJyZXNvdXJjZUxvYWRlciogbG9hZGVyLCBib29sIGNh bmNlbGxlZCkKK3sKICAgICBSZXF1ZXN0TWFwOjppdGVyYXRvciBpID0gbV9yZXF1ZXN0c0xvYWRp bmcuZmluZChsb2FkZXIpOwogICAgIGlmIChpID09IG1fcmVxdWVzdHNMb2FkaW5nLmVuZCgpKQog ICAgICAgICByZXR1cm47CkBAIC0xMjUsOCArMTMwLDExIEBACiAgICAgQ2FjaGVkUmVzb3VyY2Uq IG9iamVjdCA9IHJlcS0+Y2FjaGVkUmVzb3VyY2UoKTsKICAgICBEb2NMb2FkZXIqIGRvY0xvYWRl ciA9IHJlcS0+ZG9jTG9hZGVyKCk7CiAKLSAgICBkb2NMb2FkZXItPnNldExvYWRJblByb2dyZXNz KHRydWUpOwotICAgIG9iamVjdC0+ZXJyb3IoKTsKKyAgICBpZiAoIWNhbmNlbGxlZCkgeworICAg ICAgICBkb2NMb2FkZXItPnNldExvYWRJblByb2dyZXNzKHRydWUpOworICAgICAgICBvYmplY3Qt PmVycm9yKCk7CisgICAgfQorICAgIAogICAgIGRvY0xvYWRlci0+c2V0TG9hZEluUHJvZ3Jlc3Mo ZmFsc2UpOwogICAgIGNhY2hlKCktPnJlbW92ZShvYmplY3QpOwogCkBAIC0yMjEsNyArMjI5LDcg QEAKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsb2FkZXJzVG9DYW5jZWwuc2l6ZSgp OyArK2kpIHsKICAgICAgICAgU3VicmVzb3VyY2VMb2FkZXIqIGxvYWRlciA9IGxvYWRlcnNUb0Nh bmNlbFtpXTsKLSAgICAgICAgZGlkRmFpbChsb2FkZXIsIGxvYWRlci0+Y2FuY2VsbGVkRXJyb3Io KSk7CisgICAgICAgIGRpZEZhaWwobG9hZGVyLCB0cnVlKTsKICAgICB9CiB9CiAK