131108 2014-04-02 08:46:18 -0700 [EFL] Should flush and render layers after the root layer is changed. 2014-04-03 23:27:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 hw1008.kim hw1008.kim bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi sergio oldest_to_newest 996723 0 hw1008.kim 2014-04-02 08:46:18 -0700 When the root layer is changed, we should repaint the webview by calling syncLayers(). 996725 1 228399 hw1008.kim 2014-04-02 08:56:43 -0700 Created attachment 228399 Patch 996736 2 228399 ryuan.choi 2014-04-02 09:45:13 -0700 Comment on attachment 228399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228399&action=review > Source/WebKit/efl/ChangeLog:7 > + Maybe we need some description why? We discussed about regression. Is this patch for that? > Source/WebKit/efl/ChangeLog:11 > + (WebCore::AcceleratedCompositingContext::setRootGraphicsLayer): Deleted. This comment is ambiguous. > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:187 > + m_syncTimer.startOneShot(0); Don't we need to check wehther m_syncTimer is active? 996998 3 hw1008.kim 2014-04-02 22:29:10 -0700 (In reply to comment #2) > (From update of attachment 228399 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228399&action=review > > > Source/WebKit/efl/ChangeLog:7 > > + > > Maybe we need some description why? > > We discussed about regression. Is this patch for that? Yes, I'll add some more description. > > Source/WebKit/efl/ChangeLog:11 > > + (WebCore::AcceleratedCompositingContext::setRootGraphicsLayer): Deleted. > > This comment is ambiguous. It's automatically generated comment. I'll replace it with "Move implementation from header file to source file". > > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:187 > > + m_syncTimer.startOneShot(0); > > Don't we need to check wehther m_syncTimer is active? We will set the syncTimer with 0 interval and do flushAndRenderLayers() as soon as possible even though syncTimer is active by css animations. 997002 4 228399 ryuan.choi 2014-04-02 22:37:59 -0700 Comment on attachment 228399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228399&action=review >>> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:187 >>> + m_syncTimer.startOneShot(0); >> >> Don't we need to check wehther m_syncTimer is active? > > We will set the syncTimer with 0 interval and do flushAndRenderLayers() as soon as possible even though syncTimer is active by css animations. Well, if some javascript changes the condition of it to enable/disable sequentially? I am not sure whether it is impossible. 997015 5 hw1008.kim 2014-04-02 23:08:01 -0700 (In reply to comment #4) > (From update of attachment 228399 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228399&action=review > > >>> Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:187 > >>> + m_syncTimer.startOneShot(0); > >> > >> Don't we need to check wehther m_syncTimer is active? > > > > We will set the syncTimer with 0 interval and do flushAndRenderLayers() as soon as possible even though syncTimer is active by css animations. > > Well, if some javascript changes the condition of it to enable/disable sequentially? > I am not sure whether it is impossible. I understand your point. startOneShot(0) may be repeatedly called by setRootGraphicsLayer() calls. I'll add isActive() check. 997016 6 228468 hw1008.kim 2014-04-02 23:12:49 -0700 Created attachment 228468 Patch 997028 7 228468 ryuan.choi 2014-04-02 23:38:33 -0700 Comment on attachment 228468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228468&action=review > Source/WebKit/efl/ChangeLog:10 > + Empty or non updated webview is shown when there is no update event after the root layer is changed. > + Because the syncTimer is not being triggered by root layer change. > + We should flush and render layers by starting syncTimer when the root layer is changed. Patch itself is fine to me. Nit, comment is bit ambiguous to me. (but I am also bad with english :) ) 997030 8 228468 gyuyoung.kim 2014-04-02 23:45:27 -0700 Comment on attachment 228468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228468&action=review > Source/WebKit/efl/ChangeLog:8 > + Empty or non updated webview is shown when there is no update event after the root layer is changed. I modify this description a slightly. "Even when there isn't any update event, empty(or, non-updated webview) webview can be shown after root layer is changed." 997039 9 228476 hw1008.kim 2014-04-03 00:05:33 -0700 Created attachment 228476 Patch 997428 10 ryuan.choi 2014-04-03 18:42:19 -0700 (In reply to comment #9) > Created an attachment (id=228476) [details] > Patch Good to me. 997472 11 228476 gyuyoung.kim 2014-04-03 22:29:20 -0700 Comment on attachment 228476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228476&action=review r=me. Please land it after applying my comment. > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp:185 > +{ Please add ASSERT(rootLayer); It looks rootLayer can be null when user set it as null by using ewk_view_root_graphics_layer_set(). 997483 12 228476 commit-queue 2014-04-03 23:27:21 -0700 Comment on attachment 228476 Patch Clearing flags on attachment: 228476 Committed r166768: <http://trac.webkit.org/changeset/166768> 997484 13 commit-queue 2014-04-03 23:27:28 -0700 All reviewed patches have been landed. Closing bug. 228399 2014-04-02 08:56:43 -0700 2014-04-02 23:12:39 -0700 Patch bug-131108-20140403005621.patch text/plain 2538 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYTVhNmI2NGYx MTI2NGIzNWFmZjAxMzkyMGU3ZjIwZTU1ZGYyYTNlMC4uM2IyMTA0OTdlN2E5MTJhMjFiMTUyMGI3 MTdkM2U5ZGM0ZmM2OWFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0 LTA0LTAyICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBb RUZMXSBTaG91bGQgZmx1c2ggYW5kIHJlbmRlciBsYXllcnMgYWZ0ZXIgdGhlIHJvb3QgbGF5ZXIg aXMgY2hhbmdlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMTEwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJv b3RHcmFwaGljc0xheWVyKTogQWRkIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVmbC5oOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJvb3RH cmFwaGljc0xheWVyKTogRGVsZXRlZC4KKworMjAxNC0wNC0wMiAgSHlvd29uIEtpbSAgPGh3MTAw OC5raW1Ac2Ftc3VuZy5jb20+CisKICAgICAgICAgW0VGTF0gQ29tcG9zaXRlIGFsbCBsYXllcnMg aW50byBvbmUgZXZhc19vYmplY3QgdXNpbmcgVGV4dHVyZU1hcHBlci4KICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDk2OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29u dGV4dEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRl ZENvbXBvc2l0aW5nQ29udGV4dEVmbC5jcHAKaW5kZXggNTZlZDhjZTM4N2Y0NTY4ZDYxN2U5NDIy ZWJmMmRlMjFjMmY2OGQ0Zi4uYjI4NGNiZGVmODRiMjEzY2RlMTRlZGIzNjgwYjk2N2RhYjY0M2E2 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0RWZsLmNwcApAQCAtMTgxLDYg KzE4MSwxMiBAQCB2b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0Ojpjb21wb3NpdGVM YXllcnMoKQogICAgICAgICBtX3N5bmNUaW1lci5zdGFydE9uZVNob3QoMSAvIGNvbXBvc2l0aW5n RnJhbWVSYXRlKTsKIH0KIAordm9pZCBBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6c2V0 Um9vdEdyYXBoaWNzTGF5ZXIoR3JhcGhpY3NMYXllciogcm9vdExheWVyKQoreworICAgIG1fcm9v dExheWVyID0gcm9vdExheWVyOworICAgIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gVVNFKFRFWFRVUkVfTUFQUEVS X0dMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxl cmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVT dXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0RWZsLmgKaW5kZXggOTNiOWVhNDky NzMzMmIwMjdhN2JmZjZjZjNhZGE4MWFiYjhkN2MxMy4uNjk2YzNkZDVkOGZiYTE4N2FmODg5ZWJm ZGI2YmUxMGE0NDZmNzNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVmbC5o CkBAIC00Miw3ICs0Miw3IEBAIHB1YmxpYzoKICAgICBBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29u dGV4dChFdmFzX09iamVjdCogZXdrVmlldywgRXZhc19PYmplY3QqIGNvbXBvc2l0aW5nT2JqZWN0 KTsKICAgICB+QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQoKTsKIAotICAgIHZvaWQgc2V0 Um9vdEdyYXBoaWNzTGF5ZXIoR3JhcGhpY3NMYXllciogcm9vdExheWVyKSB7IG1fcm9vdExheWVy ID0gcm9vdExheWVyOyB9CisgICAgdm9pZCBzZXRSb290R3JhcGhpY3NMYXllcihHcmFwaGljc0xh eWVyKiByb290TGF5ZXIpOwogICAgIHZvaWQgcmVzaXplKGNvbnN0IEludFNpemUmKTsKICAgICB2 b2lkIGZsdXNoQW5kUmVuZGVyTGF5ZXJzKCk7CiAK 228468 2014-04-02 23:12:49 -0700 2014-04-03 00:05:24 -0700 Patch bug-131108-20140403151227.patch text/plain 2802 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggOTM4Y2ZiYTFk MGI2MDcxYzI4OGE1ZmUzN2RhMDUwZmJkNzU3NWM5NS4uNmY4YWNjMGZjYzBjNGVlNjNlOTQ1NTdm ODkyZjUxNzBmOTFkMGQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0 LTA0LTAyICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBTaG91bGQgZmx1c2ggYW5kIHJlbmRlciBsYXllcnMgYWZ0ZXIgdGhlIHJvb3QgbGF5ZXIg aXMgY2hhbmdlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMTEwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEVtcHR5IG9yIG5vbiB1cGRhdGVkIHdlYnZpZXcgaXMgc2hvd24gd2hlbiB0aGVyZSBpcyBu byB1cGRhdGUgZXZlbnQgYWZ0ZXIgdGhlIHJvb3QgbGF5ZXIgaXMgY2hhbmdlZC4KKyAgICAgICAg QmVjYXVzZSB0aGUgc3luY1RpbWVyIGlzIG5vdCBiZWluZyB0cmlnZ2VyZWQgYnkgcm9vdCBsYXll ciBjaGFuZ2UuCisgICAgICAgIFdlIHNob3VsZCBmbHVzaCBhbmQgcmVuZGVyIGxheWVycyBieSBz dGFydGluZyBzeW5jVGltZXIgd2hlbiB0aGUgcm9vdCBsYXllciBpcyBjaGFuZ2VkLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJv b3RHcmFwaGljc0xheWVyKTogQWRkIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVmbC5oOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJvb3RH cmFwaGljc0xheWVyKTogTW92ZSBpbXBsZW1lbnRhdGlvbiBmcm9tIGhlYWRlciB0byBzb3VyY2Uu CisKIDIwMTQtMDQtMDIgIE1hcnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgogCiAgICAgICAg IFVuaWZ5IHByaXZhdGUgYnJvd3Npbmcgd2l0aCBzZXNzaW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0 RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29t cG9zaXRpbmdDb250ZXh0RWZsLmNwcAppbmRleCA1NmVkOGNlMzg3ZjQ1NjhkNjE3ZTk0MjJlYmYy ZGUyMWMyZjY4ZDRmLi5mYWRiNTdjNzU2MGJlZmQ2OTBlOGYyM2E5MTNhM2U3MzI3YzFiM2I2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENv bXBvc2l0aW5nQ29udGV4dEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuY3BwCkBAIC0xODEsNiArMTgx LDE0IEBAIHZvaWQgQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OmNvbXBvc2l0ZUxheWVy cygpCiAgICAgICAgIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgxIC8gY29tcG9zaXRpbmdGcmFt ZVJhdGUpOwogfQogCit2b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpzZXRSb290 R3JhcGhpY3NMYXllcihHcmFwaGljc0xheWVyKiByb290TGF5ZXIpCit7CisgICAgbV9yb290TGF5 ZXIgPSByb290TGF5ZXI7CisKKyAgICBpZiAoIW1fc3luY1RpbWVyLmlzQWN0aXZlKCkpCisgICAg ICAgIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQogCiAjZW5kaWYgLy8gVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRl eHRFZmwuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29t cG9zaXRpbmdDb250ZXh0RWZsLmgKaW5kZXggOTNiOWVhNDkyNzMzMmIwMjdhN2JmZjZjZjNhZGE4 MWFiYjhkN2MxMy4uNjk2YzNkZDVkOGZiYTE4N2FmODg5ZWJmZGI2YmUxMGE0NDZmNzNjNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0NvbnRleHRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9y dC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVmbC5oCkBAIC00Miw3ICs0Miw3IEBAIHB1 YmxpYzoKICAgICBBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dChFdmFzX09iamVjdCogZXdr VmlldywgRXZhc19PYmplY3QqIGNvbXBvc2l0aW5nT2JqZWN0KTsKICAgICB+QWNjZWxlcmF0ZWRD b21wb3NpdGluZ0NvbnRleHQoKTsKIAotICAgIHZvaWQgc2V0Um9vdEdyYXBoaWNzTGF5ZXIoR3Jh cGhpY3NMYXllciogcm9vdExheWVyKSB7IG1fcm9vdExheWVyID0gcm9vdExheWVyOyB9CisgICAg dm9pZCBzZXRSb290R3JhcGhpY3NMYXllcihHcmFwaGljc0xheWVyKiByb290TGF5ZXIpOwogICAg IHZvaWQgcmVzaXplKGNvbnN0IEludFNpemUmKTsKICAgICB2b2lkIGZsdXNoQW5kUmVuZGVyTGF5 ZXJzKCk7CiAK 228476 2014-04-03 00:05:33 -0700 2014-04-03 23:27:21 -0700 Patch bug-131108-20140403160511.patch text/plain 2784 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggOTM4Y2ZiYTFk MGI2MDcxYzI4OGE1ZmUzN2RhMDUwZmJkNzU3NWM5NS4uODEyMjNjYmM5NmQ3YmEzNGE2OWJjMGMx ZTE5Y2ExZDJlMDdhOTVjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0 LTA0LTAyICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBTaG91bGQgZmx1c2ggYW5kIHJlbmRlciBsYXllcnMgYWZ0ZXIgdGhlIHJvb3QgbGF5ZXIg aXMgY2hhbmdlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMTEwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIElmIHRoZXJlIGlzIG5vIHVwZGF0ZSBldmVudCBhZnRlciByb290IGxheWVyIGlzIGNoYW5n ZWQsIG9sZCB3ZWJ2aWV3IGNhbiBiZSBzaG93bi4KKyAgICAgICAgQmVjYXVzZSB0aGUgc3luY1Rp bWVyIGlzIG5vdCBiZWluZyB0cmlnZ2VyZWQgYnkgcm9vdCBsYXllciBjaGFuZ2UuCisgICAgICAg IFdlIHNob3VsZCBmbHVzaCBhbmQgcmVuZGVyIGxheWVycyBieSBzdGFydGluZyBzeW5jVGltZXIg d2hlbiB0aGUgcm9vdCBsYXllciBpcyBjaGFuZ2VkLgorCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJvb3RHcmFwaGljc0xheWVyKTog QWRkIG1fc3luY1RpbWVyLnN0YXJ0T25lU2hvdCgwKTsKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVmbC5oOgorICAgICAgICAoV2ViQ29yZTo6 QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OnNldFJvb3RHcmFwaGljc0xheWVyKTogTW92 ZSBpbXBsZW1lbnRhdGlvbiBmcm9tIGhlYWRlciB0byBzb3VyY2UuCisKIDIwMTQtMDQtMDIgIE1h cnRpbiBIb2NrICA8bWhvY2tAYXBwbGUuY29tPgogCiAgICAgICAgIFVuaWZ5IHByaXZhdGUgYnJv d3Npbmcgd2l0aCBzZXNzaW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0RWZsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0RWZs LmNwcAppbmRleCA1NmVkOGNlMzg3ZjQ1NjhkNjE3ZTk0MjJlYmYyZGUyMWMyZjY4ZDRmLi5mYWRi NTdjNzU2MGJlZmQ2OTBlOGYyM2E5MTNhM2U3MzI3YzFiM2I2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEVm bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRD b21wb3NpdGluZ0NvbnRleHRFZmwuY3BwCkBAIC0xODEsNiArMTgxLDE0IEBAIHZvaWQgQWNjZWxl cmF0ZWRDb21wb3NpdGluZ0NvbnRleHQ6OmNvbXBvc2l0ZUxheWVycygpCiAgICAgICAgIG1fc3lu Y1RpbWVyLnN0YXJ0T25lU2hvdCgxIC8gY29tcG9zaXRpbmdGcmFtZVJhdGUpOwogfQogCit2b2lk IEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpzZXRSb290R3JhcGhpY3NMYXllcihHcmFw aGljc0xheWVyKiByb290TGF5ZXIpCit7CisgICAgbV9yb290TGF5ZXIgPSByb290TGF5ZXI7CisK KyAgICBpZiAoIW1fc3luY1RpbWVyLmlzQWN0aXZlKCkpCisgICAgICAgIG1fc3luY1RpbWVyLnN0 YXJ0T25lU2hvdCgwKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8g VVNFKFRFWFRVUkVfTUFQUEVSX0dMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2Vi Q29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwuaCBiL1NvdXJjZS9X ZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0RWZs LmgKaW5kZXggOTNiOWVhNDkyNzMzMmIwMjdhN2JmZjZjZjNhZGE4MWFiYjhkN2MxMy4uNjk2YzNk ZDVkOGZiYTE4N2FmODg5ZWJmZGI2YmUxMGE0NDZmNzNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRFZmwu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBv c2l0aW5nQ29udGV4dEVmbC5oCkBAIC00Miw3ICs0Miw3IEBAIHB1YmxpYzoKICAgICBBY2NlbGVy YXRlZENvbXBvc2l0aW5nQ29udGV4dChFdmFzX09iamVjdCogZXdrVmlldywgRXZhc19PYmplY3Qq IGNvbXBvc2l0aW5nT2JqZWN0KTsKICAgICB+QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQo KTsKIAotICAgIHZvaWQgc2V0Um9vdEdyYXBoaWNzTGF5ZXIoR3JhcGhpY3NMYXllciogcm9vdExh eWVyKSB7IG1fcm9vdExheWVyID0gcm9vdExheWVyOyB9CisgICAgdm9pZCBzZXRSb290R3JhcGhp Y3NMYXllcihHcmFwaGljc0xheWVyKiByb290TGF5ZXIpOwogICAgIHZvaWQgcmVzaXplKGNvbnN0 IEludFNpemUmKTsKICAgICB2b2lkIGZsdXNoQW5kUmVuZGVyTGF5ZXJzKCk7CiAK