131095 2014-04-02 01:22:37 -0700 [GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR. 2014-04-03 00:28:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco bunhere commit-queue gyuyoung.kim mrobinson sergio zan oldest_to_newest 996631 0 rakuco 2014-04-02 01:22:37 -0700 [GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR. 996632 1 228372 rakuco 2014-04-02 01:24:09 -0700 Created attachment 228372 Patch 996706 2 228372 mrobinson 2014-04-02 07:48:42 -0700 Comment on attachment 228372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228372&action=review > Source/cmake/OptionsGTK.cmake:231 > +set(_required_includes_old ${CMAKE_REQUIRED_INCLUDES}) Why do you use the macro naming scheme here? I think this can be old_required_includes or OLD_REQUIRED_INCLUDES. 996708 3 228372 rakuco 2014-04-02 07:55:07 -0700 Comment on attachment 228372 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228372&action=review >> Source/cmake/OptionsGTK.cmake:231 >> +set(_required_includes_old ${CMAKE_REQUIRED_INCLUDES}) > > Why do you use the macro naming scheme here? I think this can be old_required_includes or OLD_REQUIRED_INCLUDES. No particular reason, I just thought it would make sense to make the name look internal. I can change it to OLD_REQUIRED_INCLUDES before landing. 996709 4 mrobinson 2014-04-02 08:00:40 -0700 Thanks for fixing! 997053 5 228479 rakuco 2014-04-03 00:27:17 -0700 Created attachment 228479 Patch for landing 997055 6 rakuco 2014-04-03 00:28:37 -0700 Committed r166702: <http://trac.webkit.org/changeset/166702> 228372 2014-04-02 01:24:09 -0700 2014-04-03 00:27:08 -0700 Patch bug-131095-20140402112515.patch text/plain 2022 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYwOGI0 MzdhOGQwNzUxZWU2Y2Y5ZDIzYzM3ZDcwZWU4NDJkZTVhMWQuLjNlM2M0YWIzMjllZDcyN2UzNzFh NmI2MTdlOGZmYTcxOTA2YmY3NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yMjIsMTEgKzIy MiwxOSBAQCBpZiAoRU5BQkxFX0NSRURFTlRJQUxfU1RPUkFHRSkKICAgICBzZXQoRU5BQkxFX0NS RURFTlRJQUxfU1RPUkFHRSAxKQogZW5kaWYgKCkKIAotIyBXZSBkb24ndCB1c2UgZmluZF9wYWNr YWdlIGZvciBHTFggYmVjYXVzZSBpdCBpcyBwYXJ0IG9mIC1sR0wsIHVubGlrZSBFR0wuCiBmaW5k X3BhY2thZ2UoT3BlbkdMKQorCisjIFRoaXMgcGFydCBjYW4gYmUgc2ltcGxpZmllZCBvbmNlIENN YWtlIDIuOC42IGlzIHJlcXVpcmVkIGFuZAorIyBDTWFrZVB1c2hDaGVja1N0YXRlIGNhbiBiZSB1 c2VkLiBXZSBuZWVkIHRvIGhhdmUgT1BFTkdMX0lOQ0xVREVfRElSIGFzIHBhcnQKKyMgb2YgdGhl IGRpcmVjdG9yaWVzIGNoZWNrX2luY2x1ZGVfZmlsZXMoKSBsb29rcyBmb3IgaW4gY2FzZSBPcGVu R0wgaXMKKyMgaW5zdGFsbGVkIGludG8gYSBub24tc3RhbmRhcmQgbG9jYXRpb24uCitzZXQoX3Jl cXVpcmVkX2luY2x1ZGVzX29sZCAke0NNQUtFX1JFUVVJUkVEX0lOQ0xVREVTfSkKK3NldChDTUFL RV9SRVFVSVJFRF9JTkNMVURFUyAke0NNQUtFX1JFUVVJUkVEX0lOQ0xVREVTfSAke09QRU5HTF9J TkNMVURFX0RJUn0pCisjIFdlIGRvbid0IHVzZSBmaW5kX3BhY2thZ2UgZm9yIEdMWCBiZWNhdXNl IGl0IGlzIHBhcnQgb2YgLWxHTCwgdW5saWtlIEVHTC4KIGNoZWNrX2luY2x1ZGVfZmlsZXMoIkdM L2dseC5oIiBHTFhfRk9VTkQpCi1maW5kX3BhY2thZ2UoRUdMKQorc2V0KENNQUtFX1JFUVVJUkVE X0lOQ0xVREVTICR7X3JlcXVpcmVkX2luY2x1ZGVzX29sZH0pCiAKK2ZpbmRfcGFja2FnZShFR0wp CiBpZiAoRUdMX0ZPVU5EKQogICAgIHNldChXVEZfVVNFX0VHTCAxKQogZW5kaWYgKCkKZGlmZiAt LWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkNjk2MGE0OWNiY2YzMzhiYWEwNzFj NGM2MTM5NWNhZjA3MTM0MjU4Li5iMzc1Njc0ZjhlMWJkZDRmMDllY2U2MzQ4NjVmMDk2ZTliZTM2 ZGVlIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDQtMDIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5j b3N0YUBpbnRlbC5jb20+CisKKyAgICAgICAgW0dUS11bQ01ha2VdIExvb2sgZm9yIGdseC5oIGlu IE9QRU5HTF9JTkNMVURFX0RJUi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMTA5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE9uZSBuZWVkcyB0byB0YWtlIGludG8gYWNjb3VudCBPcGVuR0wncyBpbmNs dWRlIGRpcmVjdG9yeSBmb3VuZCB2aWEKKyAgICAgICAgZmluZF9wYWNrYWdlKCkgd2hlbiBsb29r aW5nIGZvciBnbHguaCwgc2luY2UgaWYgdGhlIGZvcm1lciBpcyBhCisgICAgICAgIG5vbi1zdGFu ZGFyZCBsb2NhdGlvbiB0aGUgbGF0dGVyIHdpbGwgYWxzbyBiZS4gSWYgdGhpcyBpcyBub3QgaXQg aXMKKyAgICAgICAgcG9zc2libGUgdGhhdCBPcGVuR0wgaXMgZm91bmQgYnV0IEdMWCBzdXBwb3J0 IGlzIG5vdCBwcm9wZXJseSBkZXRlY3RlZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlOgorCiAyMDE0LTA0LTAxICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBo YWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgogCiAgICAgICAgIFtDTWFrZV0gRHJvcCBwb3J0 IGNoZWNrIGZyb20gRmluZEVHTC5jbWFrZS4K 228479 2014-04-03 00:27:17 -0700 2014-04-03 00:27:17 -0700 Patch for landing bug-131095-20140403102825.patch text/plain 2021 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYwOGI0 MzdhOGQwNzUxZWU2Y2Y5ZDIzYzM3ZDcwZWU4NDJkZTVhMWQuLmU1M2RlZWRjZTc2OTJiYTE4Njkx OGMzNGM0ZmMzZDUzMjM1NGI4OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yMjIsMTEgKzIy MiwxOSBAQCBpZiAoRU5BQkxFX0NSRURFTlRJQUxfU1RPUkFHRSkKICAgICBzZXQoRU5BQkxFX0NS RURFTlRJQUxfU1RPUkFHRSAxKQogZW5kaWYgKCkKIAotIyBXZSBkb24ndCB1c2UgZmluZF9wYWNr YWdlIGZvciBHTFggYmVjYXVzZSBpdCBpcyBwYXJ0IG9mIC1sR0wsIHVubGlrZSBFR0wuCiBmaW5k X3BhY2thZ2UoT3BlbkdMKQorCisjIFRoaXMgcGFydCBjYW4gYmUgc2ltcGxpZmllZCBvbmNlIENN YWtlIDIuOC42IGlzIHJlcXVpcmVkIGFuZAorIyBDTWFrZVB1c2hDaGVja1N0YXRlIGNhbiBiZSB1 c2VkLiBXZSBuZWVkIHRvIGhhdmUgT1BFTkdMX0lOQ0xVREVfRElSIGFzIHBhcnQKKyMgb2YgdGhl IGRpcmVjdG9yaWVzIGNoZWNrX2luY2x1ZGVfZmlsZXMoKSBsb29rcyBmb3IgaW4gY2FzZSBPcGVu R0wgaXMKKyMgaW5zdGFsbGVkIGludG8gYSBub24tc3RhbmRhcmQgbG9jYXRpb24uCitzZXQoUkVR VUlSRURfSU5DTFVERVNfT0xEICR7Q01BS0VfUkVRVUlSRURfSU5DTFVERVN9KQorc2V0KENNQUtF X1JFUVVJUkVEX0lOQ0xVREVTICR7Q01BS0VfUkVRVUlSRURfSU5DTFVERVN9ICR7T1BFTkdMX0lO Q0xVREVfRElSfSkKKyMgV2UgZG9uJ3QgdXNlIGZpbmRfcGFja2FnZSBmb3IgR0xYIGJlY2F1c2Ug aXQgaXMgcGFydCBvZiAtbEdMLCB1bmxpa2UgRUdMLgogY2hlY2tfaW5jbHVkZV9maWxlcygiR0wv Z2x4LmgiIEdMWF9GT1VORCkKLWZpbmRfcGFja2FnZShFR0wpCitzZXQoQ01BS0VfUkVRVUlSRURf SU5DTFVERVMgJHtSRVFVSVJFRF9JTkNMVURFU19PTER9KQogCitmaW5kX3BhY2thZ2UoRUdMKQog aWYgKEVHTF9GT1VORCkKICAgICBzZXQoV1RGX1VTRV9FR0wgMSkKIGVuZGlmICgpCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZDY5NjBhNDljYmNmMzM4YmFhMDcxYzRj NjEzOTVjYWYwNzEzNDI1OC4uZjkxMDAxZWVmZDczZTkyZDZlMThlYjBjOTc4ZWZkOTYwMTI4MGFk OSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA0LTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29z dGFAaW50ZWwuY29tPgorCisgICAgICAgIFtHVEtdW0NNYWtlXSBMb29rIGZvciBnbHguaCBpbiBP UEVOR0xfSU5DTFVERV9ESVIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzEwOTUKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24u CisKKyAgICAgICAgT25lIG5lZWRzIHRvIHRha2UgaW50byBhY2NvdW50IE9wZW5HTCdzIGluY2x1 ZGUgZGlyZWN0b3J5IGZvdW5kIHZpYQorICAgICAgICBmaW5kX3BhY2thZ2UoKSB3aGVuIGxvb2tp bmcgZm9yIGdseC5oLCBzaW5jZSBpZiB0aGUgZm9ybWVyIGlzIGEKKyAgICAgICAgbm9uLXN0YW5k YXJkIGxvY2F0aW9uIHRoZSBsYXR0ZXIgd2lsbCBhbHNvIGJlLiBJZiB0aGlzIGlzIG5vdCBpdCBp cworICAgICAgICBwb3NzaWJsZSB0aGF0IE9wZW5HTCBpcyBmb3VuZCBidXQgR0xYIHN1cHBvcnQg aXMgbm90IHByb3Blcmx5IGRldGVjdGVkLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv bnNHVEsuY21ha2U6CisKIDIwMTQtMDQtMDEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhh ZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgW0NNYWtlXSBEcm9wIHBvcnQg Y2hlY2sgZnJvbSBGaW5kRUdMLmNtYWtlLgo=