131092 2014-04-01 23:51:50 -0700 [CSSRegions] Use RenderStyle::hasFlowInto when needed 2014-04-02 22:45:56 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 mihnea webkit-unassigned cmarcelo commit-queue esprehn+autocc glenn gyuyoung.kim kangil.han kondapallykalyan macpherson menard WebkitBugTracker oldest_to_newest 996606 0 mihnea 2014-04-01 23:51:50 -0700 Instead of direct checks for !style()->flowThread().isNull() or !style()->flowThread().isEmpty() 996610 1 228368 mihnea 2014-04-01 23:57:36 -0700 Created attachment 228368 Patch 996752 2 228368 abucur 2014-04-02 11:09:38 -0700 Comment on attachment 228368 Patch r=me 997004 3 228368 commit-queue 2014-04-02 22:45:50 -0700 Comment on attachment 228368 Patch Clearing flags on attachment: 228368 Committed r166696: <http://trac.webkit.org/changeset/166696> 997005 4 commit-queue 2014-04-02 22:45:56 -0700 All reviewed patches have been landed. Closing bug. 228368 2014-04-01 23:57:36 -0700 2014-04-02 22:45:50 -0700 Patch 131092.patch text/plain 3392 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMzM4ZTA2Li5hZDNiMzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDQtMDEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFVzZSBSZW5kZXJTdHlsZTo6aGFzRmxvd0ludG8gd2hlbiBuZWVk ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTA5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBo YXNGbG93SW50bygpIGhlbHBlciBtZXRob2Qgb24gUmVuZGVyU3R5bGUgdG8gYmUgdXNlZAorICAg ICAgICBpbnN0ZWFkIG9mIGRpcmVjdGx5IGNoZWNraW5nIHRoZSBwcmVzZW5jZSBvciBhYnNlbmNl IG9mIGZsb3dUaHJlYWQgdmFsdWUuCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5LCBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OnByb3BlcnR5VmFs dWUpOgorICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1l bnQ6OnNob3VsZE1vdmVUb0Zsb3dUaHJlYWQpOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9S ZW5kZXJTdHlsZS5oOgorICAgICAgICAqIHN0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGU6OmlzUmVuZGVyZXJSZXBhcmVudGVkKToKKwogMjAxNC0wNC0w MSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgd2lsbFJldmVhbCBl ZGdlIGV2ZW50cyBzaG91bGQgYmUgaG9va2VkIHVwIGZvciBvdmVyZmxvdzpzY3JvbGwKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKaW5k ZXggYTYyMTU0NC4uYmEzZDYxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Nv bXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Nv bXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTI3OTIsNyArMjc5Miw3IEBAIFBhc3NSZWZQ dHI8Q1NTVmFsdWU+IENvbXB1dGVkU3R5bGVFeHRyYWN0b3I6OnByb3BlcnR5VmFsdWUoQ1NTUHJv cGVydHlJRCBwcm9wZXJ0CiAgICAgICAgIH0KICNpZiBFTkFCTEUoQ1NTX1JFR0lPTlMpCiAgICAg ICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRGbG93SW50bzoKLSAgICAgICAgICAgIGlmIChzdHls ZS0+Zmxvd1RocmVhZCgpLmlzTnVsbCgpKQorICAgICAgICAgICAgaWYgKCFzdHlsZS0+aGFzRmxv d0ludG8oKSkKICAgICAgICAgICAgICAgICByZXR1cm4gY3NzVmFsdWVQb29sKCkuY3JlYXRlSWRl bnRpZmllclZhbHVlKENTU1ZhbHVlTm9uZSk7CiAgICAgICAgICAgICByZXR1cm4gY3NzVmFsdWVQ b29sKCkuY3JlYXRlVmFsdWUoc3R5bGUtPmZsb3dUaHJlYWQoKSwgQ1NTUHJpbWl0aXZlVmFsdWU6 OkNTU19TVFJJTkcpOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Rmxvd0Zyb206CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKaW5kZXggZDg1MzYzMS4uZTlmMGZmNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcApAQCAtMjQ4Niw3ICsyNDg2LDcgQEAgYm9vbCBFbGVtZW50OjpzaG91bGRNb3ZlVG9G bG93VGhyZWFkKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZVRvVXNlKSBjb25zdAogICAgIGlmIChp c0luU2hhZG93VHJlZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoc3R5bGVU b1VzZS5mbG93VGhyZWFkKCkuaXNFbXB0eSgpKQorICAgIGlmICghc3R5bGVUb1VzZS5oYXNGbG93 SW50bygpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKaW5kZXggMDUxNWNjNS4u NWJkMmI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRl clN0eWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxl LmgKQEAgLTEwMjIsNiArMTAyMiw3IEBAIHB1YmxpYzoKIAogICAgIC8vIEVuZCBDU1MzIEdldHRl cnMKIAorICAgIGJvb2wgaGFzRmxvd0ludG8oKSBjb25zdCB7IHJldHVybiAhcmFyZU5vbkluaGVy aXRlZERhdGEtPm1fZmxvd1RocmVhZC5pc051bGwoKTsgfQogICAgIGNvbnN0IEF0b21pY1N0cmlu ZyYgZmxvd1RocmVhZCgpIGNvbnN0IHsgcmV0dXJuIHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX2Zs b3dUaHJlYWQ7IH0KICAgICBib29sIGhhc0Zsb3dGcm9tKCkgY29uc3QgeyByZXR1cm4gIXJhcmVO b25Jbmhlcml0ZWREYXRhLT5tX3JlZ2lvblRocmVhZC5pc051bGwoKTsgfQogICAgIGNvbnN0IEF0 b21pY1N0cmluZyYgcmVnaW9uVGhyZWFkKCkgY29uc3QgeyByZXR1cm4gcmFyZU5vbkluaGVyaXRl ZERhdGEtPm1fcmVnaW9uVGhyZWFkOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHls ZS9TdHlsZVJlc29sdmVUcmVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2 ZVRyZWUuY3BwCmluZGV4IDRjODdjNDQuLjg4MTdiYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxl L1N0eWxlUmVzb2x2ZVRyZWUuY3BwCkBAIC0xNDYsNyArMTQ2LDcgQEAgc3RhdGljIGJvb2wgaXNS ZW5kZXJlclJlcGFyZW50ZWQoY29uc3QgUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKICAgICBp ZiAoIXJlbmRlcmVyLT5ub2RlKCktPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwotICAgIGlmICghcmVuZGVyZXItPnN0eWxlKCkuZmxvd1RocmVhZCgpLmlzRW1wdHkoKSkK KyAgICBpZiAocmVuZGVyZXItPnN0eWxlKCkuaGFzRmxvd0ludG8oKSkKICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgcmV0dXJuIGZhbHNlOwogfQo=