131055 2014-04-01 13:43:31 -0700 Eliminate HTMLFormElement::m_shouldSubmit 2014-04-03 23:19:42 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap mitz oldest_to_newest 996419 0 ap 2014-04-01 13:43:31 -0700 HTMLFormElement::m_shouldSubmit is confusing an unnecessary. 996425 1 228315 ap 2014-04-01 13:50:25 -0700 Created attachment 228315 proposed patch 996437 2 228315 thorton 2014-04-01 14:15:03 -0700 Comment on attachment 228315 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=228315&action=review > Source/WebCore/ChangeLog:9 > + - as a return value in a funciton whose return value is ignored by all callers; funciton 996470 3 ap 2014-04-01 14:57:49 -0700 Committed <http://trac.webkit.org/r166615>. 997479 4 mitz 2014-04-03 23:19:42 -0700 (In reply to comment #3) > Committed <http://trac.webkit.org/r166615>. See bug 131212. 228315 2014-04-01 13:50:25 -0700 2014-04-01 14:15:02 -0700 proposed patch ShouldSubmit.txt text/plain 4213 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjYwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA0LTAxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEVsaW1pbmF0ZSBIVE1MRm9y bUVsZW1lbnQ6Om1fc2hvdWxkU3VibWl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzEwNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBtX3Nob3VsZFN1Ym1pdCB3YXMgdXNlZCBmb3IgdHdvIHB1cnBvc2Vz OgorICAgICAgICAtIGFzIGEgcmV0dXJuIHZhbHVlIGluIGEgZnVuY2l0b24gd2hvc2UgcmV0dXJu IHZhbHVlIGlzIGlnbm9yZWQgYnkgYWxsIGNhbGxlcnM7CisgICAgICAgIC0gdG8gbWFrZSBhIGRl Y2lzaW9uIHRoYXQncyBsb2NhbCB0byBhIGZ1bmN0aW9uLgorCisgICAgICAgIFRoZXJlIGlzIG5v IG5lZWQgZm9yIGl0IHRvIGJlIGFuIGluc3RhbmNlIHZhcmlhYmxlLgorCisgICAgICAgICogaHRt bC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50 OjpIVE1MRm9ybUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50Ojpw cmVwYXJlRm9yU3VibWlzc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6 OnN1Ym1pdCk6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuaDoKKwogMjAxNC0wNC0w MSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgYSBjb3VwbGUgb2YgdXNlbGVzcyBzdGF0aWMgc3RyaW5ncwpJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24gMTY2NTMzKQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3ICs1 Nyw2IEBAIEhUTUxGb3JtRWxlbWVudDo6SFRNTEZvcm1FbGVtZW50KGNvbnN0IFEKICAgICAsIG1f YXNzb2NpYXRlZEVsZW1lbnRzQWZ0ZXJJbmRleCgwKQogICAgICwgbV93YXNVc2VyU3VibWl0dGVk KGZhbHNlKQogICAgICwgbV9pc1N1Ym1pdHRpbmdPclByZXBhcmluZ0ZvclN1Ym1pc3Npb24oZmFs c2UpCi0gICAgLCBtX3Nob3VsZFN1Ym1pdChmYWxzZSkKICAgICAsIG1faXNJblJlc2V0RnVuY3Rp b24oZmFsc2UpCiAgICAgLCBtX3dhc0RlbW90ZWQoZmFsc2UpCiB7CkBAIC0yNjAsMTkgKzI1OSwx OSBAQCBib29sIEhUTUxGb3JtRWxlbWVudDo6dmFsaWRhdGVJbnRlcmFjdGl2CiAgICAgcmV0dXJu IGZhbHNlOwogfQogCi1ib29sIEhUTUxGb3JtRWxlbWVudDo6cHJlcGFyZUZvclN1Ym1pc3Npb24o RXZlbnQqIGV2ZW50KQordm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnByZXBhcmVGb3JTdWJtaXNzaW9u KEV2ZW50KiBldmVudCkKIHsKICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCk7 CiAgICAgaWYgKG1faXNTdWJtaXR0aW5nT3JQcmVwYXJpbmdGb3JTdWJtaXNzaW9uIHx8ICFmcmFt ZSkKLSAgICAgICAgcmV0dXJuIG1faXNTdWJtaXR0aW5nT3JQcmVwYXJpbmdGb3JTdWJtaXNzaW9u OworICAgICAgICByZXR1cm47CiAKICAgICBtX2lzU3VibWl0dGluZ09yUHJlcGFyaW5nRm9yU3Vi bWlzc2lvbiA9IHRydWU7Ci0gICAgbV9zaG91bGRTdWJtaXQgPSBmYWxzZTsKKyAgICBib29sIHNo b3VsZFN1Ym1pdCA9IGZhbHNlOwogCiAgICAgLy8gSW50ZXJhY3RpdmUgdmFsaWRhdGlvbiBtdXN0 IGJlIGRvbmUgYmVmb3JlIGRpc3BhdGNoaW5nIHRoZSBzdWJtaXQgZXZlbnQuCiAgICAgaWYgKCF2 YWxpZGF0ZUludGVyYWN0aXZlbHkoZXZlbnQpKSB7CiAgICAgICAgIG1faXNTdWJtaXR0aW5nT3JQ cmVwYXJpbmdGb3JTdWJtaXNzaW9uID0gZmFsc2U7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIFN0cmluZ1BhaXJWZWN0b3IgY29udHJvbE5hbWVz QW5kVmFsdWVzOwpAQCAtMjgxLDE0ICsyODAsMTIgQEAgYm9vbCBIVE1MRm9ybUVsZW1lbnQ6OnBy ZXBhcmVGb3JTdWJtaXNzaQogICAgIGZyYW1lLT5sb2FkZXIoKS5jbGllbnQoKS5kaXNwYXRjaFdp bGxTZW5kU3VibWl0RXZlbnQoZm9ybVN0YXRlLnJlbGVhc2UoKSk7CiAKICAgICBpZiAoZGlzcGF0 Y2hFdmVudChFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5zdWJtaXRFdmVudCwgdHJ1ZSwgdHJ1 ZSkpKQotICAgICAgICBtX3Nob3VsZFN1Ym1pdCA9IHRydWU7CisgICAgICAgIHNob3VsZFN1Ym1p dCA9IHRydWU7CiAKICAgICBtX2lzU3VibWl0dGluZ09yUHJlcGFyaW5nRm9yU3VibWlzc2lvbiA9 IGZhbHNlOwogCi0gICAgaWYgKG1fc2hvdWxkU3VibWl0KQorICAgIGlmIChzaG91bGRTdWJtaXQp CiAgICAgICAgIHN1Ym1pdChldmVudCwgdHJ1ZSwgdHJ1ZSwgTm90U3VibWl0dGVkQnlKYXZhU2Ny aXB0KTsKLQotICAgIHJldHVybiBtX3Nob3VsZFN1Ym1pdDsKIH0KIAogdm9pZCBIVE1MRm9ybUVs ZW1lbnQ6OnN1Ym1pdCgpCkBAIC0zMjUsMTAgKzMyMiw4IEBAIHZvaWQgSFRNTEZvcm1FbGVtZW50 OjpzdWJtaXQoRXZlbnQqIGV2ZW4KICAgICBpZiAoIXZpZXcgfHwgIWZyYW1lKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpZiAobV9pc1N1Ym1pdHRpbmdPclByZXBhcmluZ0ZvclN1Ym1pc3Npb24p IHsKLSAgICAgICAgbV9zaG91bGRTdWJtaXQgPSB0cnVlOworICAgIGlmIChtX2lzU3VibWl0dGlu Z09yUHJlcGFyaW5nRm9yU3VibWlzc2lvbikKICAgICAgICAgcmV0dXJuOwotICAgIH0KIAogICAg IG1faXNTdWJtaXR0aW5nT3JQcmVwYXJpbmdGb3JTdWJtaXNzaW9uID0gdHJ1ZTsKICAgICBtX3dh c1VzZXJTdWJtaXR0ZWQgPSBwcm9jZXNzaW5nVXNlckdlc3R1cmU7CkBAIC0zNTgsNyArMzUzLDYg QEAgdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdChFdmVudCogZXZlbgogICAgIGlmIChuZWVk QnV0dG9uQWN0aXZhdGlvbiAmJiBmaXJzdFN1Y2Nlc3NmdWxTdWJtaXRCdXR0b24pCiAgICAgICAg IGZpcnN0U3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbi0+c2V0QWN0aXZhdGVkU3VibWl0KGZhbHNlKTsK IAotICAgIG1fc2hvdWxkU3VibWl0ID0gZmFsc2U7CiAgICAgbV9pc1N1Ym1pdHRpbmdPclByZXBh cmluZ0ZvclN1Ym1pc3Npb24gPSBmYWxzZTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxGb3JtRWxlbWVudC5oCShyZXZpc2lvbiAxNjY1MzMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxGb3JtRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC04MSw3ICs4MSw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIHJlZ2lzdGVySW1nRWxlbWVudChIVE1MSW1hZ2VFbGVtZW50Kik7CiAgICAg dm9pZCByZW1vdmVJbWdFbGVtZW50KEhUTUxJbWFnZUVsZW1lbnQqKTsKIAotICAgIGJvb2wgcHJl cGFyZUZvclN1Ym1pc3Npb24oRXZlbnQqKTsKKyAgICB2b2lkIHByZXBhcmVGb3JTdWJtaXNzaW9u KEV2ZW50Kik7IC8vIEZJWE1FOiBUaGlzIGZ1bmN0aW9uIGRvZXNuJ3Qgb25seSBwcmVwYXJlLCBp dCBzb21ldGltZXMgY2FsbHMgc3VtYml0KCkgaXRzZWxmLgogICAgIHZvaWQgc3VibWl0KCk7CiAg ICAgdm9pZCBzdWJtaXRGcm9tSmF2YVNjcmlwdCgpOwogICAgIHZvaWQgcmVzZXQoKTsKQEAgLTE3 Miw3ICsxNzIsNiBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBtX3dhc1VzZXJTdWJtaXR0ZWQ7CiAg ICAgYm9vbCBtX2lzU3VibWl0dGluZ09yUHJlcGFyaW5nRm9yU3VibWlzc2lvbjsKLSAgICBib29s IG1fc2hvdWxkU3VibWl0OwogCiAgICAgYm9vbCBtX2lzSW5SZXNldEZ1bmN0aW9uOwogCg==