131054 2014-04-01 13:29:04 -0700 Bring a 32bit JSC builder/tester online 2014-09-16 07:13:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136125 136856 1 lforschler webkit-unassigned commit-queue oldest_to_newest 996407 0 lforschler 2014-04-01 13:29:04 -0700 3/17/14, 11:06 AM Lucas Forschler: Would it be possible (do we have the resources?) to set up a build and test bot for 32-bit x86 similar to the C Loop LLINT bot? I would like to run the layout tests on it, but I think that that might require a lot of work to triage test failures that only exists on 32-bit x86 (e.g. webgl issues). I think a good goal to start with, is to build and run the jsc tests only. Unlike the C loop LLINT, the 32-bit x86 build should be able to run the full jsc tests and complete in a relative short amount of time still. Currently, there is a regression (https://bugs.webkit.org/show_bug.cgi?id=130134) that I need to fix first before we can turn this bot on. To build from open source (we should make this an open source bot): $ ./Tools/Script/build-jsc —debug —32-bit To run the tests: $ ./Tools/Script/run-javascriptcore-tests —debug —32-bit —no-build I think having this bot will help us notice and fix 32-bit JIT issues (not covered by the C loop LLINT bot) sooner, and avoid regressions that may impact 32-bit ARM on iOS as well. If we can spare the resource for it, it’ll be great to have such a bot. 996409 1 228313 lforschler 2014-04-01 13:30:31 -0700 Created attachment 228313 Patch to add JSC builder/tester to build.webkit.org v1 996411 2 228313 msaboff 2014-04-01 13:32:36 -0700 Comment on attachment 228313 Patch to add JSC builder/tester to build.webkit.org r=me 996431 3 228313 commit-queue 2014-04-01 14:09:31 -0700 Comment on attachment 228313 Patch to add JSC builder/tester to build.webkit.org Clearing flags on attachment: 228313 Committed r166608: <http://trac.webkit.org/changeset/166608> 996432 4 commit-queue 2014-04-01 14:09:33 -0700 All reviewed patches have been landed. Closing bug. 228313 2014-04-01 13:30:31 -0700 2014-04-01 14:09:30 -0700 Patch to add JSC builder/tester to build.webkit.org 131054.patch text/plain 4986 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NjYwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTA0LTAxICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgYSAzMmJpdCBKU0MgYnVpbGRlci90ZXN0ZXIuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEwNTQKKyAgICAgICAg CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb246CisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoK KyAgICAgICAgKENvbXBpbGUzMmJpdEpTQyk6CisgICAgICAgIChSdW4zMmJpdEpTQ1Rlc3RzKToK KyAgICAgICAgKFJ1bjMyYml0SlNDVGVzdHMuY291bnRGYWlsdXJlcyk6CisgICAgICAgIChCdWls ZEFuZFRlc3QzMmJpdEpTQ0ZhY3RvcnkpOgorICAgICAgICAoQnVpbGRBbmRUZXN0MzJiaXRKU0NG YWN0b3J5Ll9faW5pdF9fKToKKwogMjAxNC0wNC0wMSAgTWFydGluIFJvYmluc29uICA8bXJvYmlu c29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTm8gbG9uZ2VyIGJ1aWxkIFdlYktpdDEg Z3RrZG9jCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9jb25maWcuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbgkocmV2aXNpb24gMTY2NjAyKQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpz b24JKHdvcmtpbmcgY29weSkKQEAgLTEzLDYgKzEzLDcgQEAKICAgICAgICAgICAgICAgICAgICAg eyAibmFtZSI6ICJhcHBsZS1taW5pLTIxMCIsICJwbGF0Zm9ybSI6ICJtYWMtbW91bnRhaW5saW9u In0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiYXBwbGUtbWluaS0yMTgiLCAicGxh dGZvcm0iOiAibWFjLW1vdW50YWlubGlvbiJ9LAogICAgICAgICAgICAgICAgICAgICAKKyAgICAg ICAgICAgICAgICAgICAgeyAibmFtZSI6ICJhcHBsZS1tYWMtMTE0IiwgICJwbGF0Zm9ybSI6ICJt YWMtbWF2ZXJpY2tzIn0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiYXBwbGUtbWlu aS0xMjkiLCAicGxhdGZvcm0iOiAibWFjLW1hdmVyaWNrcyJ9LAogICAgICAgICAgICAgICAgICAg ICB7ICJuYW1lIjogImFwcGxlLW1pbmktMTMwIiwgInBsYXRmb3JtIjogIm1hYy1tYXZlcmlja3Mi fSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJhcHBsZS1taW5pLTEzNyIsICJwbGF0 Zm9ybSI6ICJtYWMtbWF2ZXJpY2tzIn0sCkBAIC05OSw2ICsxMDAsMTAgQEAKICAgICAgICAgICAg ICAgICAgICAgICAicGxhdGZvcm0iOiAibWFjLW1hdmVyaWNrcyIsICJjb25maWd1cmF0aW9uIjog ImRlYnVnIiwgImFyY2hpdGVjdHVyZXMiOiBbIng4Nl82NCJdLAogICAgICAgICAgICAgICAgICAg ICAgICJzbGF2ZW5hbWVzIjogWyJhcHBsZS1taW5pLTE4MCJdCiAgICAgICAgICAgICAgICAgICAg IH0sCisgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiQXBwbGUgTWF2ZXJpY2tzIDMyLWJp dCBKU0MgKEJ1aWxkQW5kVGVzdCkiLCAidHlwZSI6ICJCdWlsZEFuZFRlc3QzMmJpdEpTQyIsICJi dWlsZGRpciI6ICJtYXZlcmlja3MtMzJiaXRKU0MtZGVidWciLAorICAgICAgICAgICAgICAgICAg ICAgICJwbGF0Zm9ybSI6ICJtYWMtbWF2ZXJpY2tzIiwgImNvbmZpZ3VyYXRpb24iOiAiZGVidWci LCAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0sCisgICAgICAgICAgICAgICAgICAgICAgInNs YXZlbmFtZXMiOiBbImFwcGxlLW1hYy0xMTQiXQorICAgICAgICAgICAgICAgICAgICB9LAogICAg ICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIE1hdmVyaWNrcyBSZWxlYXNlIChCdWls ZCkiLCAidHlwZSI6ICJCdWlsZCIsICJidWlsZGRpciI6ICJtYXZlcmlja3MtcmVsZWFzZSIsCiAg ICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3JtIjogIm1hYy1tYXZlcmlja3MiLCAiY29uZmln dXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbIng4Nl82NCJdLAogICAgICAg ICAgICAgICAgICAgICAgICJ0cmlnZ2VycyI6IFsibWF2ZXJpY2tzLXJlbGVhc2UtdGVzdHMtd2sx IiwgIm1hdmVyaWNrcy1yZWxlYXNlLXRlc3RzLXdrMiIsICJtYXZlcmlja3MtcmVsZWFzZS1wZXJm Il0sCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDE2NjYwMikKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdv cmtpbmcgY29weSkKQEAgLTIzMyw2ICsyMzMsOCBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxs LkNvbXBpbGUpOgogY2xhc3MgQ29tcGlsZUxMSU5UQ0xvb3AoQ29tcGlsZVdlYktpdCk6CiAgICAg Y29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvYnVpbGQtanNjIiwgIi0tY2xvb3Ai LCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQogCitjbGFzcyBDb21waWxl MzJiaXRKU0MoQ29tcGlsZVdlYktpdCk6CisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xz L1NjcmlwdHMvYnVpbGQtanNjIiwgIi0tMzItYml0IiwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25m aWd1cmF0aW9uKXMiKV0KIAogY2xhc3MgQ29tcGlsZVdlYktpdDFPbmx5KENvbXBpbGVXZWJLaXQp OgogICAgIGNvbW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCIs ICItLW5vLXdlYmtpdDIiLCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQpA QCAtNTYyLDYgKzU2NCwyNSBAQCBjbGFzcyBSdW5MTElOVENMb29wVGVzdHMoVGVzdFdpdGhGYWls dXJlCiAgICAgICAgIHJldHVybiAwCiAKIAorY2xhc3MgUnVuMzJiaXRKU0NUZXN0cyhUZXN0V2l0 aEZhaWx1cmVDb3VudCk6CisgICAgbmFtZSA9ICJ3ZWJraXQtMzJiaXQtanNjLXRlc3QiCisgICAg ZGVzY3JpcHRpb24gPSBbIjMyYml0LWpzYy10ZXN0cyBydW5uaW5nIl0KKyAgICBkZXNjcmlwdGlv bkRvbmUgPSBbIjMyYml0LWpzYy10ZXN0cyJdCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rv b2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIiwgIi0tMzItYml0IiwgIi0tbm8t YnVpbGQiLCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQorICAgIGZhaWxl ZFRlc3RzRm9ybWF0U3RyaW5nID0gIiVkIHJlZ3Jlc3Npb25zIGZvdW5kLiIKKworICAgIGRlZiBj b3VudEZhaWx1cmVzKHNlbGYsIGNtZCk6CisgICAgICAgIGxvZ1RleHQgPSBjbWQubG9nc1snc3Rk aW8nXS5nZXRUZXh0KCkKKyAgICAgICAgIyBXZSdyZSBsb29raW5nIGZvciB0aGUgbGluZSB0aGF0 IGxvb2tzIGxpa2UgdGhpczogMCByZWdyZXNzaW9ucyBmb3VuZC5cbjAgdGVzdHMgZml4ZWQuCisg ICAgICAgIHJlZ2V4ID0gcmUuY29tcGlsZShyJyg/UDxjb3VudD5cZCspIHJlZ3Jlc3Npb25zIGZv dW5kLicpCisgICAgICAgIGZvciBsaW5lIGluIGxvZ1RleHQuc3BsaXRsaW5lcygpOgorICAgICAg ICAgICAgbWF0Y2ggPSByZWdleC5tYXRjaChsaW5lKQorICAgICAgICAgICAgaWYgbm90IG1hdGNo OgorICAgICAgICAgICAgICAgIGNvbnRpbnVlCisgICAgICAgICAgICByZXR1cm4gaW50KG1hdGNo Lmdyb3VwKCdjb3VudCcpKQorICAgICAgICByZXR1cm4gMAorCisKIGNsYXNzIFJ1bkJpbmRpbmdz VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgbmFtZSA9ICJiaW5kaW5ncy1nZW5lcmF0aW9uLXRlc3Rz IgogICAgIGRlc2NyaXB0aW9uID0gWyJiaW5kaW5ncy10ZXN0cyBydW5uaW5nIl0KQEAgLTg2Miw2 ICs4ODMsMTIgQEAgY2xhc3MgQnVpbGRBbmRUZXN0TExJTlRDTG9vcEZhY3RvcnkoRmFjdAogICAg ICAgICBzZWxmLmFkZFN0ZXAoQ29tcGlsZUxMSU5UQ0xvb3AoKSkKICAgICAgICAgc2VsZi5hZGRT dGVwKFJ1bkxMSU5UQ0xvb3BUZXN0cygpKQogCitjbGFzcyBCdWlsZEFuZFRlc3QzMmJpdEpTQ0Zh Y3RvcnkoRmFjdG9yeSk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1 cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCB0cmlnZ2Vycz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRz PU5vbmUsIFNWTk1pcnJvcj1Ob25lLCAqKmt3YXJncyk6CisgICAgICAgIEZhY3RvcnkuX19pbml0 X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBh ZGRpdGlvbmFsQXJndW1lbnRzLCBTVk5NaXJyb3IsICoqa3dhcmdzKQorICAgICAgICBzZWxmLmFk ZFN0ZXAoQ29tcGlsZTMyYml0SlNDKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChSdW4zMmJpdEpT Q1Rlc3RzKCkpCisKIGNsYXNzIEJ1aWxkQW5kVGVzdFdlYktpdDJGYWN0b3J5KEJ1aWxkQW5kVGVz dEZhY3RvcnkpOgogICAgIENvbXBpbGVDbGFzcyA9IENvbXBpbGVXZWJLaXQKICAgICBMYXlvdXRU ZXN0Q2xhc3MgPSBSdW5XZWJLaXQyVGVzdHMK