131045 2014-04-01 10:05:16 -0700 filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang 2022-02-28 04:13:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer bfulgham dbates dfarler joepeck oldest_to_newest 996332 0 ddkilzer 2014-04-01 10:05:16 -0700 When using newer builds of clang with xcodebuild, the following output is spewed to STDERR for every single clang invocation: 2014-04-01 09:56:33.518 xcodebuild[32115:db03] DVTAssertions: Warning in /SourceCache/IDEXcode3ProjectSupport/IDEXcode3ProjectSupport-6080.2/Xcode3Core/LegacyProjects/Frameworks/DevToolsCore/DevToolsCore/BuildSystem/BuildCommandResultsPostprocessing/XCClangResultsPostprocessor.m:88 Details: Unable to read diagnostics from file "/Volumes/Data/Build/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AffineTransform.dia" (Invalid File): diagnostics file is a newer version than the one supported Object: <XCClangResultsPostprocessor: 0x7ff56303fdb0> Method: -generateDiagnosticsFromFile:logSectionRecorder: Thread: <NSThread: 0x7ff562e125e0>{name = (null), num = 21} Please file a bug at http://bugreport.apple.com with this warning message and any useful information you can provide. The filter-build-webkit script should know how to ignore this useless output when combining STDOUT and STDERR for the build command. 996336 1 228296 ddkilzer 2014-04-01 10:11:24 -0700 Created attachment 228296 Patch v1 996338 2 228297 ddkilzer 2014-04-01 10:13:32 -0700 Created attachment 228297 Patch v2 Update copyright. 996339 3 228298 ddkilzer 2014-04-01 10:14:43 -0700 Created attachment 228298 Patch v3 Fix typo in ChangeLog. 996354 4 228298 joepeck 2014-04-01 10:30:51 -0700 Comment on attachment 228298 Patch v3 Although I would love to ignore them, shouldn't we consider filing bugs if the compiler / tools asks us to? 996356 5 ddkilzer 2014-04-01 10:37:33 -0700 (In reply to comment #4) > (From update of attachment 228298 [details]) > Although I would love to ignore them, shouldn't we consider filing bugs if the compiler / tools asks us to? No, because it's an unsupported configuration that will be fixed when they integrate a newer version of clang at a later date. 996511 6 228298 dbates 2014-04-01 16:36:20 -0700 Comment on attachment 228298 Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=228298&action=review > Tools/ChangeLog:10 > + (shouldIgnoreLine): Ignore DVTAssertions related to new builds > + of clang. This description may not fully represent the impact of the proposed change. That is, we may also ignore the error details of any Xcode warning. See my remark below for more details. > Tools/Scripts/filter-build-webkit:261 > + return 1 if $line =~ /^(Details|Object|Method|Function|Thread):/; > + return 1 if $line =~ /^Please file a bug at /; Are these lines only emitted for DVTAssertions? If not, then we'll be omitting these lines from all Xcode errors. (Is that OK?) We may want to consider omitting these lines for only DVTAssertions. 996518 7 dfarler 2014-04-01 16:48:11 -0700 You could always just tee the full build log to a file and then pipe to the filter. I wonder if we do something similar to that on the bots. 996766 8 ddkilzer 2014-04-02 11:59:53 -0700 (In reply to comment #7) > You could always just tee the full build log to a file and then pipe to the filter. I wonder if we do something similar to that on the bots. I do this all the time when building so I can go back to reference anything I miss: $ make debug ARCHS="x86_64" 2>&1 | tee build-debug.txt | ./Tools/Scripts/filter-build-webkit 996775 9 ddkilzer 2014-04-02 12:13:01 -0700 (In reply to comment #6) > (From update of attachment 228298 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228298&action=review > > > Tools/ChangeLog:10 > > + (shouldIgnoreLine): Ignore DVTAssertions related to new builds > > + of clang. > > This description may not fully represent the impact of the proposed change. That is, we may also ignore the error details of any Xcode warning. See my remark below for more details. You are correct, I could say this instead: Ignore DVTAssertions related to new builds of clang, plus debug data for all DVTAssertions. > > Tools/Scripts/filter-build-webkit:261 > > + return 1 if $line =~ /^(Details|Object|Method|Function|Thread):/; > > + return 1 if $line =~ /^Please file a bug at /; > > Are these lines only emitted for DVTAssertions? If not, then we'll be omitting these lines from all Xcode errors. (Is that OK?) We may want to consider omitting these lines for only DVTAssertions. I can't say for sure that these lines are output only for DVTAssertions, but based on my experience, they are output with every DVTAssertion, and they add nothing of immediate value if you're going to filter the output anyway. As noted in Comment #8, I always tee the full build output to a file, and the filter the rest via the script. If you're filtering output, you want the minimum necessary to spot an issue, and based on what we know so far, ignoring the Details|Object|Method|Function|Thread messages won't skip anything important. 996888 10 ddkilzer 2014-04-02 16:09:45 -0700 Committed r166674: <http://trac.webkit.org/changeset/166674> 228296 2014-04-01 10:11:24 -0700 2014-04-01 10:13:32 -0700 Patch v1 bug-131045-v1.diff text/plain 1541 ddkilzer ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzOTEz ZWI5Li4zOGE3OTJhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDQtMDEgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBmaWx0ZXItYnVpbGQtd2Via2l0OiBJZ25vcmUgeGNv ZGVidWlsZCB3YXJuaW5ncyB3aGVuIGNvbXBpbGluZyB3aXRoIG5ld2VyIGJ1aWxkcyBvZiBjbGFu ZworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzEwNDU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2ZpbHRlci1idWlsZC13 ZWJraXQ6CisgICAgICAgIChzaG91bGRJZ25vcmVMaW5lKTogSWdub3JlIERWVEFzc2VydGlvbnMg cmVsYXRlZCB0byBuZXcgYnVpZGxzCisgICAgICAgIG9mIGNsYW5nLgorCiAyMDE0LTAzLTI4ICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggcmVjZW50bHktaW50 cm9kdWNlZCBvZmYtYnktb25lIGVycm9yIGluIGNlbnRlclRydW5jYXRlVG9CdWZmZXIKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMv ZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCBlNzdkM2RjLi44MmNkOWVjIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9maWx0 ZXItYnVpbGQtd2Via2l0CkBAIC0yNTYsNiArMjU2LDkgQEAgc3ViIHNob3VsZElnbm9yZUxpbmUo JCQpCiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL153YXJuaW5nXDogZGV0ZWN0ZWQgaW50ZXJu YWwgaW5zdGFsbCwgcGFzc2luZyBlbnRpdGxlbWVudHMgdG8gc2ltdWxhdG9yIGFueXdheVwuLzsK ICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvbWF5IG5vdCBmdW5jdGlvbiBpbiB0aGUgU2ltdWxh dG9yIGJlY2F1c2UgQWQgSG9jLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXC91c3JcL2Jp blwvY2xhbmcgLio/IFw+IFxTKy5zYi87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gLyB4Y29k ZWJ1aWxkXFtbMC05XSs6WzAtOWEtZl0rXF1ccytEVlRBc3NlcnRpb25zOiBXYXJuaW5nIGluIC4q WENDbGFuZ1Jlc3VsdHNQb3N0cHJvY2Vzc29yLm0vOworICAgIHJldHVybiAxIGlmICRsaW5lID1+ IC9eKERldGFpbHN8T2JqZWN0fE1ldGhvZHxGdW5jdGlvbnxUaHJlYWQpOi87CisgICAgcmV0dXJu IDEgaWYgJGxpbmUgPX4gL15QbGVhc2UgZmlsZSBhIGJ1ZyBhdCAvOwogCiAgICAgaWYgKCRwbGF0 Zm9ybSBlcSAid2luIikgewogICAgICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKih0b3Vj aHxwZXJsfGNhdHxybSAtZnxiaXNvbnxkZWx8ZmxleHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8 Z3BlcmZ8ZWNob3xzZWR8aWYgXFsgXC1mfFdlYkNvcmVcL2dlbmVyYXRlLWV4cG9ydC1maWxlKSAv Owo= 228297 2014-04-01 10:13:32 -0700 2014-04-01 10:14:43 -0700 Patch v2 bug-131045-v2.diff text/plain 1861 ddkilzer ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzOTEz ZWI5Li4zOGE3OTJhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDQtMDEgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBmaWx0ZXItYnVpbGQtd2Via2l0OiBJZ25vcmUgeGNv ZGVidWlsZCB3YXJuaW5ncyB3aGVuIGNvbXBpbGluZyB3aXRoIG5ld2VyIGJ1aWxkcyBvZiBjbGFu ZworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzEwNDU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2ZpbHRlci1idWlsZC13 ZWJraXQ6CisgICAgICAgIChzaG91bGRJZ25vcmVMaW5lKTogSWdub3JlIERWVEFzc2VydGlvbnMg cmVsYXRlZCB0byBuZXcgYnVpZGxzCisgICAgICAgIG9mIGNsYW5nLgorCiAyMDE0LTAzLTI4ICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggcmVjZW50bHktaW50 cm9kdWNlZCBvZmYtYnktb25lIGVycm9yIGluIGNlbnRlclRydW5jYXRlVG9CdWZmZXIKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMv ZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCBlNzdkM2RjLi45M2I5MDk2IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9maWx0 ZXItYnVpbGQtd2Via2l0CkBAIC0xLDYgKzEsNiBAQAogIyEvdXNyL2Jpbi9wZXJsIC13CiAKLSMg Q29weXJpZ2h0IChDKSAyMDExLCAyMDEyLCAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyLCAyMDEzLCAyMDE0IEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI1 Niw2ICsyNTYsOSBAQCBzdWIgc2hvdWxkSWdub3JlTGluZSgkJCkKICAgICByZXR1cm4gMSBpZiAk bGluZSA9fiAvXndhcm5pbmdcOiBkZXRlY3RlZCBpbnRlcm5hbCBpbnN0YWxsLCBwYXNzaW5nIGVu dGl0bGVtZW50cyB0byBzaW11bGF0b3IgYW55d2F5XC4vOwogICAgIHJldHVybiAxIGlmICRsaW5l ID1+IC9tYXkgbm90IGZ1bmN0aW9uIGluIHRoZSBTaW11bGF0b3IgYmVjYXVzZSBBZCBIb2MvOwog ICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9cL3VzclwvYmluXC9jbGFuZyAuKj8gXD4gXFMrLnNi LzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvIHhjb2RlYnVpbGRcW1swLTldKzpbMC05YS1m XStcXVxzK0RWVEFzc2VydGlvbnM6IFdhcm5pbmcgaW4gLipYQ0NsYW5nUmVzdWx0c1Bvc3Rwcm9j ZXNzb3IubS87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14oRGV0YWlsc3xPYmplY3R8TWV0 aG9kfEZ1bmN0aW9ufFRocmVhZCk6LzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlBsZWFz ZSBmaWxlIGEgYnVnIGF0IC87CiAKICAgICBpZiAoJHBsYXRmb3JtIGVxICJ3aW4iKSB7CiAgICAg ICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eXHMqKHRvdWNofHBlcmx8Y2F0fHJtIC1mfGJpc29u fGRlbHxmbGV4fHB5dGhvbnxcL3VzclwvYmluXC9nXCtcK3xncGVyZnxlY2hvfHNlZHxpZiBcWyBc LWZ8V2ViQ29yZVwvZ2VuZXJhdGUtZXhwb3J0LWZpbGUpIC87Cg== 228298 2014-04-01 10:14:43 -0700 2022-02-28 04:13:27 -0800 Patch v3 bug-131045-v3.diff text/plain 1861 ddkilzer ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzOTEz ZWI5Li40NTQ3NTYxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDQtMDEgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBmaWx0ZXItYnVpbGQtd2Via2l0OiBJZ25vcmUgeGNv ZGVidWlsZCB3YXJuaW5ncyB3aGVuIGNvbXBpbGluZyB3aXRoIG5ld2VyIGJ1aWxkcyBvZiBjbGFu ZworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMzEwNDU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2ZpbHRlci1idWlsZC13 ZWJraXQ6CisgICAgICAgIChzaG91bGRJZ25vcmVMaW5lKTogSWdub3JlIERWVEFzc2VydGlvbnMg cmVsYXRlZCB0byBuZXcgYnVpbGRzCisgICAgICAgIG9mIGNsYW5nLgorCiAyMDE0LTAzLTI4ICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggcmVjZW50bHktaW50 cm9kdWNlZCBvZmYtYnktb25lIGVycm9yIGluIGNlbnRlclRydW5jYXRlVG9CdWZmZXIKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMv ZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCBlNzdkM2RjLi45M2I5MDk2IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9maWx0 ZXItYnVpbGQtd2Via2l0CkBAIC0xLDYgKzEsNiBAQAogIyEvdXNyL2Jpbi9wZXJsIC13CiAKLSMg Q29weXJpZ2h0IChDKSAyMDExLCAyMDEyLCAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyLCAyMDEzLCAyMDE0IEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI1 Niw2ICsyNTYsOSBAQCBzdWIgc2hvdWxkSWdub3JlTGluZSgkJCkKICAgICByZXR1cm4gMSBpZiAk bGluZSA9fiAvXndhcm5pbmdcOiBkZXRlY3RlZCBpbnRlcm5hbCBpbnN0YWxsLCBwYXNzaW5nIGVu dGl0bGVtZW50cyB0byBzaW11bGF0b3IgYW55d2F5XC4vOwogICAgIHJldHVybiAxIGlmICRsaW5l ID1+IC9tYXkgbm90IGZ1bmN0aW9uIGluIHRoZSBTaW11bGF0b3IgYmVjYXVzZSBBZCBIb2MvOwog ICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9cL3VzclwvYmluXC9jbGFuZyAuKj8gXD4gXFMrLnNi LzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvIHhjb2RlYnVpbGRcW1swLTldKzpbMC05YS1m XStcXVxzK0RWVEFzc2VydGlvbnM6IFdhcm5pbmcgaW4gLipYQ0NsYW5nUmVzdWx0c1Bvc3Rwcm9j ZXNzb3IubS87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14oRGV0YWlsc3xPYmplY3R8TWV0 aG9kfEZ1bmN0aW9ufFRocmVhZCk6LzsKKyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlBsZWFz ZSBmaWxlIGEgYnVnIGF0IC87CiAKICAgICBpZiAoJHBsYXRmb3JtIGVxICJ3aW4iKSB7CiAgICAg ICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9eXHMqKHRvdWNofHBlcmx8Y2F0fHJtIC1mfGJpc29u fGRlbHxmbGV4fHB5dGhvbnxcL3VzclwvYmluXC9nXCtcK3xncGVyZnxlY2hvfHNlZHxpZiBcWyBc LWZ8V2ViQ29yZVwvZ2VuZXJhdGUtZXhwb3J0LWZpbGUpIC87Cg==