131036 2014-04-01 08:17:28 -0700 [EFL] Make XVFBDriver optional 2014-05-14 05:44:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned clopez commit-queue glenn gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 996273 0 zsborbely.u-szeged 2014-04-01 08:17:28 -0700 Performance tests fail inside xvfb with the following error: $ Tools/Scripts/run-perf-tests --platform=efl -2 Running 128 tests Running Animation/balls.html (1 of 128) error: Animation/balls.html ERR<32384>:evas-gl_common evas_gl_shader.c:1039 _evas_gl_common_shader_program_source_init() Abort compile of shader vert (rect): #ifdef GL_ES precision highp float; #endif attribute vec4 vertex; attribute vec4 color; uniform mat4 mvp; varying vec4 col; void main() { gl_Position = mvp * vertex; col = color; } ERR<32384>:ecore_evas ecore_evas_x.c:254 _ecore_evas_x_gl_window_new() evas_engine_info_set() for engine 'opengl_x11' failed. ERR<32384>:ecore_evas ecore_evas_x.c:3571 ecore_evas_gl_x11_options_new() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<32384>:evas_main evas_gl.c:42 evas_gl_new() Evas GL engine not available. ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:336 efreet_ini_string_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL ERR<32398>: efreet_ini.c:359 efreet_ini_int_get() safety check failed: ini->section == NULL FAILED Finished: 9.698913 s 996276 1 zsborbely.u-szeged 2014-04-01 08:21:57 -0700 Tools/Scripts/webkitpy/port/efl.py def _driver_class(self): return XvfbDriver It is good for a workaround. If we remove these two lines the tests will run. But unfortunatelly we can't decide the tests are runned as layout or as performation by the driver. That's why we should search a possible solution. 1001909 2 clopez 2014-04-18 06:57:16 -0700 You can use an environment variable. For example, on the GTK port we have: def _driver_class(self): if os.environ.get("WAYLAND_DISPLAY"): return WestonDriver return XvfbDriver 1008906 3 231366 zsborbely.u-szeged 2014-05-13 03:46:21 -0700 Created attachment 231366 Patch I want to commit this manually, because first I have to revert a local workaround in the perf-bot. 1009162 4 231366 gyuyoung.kim 2014-05-13 20:09:23 -0700 Comment on attachment 231366 Patch rs=me. 1009231 5 231366 ossy 2014-05-14 05:44:46 -0700 Comment on attachment 231366 Patch Clearing flags on attachment: 231366 Committed r168833: <http://trac.webkit.org/changeset/168833> 1009232 6 ossy 2014-05-14 05:44:55 -0700 All reviewed patches have been landed. Closing bug. 231366 2014-05-13 03:46:21 -0700 2014-05-14 05:44:46 -0700 Patch xvfb.patch text/plain 1136 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZTNl YzEyLi40MzU2YjIzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDUtMTMgIFpzb2x0IEJvcmJlbHkgIDx6c2Jv cmJlbHkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBNYWtl IFhWRkJEcml2ZXIgb3B0aW9uYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2VmbC5weToKKyAgICAgICAgKEVm bFBvcnQuX2RyaXZlcl9jbGFzcyk6CisKIDIwMTQtMDUtMTEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBsYWNlIFdLQ29udGV4dFNldExvY2FsU3Rv cmFnZURpcmVjdG9yeSB3aXRoIGEgY29udGV4dCBjb25maWd1cmF0aW9uIGdldHRlci9zZXR0ZXIK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZWZsLnB5CmluZGV4IGFkOWRlM2EuLjc5NGE2NDIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2VmbC5weQpAQCAtOTAsNiArOTAsOCBAQCBjbGFzcyBFZmxQb3J0 KFBvcnQpOgogICAgICAgICByZXR1cm4gW1Rlc3RDb25maWd1cmF0aW9uKHZlcnNpb249c2VsZi5f dmVyc2lvbiwgYXJjaGl0ZWN0dXJlPSd4ODYnLCBidWlsZF90eXBlPWJ1aWxkX3R5cGUpIGZvciBi dWlsZF90eXBlIGluIHNlbGYuQUxMX0JVSUxEX1RZUEVTXQogCiAgICAgZGVmIF9kcml2ZXJfY2xh c3Moc2VsZik6CisgICAgICAgIGlmIG9zLmVudmlyb24uZ2V0KCJESVNBQkxFX1hWRkJfRFJJVkVS Iik6CisgICAgICAgICAgICByZXR1cm4gUG9ydC5fZHJpdmVyX2NsYXNzKHNlbGYpCiAgICAgICAg IHJldHVybiBYdmZiRHJpdmVyCiAKICAgICBkZWYgX3BhdGhfdG9fZHJpdmVyKHNlbGYpOgo=