13103 2007-03-17 16:31:24 -0700 REGRESSION (r15069): getPropertyValue() returns null when element has display: none (affects Technorati.com) 2007-03-29 01:58:34 -0700 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) Mac (PowerPC) OS X 10.4 RESOLVED FIXED http://technorati.com/ HasReduction, InRadar, Regression P1 Normal --- 1 stef.pause hyatt ap dev+webkit hyatt mepard mitz mrowe oldest_to_newest 18457 0 stef.pause 2007-03-17 16:31:24 -0700 Go to Technorati.com and click the "Sign In" link at the top-right. This onclick JavaScript should cause the div id="signin" to change its style (via a slide effect) to "display: block;" which it does correctly in Safari v2.0.4, Firefox, Camino, etc. However, in the latest Webkit nightly it slides down then immediately changes back to "display: none;". This obviously makes it somewhat difficult to sign in ;) The relevant JavaScript is: onclick="if(document.all) $('select').hide();if($e('signin').style.display=='block') {$('#signin').slideUp('fast'); } else { $('#signin').slideDown('fast');$e('username').focus()};return false" I'm not entirely sure if it's a Javascript bug or a DOM bug, I suspect the former, so I've filed it under "New Bugs". 18306 1 13701 dev+webkit 2007-03-18 22:20:36 -0700 Created attachment 13701 Reduction The heart of this bug is that when an element has display: none, getPropertyValue() returns null instead of 'none' like Firefox/Opera. This works in Safari 2.0.4 because jQuery (Technorati's JS framework of choice) checks if the getComputedStye() returns null, which Safari 2.0.4 does when an element has display: none. In that case they then check if they're looking for the display property and return 'none'. The reason this disappears in ToT after the animation is because we don't return 'none', jQuery's animation gizmo never gets sets the display as block permanently when it's finished, presuming we're handling that ourselves (ie: we want it to be display: inline) and removes the temporary display: block it added during animation. 18280 2 mjs 2007-03-19 11:51:34 -0700 <rdar://problem/5072345> 17247 3 mitz 2007-03-26 12:55:11 -0700 *** Bug 13193 has been marked as a duplicate of this bug. *** 17225 4 mitz 2007-03-26 13:48:47 -0700 Regressed in <http://trac.webkit.org/projects/webkit/changeset/15069>. Safari 2 returns null from getComputedStyle() if the element doesn't have a renderer. r15069 and later return a CSSStyleDeclaration (which subsequently return null for all properties, see bug 12384). 16580 5 13859 hyatt 2007-03-29 01:27:07 -0700 Created attachment 13859 Honor display property when we have no renderer. 16574 6 mitz 2007-03-29 01:27:46 -0700 *** Bug 13223 has been marked as a duplicate of this bug. *** 16573 7 13859 mitz 2007-03-29 01:40:34 -0700 Comment on attachment 13859 Honor display property when we have no renderer. Needs a change log and a layout test. Also make sure that existing tests pass or are updated as needed. r=me 16571 8 hyatt 2007-03-29 01:58:34 -0700 Fixed in r20570. 13701 2007-03-18 22:20:36 -0700 2007-03-18 22:20:36 -0700 Reduction 13103Reduction.html text/html 645 dev+webkit PGh0bWw+Cgo8aGVhZD4KICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0 PSJ1dGYtOCI+CiAgICAgICAgZnVuY3Rpb24gZG9Gb28oKQogICAgICAgIHsKICAgICAgICAgICAg dmFyIGVsZW0gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZm9vYmFyIik7CiAgICAgICAgICAg IHZhciBjdXIgPSBkb2N1bWVudC5kZWZhdWx0Vmlldy5nZXRDb21wdXRlZFN0eWxlKGVsZW0sIG51 bGwpOwoKICAgICAgICAgICAgLy8gRmlyZWZveC9PcGVyYSB3aWxsIHNob3cgImRpc3BsYXk6IG5v bmUiLCB3aGljaCBpcyB3aGF0IFRvVCBzaG91bGQgZG8sIGJ1dCBkb2Vzbid0LgogICAgICAgICAg ICAvLyBTYWZhcmkgMiB3aWxsIGNvbXBsYWluIGFib3V0IGN1ciBiZWluZyBudWxsIGFuZCBub3Qg ZG8gYW55dGhpbmcuCiAgICAgICAgICAgIGFsZXJ0KCJkaXNwbGF5OiAiICsgY3VyLmdldFByb3Bl cnR5VmFsdWUoImRpc3BsYXkiKSk7CiAgICAgICAgfQogICAgPC9zY3JpcHQ+CjwvaGVhZD4KCjxi b2R5PgogICAgPGJ1dHRvbiBvbmNsaWNrPSJkb0ZvbygpIj5UZXN0PC9idXR0b24+CiAgICA8ZGl2 IGlkPSJmb29iYXIiIHN0eWxlPSJkaXNwbGF5OiBub25lOyI+SSdtIGEgcmVhbCBib3khPC9kaXY+ CjwvYm9keT4KCjwvaHRtbD4K 13859 2007-03-29 01:27:07 -0700 2007-03-29 01:40:34 -0700 Honor display property when we have no renderer. patch.txt text/plain 892 hyatt SW5kZXg6IGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCShyZXZpc2lvbiAyMDU0NCkKKysr IGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 ODEsMTAgKzQ4MSwxNSBAQAogICAgIGlmICh1cGRhdGVMYXlvdXQpCiAgICAgICAgIG5vZGUtPmRv Y3VtZW50KCktPnVwZGF0ZUxheW91dCgpOwogCi0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHdv cmsgZXZlbiBpZiB3ZSBkbyBub3QgaGF2ZSBhIHJlbmRlcmVyLgorICAgIC8vIEZJWE1FOiBUaGlz IHNob3VsZCB3b3JrIGV2ZW4gaWYgd2UgZG8gbm90IGhhdmUgYSByZW5kZXJlciBmb3IgYWxsIHBy b3BlcnRpZXMuCiAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IG5vZGUtPnJlbmRlcmVyKCk7 Ci0gICAgaWYgKCFyZW5kZXJlcikKKyAgICBpZiAoIXJlbmRlcmVyKSB7CisgICAgICAgIC8vIEhh bmRsZSBkaXNwbGF5Om5vbmUgYXQgdGhlIHZlcnkgbGVhc3QuICBCeSBkZWZpbml0aW9uIGlmIHdl IGRvbid0IGhhdmUgYSByZW5kZXJlcgorICAgICAgICAvLyB3ZSBhcmUgY29uc2lkZXJlZCB0byBo YXZlIG5vIGRpc3BsYXkuCisgICAgICAgIGlmIChwcm9wZXJ0eUlEID09IENTU19QUk9QX0RJU1BM QVkpCisgICAgICAgICAgICByZXR1cm4gbmV3IENTU1ByaW1pdGl2ZVZhbHVlKENTU19WQUxfTk9O RSk7CiAgICAgICAgIHJldHVybiAwOworICAgIH0KIAogICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9 IHJlbmRlcmVyLT5zdHlsZSgpOwogICAgIGlmICghc3R5bGUpCg==