131020 2014-04-01 01:45:22 -0700 Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement 2014-04-01 08:23:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue d-r fmalita gyuyoung.kim pdr schenney sergio oldest_to_newest 996190 0 zan 2014-04-01 01:45:22 -0700 Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement 996194 1 228258 zan 2014-04-01 02:04:13 -0700 Created attachment 228258 Patch 996266 2 228258 kling 2014-04-01 07:43:55 -0700 Comment on attachment 228258 Patch r=me 996277 3 228258 zan 2014-04-01 08:23:02 -0700 Comment on attachment 228258 Patch Clearing flags on attachment: 228258 Committed r166586: <http://trac.webkit.org/changeset/166586> 996279 4 zan 2014-04-01 08:23:11 -0700 All reviewed patches have been landed. Closing bug. 228258 2014-04-01 02:04:13 -0700 2014-04-01 08:23:02 -0700 Patch bug-131020-20140401020352.patch text/plain 4533 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjU3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA0LTAxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lY2Vzc2Fy eSBIYXNoU2V0IGNvcGllcyB3aGVuIGNhbGxpbmcgY29sbGVjdEluc3RhbmNlc0ZvclNWR0VsZW1l bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTAy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBjb2xsZWN0SW5zdGFuY2VzRm9yU1ZHRWxlbWVudCgpIHRvIGF2b2lkIEhhc2hTZXQgY29waWVz IHdoZW4gYXNzaWduaW5nIGEgY29uc3QKKyAgICAgICAgSGFzaFNldCByZWZlcmVuY2UgdG8gYSBu b24tY29uc3QgSGFzaFNldCByZWZlcmVuY2UuIEluc3RlYWQsIHJhbmdlLWJhc2VkIGZvci1sb29w cyBhcmUKKyAgICAgICAgZGVwbG95ZWQgdG8gaXRlcmF0ZSBkaXJlY3RseSBvdmVyIHRoZSBjb25z dCByZWZlcmVuY2UgdG8gSGFzaFNldCB0aGF0J3MgcmV0dXJuZWQgYnkKKyAgICAgICAgU1ZHRWxl bWVudDo6aW5zdGFuY2VzRm9yRWxlbWVudCgpLiBTVkdFbGVtZW50Ojpjb250YWluaW5nU2hhZG93 Um9vdCgpIHJldHVybiB2YWx1ZQorICAgICAgICBpcyBjaGVja2VkIHRvIHNlZSBpZiB0aGUgaXRl cmF0aW9uIHNob3VsZCBiZSBwZXJmb3JtZWQgaW4gdGhlIGZpcnN0IHBsYWNlLCBwcmVzZXJ2aW5n CisgICAgICAgIHRoZSBiZWhhdmlvciBvZiBjb2xsZWN0SW5zdGFuY2VzRm9yU1ZHRWxlbWVudCgp LgorCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZH RWxlbWVudDo6YWRkRXZlbnRMaXN0ZW5lcik6CisgICAgICAgIChXZWJDb3JlOjpTVkdFbGVtZW50 OjpyZW1vdmVFdmVudExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbGxlY3RJbnN0YW5j ZXNGb3JTVkdFbGVtZW50KTogRGVsZXRlZC4KKwogMjAxNC0wNC0wMSAgUnl1YW4gQ2hvaSAgPHJ5 dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggd2hl biBkaXNhYmxlZCBBQ0NFU1NJQklMSVRZCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3Bw CShyZXZpc2lvbiAxNjY1NjYpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzNSwxNyArNTM1LDYgQEAgYm9vbCBTVkdFbGVtZW50OjpoYXZl TG9hZGVkUmVxdWlyZWRSZXNvdQogICAgIHJldHVybiB0cnVlOwogfQogCi1zdGF0aWMgaW5saW5l IHZvaWQgY29sbGVjdEluc3RhbmNlc0ZvclNWR0VsZW1lbnQoU1ZHRWxlbWVudCogZWxlbWVudCwg SGFzaFNldDxTVkdFbGVtZW50SW5zdGFuY2UqPiYgaW5zdGFuY2VzKQotewotICAgIEFTU0VSVChl bGVtZW50KTsKLSAgICBpZiAoZWxlbWVudC0+Y29udGFpbmluZ1NoYWRvd1Jvb3QoKSkKLSAgICAg ICAgcmV0dXJuOwotCi0gICAgQVNTRVJUKCFlbGVtZW50LT5pbnN0YW5jZVVwZGF0ZXNCbG9ja2Vk KCkpOwotCi0gICAgaW5zdGFuY2VzID0gZWxlbWVudC0+aW5zdGFuY2VzRm9yRWxlbWVudCgpOwot fQotCiBib29sIFNWR0VsZW1lbnQ6OmFkZEV2ZW50TGlzdGVuZXIoY29uc3QgQXRvbWljU3RyaW5n JiBldmVudFR5cGUsIFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gcHJwTGlzdGVuZXIsIGJvb2wg dXNlQ2FwdHVyZSkKIHsKICAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBwcnBM aXN0ZW5lcjsKQEAgLTU1NCwxNSArNTQzLDE2IEBAIGJvb2wgU1ZHRWxlbWVudDo6YWRkRXZlbnRM aXN0ZW5lcihjb25zdAogICAgIGlmICghTm9kZTo6YWRkRXZlbnRMaXN0ZW5lcihldmVudFR5cGUs IGxpc3RlbmVyLCB1c2VDYXB0dXJlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYg KGNvbnRhaW5pbmdTaGFkb3dSb290KCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgLy8g QWRkIGV2ZW50IGxpc3RlbmVyIHRvIGFsbCBzaGFkb3cgdHJlZSBET00gZWxlbWVudCBpbnN0YW5j ZXMKLSAgICBIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+IGluc3RhbmNlczsKLSAgICBjb2xs ZWN0SW5zdGFuY2VzRm9yU1ZHRWxlbWVudCh0aGlzLCBpbnN0YW5jZXMpOyAgICAKLSAgICBjb25z dCBIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBpbnN0 YW5jZXMuZW5kKCk7Ci0gICAgZm9yIChIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25z dF9pdGVyYXRvciBpdCA9IGluc3RhbmNlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAg ICAgICAgQVNTRVJUKCgqaXQpLT5zaGFkb3dUcmVlRWxlbWVudCgpKTsKLSAgICAgICAgQVNTRVJU KCgqaXQpLT5jb3JyZXNwb25kaW5nRWxlbWVudCgpID09IHRoaXMpOworICAgIEFTU0VSVCghZWxl bWVudC0+aW5zdGFuY2VVcGRhdGVzQmxvY2tlZCgpKTsKKyAgICBmb3IgKGF1dG8mIGluc3RhbmNl IDogaW5zdGFuY2VzRm9yRWxlbWVudCgpKSB7CisgICAgICAgIEFTU0VSVChpbnN0YW5jZS0+c2hh ZG93VHJlZUVsZW1lbnQoKSk7CisgICAgICAgIEFTU0VSVChpbnN0YW5jZS0+Y29ycmVzcG9uZGlu Z0VsZW1lbnQoKSA9PSB0aGlzKTsKIAotICAgICAgICBib29sIHJlc3VsdCA9ICgqaXQpLT5zaGFk b3dUcmVlRWxlbWVudCgpLT5Ob2RlOjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVu ZXIsIHVzZUNhcHR1cmUpOworICAgICAgICBib29sIHJlc3VsdCA9IGluc3RhbmNlLT5zaGFkb3dU cmVlRWxlbWVudCgpLT5Ob2RlOjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVuZXIs IHVzZUNhcHR1cmUpOwogICAgICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0KTsKICAg ICB9CiAKQEAgLTU3MSw5ICs1NjEsNyBAQCBib29sIFNWR0VsZW1lbnQ6OmFkZEV2ZW50TGlzdGVu ZXIoY29uc3QKIAogYm9vbCBTVkdFbGVtZW50OjpyZW1vdmVFdmVudExpc3RlbmVyKGNvbnN0IEF0 b21pY1N0cmluZyYgZXZlbnRUeXBlLCBFdmVudExpc3RlbmVyKiBsaXN0ZW5lciwgYm9vbCB1c2VD YXB0dXJlKQogewotICAgIEhhc2hTZXQ8U1ZHRWxlbWVudEluc3RhbmNlKj4gaW5zdGFuY2VzOwot ICAgIGNvbGxlY3RJbnN0YW5jZXNGb3JTVkdFbGVtZW50KHRoaXMsIGluc3RhbmNlcyk7Ci0gICAg aWYgKGluc3RhbmNlcy5pc0VtcHR5KCkpCisgICAgaWYgKGNvbnRhaW5pbmdTaGFkb3dSb290KCkp CiAgICAgICAgIHJldHVybiBOb2RlOjpyZW1vdmVFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlz dGVuZXIsIHVzZUNhcHR1cmUpOwogCiAgICAgLy8gRXZlbnRUYXJnZXQ6OnJlbW92ZUV2ZW50TGlz dGVuZXIgY3JlYXRlcyBhIFBhc3NSZWZQdHIgYXJvdW5kIHRoZSBnaXZlbiBFdmVudExpc3RlbmVy CkBAIC01ODgsMTEgKzU3NiwxMSBAQCBib29sIFNWR0VsZW1lbnQ6OnJlbW92ZUV2ZW50TGlzdGVu ZXIoY29uCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIFJlbW92ZSBldmVudCBsaXN0 ZW5lciBmcm9tIGFsbCBzaGFkb3cgdHJlZSBET00gZWxlbWVudCBpbnN0YW5jZXMKLSAgICBjb25z dCBIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBpbnN0 YW5jZXMuZW5kKCk7Ci0gICAgZm9yIChIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+Ojpjb25z dF9pdGVyYXRvciBpdCA9IGluc3RhbmNlcy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAg ICAgICAgQVNTRVJUKCgqaXQpLT5jb3JyZXNwb25kaW5nRWxlbWVudCgpID09IHRoaXMpOworICAg IEFTU0VSVCghZWxlbWVudC0+aW5zdGFuY2VVcGRhdGVzQmxvY2tlZCgpKTsKKyAgICBmb3IgKGF1 dG8mIGluc3RhbmNlIDogaW5zdGFuY2VzRm9yRWxlbWVudCgpKSB7CisgICAgICAgIEFTU0VSVChp bnN0YW5jZS0+Y29ycmVzcG9uZGluZ0VsZW1lbnQoKSA9PSB0aGlzKTsKIAotICAgICAgICBTVkdF bGVtZW50KiBzaGFkb3dUcmVlRWxlbWVudCA9ICgqaXQpLT5zaGFkb3dUcmVlRWxlbWVudCgpOwor ICAgICAgICBTVkdFbGVtZW50KiBzaGFkb3dUcmVlRWxlbWVudCA9IGluc3RhbmNlLT5zaGFkb3dU cmVlRWxlbWVudCgpOwogICAgICAgICBBU1NFUlQoc2hhZG93VHJlZUVsZW1lbnQpOwogCiAgICAg ICAgIGlmIChzaGFkb3dUcmVlRWxlbWVudC0+Tm9kZTo6cmVtb3ZlRXZlbnRMaXN0ZW5lcihldmVu dFR5cGUsIGxpc3RlbmVyLCB1c2VDYXB0dXJlKSkK