131016 2014-04-01 00:52:17 -0700 [GTK] Don't copy the children map in webkitWebViewBaseContainerForall 2014-04-01 02:11:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan berto cgarcia commit-queue gustavo mrobinson pnormand svillar oldest_to_newest 996170 0 zan 2014-04-01 00:52:17 -0700 Don't copy the children map in webkitWebViewBaseContainerForall 996172 1 228252 zan 2014-04-01 00:54:42 -0700 Created attachment 228252 Patch 996173 2 commit-queue 2014-04-01 00:56:59 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 996182 3 228252 cgarcia 2014-04-01 01:21:01 -0700 Comment on attachment 228252 Patch Add this to the 2.4 wiki as well, please 996197 4 228252 zan 2014-04-01 02:11:39 -0700 Comment on attachment 228252 Patch Clearing flags on attachment: 228252 Committed r166575: <http://trac.webkit.org/changeset/166575> 996198 5 zan 2014-04-01 02:11:48 -0700 All reviewed patches have been landed. Closing bug. 228252 2014-04-01 00:54:42 -0700 2014-04-01 02:11:39 -0700 Patch bug-131016-20140401005421.patch text/plain 1728 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjU3MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTAxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBEb24ndCBjb3B5IHRoZSBj aGlsZHJlbiBtYXAgaW4gd2Via2l0V2ViVmlld0Jhc2VDb250YWluZXJGb3JhbGwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTAxNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VDb250 YWluZXJGb3JhbGwpOiBBdm9pZCBjb3B5aW5nIHRoZSBHdGtXaWRnZXQtdG8tSW50UmVjdCBIYXNo TWFwIG9iamVjdAorICAgICAgICBieSB0cmFuc2Zvcm1pbmcgdGhlIGl0ZXJhdGlvbiB0byBhIHJh bmdlLWJhc2VkIGZvci1sb29wIG92ZXIgdGhhdCBIYXNoTWFwJ3Mga2V5cy4KKwogMjAxNC0wMy0z MSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBHVEsgYnVpbGQgZml4IGFmdGVyIHIxNjY1NTMuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCShyZXZp c2lvbiAxNjY1NjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2MywxMCArMzYzLDggQEAgc3RhdGlj IHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDb250YWluZXJGbwogICAgIFdlYktpdFdlYlZpZXdCYXNl KiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXX0JBU0UoY29udGFpbmVyKTsKICAgICBXZWJLaXRX ZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3LT5wcml2OwogCi0gICAgV2ViS2l0V2Vi Vmlld0NoaWxkcmVuTWFwIGNoaWxkcmVuID0gcHJpdi0+Y2hpbGRyZW47Ci0gICAgV2ViS2l0V2Vi Vmlld0NoaWxkcmVuTWFwOjpjb25zdF9pdGVyYXRvciBlbmQgPSBjaGlsZHJlbi5lbmQoKTsKLSAg ICBmb3IgKFdlYktpdFdlYlZpZXdDaGlsZHJlbk1hcDo6Y29uc3RfaXRlcmF0b3IgY3VycmVudCA9 IGNoaWxkcmVuLmJlZ2luKCk7IGN1cnJlbnQgIT0gZW5kOyArK2N1cnJlbnQpCi0gICAgICAgICgq Y2FsbGJhY2spKGN1cnJlbnQtPmtleSwgY2FsbGJhY2tEYXRhKTsKKyAgICBmb3IgKGNvbnN0IGF1 dG8mIHdpZGdldCA6IHByaXYtPmNoaWxkcmVuLmtleXMoKSkKKyAgICAgICAgKCpjYWxsYmFjayko d2lkZ2V0LCBjYWxsYmFja0RhdGEpOwogCiAgICAgaWYgKGluY2x1ZGVJbnRlcm5hbHMgJiYgcHJp di0+aW5zcGVjdG9yVmlldykKICAgICAgICAgKCpjYWxsYmFjaykocHJpdi0+aW5zcGVjdG9yVmll dywgY2FsbGJhY2tEYXRhKTsK