131014 2014-04-01 00:41:46 -0700 Prevent unnecessary copies in compareEqual template 2014-04-01 08:36:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue esprehn+autocc glenn kling koivisto kondapallykalyan oldest_to_newest 996166 0 zan 2014-04-01 00:41:46 -0700 Prevent unnecessary copies in compareEqual template 996167 1 228250 zan 2014-04-01 00:46:28 -0700 Created attachment 228250 Patch 996206 2 228250 koivisto 2014-04-01 03:08:08 -0700 Comment on attachment 228250 Patch Good spotting. What did this affect? 996284 3 zan 2014-04-01 08:34:55 -0700 There was no explicit performance issues as such, just an inefficiency that was spotted when looking for unnecessary HashMap copies. 996285 4 228250 zan 2014-04-01 08:36:11 -0700 Comment on attachment 228250 Patch Clearing flags on attachment: 228250 Committed r166589: <http://trac.webkit.org/changeset/166589> 996286 5 zan 2014-04-01 08:36:19 -0700 All reviewed patches have been landed. Closing bug. 228250 2014-04-01 00:46:28 -0700 2014-04-01 08:36:11 -0700 Patch bug-131014-20140401004606.patch text/plain 1421 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjU2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTAxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBQcmV2ZW50IHVubmVjZXNz YXJ5IGNvcGllcyBpbiBjb21wYXJlRXF1YWwgdGVtcGxhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxl Lmg6CisgICAgICAgIChjb21wYXJlRXF1YWwpOiBDYXN0aW5nIHRoZSBzZWNvbmQgcGFyYW1ldGVy IHRvIGEgbm9uLWNvbnN0LCBub24tcmVmZXJlbmNlIHR5cGUKKyAgICAgICAgY2F1c2VzIGFuIGV4 dHJhIGNvcHkgb2YgdGhhdCBvYmplY3QuIENhc3RpbmcgdG8gdGhlIGNvbnN0IHJlZmVyZW5jZSB0 eXBlIG9mIHRoZQorICAgICAgICBmaXJzdCBwYXJhbWV0ZXIgYXZvaWRzIHRoYXQuCisKIDIwMTQt MDQtMDEgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbQ01ha2VdW0VGTF0gRW5hYmxlIENTUyBKSVQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCShyZXZpc2lvbiAxNjY1NjYpCisrKyBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAkod29ya2luZyBjb3B5KQpAQCAt OTEsNyArOTEsNyBAQAogI2luY2x1ZGUgIlRleHRTaXplQWRqdXN0bWVudC5oIgogI2VuZGlmCiAK LXRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+IGlubGluZSBib29sIGNvbXBhcmVFcXVh bChjb25zdCBUJiB0LCBjb25zdCBVJiB1KSB7IHJldHVybiB0ID09IHN0YXRpY19jYXN0PFQ+KHUp OyB9Cit0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVPiBpbmxpbmUgYm9vbCBjb21wYXJl RXF1YWwoY29uc3QgVCYgdCwgY29uc3QgVSYgdSkgeyByZXR1cm4gdCA9PSBzdGF0aWNfY2FzdDxj b25zdCBUJj4odSk7IH0KIAogI2RlZmluZSBTRVRfVkFSKGdyb3VwLCB2YXJpYWJsZSwgdmFsdWUp IFwKICAgICBpZiAoIWNvbXBhcmVFcXVhbChncm91cC0+dmFyaWFibGUsIHZhbHVlKSkgXAo=