131008 2014-03-31 20:54:19 -0700 [Win] Correct media controls for test harness 2014-04-02 11:12:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 996113 0 bfulgham 2014-03-31 20:54:19 -0700 WebKit on Windows uses RenderThemeSafari theme while running tests to allow more Mac layout results to be used on Windows. When the media controls were switched to an HTML/CSS-based implementation, we forgot to update RenderThemeSafari. This caused a great number of media tests to fail on Windows. This patch corrects this problem so we can reactivate the offending tests. 996555 1 228351 bfulgham 2014-04-01 17:59:23 -0700 Created attachment 228351 Patch 996557 2 bfulgham 2014-04-01 18:01:09 -0700 I'd like to land the test reactivation later, as I'm doing other test maintenance. 996753 3 bfulgham 2014-04-02 11:12:33 -0700 Committed r166653: <http://trac.webkit.org/changeset/166653> 228351 2014-04-01 17:59:23 -0700 2014-04-02 10:58:47 -0700 Patch bug-131008-20140401175903.patch text/plain 5571 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjYyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAzLTMxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENvcnJlY3QgbWVk aWEgY29udHJvbHMgZm9yIHRlc3QgaGFybmVzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMDA4IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lU2FmYXJpLmNwcDog UmV2aXNlIHRvIG1hdGNoIFJlbmRlclRoZW1lV2luIGxvZ2ljLgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGhlbWVTYWZhcmk6OnN5c3RlbUZvbnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWVTYWZhcmk6OnBhaW50TWVudUxpc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhl bWVTYWZhcmk6OnBhaW50U2VhcmNoRmllbGRSZXN1bHRzQnV0dG9uKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRoZW1lU2FmYXJpOjptZWRpYUNvbnRyb2xzU3R5bGVTaGVldCk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJUaGVtZVNhZmFyaTo6bWVkaWFDb250cm9sc1NjcmlwdCk6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVNhZmFyaTo6cGFpbnRNZWRpYUZ1bGxzY3JlZW5CdXR0 b24pOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVTYWZhcmk6OnBhaW50 TWVkaWFNdXRlQnV0dG9uKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l U2FmYXJpOjpwYWludE1lZGlhUGxheUJ1dHRvbik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUaGVtZVNhZmFyaTo6cGFpbnRNZWRpYVNlZWtCYWNrQnV0dG9uKTogRGVsZXRlZC4K KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lU2FmYXJpOjpwYWludE1lZGlhU2Vla0Zvcndh cmRCdXR0b24pOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVTYWZhcmk6 OnBhaW50TWVkaWFTbGlkZXJUcmFjayk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUaGVtZVNhZmFyaTo6cGFpbnRNZWRpYVNsaWRlclRodW1iKTogRGVsZXRlZC4KKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuaDoKKwogMjAxNC0wNC0wMSAgWm9sdGFuIEhv cnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIFJl bW92ZSBleGNsdXNpb25zIHBhcnNpbmcgc3VwcG9ydApJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lU2FmYXJpLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuY3BwCShyZXZpc2lvbiAxNjY2MjApCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVTYWZhcmkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00NSw5ICs0NSwxNCBAQAogI2luY2x1ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRl ICJTb2Z0TGlua2luZy5oIgogI2luY2x1ZGUgIlN0eWxlUmVzb2x2ZXIuaCIKKyNpbmNsdWRlICJV c2VyQWdlbnRTdHlsZVNoZWV0cy5oIgogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9Db3JlR3JhcGhp Y3MuaD4KICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+Ci0gCisKKyNpZiBFTkFCTEUoTUVESUFf Q09OVFJPTFNfU0NSSVBUKQorI2luY2x1ZGUgIlVzZXJBZ2VudFNjcmlwdHMuaCIKKyNlbmRpZgor CiB1c2luZyBzdGQ6Om1pbjsKIAogLy8gRklYTUU6IFRoZSBwbGF0Zm9ybS1pbmRlcGVuZGVudCBj b2RlIGluIHRoaXMgY2xhc3Mgc2hvdWxkIGJlIGZhY3RvcmVkIG91dCBhbmQgbWVyZ2VkIHdpdGgg UmVuZGVyVGhlbWVNYWMuIApAQCAtMTE2OCw0MCArMTE3MywyNCBAQCBib29sIFJlbmRlclRoZW1l U2FmYXJpOjpwYWludFNlYXJjaEZpZWxkCiAgICAgcGFpbnRUaGVtZVBhcnQoU2FmYXJpVGhlbWU6 OlNlYXJjaEZpZWxkUmVzdWx0c0J1dHRvblBhcnQsIHBhaW50SW5mby5jb250ZXh0LT5wbGF0Zm9y bUNvbnRleHQoKSwgc2VhcmNoUmVjdCwgY29udHJvbFNpemVGcm9tUmVjdChzZWFyY2hSZWN0LCBz ZWFyY2hGaWVsZFNpemVzKCkpLCBkZXRlcm1pbmVTdGF0ZShvKSk7CiAgICAgcmV0dXJuIGZhbHNl OwogfQotI2lmIEVOQUJMRShWSURFTykKLWJvb2wgUmVuZGVyVGhlbWVTYWZhcmk6OnBhaW50TWVk aWFGdWxsc2NyZWVuQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWlu dEluZm8sIGNvbnN0IEludFJlY3QmIHIpCi17Ci0gICAgcmV0dXJuIFJlbmRlck1lZGlhQ29udHJv bHM6OnBhaW50TWVkaWFDb250cm9sc1BhcnQoTWVkaWFFbnRlckZ1bGxzY3JlZW5CdXR0b24sIG8s IHBhaW50SW5mbywgcik7Ci19Ci0KLWJvb2wgUmVuZGVyVGhlbWVTYWZhcmk6OnBhaW50TWVkaWFN dXRlQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNv bnN0IEludFJlY3QmIHIpCi17Ci0gICAgcmV0dXJuIFJlbmRlck1lZGlhQ29udHJvbHM6OnBhaW50 TWVkaWFDb250cm9sc1BhcnQoTWVkaWFNdXRlQnV0dG9uLCBvLCBwYWludEluZm8sIHIpOwotfQot Ci1ib29sIFJlbmRlclRoZW1lU2FmYXJpOjpwYWludE1lZGlhUGxheUJ1dHRvbihSZW5kZXJPYmpl Y3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBJbnRSZWN0JiByKQotewot ICAgIHJldHVybiBSZW5kZXJNZWRpYUNvbnRyb2xzOjpwYWludE1lZGlhQ29udHJvbHNQYXJ0KE1l ZGlhUGxheUJ1dHRvbiwgbywgcGFpbnRJbmZvLCByKTsKLX0KLQotYm9vbCBSZW5kZXJUaGVtZVNh ZmFyaTo6cGFpbnRNZWRpYVNlZWtCYWNrQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFp bnRJbmZvJiBwYWludEluZm8sIGNvbnN0IEludFJlY3QmIHIpCi17Ci0gICAgcmV0dXJuIFJlbmRl ck1lZGlhQ29udHJvbHM6OnBhaW50TWVkaWFDb250cm9sc1BhcnQoTWVkaWFTZWVrQmFja0J1dHRv biwgbywgcGFpbnRJbmZvLCByKTsKLX0KLQotYm9vbCBSZW5kZXJUaGVtZVNhZmFyaTo6cGFpbnRN ZWRpYVNlZWtGb3J3YXJkQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBw YWludEluZm8sIGNvbnN0IEludFJlY3QmIHIpCi17Ci0gICAgcmV0dXJuIFJlbmRlck1lZGlhQ29u dHJvbHM6OnBhaW50TWVkaWFDb250cm9sc1BhcnQoTWVkaWFTZWVrRm9yd2FyZEJ1dHRvbiwgbywg cGFpbnRJbmZvLCByKTsKLX0KIAotYm9vbCBSZW5kZXJUaGVtZVNhZmFyaTo6cGFpbnRNZWRpYVNs aWRlclRyYWNrKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNv bnN0IEludFJlY3QmIHIpCisjaWYgRU5BQkxFKFZJREVPKQorU3RyaW5nIFJlbmRlclRoZW1lU2Fm YXJpOjptZWRpYUNvbnRyb2xzU3R5bGVTaGVldCgpCiB7Ci0gICAgcmV0dXJuIFJlbmRlck1lZGlh Q29udHJvbHM6OnBhaW50TWVkaWFDb250cm9sc1BhcnQoTWVkaWFTbGlkZXIsIG8sIHBhaW50SW5m bywgcik7CisjaWYgRU5BQkxFKE1FRElBX0NPTlRST0xTX1NDUklQVCkKKyAgICByZXR1cm4gU3Ry aW5nKG1lZGlhQ29udHJvbHNBcHBsZVVzZXJBZ2VudFN0eWxlU2hlZXQsIHNpemVvZihtZWRpYUNv bnRyb2xzQXBwbGVVc2VyQWdlbnRTdHlsZVNoZWV0KSk7CisjZWxzZQorICAgIHJldHVybiBlbXB0 eVN0cmluZygpOworI2VuZGlmCiB9CiAKLWJvb2wgUmVuZGVyVGhlbWVTYWZhcmk6OnBhaW50TWVk aWFTbGlkZXJUaHVtYihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFpbnRJbmZv LCBjb25zdCBJbnRSZWN0JiByKQorU3RyaW5nIFJlbmRlclRoZW1lU2FmYXJpOjptZWRpYUNvbnRy b2xzU2NyaXB0KCkKIHsKLSAgICByZXR1cm4gUmVuZGVyTWVkaWFDb250cm9sczo6cGFpbnRNZWRp YUNvbnRyb2xzUGFydChNZWRpYVNsaWRlclRodW1iLCBvLCBwYWludEluZm8sIHIpOworI2lmIEVO QUJMRShNRURJQV9DT05UUk9MU19TQ1JJUFQpCisgICAgcmV0dXJuIFN0cmluZyhtZWRpYUNvbnRy b2xzQXBwbGVKYXZhU2NyaXB0LCBzaXplb2YobWVkaWFDb250cm9sc0FwcGxlSmF2YVNjcmlwdCkp OworI2Vsc2UKKyAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKKyNlbmRpZgogfQogI2VuZGlmCiAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVNhZmFyaS5oCShy ZXZpc2lvbiAxNjY2MjApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVT YWZhcmkuaAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDEzICsxMjksOCBAQCBwcm90ZWN0ZWQ6CiAg ICAgdmlydHVhbCBib29sIHBhaW50Q2Fwc0xvY2tJbmRpY2F0b3IoUmVuZGVyT2JqZWN0KiwgY29u c3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogCiAjaWYgRU5BQkxFKFZJREVPKQotICAg IHZpcnR1YWwgYm9vbCBwYWludE1lZGlhRnVsbHNjcmVlbkJ1dHRvbihSZW5kZXJPYmplY3QqLCBj b25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7Ci0gICAgdmlydHVhbCBib29sIHBhaW50 TWVkaWFQbGF5QnV0dG9uKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IElu dFJlY3QmKTsKLSAgICB2aXJ0dWFsIGJvb2wgcGFpbnRNZWRpYU11dGVCdXR0b24oUmVuZGVyT2Jq ZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwotICAgIHZpcnR1YWwgYm9v bCBwYWludE1lZGlhU2Vla0JhY2tCdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZv JiwgY29uc3QgSW50UmVjdCYpOwotICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhU2Vla0Zvcndh cmRCdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYp OwotICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhU2xpZGVyVHJhY2soUmVuZGVyT2JqZWN0Kiwg Y29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwotICAgIHZpcnR1YWwgYm9vbCBwYWlu dE1lZGlhU2xpZGVyVGh1bWIoUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3Qg SW50UmVjdCYpOworICAgIHZpcnR1YWwgU3RyaW5nIG1lZGlhQ29udHJvbHNTdHlsZVNoZWV0KCkg b3ZlcnJpZGU7CisgICAgdmlydHVhbCBTdHJpbmcgbWVkaWFDb250cm9sc1NjcmlwdCgpIG92ZXJy aWRlOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoTUVURVJfRUxFTUVOVCkK