130992 2014-03-31 16:15:57 -0700 REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects 2014-03-31 18:11:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 996040 0 msaboff 2014-03-31 16:15:57 -0700 The global object returned from JSContextGetGlobalObject() is actually wrapped by a JSProxy object. The JSObjectGetPrivate() and JSObjectSetPrivate() don't work with the wrapped object. The JSProxy was added in r166415 - <http://trac.webkit.org/changeset/166415> 996052 1 228219 msaboff 2014-03-31 16:32:27 -0700 Created attachment 228219 Patch 996053 2 228219 mhahnenberg 2014-03-31 16:34:45 -0700 Comment on attachment 228219 Patch r=me 996076 3 msaboff 2014-03-31 18:11:07 -0700 Committed r166554: <http://trac.webkit.org/changeset/166554> 228219 2014-03-31 16:32:27 -0700 2014-03-31 16:34:44 -0700 Patch 130992.patch text/plain 3074 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2NTQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAzLTMxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE2NjQxNSk6IEpTT2JqZWN0e0dldCxTZXR9UHJpdmF0ZSgpIGRvbid0 IHdvcmsgd2l0aCBwcm94aWVzIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMDk5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZvcndhcmQgSlNPYmplY3RHZXRQcml2YXRlKCkgYW5kIEpTT2Jq ZWN0U2V0UHJpdmF0ZSgpIHRvIHRoZSB3cmFwcGVkIG9iamVjdC4KKworICAgICAgICAqIEFQSS9K U09iamVjdFJlZi5jcHA6CisgICAgICAgIChKU09iamVjdEdldFByaXZhdGUpOgorICAgICAgICAo SlNPYmplY3RTZXRQcml2YXRlKToKKyAgICAgICAgKiBBUEkvdGVzdHMvdGVzdGFwaS5jOgorICAg ICAgICAobWFpbik6IEFkZGVkIG5ldyB0ZXN0IGNhc2UgdG8gdmFsaWRhdGUgd2UgYXJlIHByb3Bl cmx5IGZvYXJ3YXJkaW5nLgorCiAyMDE0LTAzLTMxICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgV0VCX0FOSU1BVElPTlMKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCShyZXZpc2lvbiAxNjY1NDEpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDUxLDcgKzQ1MSwxMSBAQCBib29sIEpTT2JqZWN0RGVsZXRlUHJvcGVydHkoSlNDb250ZXh0UmVm CiB2b2lkKiBKU09iamVjdEdldFByaXZhdGUoSlNPYmplY3RSZWYgb2JqZWN0KQogewogICAgIEpT T2JqZWN0KiBqc09iamVjdCA9IHVuY2hlY2tlZFRvSlMob2JqZWN0KTsKLSAgICAKKworICAgIC8v IEdldCB3cmFwcGVkIG9iamVjdCBpZiBwcm94aWVkCisgICAgaWYgKGpzT2JqZWN0LT5pbmhlcml0 cyhKU1Byb3h5OjppbmZvKCkpKQorICAgICAgICBqc09iamVjdCA9IGpzQ2FzdDxKU1Byb3h5Kj4o anNPYmplY3QpLT50YXJnZXQoKTsKKwogICAgIGlmIChqc09iamVjdC0+aW5oZXJpdHMoSlNDYWxs YmFja09iamVjdDxKU0dsb2JhbE9iamVjdD46OmluZm8oKSkpCiAgICAgICAgIHJldHVybiBqc0Nh c3Q8SlNDYWxsYmFja09iamVjdDxKU0dsb2JhbE9iamVjdD4qPihqc09iamVjdCktPmdldFByaXZh dGUoKTsKICAgICBpZiAoanNPYmplY3QtPmluaGVyaXRzKEpTQ2FsbGJhY2tPYmplY3Q8SlNEZXN0 cnVjdGlibGVPYmplY3Q+OjppbmZvKCkpKQpAQCAtNDY3LDcgKzQ3MSwxMSBAQCB2b2lkKiBKU09i amVjdEdldFByaXZhdGUoSlNPYmplY3RSZWYgb2JqCiBib29sIEpTT2JqZWN0U2V0UHJpdmF0ZShK U09iamVjdFJlZiBvYmplY3QsIHZvaWQqIGRhdGEpCiB7CiAgICAgSlNPYmplY3QqIGpzT2JqZWN0 ID0gdW5jaGVja2VkVG9KUyhvYmplY3QpOwotICAgIAorCisgICAgLy8gR2V0IHdyYXBwZWQgb2Jq ZWN0IGlmIHByb3hpZWQKKyAgICBpZiAoanNPYmplY3QtPmluaGVyaXRzKEpTUHJveHk6OmluZm8o KSkpCisgICAgICAgIGpzT2JqZWN0ID0ganNDYXN0PEpTUHJveHkqPihqc09iamVjdCktPnRhcmdl dCgpOworCiAgICAgaWYgKGpzT2JqZWN0LT5pbmhlcml0cyhKU0NhbGxiYWNrT2JqZWN0PEpTR2xv YmFsT2JqZWN0Pjo6aW5mbygpKSkgewogICAgICAgICBqc0Nhc3Q8SlNDYWxsYmFja09iamVjdDxK U0dsb2JhbE9iamVjdD4qPihqc09iamVjdCktPnNldFByaXZhdGUoZGF0YSk7CiAgICAgICAgIHJl dHVybiB0cnVlOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBp LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBp LmMJKHJldmlzaW9uIDE2NjU0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMv dGVzdGFwaS5jCSh3b3JraW5nIGNvcHkpCkBAIC0xMjI1LDYgKzEyMjUsMTMgQEAgaW50IG1haW4o aW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICBKU09iamVjdFJlZiBqc09iamVjdE5vUHJvdG8g PSBKU09iamVjdE1ha2UoY29udGV4dCwgTlVMTCwgTlVMTCk7CiAgICAgSlNPYmplY3RTZXRQcm90 b3R5cGUoY29udGV4dCwganNPYmplY3ROb1Byb3RvLCBKU1ZhbHVlTWFrZU51bGwoY29udGV4dCkp OwogCisgICAgSlNPYmplY3RTZXRQcml2YXRlKGdsb2JhbE9iamVjdCwgKHZvaWQqKTEyMyk7Cisg ICAgaWYgKEpTT2JqZWN0R2V0UHJpdmF0ZShnbG9iYWxPYmplY3QpICE9ICh2b2lkKikxMjMpIHsK KyAgICAgICAgcHJpbnRmKCJGQUlMOiBEaWRuJ3QgcmV0dXJuIHByaXZhdGUgZGF0YSB3aGVuIHNl dCBieSBKU09iamVjdFNldFByaXZhdGUoKS5cbiIpOworICAgICAgICBmYWlsZWQgPSAxOworICAg IH0gZWxzZQorICAgICAgICBwcmludGYoIlBBU1M6IHJldHVybmVkIHByaXZhdGUgZGF0YSB3aGVu IHNldCBieSBKU09iamVjdFNldFByaXZhdGUoKS5cbiIpOworCiAgICAgLy8gRklYTUU6IHRlc3Qg ZnVubnkgdXRmOCBjaGFyYWN0ZXJzCiAgICAgSlNTdHJpbmdSZWYganNFbXB0eUlTdHJpbmcgPSBK U1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiIik7CiAgICAgSlNWYWx1ZVJlZiBqc0VtcHR5 U3RyaW5nID0gSlNWYWx1ZU1ha2VTdHJpbmcoY29udGV4dCwganNFbXB0eUlTdHJpbmcpOwo=