130981 2014-03-31 12:53:53 -0700 Small adjustments to WebCore::IOSurface (inUse->isInUse, createImage always works, clearGraphicsContext) 2014-03-31 14:11:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton commit-queue simon.fraser oldest_to_newest 995955 0 228190 thorton 2014-03-31 12:53:53 -0700 Created attachment 228190 patch Some small fixes that are the dependencies of multiple future patches, and as such were factored out. 995956 1 commit-queue 2014-03-31 12:54:54 -0700 Attachment 228190 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 995974 2 228190 simon.fraser 2014-03-31 13:45:13 -0700 Comment on attachment 228190 patch View in context: https://bugs.webkit.org/attachment.cgi?id=228190&action=review > Source/WebCore/ChangeLog:3 > + Small adjustments to WebCore::IOSurface Missing bug number. 995998 3 thorton 2014-03-31 14:11:30 -0700 http://trac.webkit.org/changeset/166528 228190 2014-03-31 12:53:53 -0700 2014-03-31 13:45:12 -0700 patch 0002-Small-adjustments-to-WebCore-IOSurface-inUse-isInUse.patch text/plain 4733 thorton RnJvbSA5YzllYjY2YWJmMWE3ZDUyMzZkNjkzMDRhOGE3MjcxMTZjNzliYTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gSG9ydG9uIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CkRhdGU6IFN1biwgMzAgTWFyIDIwMTQgMTk6NDE6MDggLTA3MDAKU3ViamVjdDogW1BBVENIIDAy LzEwXSBTbWFsbCBhZGp1c3RtZW50cyB0byBXZWJDb3JlOjpJT1N1cmZhY2UKIChpblVzZS0+aXNJ blVzZSwgY3JlYXRlSW1hZ2UgZXZlbiBpZiBwbGF0Zm9ybUNvbnRleHQgaXMgY2xlYXJlZCwgYWRk CiBjbGVhckdyYXBoaWNzQ29udGV4dCwgZXRjLikKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyNCArKysrKysrKysrKysrKysrKysrKysr CiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiAgICAgICAgICAgICAgICAgICAgICB8ICA0 ICsrKy0KIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5o IHwgIDggKysrKysrLS0KIC4uLi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3Vy ZmFjZS5tbSAgIHwgMTUgKysrKysrKystLS0tLS0KIDQgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMwZmY1Ny4uYWUxOTE3YiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTAzLTMwICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIFNtYWxsIGFkanVzdG1lbnRzIHRvIFdl YkNvcmU6OklPU3VyZmFjZQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgIEV4cG9ydCBzb21lIG1vcmUgdGhp bmdzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmg6Cisg ICAgICAgIGNyZWF0ZUltYWdlKCkgY2FuJ3QgYmUgY29uc3QgYmVjYXVzZSBpdCBjYWxscyBlbnN1 cmVQbGF0Zm9ybUNvbnRleHQoKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29h L0lPU3VyZmFjZS5tbToKKyAgICAgICAgKElPU3VyZmFjZTo6Y3JlYXRlSW1hZ2UpOgorICAgICAg ICBXZSBzaG91bGQgYmUgYWJsZSB0byBjcmVhdGUgYW4gaW1hZ2UgZXZlbiBpZiB0aGUgQ0dDb250 ZXh0IGhhcyBiZWVuIGNsZWFyZWQgKG9yIG5ldmVyIGNyZWF0ZWQpLgorCisgICAgICAgIChJT1N1 cmZhY2U6OmlzSW5Vc2UpOgorICAgICAgICBSZW5hbWUgaW5Vc2UoKSB0byBpc0luVXNlKCkuCisK KyAgICAgICAgKElPU3VyZmFjZTo6Y2xlYXJHcmFwaGljc0NvbnRleHQpOgorICAgICAgICBBZGQg Y2xlYXJHcmFwaGljc0NvbnRleHQoKS4KKworMjAxNC0wMy0zMCAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBBbGxvY2F0ZSBJT1N1cmZhY2VzIHdpdGgg dGhlIHNhbWUgY2FjaGUgbW9kZSB0aGF0IENvcmVBbmltYXRpb24gdXNlcwogCiAgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4gYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCA3NmVhYmM3 Li5hNmM3ZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysg Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtMzA2NiwxMyArMzA2NiwxNSBAQCBf X1pOSzdXZWJDb3JlOUZsb2F0UXVhZDEzY29udGFpbnNQb2ludEVSS05TXzEwRmxvYXRQb2ludEUK ICNlbmRpZgogCiAjaWYgVVNFKElPU1VSRkFDRSkKK19fWk43V2ViQ29yZTlJT1N1cmZhY2UxMWNy ZWF0ZUltYWdlRXYKIF9fWk43V2ViQ29yZTlJT1N1cmZhY2UxNHNldElzUHVyZ2VhYmxlRWIKIF9f Wk43V2ViQ29yZTlJT1N1cmZhY2UxOGNyZWF0ZUZyb21NYWNoUG9ydEVqTlNfMTBDb2xvclNwYWNl RQorX19aTjdXZWJDb3JlOUlPU3VyZmFjZTIwY2xlYXJHcmFwaGljc0NvbnRleHRFdgogX19aTjdX ZWJDb3JlOUlPU3VyZmFjZTIxZW5zdXJlR3JhcGhpY3NDb250ZXh0RXYKIF9fWk43V2ViQ29yZTlJ T1N1cmZhY2UyMWVuc3VyZVBsYXRmb3JtQ29udGV4dEV2CiBfX1pON1dlYkNvcmU5SU9TdXJmYWNl NmNyZWF0ZUVOU183SW50U2l6ZUVOU18xMENvbG9yU3BhY2VFCi1fX1pOSzdXZWJDb3JlOUlPU3Vy ZmFjZTExY3JlYXRlSW1hZ2VFdgogX19aTks3V2ViQ29yZTlJT1N1cmZhY2UxNGNyZWF0ZU1hY2hQ b3J0RXYKK19fWk5LN1dlYkNvcmU5SU9TdXJmYWNlN2lzSW5Vc2VFdgogX3drSU9TdXJmYWNlQ29u dGV4dENyZWF0ZQogX3drSU9TdXJmYWNlQ29udGV4dENyZWF0ZUltYWdlCiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKaW5k ZXggYmMxMmYyOC4uZGNhMTcyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKQEAgLTQ3LDcgKzQ3LDcgQEAgcHVibGljOgogCiAg ICAgLy8gQW55IGltYWdlcyBjcmVhdGVkIGZyb20gYSBzdXJmYWNlIG5lZWQgdG8gYmUgcmVsZWFz ZWQgYmVmb3JlIHJlbGVhc2luZwogICAgIC8vIHRoZSBzdXJmYWNlLCBvciBhbiBleHBlbnNpdmUg R1BVIHJlYWRiYWNrIGNhbiByZXN1bHQuCi0gICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGNyZWF0 ZUltYWdlKCkgY29uc3Q7CisgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGNyZWF0ZUltYWdlKCk7 CiAKICAgICBJT1N1cmZhY2VSZWYgc3VyZmFjZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3VyZmFjZS5n ZXQoKTsgfQogICAgIEdyYXBoaWNzQ29udGV4dCYgZW5zdXJlR3JhcGhpY3NDb250ZXh0KCk7CkBA IC03MSw3ICs3MSwxMSBAQCBwdWJsaWM6CiAgICAgc2l6ZV90IHRvdGFsQnl0ZXMoKSBjb25zdCB7 IHJldHVybiBtX3RvdGFsQnl0ZXM7IH0KICAgICBDb2xvclNwYWNlIGNvbG9yU3BhY2UoKSBjb25z dCB7IHJldHVybiBtX2NvbG9yU3BhY2U7IH0KIAotICAgIGJvb2wgaW5Vc2UoKSBjb25zdDsKKyAg ICBib29sIGlzSW5Vc2UoKSBjb25zdDsKKworICAgIC8vIFRoZSBncmFwaGljcyBjb250ZXh0IGNh Y2hlZCBvbiB0aGUgc3VyZmFjZSBjb3VudHMgYXMgYSAidXNlciIsIHNvIHRvIGdldAorICAgIC8v IGFuIGFjY3VyYXRlIHJlc3VsdCBmcm9tIGlzSW5Vc2UoKSwgaXQgbmVlZHMgdG8gYmUgcmVsZWFz ZWQuCisgICAgdm9pZCBjbGVhckdyYXBoaWNzQ29udGV4dCgpOwogCiBwcml2YXRlOgogICAgIElP U3VyZmFjZShJbnRTaXplLCBDb2xvclNwYWNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbSBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQppbmRleCA4NGIwMGZiLi4wNjNkZmUz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1 cmZhY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9T dXJmYWNlLm1tCkBAIC0xMTUsMTIgKzExNSw5IEBAIG1hY2hfcG9ydF90IElPU3VyZmFjZTo6Y3Jl YXRlTWFjaFBvcnQoKSBjb25zdAogICAgIHJldHVybiBJT1N1cmZhY2VDcmVhdGVNYWNoUG9ydCht X3N1cmZhY2UuZ2V0KCkpOwogfQogCi1SZXRhaW5QdHI8Q0dJbWFnZVJlZj4gSU9TdXJmYWNlOjpj cmVhdGVJbWFnZSgpIGNvbnN0CitSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gSU9TdXJmYWNlOjpjcmVh dGVJbWFnZSgpCiB7Ci0gICAgaWYgKCFtX2NnQ29udGV4dCkKLSAgICAgICAgcmV0dXJuIG51bGxw dHI7Ci0KLSAgICByZXR1cm4gYWRvcHRDRihDR0lPU3VyZmFjZUNvbnRleHRDcmVhdGVJbWFnZSht X2NnQ29udGV4dC5nZXQoKSkpOworICAgIHJldHVybiBhZG9wdENGKENHSU9TdXJmYWNlQ29udGV4 dENyZWF0ZUltYWdlKGVuc3VyZVBsYXRmb3JtQ29udGV4dCgpKSk7CiB9CiAKIENHQ29udGV4dFJl ZiBJT1N1cmZhY2U6OmVuc3VyZVBsYXRmb3JtQ29udGV4dCgpCkBAIC0xODYsOSArMTgzLDE1IEBA IElPU3VyZmFjZTo6U3VyZmFjZVN0YXRlIElPU3VyZmFjZTo6c2V0SXNQdXJnZWFibGUoYm9vbCBp c1B1cmdlYWJsZSkKICAgICByZXR1cm4gSU9TdXJmYWNlOjpTdXJmYWNlU3RhdGU6OlZhbGlkOwog fQogCi1ib29sIElPU3VyZmFjZTo6aW5Vc2UoKSBjb25zdAorYm9vbCBJT1N1cmZhY2U6OmlzSW5V c2UoKSBjb25zdAogewogICAgIHJldHVybiBJT1N1cmZhY2VJc0luVXNlKG1fc3VyZmFjZS5nZXQo KSk7CiB9CiAKK3ZvaWQgSU9TdXJmYWNlOjpjbGVhckdyYXBoaWNzQ29udGV4dCgpCit7CisgICAg bV9ncmFwaGljc0NvbnRleHQgPSBudWxscHRyOworICAgIG1fY2dDb250ZXh0ID0gbnVsbHB0cjsK K30KKwogI2VuZGlmIC8vIFVTRShJT1NVUkZBQ0UpCi0tIAoxLjguNS4yIChBcHBsZSBHaXQtNDgp Cgo=