130970 2014-03-31 08:46:41 -0700 [GTK] No longer build WebKit1 gtkdoc 2014-04-01 08:14:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130899 1 mrobinson mrobinson oldest_to_newest 995876 0 mrobinson 2014-03-31 08:46:41 -0700 We no longer need this. 995877 1 228181 mrobinson 2014-03-31 08:52:35 -0700 Created attachment 228181 Patch 996153 2 228181 cgarcia 2014-04-01 00:13:05 -0700 Comment on attachment 228181 Patch I think we should also update the build files, I think we have rules to generate the docs for webkit1 and webkit2, no? 996157 3 mrobinson 2014-04-01 00:21:09 -0700 (In reply to comment #2) > (From update of attachment 228181 [details]) > I think we should also update the build files, I think we have rules to generate the docs for webkit1 and webkit2, no? It's true that we are still generating the gtkdoc configuration file, but I think it makes sense to simply wait until we remove everything in the Source/WebKit/gtk directory instead of pulling apart the build files now. 996269 4 228181 mrobinson 2014-04-01 08:14:05 -0700 Comment on attachment 228181 Patch Clearing flags on attachment: 228181 Committed r166584: <http://trac.webkit.org/changeset/166584> 996270 5 mrobinson 2014-04-01 08:14:09 -0700 All reviewed patches have been landed. Closing bug. 228181 2014-03-31 08:52:35 -0700 2014-04-01 08:14:05 -0700 Patch bug-130970-20140331085215.patch text/plain 3930 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NTAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzA5YWUxYTJkOWRjNTQxY2ZlZGEzZTI3MmM0NmY4Mzg4 MGIzN2U0OS4uOTI1NDgzZmY3Y2RkOWQzNzU0MWFjZWIzNDhmYTg2MDM1OTczMTNiNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE0LTAzLTMxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAorICAgICAgICBbR1RLXSBObyBsb25nZXIgYnVpbGQgV2ViS2l0MSBndGtkb2MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDk3MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2NvbW1vbi5weToK KyAgICAgICAgKGd0a192ZXJzaW9uX29mX3BrZ19jb25maWdfZmlsZSk6IERlbGV0ZWQuCisgICAg ICAgICogZ3RrL2dlbmVyYXRlLWd0a2RvYzoKKyAgICAgICAgKGdldF9ndGtkb2NfbW9kdWxlX3Bh dGhzKTogV2Ugbm8gbG9uZ2VyIG5lZWQgdG8gd29ycnkgYWJvdXQgR1RLKyAyLCBzaW5jZSBpdAor ICAgICAgICB3YXMgb25seSBhcHBsaWNhYmxlIGZvciBXZWJLaXQxLgorICAgICAgICAoZ2V0X2dl bmVyYXRvcl9mb3JfY29uZmlnKTogTm8gbG9uZ2VyIGxvb2sgZm9yIHRoZSBXZWJLaXQxIGNvbmZp Z3VyYXRpb24gZmlsZS4KKworMjAxNC0wMy0zMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u QGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gUmVtb3ZlIHNjcmlwdHMgY29kZSBvbmx5IGFw cGxpY2FibGUgdG8gYXV0b3Rvb2xzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzA4NDEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2NvbW1vbi5weSBi L1Rvb2xzL2d0ay9jb21tb24ucHkKaW5kZXggNmI2ODEwMzdmZmNkZjlmMWVjYTY3MTBjZDhiMTM3 Y2ZjNzEzNGI4My4uZjYyYTM4OTNlOGM2ODgyOGNkZDg1ZjhmZmVhNWJiYzQ1MGEwNzgzOSAxMDA2 NDQKLS0tIGEvVG9vbHMvZ3RrL2NvbW1vbi5weQorKysgYi9Ub29scy9ndGsvY29tbW9uLnB5CkBA IC0xMTcsMTYgKzExNyw2IEBAIGRlZiBwcmVmaXhfb2ZfcGtnX2NvbmZpZ19maWxlKHBhY2thZ2Up OgogICAgIHJldHVybiBwa2dfY29uZmlnX2ZpbGVfdmFyaWFibGUocGFja2FnZSwgJ3ByZWZpeCcp CiAKIAotZGVmIGd0a192ZXJzaW9uX29mX3BrZ19jb25maWdfZmlsZShwa2dfY29uZmlnX3BhdGgp OgotICAgIHByb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKFsncGtnLWNvbmZpZycsIHBrZ19jb25m aWdfcGF0aCwgJy0tcHJpbnQtcmVxdWlyZXMnXSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQotICAgIHN0ZG91dCA9IHByb2Nlc3MuY29tbXVu aWNhdGUoKVswXS5kZWNvZGUoInV0Zi04IikKLQotICAgIGlmICdndGsrLTMuMCcgaW4gc3Rkb3V0 OgotICAgICAgICByZXR1cm4gMwotICAgIHJldHVybiAyCi0KLQogZGVmIHBhcnNlX291dHB1dF9s aW5lcyhmZCwgcGFyc2VfbGluZV9jYWxsYmFjayk6CiAgICAgb3V0cHV0ID0gJycKICAgICByZWFk X3NldCA9IFtmZF0KZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MgYi9Ub29s cy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCmluZGV4IGY3MzBlYTQwMDlhMzJhNTIxNmY3YWM2ZTcyMWUw Y2E1YmNhOGY2ZDAuLjNlN2YwMDhjZTVhZDMwODQyMGM1MjZmMmVkNmY2MjNiZjFhN2YwYmYgMTAw NzU1Ci0tLSBhL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MKKysrIGIvVG9vbHMvZ3RrL2dlbmVy YXRlLWd0a2RvYwpAQCAtMzksMTYgKzM5LDEzIEBAIGRlZiBjb25maWd1cmVfbG9nZ2luZyh2ZXJi b3NlKToKICAgICBlbHNlOgogICAgICAgICBoYW5kbGVyLnNldEZvcm1hdHRlcihsb2dnaW5nLkZv cm1hdHRlcignJShtZXNzYWdlKXMnKSkKIAotZGVmIGdldF9ndGtkb2NfbW9kdWxlX3BhdGhzKGd0 a192ZXJzaW9uKToKK2RlZiBnZXRfZ3RrZG9jX21vZHVsZV9wYXRocygpOgogICAgIGRlcGVuZGVu dF9wYWNrYWdlcyA9IHsKICAgICAgICAgJ2dsaWItMi4wJyA6IFsnZ2xpYicsICdnb2JqZWN0Jywg J2dpbyddLAogICAgICAgICAnbGlic291cC0yLjQnIDogWydsaWJzb3VwLTIuNCddLAotICAgICAg ICAnZ2RrLXBpeGJ1Zi0yLjAnOiBbJ2dkay1waXhidWYnXQorICAgICAgICAnZ2RrLXBpeGJ1Zi0y LjAnOiBbJ2dkay1waXhidWYnXSwKKyAgICAgICAgJ2d0aystMy4wJyA6IFsnZ3RrMycsICdnZGsz J10KICAgICB9Ci0gICAgaWYgZ3RrX3ZlcnNpb24gPT0gMzoKLSAgICAgICAgZGVwZW5kZW50X3Bh Y2thZ2VzLnVwZGF0ZSh7J2d0aystMy4wJyA6IFsnZ3RrMycsICdnZGszJ119KQotICAgIGVsc2U6 Ci0gICAgICAgIGRlcGVuZGVudF9wYWNrYWdlcy51cGRhdGUoeydndGsrLTIuMCcgOiBbJ2d0aycs ICdnZGsnXX0pCiAKICAgICBwYXRocyA9IFtdCiAgICAgaHRtbF9kaXIgPSBvcy5wYXRoLmpvaW4o J3NoYXJlJywgJ2d0ay1kb2MnLCAnaHRtbCcpCkBAIC0xMDUsNyArMTAyLDYgQEAgZGVmIGdldF9n ZW5lcmF0b3JfZm9yX2NvbmZpZyhjb25maWdfZmlsZSwgdmlydHVhbF9yb290KToKICAgICBjb25m aWcucmVhZChjb25maWdfZmlsZSkKICAgICBtb2R1bGVfbmFtZSA9IGNvbmZpZy5zZWN0aW9ucygp WzBdCiAgICAgcGtnY29uZmlnX2ZpbGUgPSBjb25maWcuZ2V0KG1vZHVsZV9uYW1lLCAncGtnY29u ZmlnX2ZpbGUnKQotICAgIGd0a192ZXJzaW9uID0gY29tbW9uLmd0a192ZXJzaW9uX29mX3BrZ19j b25maWdfZmlsZShwa2djb25maWdfZmlsZSkKIAogICAgIGlmIG5vdCBvcy5wYXRoLmlzZmlsZShw a2djb25maWdfZmlsZSk6CiAgICAgICAgIHJldHVybiBOb25lCkBAIC0xMjQsNyArMTIwLDcgQEAg ZGVmIGdldF9nZW5lcmF0b3JfZm9yX2NvbmZpZyhjb25maWdfZmlsZSwgdmlydHVhbF9yb290KToK ICAgICAgICAgJ3NvdXJjZV9kaXJzJzogc291cmNlX2RpcnMsCiAgICAgICAgICdoZWFkZXJzJzog aGVhZGVycywKICAgICAgICAgJ2NmbGFncyc6ICIgIi5qb2luKGNvbmZpZy5nZXQobW9kdWxlX25h bWUsICdjZmxhZ3MnKS5zcGxpdCgpKSwKLSAgICAgICAgJ2Nyb3NzX3JlZmVyZW5jZV9kZXBzJzog Z2V0X2d0a2RvY19tb2R1bGVfcGF0aHMoZ3RrX3ZlcnNpb24pLAorICAgICAgICAnY3Jvc3NfcmVm ZXJlbmNlX2RlcHMnOiBnZXRfZ3RrZG9jX21vZHVsZV9wYXRocygpLAogICAgICAgICAnaWdub3Jl ZF9maWxlcyc6IGZpbGVzX3RvX2lnbm9yZShzb3VyY2VfZGlycywgaGVhZGVycyksCiAgICAgfSkK IApAQCAtMTkzLDggKzE4OSw2IEBAIGlmIF9fbmFtZV9fID09ICJfX21haW5fXyI6CiAKICAgICB3 ZWJraXRkb20ud3JpdGVfZG9jX2ZpbGVzKCkKICAgICBnZW5lcmF0ZV9kb2N1bWVudGF0aW9uX2Zv cl9jb25maWcoY29tbW9uLmJ1aWxkX3BhdGgoJ2d0a2RvYy13ZWJraXRkb20uY2ZnJykpCisgICAg c2F3X3dhcm5pbmdzID0gZ2VuZXJhdGVfZG9jdW1lbnRhdGlvbl9mb3JfY29uZmlnKGNvbW1vbi5i dWlsZF9wYXRoKCdndGtkb2Mtd2Via2l0Mmd0ay5jZmcnKSkKIAotICAgIHNhd193ZWJraXQxX3dh cm5pbmdzID0gZ2VuZXJhdGVfZG9jdW1lbnRhdGlvbl9mb3JfY29uZmlnKGNvbW1vbi5idWlsZF9w YXRoKCdndGtkb2Mtd2Via2l0Z3RrLmNmZycpKQotICAgIHNhd193ZWJraXQyX3dhcm5pbmdzID0g Z2VuZXJhdGVfZG9jdW1lbnRhdGlvbl9mb3JfY29uZmlnKGNvbW1vbi5idWlsZF9wYXRoKCdndGtk b2Mtd2Via2l0Mmd0ay5jZmcnKSkKLQotICAgIHN5cy5leGl0KHNhd193ZWJraXQxX3dhcm5pbmdz IG9yIHNhd193ZWJraXQyX3dhcm5pbmdzKQorICAgIHN5cy5leGl0KHNhd193YXJuaW5ncykK