13097 2007-03-16 18:19:27 -0700 Unsupported content:inherit value 2022-07-06 16:14:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac OS X 10.4 RESOLVED INVALID http://test.csswg.org/harness/test/CSS21_DEV/single/content-inherit-001/ P3 Normal --- 1 david webkit-unassigned bfulgham emacemac7 mitz nicholas nickshanks robert syoichi webkit webkit.review.bot oldest_to_newest 18422 0 david 2007-03-16 18:19:27 -0700 WebKit ToT does not recognise content:inherit, at least on hreflang. See attached test case. 18423 1 13677 david 2007-03-16 18:21:22 -0700 Created attachment 13677 Reduced test case. 18430 2 hyatt 2007-03-17 02:14:26 -0700 Not a regression. 17311 3 hyatt 2007-03-25 23:10:38 -0700 *** Bug 13191 has been marked as a duplicate of this bug. *** 17185 4 ddkilzer 2007-03-27 04:46:02 -0700 *** Bug 13200 has been marked as a duplicate of this bug. *** 76436 5 20372 magic 2008-04-06 12:36:04 -0700 Created attachment 20372 Implements 'inherit' value for 'content' This patch implements the 'inherit' value for 'content'. I let the note about CSS3... if this patch is correct, we could remove it. I commented the switch case about the CONTENT_QUOTE, waiting my patch for #6503 is landed. 77378 6 20372 darin 2008-04-12 23:29:04 -0700 Comment on attachment 20372 Implements 'inherit' value for 'content' Thanks for taking this on. Looks like a good first cut. A few things need fixing. If you're going to implement inherit, then you need to remove the following now-inaccurate comment: // FIXME: In CSS3, it will be possible to inherit content. In CSS2 it is not. This // note is a reminder that eventually "inherit" needs to be supported. And replace it with a new one. +/* case CONTENT_QUOTE: + m_style->setContent(content->m_content.m_quote); + break;*/ We don't check in commented-out code like this in the WebKit project. The test case is inadequate. For example, it doesn't exercise the CONTENT_OBJECT or CONTENT_COUNTER cases in the newly-added switch statement. The only type of inheritance it checks is inheriting nothing. Also, are we guaranteed that m_parentStyle is non-0? I think you could probably create a test case where content: inherit is in a style without a parent, and then we'd dereference null in the inherit code. review- because of these issues. 86423 7 mitz 2008-07-19 13:23:02 -0700 See also bug 20032. 211694 8 nicholas 2010-04-12 12:04:37 -0700 I am afraid to say that this behaviour is actually wrong. It seems sensible that inherit should inherit, but there are a lot of non-obvious decisions about how to treat replaced content. In CSS3, the current public Gen-Con draft is very incomplete, but does not want does not want to allow inheritance (please comment if you know personally of any move to change this). On the other hand, in CSS2.1, 'inherit' is basically just there as a placeholder value that nearly any property can have set. It it is not intended to have any function for "content" and the spec requires none, normal, and inherit to all work the same way. Patch on its way. 211695 9 53180 nicholas 2010-04-12 12:10:18 -0700 Created attachment 53180 Rounds off support for CSS2.1 content This should go a way towards the various bugs around this (fixes bug 20032, bug 18587). 2.1 spec a little vague, but I have thought the behaviour through and am willing to explain further why I think this is the correct interpretation. Test case and code has some explanation to check first. Have worked on various projects, but this is my first time tinkering with any browser, so any problems are due to sheer ignorance. 211697 10 webkit.review.bot 2010-04-12 12:13:40 -0700 Attachment 53180 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/css/CSSParser.cpp:633: One space before end of line comments [whitespace/comments] [5] WebCore/css/CSSParser.cpp:634: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/css/CSSParser.cpp:639: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 237425 11 53180 darin 2010-06-12 19:10:22 -0700 Comment on attachment 53180 Rounds off support for CSS2.1 content Looks good. > + if (id == CSSValueNormal || > + id == CSSValueNone) > + validPrimitive = true; > + else { > + return parseContent(propId, important); > + } No braces around a single-line else. No need to break that up into multiple lines. I suggest this formatting: if (id == CSSValueNormal || id == CSSValueNone) validPrimitive = true; else return parseContent(propId, important) break; review- because this patch includes a new regression test but does not include the expected result for the test It would also be best if the test could be changed so that it can be dumpAsText instead, as we have done for many style tests in the past. But what's mandatory is including the expected results. 1881180 12 bfulgham 2022-07-06 16:14:54 -0700 It doesn't seem like 'content' supports 'inherit' in the current spec. 13677 2007-03-16 18:21:22 -0700 2007-03-16 18:21:22 -0700 Reduced test case. content-inherit.xhtml application/xhtml+xml 1252 david PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPCFET0NUWVBFIGh0bWwgUFVC TElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvVFIveGh0 bWwxMS9EVEQveGh0bWwxMS5kdGQiPgo8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5 OS94aHRtbCIgeG1sOmxhbmc9ImVuIj4KPGhlYWQ+Cgk8dGl0bGU+Y29udGVudDppbmhlcml0PC90 aXRsZT4KCTxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CltocmVmbGFuZ106YWZ0ZXIge2NvbnRlbnQ6 IlxhMFsiIGF0dHIoaHJlZmxhbmcpICJdIn0KW2hyZWZsYW5nfD1lbl06YWZ0ZXIJe2NvbnRlbnQ6 aW5oZXJpdH0KI2NvbnRlbnQtbm9uZVtocmVmbGFuZ3w9ZW5dOmFmdGVyCXtjb250ZW50OiIifQoJ PC9zdHlsZT4KPC9oZWFkPgoKPGJvZHk+CjxoMT5Db2RlPC9oMT4KPG9sPgoJPGxpPjxjb2RlPlto cmVmbGFuZ106YWZ0ZXIge2NvbnRlbnQ6IlxhMFsiIGF0dHIoaHJlZmxhbmcpICJdIn08L2NvZGU+ PC9saT4KCTxsaT48Y29kZT5baHJlZmxhbmd8PWVuXTphZnRlcgl7Y29udGVudDppbmhlcml0fTwv Y29kZT48L2xpPgoJPGxpPjxjb2RlPltocmVmbGFuZ3w9ZW5dOmFmdGVyCXtjb250ZW50OiIifTwv Y29kZT48L2xpPgo8L29sPgo8aDE+RGVzY3JpcHRpb248L2gxPgo8b2w+Cgk8bGk+PGEgaHJlZj0i IyIgaHJlZmxhbmc9ImZyIj5UaGlzIGxpbms8L2E+IGxlYWRzIHRvIGEgRnJlbmNoLWxhbmd1YWdl IHBhZ2UuIFlvdSBzaGFsbCBzZWUgPGNvZGU+W2ZyXTwvY29kZT4gYWZ0ZXIgaXQuPC9saT4KCTxs aT48YSBocmVmPSIjIiBocmVmbGFuZz0iZW4tdXMiIGlkPSJjb250ZW50LW5vbmUiPlRoaXMgbGlu azwvYT4gbGVhZHMgdG8gYW4gRW5nbGlzaC1sYW5ndWFnZSBwYWdlLiBZb3Ugc2hhbGwgc2VlIG5v dGhpbmcgYWZ0ZXIgaXQuIFN0eWxlIGlzIDxjb2RlPmNvbnRlbnQ6IiI8L2NvZGU+LjwvbGk+Cgk8 bGk+PGEgaHJlZj0iIyIgaHJlZmxhbmc9ImVuLXVzIj5UaGlzIGxpbms8L2E+IGxlYWRzIHRvIGFu IEVuZ2xpc2gtbGFuZ3VhZ2UgcGFnZS4gWW91IHNoYWxsIHNlZSBub3RoaW5nIGFmdGVyIGl0LiBT dHlsZSBpcyA8Y29kZT5jb250ZW50OmluaGVyaXQ8L2NvZGU+LjwvbGk+Cjwvb2w+CjxwPk9uIHRo ZSBsYXN0LCB3aXRoIFdlYktpdCBUb1QsIHlvdSBzZWUgPGNvZGU+W2VuLXVzXTwvY29kZT4uIE1v emlsbGEgYW5kIE9wZXJhIGJlaGF2ZSBhcyBleHBlY3RlZC48L3A+CjwvYm9keT4KPC9odG1sPg== 20372 2008-04-06 12:36:04 -0700 2008-04-12 23:29:04 -0700 Implements 'inherit' value for 'content' 13097.diff text/plain 3509 magic SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTY3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDQtMDYgIFZpbmNlbnQgUmljYXJkICA8bWFnaWNAbWFnaWNu aW5qYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnVnIDEzMDk3OiBVbnN1cHBvcnRlZCBjb250ZW50OmluaGVyaXQgdmFsdWUKKworICAgICAg ICBUZXN0OiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9jb250ZW50LWluaGVyaXQuaHRtbAor CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisKIDIwMDgtMDQtMDUgIEtldmluIE9s bGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFyayBSb3dlLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDMxNjY3 KQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTMzNTgsNiArMzM1OCwyNiBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHko aW50CiAgICAgewogICAgICAgICAvLyBGSVhNRTogSW4gQ1NTMywgaXQgd2lsbCBiZSBwb3NzaWJs ZSB0byBpbmhlcml0IGNvbnRlbnQuICBJbiBDU1MyIGl0IGlzIG5vdC4gIFRoaXMKICAgICAgICAg Ly8gbm90ZSBpcyBhIHJlbWluZGVyIHRoYXQgZXZlbnR1YWxseSAiaW5oZXJpdCIgbmVlZHMgdG8g YmUgc3VwcG9ydGVkLgorICAgICAgICBpZiAoaXNJbmhlcml0KSB7CisgICAgICAgICAgICBtX3N0 eWxlLT5jbGVhckNvbnRlbnQoKTsKKyAgICAgICAgICAgIGZvciAoY29uc3QgQ29udGVudERhdGEq IGNvbnRlbnQgPSBtX3BhcmVudFN0eWxlLT5jb250ZW50RGF0YSgpOyBjb250ZW50OyBjb250ZW50 ID0gY29udGVudC0+bV9uZXh0KSB7CisgICAgICAgICAgICAgICAgc3dpdGNoIChjb250ZW50LT5t X3R5cGUpIHsKKyAgICAgICAgICAgICAgICAgICAgY2FzZSBDT05URU5UX09CSkVDVDoKKyAgICAg ICAgICAgICAgICAgICAgICAgIG1fc3R5bGUtPnNldENvbnRlbnQoY29udGVudC0+bV9jb250ZW50 Lm1fb2JqZWN0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAg ICAgICAgICBjYXNlIENPTlRFTlRfVEVYVDoKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fc3R5 bGUtPnNldENvbnRlbnQoY29udGVudC0+bV9jb250ZW50Lm1fdGV4dCk7CisgICAgICAgICAgICAg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgY2FzZSBDT05URU5UX0NPVU5U RVI6CisgICAgICAgICAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRDb250ZW50KGNvbnRlbnQt Pm1fY29udGVudC5tX2NvdW50ZXIpOworICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cisv KiAgICAgICAgICAgICAgICAgICAgY2FzZSBDT05URU5UX1FVT1RFOgorICAgICAgICAgICAgICAg ICAgICAgICAgbV9zdHlsZS0+c2V0Q29udGVudChjb250ZW50LT5tX2NvbnRlbnQubV9xdW90ZSk7 CisgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsqLworICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogCiAgICAgICAgIGlm IChpc0luaXRpYWwpIHsKICAgICAgICAgICAgIG1fc3R5bGUtPmNsZWFyQ29udGVudCgpOwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gMzE2NzIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0wNC0wNiAgVmluY2VudCBSaWNhcmQgIDxtYWdp Y0BtYWdpY25pbmphLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0Y2FzZSBmb3I6CisgICAgICAgIEJ1ZyAxMzA5NzogVW5zdXBwb3J0ZWQg Y29udGVudDppbmhlcml0IHZhbHVlCisKKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29u dGVudC9jb250ZW50LWluaGVyaXQuaHRtbDogQWRkZWQuCisKIDIwMDgtMDQtMDUgIFJvYiBCdWlz ICA8YnVpc0BrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9jb250ZW50LWluaGVyaXQuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9jb250 ZW50LWluaGVyaXQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzLWdl bmVyYXRlZC1jb250ZW50L2NvbnRlbnQtaW5oZXJpdC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDE4IEBACis8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJ1dGYtOCI/PgorPCFET0NU WVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDovL3d3dy53 My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPgorPGh0bWwgeG1sbnM9Imh0dHA6Ly93 d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiI+Cis8aGVhZD4KKwk8dGl0bGU+Y29u dGVudDppbmhlcml0PC90aXRsZT4KKwk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorW2hyZWZsYW5n XTphZnRlciB7Y29udGVudDoiXGEwWyIgYXR0cihocmVmbGFuZykgIl0ifQorW2hyZWZsYW5nfD1l bl06YWZ0ZXIJe2NvbnRlbnQ6aW5oZXJpdH0KKwk8L3N0eWxlPgorPC9oZWFkPgorCis8Ym9keT4K KzxvbD4KKwk8bGk+PGEgaHJlZj0iIyIgaHJlZmxhbmc9ImZyIj5UaGlzIGxpbms8L2E+IGxlYWRz IHRvIGEgRnJlbmNoLWxhbmd1YWdlIHBhZ2UuIFlvdSBzaGFsbCBzZWUgPGNvZGU+W2ZyXTwvY29k ZT4gYWZ0ZXIgaXQuPC9saT4KKwk8bGk+PGEgaHJlZj0iIyIgaHJlZmxhbmc9ImVuLXVzIj5UaGlz IGxpbms8L2E+IGxlYWRzIHRvIGFuIEVuZ2xpc2gtbGFuZ3VhZ2UgcGFnZS4gWW91IHNoYWxsIHNl ZSBub3RoaW5nIGFmdGVyIGl0LiBTdHlsZSBpcyA8Y29kZT5jb250ZW50OmluaGVyaXQ8L2NvZGU+ LjwvbGk+Cis8L29sPgorPC9ib2R5PgorPC9odG1sPgo= 53180 2010-04-12 12:10:18 -0700 2010-06-12 19:10:22 -0700 Rounds off support for CSS2.1 content patch-base text/plain 7691 nicholas SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzQ3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMTIgIE5pY2hvbGFzIFdpbHNvbiAgPG5pY2hvbGFzQG5p Y2hvbGFzd2lsc29uLm1lLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvcnJlY3QgaGFuZGxpbmcgQ1NTIGdlbmVyYXRlZCBjb250ZW50LCB2YWx1 ZXM6IG5vbmUsIGluaGVyaXQsIG5vcm1hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTcKKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy1nZW5lcmF0 ZWQtY29udGVudC9ub25lLW5vcm1hbC1pbmhlcml0Lmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQ YXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZVZhbHVlKToKKyAg ICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NT dHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KToKKwogMjAxMC0wNC0xMiAgRGF2aWQgSHlhdHQg IDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5k ZXg6IFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcAkocmV2aXNpb24gNTc0NjcpCisrKyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MzAsOSArNjMwLDE0IEBAIGJvb2wgQ1NTUGFyc2VyOjpw YXJzZVZhbHVlKGludCBwcm9wSWQsIGIKICAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gdHJ1 ZTsKICAgICAgICAgYnJlYWs7CiAKLSAgICBjYXNlIENTU1Byb3BlcnR5Q29udGVudDogICAgICAg ICAgICAgIC8vIFsgPHN0cmluZz4gfCA8dXJpPiB8IDxjb3VudGVyPiB8IGF0dHIoWCkgfCBvcGVu LXF1b3RlIHwKLSAgICAgICAgLy8gY2xvc2UtcXVvdGUgfCBuby1vcGVuLXF1b3RlIHwgbm8tY2xv c2UtcXVvdGUgXSsgfCBpbmhlcml0Ci0gICAgICAgIHJldHVybiBwYXJzZUNvbnRlbnQocHJvcElk LCBpbXBvcnRhbnQpOworICAgIGNhc2UgQ1NTUHJvcGVydHlDb250ZW50OiAgICAgICAgICAgICAg Ly8gWyAuLi4gXSsgfCBpbmhlcml0IHwgbm9uZSB8IG5vcm1hbAorICAgICAgICBpZiAoaWQgPT0g Q1NTVmFsdWVOb3JtYWwgfHwKKyAgICAgICAgICAgIGlkID09IENTU1ZhbHVlTm9uZSkKKyAgICAg ICAgICAgIHZhbGlkUHJpbWl0aXZlID0gdHJ1ZTsKKyAgICAgICAgZWxzZSB7CisgICAgICAgICAg ICByZXR1cm4gcGFyc2VDb250ZW50KHByb3BJZCwgaW1wb3J0YW50KTsKKyAgICAgICAgfQorICAg ICAgICBicmVhazsKIAogICAgIGNhc2UgQ1NTUHJvcGVydHlXaGl0ZVNwYWNlOiAgICAgICAgICAv LyBub3JtYWwgfCBwcmUgfCBub3dyYXAgfCBpbmhlcml0CiAgICAgICAgIGlmIChpZCA9PSBDU1NW YWx1ZU5vcm1hbCB8fApAQCAtMjEwNCw5ICsyMTA5LDkgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNl NFZhbHVlcyhpbnQgcHJvcElkLAogICAgIHJldHVybiB0cnVlOwogfQogCi0vLyBbIDxzdHJpbmc+ IHwgPHVyaT4gfCA8Y291bnRlcj4gfCBhdHRyKFgpIHwgb3Blbi1xdW90ZSB8IGNsb3NlLXF1b3Rl IHwgbm8tb3Blbi1xdW90ZSB8IG5vLWNsb3NlLXF1b3RlIF0rIHwgaW5oZXJpdAotLy8gaW4gQ1NT IDIuMSB0aGlzIGdvdCBzb21ld2hhdCByZWR1Y2VkOgotLy8gWyA8c3RyaW5nPiB8IGF0dHIoWCkg fCBvcGVuLXF1b3RlIHwgY2xvc2UtcXVvdGUgfCBuby1vcGVuLXF1b3RlIHwgbm8tY2xvc2UtcXVv dGUgXSsgfCBpbmhlcml0CisvLyBDU1MyLjEgdmFsdWVzCisvLyBub3JtYWwgfCBub25lIHwgWyA8 c3RyaW5nPiB8IDx1cmk+IHwgPGNvdW50ZXI+IHwgYXR0cig8aWRlbnRpZmllcj4pIHwgb3Blbi1x dW90ZSB8IGNsb3NlLXF1b3RlIHwgbm8tb3Blbi1xdW90ZSB8IG5vLWNsb3NlLXF1b3RlIF0rIHwg aW5oZXJpdAorLy8gSGVyZSB3ZSBwYXJzZSBqdXN0IHRoZSBbLi4uXSsgcGFydAogYm9vbCBDU1NQ YXJzZXI6OnBhcnNlQ29udGVudChpbnQgcHJvcElkLCBib29sIGltcG9ydGFudCkKIHsKICAgICBS ZWZQdHI8Q1NTVmFsdWVMaXN0PiB2YWx1ZXMgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZUNvbW1hU2Vw YXJhdGVkKCk7CkluZGV4OiBXZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gNTc0Njcp CisrKyBXZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDEzMywxNiArNDEzMywyMiBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHko aW50CiAKIC8vIGxpc3RzCiAgICAgY2FzZSBDU1NQcm9wZXJ0eUNvbnRlbnQ6Ci0gICAgICAgIC8v IGxpc3Qgb2Ygc3RyaW5nLCB1cmksIGNvdW50ZXIsIGF0dHIsIGkKLSAgICB7Ci0gICAgICAgIC8v IEZJWE1FOiBJbiBDU1MzLCBpdCB3aWxsIGJlIHBvc3NpYmxlIHRvIGluaGVyaXQgY29udGVudC4g IEluIENTUzIgaXQgaXMgbm90LiAgVGhpcwotICAgICAgICAvLyBub3RlIGlzIGEgcmVtaW5kZXIg dGhhdCBldmVudHVhbGx5ICJpbmhlcml0IiBuZWVkcyB0byBiZSBzdXBwb3J0ZWQuCisgICAgICAg ICAvLyBub25lIHwgbm9ybWFsIHwgaW5oZXJpdCB8IFtzdHJpbmcgfCB1cmkgfCBjb3VudGVyIHwg YXR0ciB8IEZJWE1FIHF1b3RlLi4uXSsKKyAgICAgeworICAgICAgICAvLyBJbiBDU1MgMi4xLCAn bm9ybWFsJyBhbHdheXMgZG9lcyBub3RoaW5nIChidXQgaXMgYW4gaW1wb3J0YW50IHBsYWNlLWhv bGRlcgorICAgICAgICAvLyBmb3IgQ1NTMyksIGFuZCAnaW5oZXJpdCcgaXMgYSBnZW5lcmljIHBy b3BlcnR5IHRoYXQgY29tcHV0ZXMgdG8gJ25vbmUnLgorICAgICAgICAvLyBUbyBiZSBjbGVhcjog ZGVsaWJlcmF0ZWx5IGRvIG5vdCB0b3VjaCBDU1MzIGhlcmUuIEZ1bGwKKyAgICAgICAgLy8gQ1NT MiBjb250ZW50IGlzIGNyb3NzLWJyb3dzZXIgaW5jb25zaXN0ZW50LCBzbyBzdGljayB0byBzYWZl IGJlaGF2aW91cgorICAgICAgICAvLyB1bnRpbCBzdXJlIGNoYW5nZXMgYXJlIGNvbnN0cnVjdGl2 ZS4KIAotICAgICAgICBpZiAoaXNJbml0aWFsKSB7Ci0gICAgICAgICAgICBtX3N0eWxlLT5jbGVh ckNvbnRlbnQoKTsKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgaW50IGlkID0gMDsKKyAg ICAgICAgaWYgKHByaW1pdGl2ZVZhbHVlKQorICAgICAgICAgICAgaWQgPSBwcmltaXRpdmVWYWx1 ZS0+Z2V0SWRlbnQoKTsKKyAgICAgICAgaWYgKGlzSW5pdGlhbCB8fCBpc0luaGVyaXQgfHwgaWQg PT0gQ1NTVmFsdWVOb3JtYWwgfHwgaWQgPT0gQ1NTVmFsdWVOb25lKSB7CisgICAgICAgICAgICAg bV9zdHlsZS0+Y2xlYXJDb250ZW50KCk7CisgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 Ci0gICAgICAgIAorCiAgICAgICAgIGlmICghdmFsdWUtPmlzVmFsdWVMaXN0KCkpCiAgICAgICAg ICAgICByZXR1cm47CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3NDc2KQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTIgIE5p Y2hvbGFzIFdpbHNvbiAgPG5pY2hvbGFzQG5pY2hvbGFzd2lsc29uLm1lLnVrPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3QgaGFuZGxpbmcg Q1NTIGdlbmVyYXRlZCBjb250ZW50LCB2YWx1ZXM6IG5vbmUsIGluaGVyaXQsIG5vcm1hbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTcKKyAgICAg ICAgVGhlIHRlc3QgY2hlY2tzIHRoYXQgdGhlIG5ldyB2YWx1ZXMgd29yayBhbmQgZW5zdXJlcyBv bGQgaW1wbGVtZW50YXRpb25zIG9mIGluaGVyaXQgYXJlIGNhdWdodCAKKworICAgICAgICAqIGZh c3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L25vbmUtbm9ybWFsLWluaGVyaXQuaHRtbDogQWRkZWQu CisKIDIwMTAtMDQtMTIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5l cmF0ZWQtY29udGVudC9ub25lLW5vcm1hbC1pbmhlcml0Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvbm9uZS1ub3JtYWwtaW5oZXJpdC5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRl bnQvbm9uZS1ub3JtYWwtaW5oZXJpdC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDgwIEBA Cis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMS8vRU4iICJodHRw Oi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJpY3QuZHRkIj4KKzxodG1sPgorICA8aGVhZD4KKyAg ICA8dGl0bGU+VGVzdCBmb3IgY29udGVudDogbm9uZSBhbmQgY29udGVudDogbm9ybWFsPC90aXRs ZT4KKyAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorZGl2OmJlZm9yZSwgZGl2OmFmdGVyIHsg Y29sb3I6IHJlZDsgcGFkZGluZzogMCAxZW07IGJhY2tncm91bmQ6ICNGRkNDQ0M7fQorCisjbm9u ZS1ub3JtYWw6YmVmb3JlLCAjbm9uZS1ub3JtYWw6YWZ0ZXIgeyBjb250ZW50OiAiRmFpbGVkICI7 IH0KKyNub25lLW5vcm1hbDpiZWZvcmUgeyBjb250ZW50OiBub25lOyB9Cisjbm9uZS1ub3JtYWw6 YWZ0ZXIgeyBjb250ZW50OiBub3JtYWw7IH0KKworI2VtcHR5LXN0cmluZyB7CisgICAgd2lkdGg6 IDEwZW07CisgICAgbGluZS1oZWlnaHQ6IDJlbTsKKyAgICBiYWNrZ3JvdW5kOiAjRkZDQ0NDOwor ICAgIGNvbG9yOiByZWQ7CisgICAgdGV4dC1hbGlnbjogY2VudGVyOworICAgIHBvc2l0aW9uOiBy ZWxhdGl2ZTsKK30KKyNlbXB0eS1zdHJpbmc6YmVmb3JlIHsgbGVmdDogMDsgfQorI2VtcHR5LXN0 cmluZzphZnRlciB7IHJpZ2h0OiAwOyB9CisjZW1wdHktc3RyaW5nOmJlZm9yZSwgI2VtcHR5LXN0 cmluZzphZnRlciB7CisgICAgY29udGVudDogIiI7CisgICAgcG9zaXRpb246IGFic29sdXRlOwor ICAgIHdpZHRoOiAzZW07CisgICAgaGVpZ2h0OiAyZW07CisgICAgYmFja2dyb3VuZDogZ3JlZW47 fQorCisjaW5oZXJpdC1wOmJlZm9yZSwgI2luaGVyaXQtcDphZnRlciB7CisgICAgY29udGVudDog IkZhaWxlZCAiOworICAgIGNvbnRlbnQ6IGluaGVyaXQ7Cit9CisKKyNpbmhlcml0LWUgeyBjb250 ZW50OiAiRmFpbGVkICI7IH0KKworI2luaGVyaXQtZXAgeyBjb250ZW50OiAiRmFpbGVkICI7IH0K KyNpbmhlcml0LWVwOmJlZm9yZSwgI2luaGVyaXQtZXA6YWZ0ZXIgeworICAgIGNvbnRlbnQ6IGlu aGVyaXQ7Cit9CisgICAgPC9zdHlsZT4KKyAgPC9oZWFkPgorICA8Ym9keT4KKyAgICA8c3Ryb25n Pk5vdGhpbmcgaW4gcmVkIHNob3VsZCBhcHBlYXIgYmVsb3csIG5laXRoZXIgdGhlIHRleHQgIkZh aWxlZCIgbm9yIGEgcmVkIGJhY2tncm91bmQgd2l0aCBubyB0ZXh0Ljwvc3Ryb25nPgorICAgIDxv bD4KKyAgICA8bGk+CisgICAgICAgIDxwPgorICAgICAgICBUaGlzIHRlc3QgY2hlY2tzIGlmIHRo ZSBwcm9wZXJ0eSB2YWx1ZXMgIm5vbmUiIGFuZCAibm9ybWFsIiBmb3IKKyAgICAgICAgPGEgaHJl Zj0iaHR0cDovL3d3dy53My5vcmcvVFIvMjAwOS9DUi1DU1MyLTIwMDkwNDIzL2dlbmVyYXRlLmh0 bWwjY29udGVudCI+Q1NTIDIuMSAiY29udGVudCIgcHJvcGVydHk8L2E+CisKKyAgICAgICAgYXJl IHByb3Blcmx5IHN1cHBvcnRlZC4KKyAgICAgICAgPC9wPgorICAgICAgICA8ZGl2IGlkPSJub25l LW5vcm1hbCI+PC9kaXY+CisgICAgPC9saT4KKyAgICA8bGk+CisgICAgICAgIDxwPgorICAgICAg ICBUaGlzIHRlc3QgY2hlY2tzIHRoYXQgcHNldWRvLWVsZW1lbnRzIGFyZSBzdGlsbCByZW5kZXJl ZCB3aGVuICJjb250ZW50IiBpcyBhbiBlbXB0eSBzdHJpbmcuIEEgZ3JlZW4gYm94IHNob3VsZCBh cHBlYXIuCisgICAgICAgIDwvcD4KKyAgICAgICAgPGRpdiBpZD0iZW1wdHktc3RyaW5nIj5GYWls ZWQ8L2Rpdj4KKyAgICA8L2xpPgorICAgIDxsaT4KKyAgICAgICAgPHA+CisgICAgICAgIFRoaXMg dGVzdCBjaGVja3MgaWYgdGhlIHByb3BlcnR5IHZhbHVlICJpbmhlcml0IiBmcm9tIENTUzIuMSBm b3IgdGhlICJjb250ZW50IiBwcm9wZXJ0eSBpcyBzdXBwb3J0ZWQgb24gcHNldWRvLWVsZW1lbnRz LiBUaGUgd29yZCAiRmFpbGVkIiBzaG91bGQgbm90IGFwcGVhciBiZWxvdy4KKyAgICAgICAgPC9w PgorICAgICAgICA8ZGl2IGlkPSJpbmhlcml0LXAiPjwvZGl2PgorICAgIDwvbGk+CisgICAgPGxp PgorICAgICAgICA8cD4KKyAgICAgICAgVGhpcyB0ZXN0IGNoZWNrcyBpZiB0aGUgcHJvcGVydHkg dmFsdWUgImluaGVyaXQiIGZyb20gQ1NTMi4xIGZvciB0aGUgImNvbnRlbnQiIHByb3BlcnR5IGlz IHN1cHBvcnRlZCBvbiAobm9uLXBzZXVkby0pZWxlbWVudHMuIEluIENTUzIuMSwgImNvbnRlbnQi IG11c3QgYWx3YXlzIGNvbXB1dGUgdG8gbm9ybWFsIG9uIGVsZW1lbnRzLgorICAgICAgICA8L3A+ CisgICAgICAgIDxkaXYgaWQ9ImluaGVyaXQtZSI+PC9kaXY+CisgICAgPC9saT4KKyAgICA8bGk+ CisgICAgICAgIDxwPgorICAgICAgICBUaGlzIHRlc3QgY2hlY2tzIGlmIHRoZSBwcm9wZXJ0eSB2 YWx1ZSAiaW5oZXJpdCIgZnJvbSBDU1MyLjEgZm9yIHRoZSAiY29udGVudCIgcHJvcGVydHkgaXMg Y29ycmVjdGx5IGhhbmRsZWQgb24gcHNldWRvLWVsZW1lbnRzIHdoZW4gdGhlIHBhcmVudCBlbGVt ZW50IGhhcyAiY29udGVudCIgc2V0LiBUaGlzIHRlc3QgY29uZm9ybXMgdG8gQ1NTMi4xIGFuZCB0 aGUgPGEgaHJlZj0iaHR0cDovL3d3dy53My5vcmcvVFIvMjAwMy9XRC1jc3MzLWNvbnRlbnQtMjAw MzA1MTQvI2luc2VydGluZy0zIj4yMDAzIGRyYWZ0IG9mIENTUzM8L2E+LCB3aGljaCBpbiBmYWN0 IGRvZXMgbm90IGFsbG93ICJpbmhlcml0IiBhdCBhbGwuIFRoaXMgdGVzdCBpcyBzcGVjaWZpY2Fs bHkgdXNlZCBiZWNhdXNlIG9mIGNoYW5nZWQgYmVoYXZpb3VyIGZyb20gb2xkZXIgQ1NTMyBkcmFm dHMuIFJlZ2FyZGxlc3Mgb2YgdGhlIGZpbmFsIENTUzMgYmVoYXZpb3VyLCBDU1MyIGNvbXBsaWFu Y2UgbXVzdCBiZSBrZXB0LgorICAgICAgICA8L3A+CisgICAgICAgIDxkaXYgaWQ9ImluaGVyaXQt ZXAiPjwvZGl2PgorICAgIDwvbGk+CisgICAgPC9vbD4KKyAgPC9ib2R5PgorPC9odG1sPgo=