130965 2014-03-31 04:09:59 -0700 [CMake] Stop checking for WTF_USE_ICU_UNICODE. 2014-03-31 08:06:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco bunhere cgarcia commit-queue gyuyoung.kim gyuyoung.kim mrobinson sergio oldest_to_newest 995829 0 rakuco 2014-03-31 04:09:59 -0700 [CMake] Stop checking for WTF_USE_ICU_UNICODE. 995830 1 228172 rakuco 2014-03-31 04:11:00 -0700 Created attachment 228172 Patch 995852 2 228172 mrobinson 2014-03-31 07:11:31 -0700 Comment on attachment 228172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review > Source/JavaScriptCore/CMakeLists.txt:30 > + "${ICU_INCLUDE_DIRS}" I'm pretty sure you don't want parenthesis here, since there may be more than one directory. 995854 3 rakuco 2014-03-31 07:30:34 -0700 (In reply to comment #2) > (From update of attachment 228172 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review > > > Source/JavaScriptCore/CMakeLists.txt:30 > > + "${ICU_INCLUDE_DIRS}" > > I'm pretty sure you don't want parenthesis here, since there may be more than one directory. This should be fine; if the variable has a list each item is added as a separate path. 995855 4 mrobinson 2014-03-31 07:35:58 -0700 (In reply to comment #3) > This should be fine; if the variable has a list each item is added as a separate path. Won't it evaluate the list as "one two three" instead of "one" "two" "three" though? 995860 5 rakuco 2014-03-31 07:42:37 -0700 (In reply to comment #4) > (In reply to comment #3) > > > This should be fine; if the variable has a list each item is added as a separate path. > > Won't it evaluate the list as "one two three" instead of "one" "two" "three" though? As in "-Ione two three" instead of "-Ione -Itwo -Ithree"? Not really; include_directories("one;two;three") becomes "-Ione -Itwo -Ithree". 995866 6 rakuco 2014-03-31 08:06:12 -0700 Committed r166503: <http://trac.webkit.org/changeset/166503> 995867 7 rakuco 2014-03-31 08:06:41 -0700 (In reply to comment #6) > Committed r166503: <http://trac.webkit.org/changeset/166503> This is a slightly modified version that does not quote ${ICU_INCLUDE_DIRS}. 228172 2014-03-31 04:11:00 -0700 2014-03-31 07:11:31 -0700 Patch bug-130965-20140331141206.patch text/plain 1850 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MzU4MWVjZjUxZTY4ZjVjYTMwNzg5OTg1MzBmMWYxYzlhYTlkMTg2Li4yOTU1MGYxMmNmYmUwMjA4 OWI0YTcxNDExYzZlODkyMmVmYjg1ZmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wMy0zMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFwaGFlbC5r dWJvLmRhLmNvc3RhQGludGVsLmNvbT4KKworICAgICAgICBbQ01ha2VdIFN0b3AgY2hlY2tpbmcg Zm9yIFdURl9VU0VfSUNVX1VOSUNPREUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzA5NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIHNvbWV3aGF0IG9mIGEgZm9sbG93LXVwIHRvIHIxNjI3 ODIsIHdoaWNoIGdvdCByaWQgb2YKKyAgICAgICAgV1RGX1VTRV9JQ1VfVU5JQ09ERSBpbiBDTWFr ZSBidXQgZGlkIG5vdCByZW1vdmUgdGhlIGNoZWNrIGluIEpTQydzCisgICAgICAgIENNYWtlTGlz dHMudHh0LiBUaGlzIG1lYW50IHRoZSBpbmNsdWRlcyBhbmQgbGlicmFyaWVzIHdlcmUgbm90Cisg ICAgICAgIGJlaW5nIHByb3Blcmx5IGluY2x1ZGVkIHNpbmNlIHRoZW4uCisKKyAgICAgICAgKiBD TWFrZUxpc3RzLnR4dDoKKwogMjAxNC0wMy0yOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIExhbmQgdGhlIHN0YWNrbWFwIHJlZ2lzdGVyIGxpdmVuZXNzIGdsdWUg d2l0aCB0aGUgdXNlcyBvZiB0aGUgbGl2ZW5lc3MgZGlzYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D TWFrZUxpc3RzLnR4dAppbmRleCBmZjk1NTllZjVjYjRkZWUxMTBlYzNhNGM4YmZjZmRkZGUyNzA1 YjA0Li5mMmJkMjFiODdiZDM1NTYyY2U4ODk3ODNiMzUzZjY4ODIwMjhhNjBlIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0yNyw2ICsyNyw3IEBAIHNldChKYXZhU2NyaXB0 Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V1RGX0RJUn0iCiAgICAgIiR7REVSSVZF RF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0iCiAgICAgIiR7Q01BS0VfU09VUkNFX0RJUn0v U291cmNlIgorICAgICIke0lDVV9JTkNMVURFX0RJUlN9IgogKQogCiBzZXQoSmF2YVNjcmlwdENv cmVfU09VUkNFUwpAQCAtNTI4LDE3ICs1MjksOSBAQCBzZXQoSmF2YVNjcmlwdENvcmVfTFVUX0ZJ TEVTCiAKIHNldChKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMKICAgICBXVEYKKyAgICAke0lDVV9J MThOX0xJQlJBUklFU30KICkKIAotaWYgKFdURl9VU0VfSUNVX1VOSUNPREUpCi0gICAgbGlzdChB UFBFTkQgSmF2YVNjcmlwdENvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwotICAgICAgICAke0lDVV9J TkNMVURFX0RJUlN9Ci0gICAgKQotICAgIGxpc3QoQVBQRU5EIEphdmFTY3JpcHRDb3JlX0xJQlJB UklFUwotICAgICAgICAke0lDVV9JMThOX0xJQlJBUklFU30KLSAgICApCi1lbmRpZiAoKQotCiBp ZiAoV1RGX1VTRV9VRElTODYpCiAgICAgc2V0KFVESVNfR0VOX0RFUAogICAgICAgICBkaXNhc3Nl bWJsZXIvdWRpczg2L3VkX29wY29kZS5weQo=