130961 2014-03-31 01:02:44 -0700 Upgrade to SelectorFailsAllSiblings failure when Child selector is failed 2014-04-05 00:37:31 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki webkit-unassigned allan.jensen benjamin commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 995787 0 ysuzuki 2014-03-31 01:02:44 -0700 When Child selector fails, we should resume matching from the closest Descendant selector. So upgrading SelectorFailsLocally to SelectorFailsAllSibling at least to prevent unnecessary direct/indirect adjacent selectors matching. 995789 1 228158 ysuzuki 2014-03-31 01:07:17 -0700 Created attachment 228158 Patch 995897 2 ysuzuki 2014-03-31 09:49:39 -0700 To clearify the executing model in my mind, I've created a small patch to match markRecursively's resuming strategy to CSS JIT's. 997705 3 228158 benjamin 2014-04-04 15:28:41 -0700 Comment on attachment 228158 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228158&action=review Great idea! > Source/WebCore/css/SelectorChecker.cpp:219 > + nextContext.elementStyle = 0; You can change this to nullptr now that WebKit supports C++ 11. 997707 4 benjamin 2014-04-04 15:31:12 -0700 Committed r166808: <http://trac.webkit.org/changeset/166808> 997850 5 ysuzuki 2014-04-05 00:37:31 -0700 Thank you for your review and fixing 0 to nullptr! 228158 2014-03-31 01:07:17 -0700 2014-04-04 15:28:52 -0700 Patch bug-130961-20140331170717.patch text/plain 2314 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc0MDAxOTJlYWY2ZGE1 MzJkMGUyMjdlOWRmNDJmNTMxOGE4OWE2Yi4uZTUyNjE2Mjk0OTVlMWUyZDNmM2Q1OTg2MjA1NGYx Y2U3MDA4Mjg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTMxICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVwZ3JhZGUgdG8g U2VsZWN0b3JGYWlsc0FsbFNpYmxpbmdzIHdoZW4gQ2hpbGQgc2VsZWN0b3IgaXMgZmFpbGVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTYxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBDaGls ZCBzZWxlY3RvciBmYWlscywgd2Ugc2hvdWxkIHJlc3VtZSBtYXRjaGluZyBmcm9tIHRoZSBjbG9z ZXN0CisgICAgICAgIERlc2NlbmRhbnQgc2VsZWN0b3IuCisgICAgICAgIFNvIHVwZ3JhZGluZyBT ZWxlY3RvckZhaWxzTG9jYWxseSB0byBTZWxlY3RvckZhaWxzQWxsU2libGluZyBhdCBsZWFzdAor ICAgICAgICB0byBwcmV2ZW50IHVubmVjZXNzYXJ5IGRpcmVjdC9pbmRpcmVjdCBhZGphY2VudCBz ZWxlY3RvcnMgbWF0Y2hpbmcuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JDaGVja2VyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6bWF0Y2hSZWN1cnNpdmVseSk6CisK IDIwMTQtMDMtMjggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBDbGVhciBTVkdJbmxpbmVUZXh0Qm94IGZyYWdtZW50cyB3aGVuIHRoZSB0ZXh0IGNo YW5nZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCmluZGV4IDUzYzUwZDhj ZGFiYzdmZTM2NDc4ZTgxODE0ZDAzMWNhZDc4Y2NhMDYuLjE1ZDNhMjI2MTYzZGE2ZjQ1MGJkMjA1 OWNlMzcxN2QyMjkwYmZjNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3Rv ckNoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3Bw CkBAIC0yMTEsMTIgKzIxMSwxNyBAQCBzdGF0aWMgaW5saW5lIGludCBjb3VudEVsZW1lbnRzT2ZU eXBlQWZ0ZXIoY29uc3QgRWxlbWVudCogZWxlbWVudCwgY29uc3QgUXVhbGlmaQogICAgICAgICBy ZXR1cm4gU2VsZWN0b3JGYWlsc0NvbXBsZXRlbHk7CiAKICAgICBjYXNlIENTU1NlbGVjdG9yOjpD aGlsZDoKLSAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudCA9IGNvbnRleHQuZWxlbWVudC0+cGFy ZW50RWxlbWVudCgpOwotICAgICAgICBpZiAoIW5leHRDb250ZXh0LmVsZW1lbnQpCi0gICAgICAg ICAgICByZXR1cm4gU2VsZWN0b3JGYWlsc0NvbXBsZXRlbHk7Ci0gICAgICAgIG5leHRDb250ZXh0 LmlzU3ViU2VsZWN0b3IgPSBmYWxzZTsKLSAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFN0eWxl ID0gMDsKLSAgICAgICAgcmV0dXJuIG1hdGNoUmVjdXJzaXZlbHkobmV4dENvbnRleHQsIGlnbm9y ZUR5bmFtaWNQc2V1ZG8pOworICAgICAgICB7CisgICAgICAgICAgICBuZXh0Q29udGV4dC5lbGVt ZW50ID0gY29udGV4dC5lbGVtZW50LT5wYXJlbnRFbGVtZW50KCk7CisgICAgICAgICAgICBpZiAo IW5leHRDb250ZXh0LmVsZW1lbnQpCisgICAgICAgICAgICAgICAgcmV0dXJuIFNlbGVjdG9yRmFp bHNDb21wbGV0ZWx5OworICAgICAgICAgICAgbmV4dENvbnRleHQuaXNTdWJTZWxlY3RvciA9IGZh bHNlOworICAgICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFN0eWxlID0gMDsKKyAgICAgICAg ICAgIE1hdGNoIG1hdGNoID0gbWF0Y2hSZWN1cnNpdmVseShuZXh0Q29udGV4dCwgaWdub3JlRHlu YW1pY1BzZXVkbyk7CisgICAgICAgICAgICBpZiAobWF0Y2ggPT0gU2VsZWN0b3JNYXRjaGVzIHx8 IG1hdGNoID09IFNlbGVjdG9yRmFpbHNDb21wbGV0ZWx5KQorICAgICAgICAgICAgICAgIHJldHVy biBtYXRjaDsKKyAgICAgICAgICAgIHJldHVybiBTZWxlY3RvckZhaWxzQWxsU2libGluZ3M7Cisg ICAgICAgIH0KIAogICAgIGNhc2UgQ1NTU2VsZWN0b3I6OkRpcmVjdEFkamFjZW50OgogICAgICAg ICBpZiAobV9tb2RlID09IFJlc29sdmluZ1N0eWxlKSB7Cg==