130941 2014-03-30 01:27:13 -0700 [ATK] No accessible caret-moved events in a href display:block in div 2014-06-24 04:09:53 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk, InRadar P2 Normal --- 25531 1 jarekczek webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 995650 0 228124 jarekczek 2014-03-30 01:27:13 -0700 Created attachment 228124 html file to reproduce the bug Gnome-help contains "a" tag with css style display:block as the only element inside a div. In such cases webkit does not emit "caret-moved" events. While chasing the bug I discovered also other cases were the event is not sent. I attach an example html file with 8 lines. It shows all the possibilities of "a" tags considering 3 states: 1. with href attribute or not 2. with display:block style or not 3. as a single element inside a div or without a div The 4 lines that exhibit the bug are marked with "-" at the beginning. To reproduce the bug use means similar as those in bug #76069, bug #72811. I launch yelp with block.html and run the python script like the one from https://bugs.webkit.org/attachment.cgi?id=115151 I will slowly work on more internal info about the bug and on providing the test cases (testatk.c). For now I discovered from Source/WebCore/editing/atk/FrameSelectionAtk.cpp that: Errors in lines 2 and 6 are rejected by objectFocusedAndCaretOffsetUnignored. Errors in lines 5 and 7 are rejected by the condition in emitTextSelectionChange. 995651 1 webkit-bug-importer 2014-03-30 01:27:27 -0700 <rdar://problem/16467594> 1002530 2 229800 jarekczek 2014-04-21 04:44:08 -0700 Created attachment 229800 a test case Actually the html file I attached earlier demonstrates a different bug, that I reported as bug #131933. So I submit a new test case for the bug here, which actually resembles the problem in gnome help. This is the clue of the bug: <div> <p>Para 1</p> <a style="display:block;" href="anything">An a tag with href</a> <p>Para 2</p> </div> To the bug #131933 I attached a testatk.c patch which detects both problems. This patch is hard to divide into 2 pieces. Actually the testatk.c patch contains additional divs in the test case shown above, they should rather be removed. 1004345 3 jarekczek 2014-04-26 11:25:25 -0700 The crucial part is this: // Don't ignore links if the offset is being requested for a link. if (!referenceObject->isLink() && firstUnignoredParent->isLink()) firstUnignoredParent = firstUnignoredParent->parentObjectUnignored(); objectFocusedAndCaretOffsetUnignored in Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp, line 1333 Our accessibility tree branch is as follows: web_document -> link -> text text is the role for which objectFocusedAndCaretOffsetUnignored is executed. It is not the link, it's the link's child. So the condition above results in dropping the caret moved event. Why does this happen? Traces lead to r53072, which is commented as follows: Adjust the caret offset and object with focus to reflect the unignored parent of the static text object which contains the caret. This is necessary because the static text objects are no longer being exposed to ATs. That's seems to contradict the current actual situation, where something under the link, being text, is exposed to atk. How do we deal with this? Why do we need to ignore links at all? Maybe some answers are in bug #30883 (related with r53072), but I have not read it yet. Just reporting the results so far. 1004387 4 jarekczek 2014-04-27 01:39:26 -0700 I was wrong. The atk text object, whose parent is the link, is not exposed. That is the link has 0 children. I tried to check if renderer()->isRenderObject() to stop ignoring block links. This works for the provided test case. Unfortunately gnome documentation still does not work, so I have to prepare another test case and think of a patch then. 1016131 5 233237 jarekczek 2014-06-17 10:07:33 -0700 Created attachment 233237 fix caret in a block, v1.00 Hello again, Mario! I'm attaching another short patch. Please consider whether the suggested solution is correct. It would be cleaner to use renderer()->isBlock instead of !renderer()->isInline(), but only the latter syntax may be easily merged into stable branch. After this patch yelp title page becomes accessible in webkit1. I'm planning to ask for stable branch merge for this patch, which should be applied after: 1. Bug #132527 2. the hot fix for the above patch (contained in the ticket) 3. Bug #132349 4. Bug #130941 (the one here) These patches apply almost cleanly to the stable branch, a small adjustment is needed for the first one. Thanks in advance for the review. 1017914 6 233237 mario 2014-06-24 04:06:54 -0700 Comment on attachment 233237 fix caret in a block, v1.00 Thanks for the patch, it does look good to me. 1017915 7 233237 commit-queue 2014-06-24 04:09:47 -0700 Comment on attachment 233237 fix caret in a block, v1.00 Clearing flags on attachment: 233237 Committed r170359: <http://trac.webkit.org/changeset/170359> 1017916 8 commit-queue 2014-06-24 04:09:53 -0700 All reviewed patches have been landed. Closing bug. 228124 2014-03-30 01:27:13 -0700 2014-04-21 04:44:08 -0700 html file to reproduce the bug block.html text/html 516 jarekczek PGh0bWw+PGJvZHk+CjxhIHN0eWxlPSJkaXNwbGF5OmJsb2NrOyI+KyBhIGJsb2NrPC9hPgo8YSBz dHlsZT0iZGlzcGxheTppbmxpbmU7Ij4tIGEgaW5saW5lPC9hPjxicj4KPGRpdj4KPGEgc3R5bGU9 ImRpc3BsYXk6YmxvY2s7Ij4rIGEgaW4gZGl2IGJsb2NrPC9hPgo8L2Rpdj4KPGRpdj4KPGEgc3R5 bGU9ImRpc3BsYXk6aW5saW5lOyI+KyBhIGluIGRpdiBpbmxpbmU8L2E+PGJyPgo8L2Rpdj4KPGEg aHJlZj0idGVzdCJzdHlsZT0iZGlzcGxheTpibG9jazsiPi0gYSBocmVmIGJsb2NrPC9hPgo8YSBo cmVmPSJ0ZXN0InN0eWxlPSJkaXNwbGF5OmlubGluZTsiPi0gYSBocmVmIGlubGluZTwvYT48YnI+ CjxkaXY+CjxhIGhyZWY9InRlc3Qic3R5bGU9ImRpc3BsYXk6YmxvY2s7Ij4tIGEgaHJlZiBpbiBk aXYgYmxvY2s8L2E+CjwvZGl2Pgo8ZGl2Pgo8YSBocmVmPSJ0ZXN0InN0eWxlPSJkaXNwbGF5Omlu bGluZTsiPisgYSBocmVmIGluIGRpdiBpbmxpbmU8L2E+PGJyPgo8L2Rpdj4KPC9ib2R5PjwvaHRt bD4K 229800 2014-04-21 04:44:08 -0700 2014-04-21 04:44:08 -0700 a test case yelp2.html text/html 134 jarekczek PGh0bWw+PGJvZHk+CjxkaXY+CjxwPlBhcmEgMTwvcD4KPGEgc3R5bGU9ImRpc3BsYXk6YmxvY2s7 IiBocmVmPSJhbnl0aGluZyI+QW4gYSB0YWcgd2l0aCBocmVmPC9hPgo8cD5QYXJhIDI8L3A+Cjwv ZGl2Pgo8L2JvZHk+PC9odG1sPgo= 233237 2014-06-17 10:07:33 -0700 2014-06-24 04:09:46 -0700 fix caret in a block, v1.00 caret_in_a_block_1_00.patch text/plain 5378 jarekczek SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3MDAxNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA2LTE3ICBKYXJlayBDemVrYWxza2kg IDxqYXJla2N6ZWtAcG9jenRhLm9uZXQucGw+CisKKyAgICAgICAgW0FUS10gRXh0ZW5kZWQgdGhl IHRlc3QgZm9yIGFjY2Vzc2liaWxpdHkgb2YgdGV4dCBpbnNpZGUgInNwYW4iIGJsb2NrIGluICJh IiBibG9jaworICAgICAgICB3aXRoIHRoZSB0ZXN0cyBmb3IgY2FyZXQgbW92ZW1lbnRzIGluIHRo ZXNlIGNhc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMwOTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS90ZXh0LWluLXNwYW4tYmxvY2staW4tYS1i bG9jay1leHBlY3RlZC50eHQ6IAorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5 L3RleHQtaW4tc3Bhbi1ibG9jay1pbi1hLWJsb2NrLmh0bWw6CisgICAgICAgIEFkZGVkIHRlc3Rp bmcgZm9yIHRleHQtY2FyZXQtbW92ZWQgc2lnbmFsLiBBZGRlZCBvbmUgbW9yZSAiYSIgZWxlbWVu dCB0byB0aGUgc2V0LgorCiAyMDE0LTA2LTE2ICBSYWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2Jl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTY4MDQ2KTogSW5jb3JyZWN0IGxheW91dCBm b3IgbXVsdGljb2wgc3Bhbm5lcnMgd2hlbiBtb3ZpbmcgZnJvbSBvbmUgdGhyZWFkIHRvIGFub3Ro ZXIKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3RleHQtaW4t c3Bhbi1ibG9jay1pbi1hLWJsb2NrLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS90ZXh0LWluLXNwYW4tYmxvY2staW4tYS1i bG9jay1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE3MDAxNykKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3RleHQtaW4tc3Bhbi1ibG9jay1pbi1hLWJsb2NrLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMTAsNiArMTAsNyBAQAogLGFmdGVyCiBiZWZvcmUs CiBzaXgKK25vIHNwYW4gaGVyZQogVGhpcyB0ZXN0cyB0aGF0IHRleHQgaW5zaWRlICJhIiBibG9j ayBpbnNpZGUgInNwYW4iIGJsb2NrIGlzIGFjY2Vzc2libGUuCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KQEAgLTE3LDE2ICsxOCwyNSBAQAogCiBQQVNTIGFjY1RleHQgaXMgIkFYVmFsdWU6 b25lIgogUEFTUyBzZXRDYXJldE9mZnNldChlbGVtLCAxKSBpcyB0cnVlCitQQVNTIGNhcmV0TW92 ZWREYXRhIGlzICJMaW5rfDEiCiBQQVNTIGFjY1RleHQgaXMgIkFYVmFsdWU6dHdvIgogUEFTUyBz ZXRDYXJldE9mZnNldChlbGVtLCAxKSBpcyB0cnVlCitQQVNTIGNhcmV0TW92ZWREYXRhIGlzICJM aW5rfDEiCiBQQVNTIGFjY1RleHQgaXMgIkFYVmFsdWU6dGhyZWUiCiBQQVNTIHNldENhcmV0T2Zm c2V0KGVsZW0sIDEpIGlzIHRydWUKK1BBU1MgY2FyZXRNb3ZlZERhdGEgaXMgIkxpbmt8MSIKIFBB U1MgYWNjVGV4dCBpcyAiQVhWYWx1ZTpiZWZvcmUsZm91cixhZnRlciIKIFBBU1Mgc2V0Q2FyZXRP ZmZzZXQoZWxlbSwgMSkgaXMgdHJ1ZQorUEFTUyBjYXJldE1vdmVkRGF0YSBpcyAiTGlua3wxIgog UEFTUyBhY2NUZXh0IGlzICJBWFZhbHVlOmZpdmUsYWZ0ZXIiCiBQQVNTIHNldENhcmV0T2Zmc2V0 KGVsZW0sIDEpIGlzIHRydWUKK1BBU1MgY2FyZXRNb3ZlZERhdGEgaXMgIkxpbmt8MSIKIFBBU1Mg YWNjVGV4dCBpcyAiQVhWYWx1ZTpiZWZvcmUsc2l4IgogUEFTUyBzZXRDYXJldE9mZnNldChlbGVt LCAxKSBpcyB0cnVlCitQQVNTIGNhcmV0TW92ZWREYXRhIGlzICJMaW5rfDEiCitQQVNTIGFjY1Rl eHQgaXMgIkFYVmFsdWU6bm9zcGFuaGVyZSIKK1BBU1Mgc2V0Q2FyZXRPZmZzZXQoZWxlbSwgMSkg aXMgdHJ1ZQorUEFTUyBjYXJldE1vdmVkRGF0YSBpcyAiTGlua3wxIgogUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS90ZXh0LWluLXNwYW4tYmxvY2staW4tYS1ibG9jay5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Rl eHQtaW4tc3Bhbi1ibG9jay1pbi1hLWJsb2NrLmh0bWwJKHJldmlzaW9uIDE3MDAxNykKKysrIExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3RleHQtaW4tc3Bhbi1ibG9jay1p bi1hLWJsb2NrLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDggQEAKIAogPGEgaWQ9 ImlkNiIgaHJlZj0ieCIgc3R5bGU9ImRpc3BsYXk6YmxvY2s7Ij5iZWZvcmUsPHNwYW4gc3R5bGU9 ImRpc3BsYXk6YmxvY2s7Ij5zaXg8L3NwYW4+PC9hPgogCis8YSBpZD0iaWQ3IiBocmVmPSJ4IiBz dHlsZT0iZGlzcGxheTpibG9jazsiPm5vIHNwYW4gaGVyZTwvYT4KKwogPGRpdiBpZD0iY29uc29s ZSI+PC9kaXY+CiAKIDxzY3JpcHQ+CkBAIC03Miw3ICs3NCw3IEBACiBpZiAod2luZG93LmFjY2Vz c2liaWxpdHlDb250cm9sbGVyKSB7CiAgICAgdmFyIGksIGxpbmtUZXh0LCBhY2NUZXh0LCBpZDsK ICAgICBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hZGROb3RpZmljYXRpb25MaXN0ZW5lcihnbG9i YWxMaXN0ZW5lcikKLSAgICBmb3IgKGkgPSAxOyBpIDw9IDY7IGkrKykgeworICAgIGZvciAoaSA9 IDE7IGkgPD0gNzsgaSsrKSB7CiAgICAgICAgIGlkID0gJ2lkJyArIGk7CiAgICAgICAgIGVsZW0g PSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoaWQpOwogICAg ICAgICBsaW5rVGV4dCA9IHN0cmlwTm9uV2hpdGUoZG9jdW1lbnQubGlua3NbaWRdLnRleHRDb250 ZW50KTsKQEAgLTgwLDggKzgyLDcgQEAKICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJh Y2NUZXh0IiwgIkFYVmFsdWU6IiArIGxpbmtUZXh0KTsKICAgICAgICAgY2FyZXRNb3ZlZERhdGEg PSAnJzsKICAgICAgICAgc2hvdWxkQmUoInNldENhcmV0T2Zmc2V0KGVsZW0sIDEpIiwgInRydWUi KTsKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgbGluZSB3aWxsIGJlIGFkZGVkIGFmdGVyIGZpeGlu ZyBidWcgIzEzMDk0MS4KLSAgICAgICAgLy9zaG91bGRCZUVxdWFsVG9TdHJpbmcoImNhcmV0TW92 ZWREYXRhIiwgIkxpbmt8MSIpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImNhcmV0 TW92ZWREYXRhIiwgIkxpbmt8MSIpOwogICAgIH0KIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNp b24gMTcwMDE3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTQtMDYtMTcgIEphcmVrIEN6ZWthbHNraSAgPGphcmVrY3pla0Bw b2N6dGEub25ldC5wbD4KKworICAgICAgICBbQVRLXSBEb24ndCBpZ25vcmUgbGlua3MgcmVuZGVy ZWQgYXMgYmxvY2tzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMwOTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiAvbS91c3Ivc3JjL3dlYmtpdC10cnVuay9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpvYmplY3RGb2N1c2VkQW5kQ2FyZXRPZmZzZXRVbmlnbm9y ZWQpOiBEb24ndCBpZ25vcmUgbGlua3MKKyAgICAgICAgd2hlbiB0aGV5IGFyZSByZW5kZXJlcmVk IHdpdGggZGlzcGxheTpibG9jay4KKwogMjAxNC0wNC0wNSAgQW50b25pbyBHb21lcyAgPGExLmdv bWVzQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0JpbmRpbmdzXSAibnVsbGFibGUiIHNl cXVlbmNlIHN1cHBvcnQgaXMgaW5jb21wbGV0ZSAoaS5lLiBzZXF1ZW5jZTxOYXRpdmVUeXBlPj8p CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxl V3JhcHBlckF0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCShyZXZpc2lvbiAxNzAwMTcpCisr KyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBl ckF0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMjksOCArMTMyOSwxMCBAQAogICAgIGlmICgh Zmlyc3RVbmlnbm9yZWRQYXJlbnQpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgLy8gRG9uJ3Qg aWdub3JlIGxpbmtzIGlmIHRoZSBvZmZzZXQgaXMgYmVpbmcgcmVxdWVzdGVkIGZvciBhIGxpbmsu Ci0gICAgaWYgKCFyZWZlcmVuY2VPYmplY3QtPmlzTGluaygpICYmIGZpcnN0VW5pZ25vcmVkUGFy ZW50LT5pc0xpbmsoKSkKKyAgICAvLyBEb24ndCBpZ25vcmUgbGlua3MgaWYgdGhlIG9mZnNldCBp cyBiZWluZyByZXF1ZXN0ZWQgZm9yIGEgbGluaworICAgIC8vIG9yIGlmIHRoZSBsaW5rIGlzIGEg YmxvY2suCisgICAgaWYgKCFyZWZlcmVuY2VPYmplY3QtPmlzTGluaygpICYmIGZpcnN0VW5pZ25v cmVkUGFyZW50LT5pc0xpbmsoKQorICAgICAgICAmJiAhKGZpcnN0VW5pZ25vcmVkUGFyZW50LT5y ZW5kZXJlcigpICYmICFmaXJzdFVuaWdub3JlZFBhcmVudC0+cmVuZGVyZXIoKS0+aXNJbmxpbmUo KSkpCiAgICAgICAgIGZpcnN0VW5pZ25vcmVkUGFyZW50ID0gZmlyc3RVbmlnbm9yZWRQYXJlbnQt PnBhcmVudE9iamVjdFVuaWdub3JlZCgpOwogICAgIGlmICghZmlyc3RVbmlnbm9yZWRQYXJlbnQp CiAgICAgICAgIHJldHVybiAwOwo=