130940 2014-03-30 01:25:57 -0700 Remove special handling of soft hyphens in search code 2014-03-31 10:00:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca darin rniwa oldest_to_newest 995649 0 ap 2014-03-30 01:25:57 -0700 ICU knows to ignore soft hyphens, so we don't need to replace them before searching. See aso <rdar://problem/9464270>. 995652 1 228125 ap 2014-03-30 01:27:46 -0700 Created attachment 228125 proposed patch 995674 2 228125 andersca 2014-03-30 12:48:41 -0700 Comment on attachment 228125 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=228125&action=review > Source/WebCore/ChangeLog:3 > + Remove special handling of soft hyphens in search code Why? 995719 3 ap 2014-03-30 19:57:33 -0700 > Why? Quoting bug description, "ICU knows to ignore soft hyphens, so we don't need to replace them before searching." 995861 4 andersca 2014-03-31 07:45:01 -0700 (In reply to comment #3) > > Why? > > Quoting bug description, "ICU knows to ignore soft hyphens, so we don't need to replace them before searching." Ah! Can you put that in the ChangeLog as well? 995888 5 ap 2014-03-31 09:33:05 -0700 Committed <http://trac.webkit.org/r166507>. 995891 6 darin 2014-03-31 09:41:35 -0700 (In reply to comment #0) > ICU knows to ignore soft hyphens Has that always been true, or is this a recent development? 995904 7 ap 2014-03-31 10:00:13 -0700 I've been told that ICU "already" does this, and EWS confirmed that it's true as of 10.8 at least. I think that this code was added before Mac WebKit started to use ICU, and it was recently needed because of other non-ICU platforms that we used to support. This is some history that I'm aware of, although it doesn't fully answer your question. 228125 2014-03-30 01:27:46 -0700 2014-03-31 07:45:09 -0700 proposed patch shy.txt text/plain 4013 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjQ1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAzLTMwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzcGVjaWFsIGhh bmRsaW5nIG9mIHNvZnQgaHlwaGVucyBpbiBzZWFyY2ggY29kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTQwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4K KworICAgICAgICAqIGVkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmZvbGRRdW90ZU1hcmspOgorICAgICAgICAoV2ViQ29yZTo6Zm9sZFF1b3RlTWFya3MpOgorICAg ICAgICAoV2ViQ29yZTo6U2VhcmNoQnVmZmVyOjpTZWFyY2hCdWZmZXIpOgorICAgICAgICAoV2Vi Q29yZTo6U2VhcmNoQnVmZmVyOjphcHBlbmQpOgorICAgICAgICAoV2ViQ29yZTo6Zm9sZFF1b3Rl TWFya09yU29mdEh5cGhlbik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpmb2xkUXVvdGVN YXJrc0FuZFNvZnRIeXBoZW5zKTogRGVsZXRlZC4KKwogMjAxNC0wMy0yOSAgQ29tbWl0IFF1ZXVl ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjE2NjQzNC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5j cHAJKHJldmlzaW9uIDE2NjQ1NykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJh dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyMSw3ICsxNjIxLDcgQEAgU3RyaW5nVmlldyBX b3JkQXdhcmVJdGVyYXRvcjo6dGV4dCgpIGNvbgogCiAvLyAtLS0tLS0tLQogCi1zdGF0aWMgaW5s aW5lIFVDaGFyIGZvbGRRdW90ZU1hcmtPclNvZnRIeXBoZW4oVUNoYXIgYykKK3N0YXRpYyBpbmxp bmUgVUNoYXIgZm9sZFF1b3RlTWFyayhVQ2hhciBjKQogewogICAgIHN3aXRjaCAoYykgewogICAg ICAgICBjYXNlIGhlYnJld1B1bmN0dWF0aW9uR2Vyc2hheWltOgpAQCAtMTYzMiwxMCArMTYzMiw2 IEBAIHN0YXRpYyBpbmxpbmUgVUNoYXIgZm9sZFF1b3RlTWFya09yU29mdEgKICAgICAgICAgY2Fz ZSBsZWZ0U2luZ2xlUXVvdGF0aW9uTWFyazoKICAgICAgICAgY2FzZSByaWdodFNpbmdsZVF1b3Rh dGlvbk1hcms6CiAgICAgICAgICAgICByZXR1cm4gJ1wnJzsKLSAgICAgICAgY2FzZSBzb2Z0SHlw aGVuOgotICAgICAgICAgICAgLy8gUmVwbGFjZSBzb2Z0IGh5cGhlbiB3aXRoIGFuIGlnbm9yYWJs ZSBjaGFyYWN0ZXIgc28gdGhhdCB0aGVpciBwcmVzZW5jZSBvciBhYnNlbmNlIHdpbGwKLSAgICAg ICAgICAgIC8vIG5vdCBhZmZlY3Qgc3RyaW5nIGNvbXBhcmlzb24uCi0gICAgICAgICAgICByZXR1 cm4gMDsKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiBjOwogICAgIH0KQEAg LTE2NDQsNyArMTY0MCw3IEBAIHN0YXRpYyBpbmxpbmUgVUNoYXIgZm9sZFF1b3RlTWFya09yU29m dEgKIC8vIEZJWE1FOiBXZSdkIGxpa2UgdG8gdGFpbG9yIHRoZSBzZWFyY2hlciB0byBmb2xkIHF1 b3RlIG1hcmtzIGZvciB1cyBpbnN0ZWFkCiAvLyBvZiBkb2luZyBpdCBpbiBhIHNlcGFyYXRlIHJl cGxhY2VtZW50IHBhc3MgaGVyZSwgYnV0IElDVSBkb2Vzbid0IG9mZmVyIGEgd2F5CiAvLyB0byBh ZGQgdGFpbG9yaW5nIG9uIHRvcCBvZiB0aGUgbG9jYWxlLXNwZWNpZmljIHRhaWxvcmluZyBhcyBv ZiB0aGlzIHdyaXRpbmcuCi1zdGF0aWMgaW5saW5lIFN0cmluZyBmb2xkUXVvdGVNYXJrc0FuZFNv ZnRIeXBoZW5zKFN0cmluZyBzdHJpbmcpCitzdGF0aWMgaW5saW5lIFN0cmluZyBmb2xkUXVvdGVN YXJrcyhTdHJpbmcgc3RyaW5nKQogewogICAgIHN0cmluZy5yZXBsYWNlKGhlYnJld1B1bmN0dWF0 aW9uR2VyZXNoLCAnXCcnKTsKICAgICBzdHJpbmcucmVwbGFjZShoZWJyZXdQdW5jdHVhdGlvbkdl cnNoYXlpbSwgJyInKTsKQEAgLTE2NTMsOSArMTY0OSw2IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5n IGZvbGRRdW90ZU1hcmtzQW5kU28KICAgICBzdHJpbmcucmVwbGFjZShyaWdodERvdWJsZVF1b3Rh dGlvbk1hcmssICciJyk7CiAgICAgc3RyaW5nLnJlcGxhY2UocmlnaHRTaW5nbGVRdW90YXRpb25N YXJrLCAnXCcnKTsKIAotICAgIC8vIFJlcGxhY2Ugc29mdCBoeXBoZW5zIHdpdGggYW4gaWdub3Jh YmxlIGNoYXJhY3RlciBzbyB0aGF0IHByZXNlbmNlIG9yIGFic2VuY2Ugd2lsbCBub3QgYWZmZWN0 IHN0cmluZyBjb21wYXJpc29uLgotICAgIHN0cmluZy5yZXBsYWNlKHNvZnRIeXBoZW4sIDApOwot CiAgICAgcmV0dXJuIHN0cmluZzsKIH0KIApAQCAtMTk0MCw3ICsxOTMzLDcgQEAgc3RhdGljIGlu bGluZSBib29sIGlzU2VwYXJhdG9yKFVDaGFyMzIgYwogfQogCiBpbmxpbmUgU2VhcmNoQnVmZmVy OjpTZWFyY2hCdWZmZXIoY29uc3QgU3RyaW5nJiB0YXJnZXQsIEZpbmRPcHRpb25zIG9wdGlvbnMp Ci0gICAgOiBtX3RhcmdldChmb2xkUXVvdGVNYXJrc0FuZFNvZnRIeXBoZW5zKHRhcmdldCkpCisg ICAgOiBtX3RhcmdldChmb2xkUXVvdGVNYXJrcyh0YXJnZXQpKQogICAgICwgbV90YXJnZXRDaGFy YWN0ZXJzKFN0cmluZ1ZpZXcobV90YXJnZXQpLnVwY29udmVydGVkQ2hhcmFjdGVycygpKQogICAg ICwgbV9vcHRpb25zKG9wdGlvbnMpCiAgICAgLCBtX3ByZWZpeExlbmd0aCgwKQpAQCAtMjAzMCw3 ICsyMDIzLDcgQEAgaW5saW5lIHNpemVfdCBTZWFyY2hCdWZmZXI6OmFwcGVuZChTdHJpbgogICAg IEFTU0VSVCh1c2FibGVMZW5ndGgpOwogICAgIG1fYnVmZmVyLmdyb3cob2xkTGVuZ3RoICsgdXNh YmxlTGVuZ3RoKTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdXNhYmxlTGVuZ3RoOyAr K2kpCi0gICAgICAgIG1fYnVmZmVyW29sZExlbmd0aCArIGldID0gZm9sZFF1b3RlTWFya09yU29m dEh5cGhlbih0ZXh0W2ldKTsKKyAgICAgICAgbV9idWZmZXJbb2xkTGVuZ3RoICsgaV0gPSBmb2xk UXVvdGVNYXJrKHRleHRbaV0pOwogICAgIHJldHVybiB1c2FibGVMZW5ndGg7CiB9CiAKQEAgLTIy NjcsNyArMjI2MCw3IEBAIGlubGluZSBTZWFyY2hCdWZmZXI6OlNlYXJjaEJ1ZmZlcihjb25zdCAK IHsKICAgICBBU1NFUlQoIW1fdGFyZ2V0LmlzRW1wdHkoKSk7CiAgICAgbV90YXJnZXQucmVwbGFj ZShub0JyZWFrU3BhY2UsICcgJyk7Ci0gICAgZm9sZFF1b3RlTWFya3NBbmRTb2Z0SHlwaGVucyht X3RhcmdldCk7CisgICAgZm9sZFF1b3RlTWFya3MobV90YXJnZXQpOwogfQogCiBpbmxpbmUgU2Vh cmNoQnVmZmVyOjp+U2VhcmNoQnVmZmVyKCkKQEAgLTIyODcsNyArMjI4MCw3IEBAIGlubGluZSBi b29sIFNlYXJjaEJ1ZmZlcjo6YXRCcmVhaygpIGNvbnMKIAogaW5saW5lIHZvaWQgU2VhcmNoQnVm ZmVyOjphcHBlbmQoVUNoYXIgYywgYm9vbCBpc1N0YXJ0KQogewotICAgIG1fYnVmZmVyW21fY3Vy c29yXSA9IGMgPT0gbm9CcmVha1NwYWNlID8gJyAnIDogZm9sZFF1b3RlTWFya09yU29mdEh5cGhl bihjKTsKKyAgICBtX2J1ZmZlclttX2N1cnNvcl0gPSBjID09IG5vQnJlYWtTcGFjZSA/ICcgJyA6 IGZvbGRRdW90ZU1hcmsoYyk7CiAgICAgbV9pc0NoYXJhY3RlclN0YXJ0QnVmZmVyW21fY3Vyc29y XSA9IGlzU3RhcnQ7CiAgICAgaWYgKCsrbV9jdXJzb3IgPT0gbV90YXJnZXQubGVuZ3RoKCkpIHsK ICAgICAgICAgbV9jdXJzb3IgPSAwOwo=