130936 2014-03-29 15:17:39 -0700 [GTK] Use PROJECT_VERSION_* instead of WEBKIT_*_VERSION 2014-03-31 07:39:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson berto bunhere cgarcia commit-queue gustavo gyuyoung.kim rakuco sergio oldest_to_newest 995616 0 mrobinson 2014-03-29 15:17:39 -0700 These are the common CMake project version variables and using them makes the build a bit less confusing. 995642 1 228121 mrobinson 2014-03-29 23:35:35 -0700 Created attachment 228121 Patch 995643 2 commit-queue 2014-03-29 23:37:34 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 995856 3 228121 mrobinson 2014-03-31 07:39:03 -0700 Comment on attachment 228121 Patch Clearing flags on attachment: 228121 Committed r166499: <http://trac.webkit.org/changeset/166499> 995857 4 mrobinson 2014-03-31 07:39:08 -0700 All reviewed patches have been landed. Closing bug. 228121 2014-03-29 23:35:35 -0700 2014-03-31 07:39:03 -0700 Patch bug-130936-20140329233515.patch text/plain 5264 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNGIwNjczZTdj N2FjNzA4OTUxYTVlYTNlMDg3ZjU4NGE2MmZlYTBjYy4uZTg3ODVhNjUyYzkzOGJhY2JkMDMwZjcx MGFhMzJmMmM5NjdlNjc3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0 LTAzLTI5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBVc2UgUFJPSkVDVF9WRVJTSU9OXyogaW5zdGVhZCBvZiBXRUJLSVRfKl9WRVJTSU9O CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA5MzYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYmtp dC93ZWJraXR2ZXJzaW9uLmguaW46IFVzZSBQUk9KRUNUX1ZFUlNJT05fKiBtYWNyb3MgaW5zdGVh ZCBvZiB0aGUgQXV0b3Rvb2xzIG9uZXMuCisKIDIwMTQtMDMtMjggIERpZWdvIFBpbm8gR2FyY2lh ICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBUb28gbWFueSByZWRpcmVjdHMg dmlzaXRpbmcgd3d3Lmdsb2JhbGZvcmVzdHdhdGNoLm9yZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGMxNTAxNGRi YmQ5NTE1ZmZmZjRkYjZmOTc3ZmMyZTU2NmE0Njg3MjQuLmJhNjI0N2U3YWZhNTRiZTU3ZWU5NzBi MTA0ZmRlNWQ3ZTJlOWFiZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wMy0y OSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dU S10gVXNlIFBST0pFQ1RfVkVSU0lPTl8qIGluc3RlYWQgb2YgV0VCS0lUXypfVkVSU0lPTgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTM2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRWZXJzaW9uLmguaW46IFVzZSBQUk9KRUNUX1ZFUlNJT05fKiBtYWNyb3Mg aW5zdGVhZCBvZiB0aGUgQXV0b3Rvb2xzIG9uZXMuCisKIDIwMTQtMDMtMjggIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmNhdWdodCBOU0V4Y2VwdGlv bnMgc2hvdWxkIGNyYXNoIHRoZSB3ZWIgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHZlcnNpb24uaC5pbiBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR2ZXJzaW9uLmguaW4KaW5kZXggNGQ2MzY1NWMzOTA2NGU0MGQ3NjA4NTQ5ZTU1NThl MTJkZTI5ZGVlZi4uY2M4OTMyNWVhM2RhNmI4ZTQ1Y2E3NTBhYjdjNzFjY2E4ODU2MDQxNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHZlcnNpb24uaC5pbgorKysg Yi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0dmVyc2lvbi5oLmluCkBAIC0yNSw5ICsy NSw5IEBACiAKIEdfQkVHSU5fREVDTFMKIAotI2RlZmluZSBXRUJLSVRfTUFKT1JfVkVSU0lPTiAo QFdFQktJVF9NQUpPUl9WRVJTSU9OQCkKLSNkZWZpbmUgV0VCS0lUX01JTk9SX1ZFUlNJT04gKEBX RUJLSVRfTUlOT1JfVkVSU0lPTkApCi0jZGVmaW5lIFdFQktJVF9NSUNST19WRVJTSU9OIChAV0VC S0lUX01JQ1JPX1ZFUlNJT05AKQorI2RlZmluZSBXRUJLSVRfTUFKT1JfVkVSU0lPTiAoQFBST0pF Q1RfVkVSU0lPTl9QQVRDSEApCisjZGVmaW5lIFdFQktJVF9NSU5PUl9WRVJTSU9OIChAUFJPSkVD VF9WRVJTSU9OX01JTk9SQCkKKyNkZWZpbmUgV0VCS0lUX01JQ1JPX1ZFUlNJT04gKEBQUk9KRUNU X1ZFUlNJT05fUEFUQ0hAKQogI2RlZmluZSBXRUJLSVRfVVNFUl9BR0VOVF9NQUpPUl9WRVJTSU9O IChAV0VCS0lUX1VTRVJfQUdFTlRfTUFKT1JfVkVSU0lPTkApCiAjZGVmaW5lIFdFQktJVF9VU0VS X0FHRU5UX01JTk9SX1ZFUlNJT04gKEBXRUJLSVRfVVNFUl9BR0VOVF9NSU5PUl9WRVJTSU9OQCkK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VmVy c2lvbi5oLmluIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VmVyc2lv bi5oLmluCmluZGV4IDgxZWY1MTc5YTNjNWZjNzU2NDdmZmFmZjZiZmIyMTg3MDVkYjg1M2UuLmM0 MzJhNmZiMjMwZjY5M2VmODU3YTgyMWUxMzFjMjA5OTA4ODMwYWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFZlcnNpb24uaC5pbgorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRWZXJzaW9uLmguaW4KQEAgLTM1LDcg KzM1LDcgQEAgR19CRUdJTl9ERUNMUwogICogYXBwbGljYXRpb24gY29tcGlsZSB0aW1lLCByYXRo ZXIgdGhhbiBmcm9tIHRoZSBsaWJyYXJ5IGxpbmtlZAogICogYWdhaW5zdCBhdCBhcHBsaWNhdGlv biBydW4gdGltZS4KICAqLwotI2RlZmluZSBXRUJLSVRfTUFKT1JfVkVSU0lPTiAoQFdFQktJVF9N QUpPUl9WRVJTSU9OQCkKKyNkZWZpbmUgV0VCS0lUX01BSk9SX1ZFUlNJT04gKEBQUk9KRUNUX1ZF UlNJT05fTUFKT1JAKQogCiAvKioKICAqIFdFQktJVF9NSU5PUl9WRVJTSU9OOgpAQCAtNDQsNyAr NDQsNyBAQCBHX0JFR0lOX0RFQ0xTCiAgKiBhcHBsaWNhdGlvbiBjb21waWxlIHRpbWUsIHJhdGhl ciB0aGFuIGZyb20gdGhlIGxpYnJhcnkgbGlua2VkCiAgKiBhZ2FpbnN0IGF0IGFwcGxpY2F0aW9u IHJ1biB0aW1lLgogICovCi0jZGVmaW5lIFdFQktJVF9NSU5PUl9WRVJTSU9OIChAV0VCS0lUX01J Tk9SX1ZFUlNJT05AKQorI2RlZmluZSBXRUJLSVRfTUlOT1JfVkVSU0lPTiAoQFBST0pFQ1RfVkVS U0lPTl9NSU5PUkApCiAKIC8qKgogICogV0VCS0lUX01JQ1JPX1ZFUlNJT046CkBAIC01Myw3ICs1 Myw3IEBAIEdfQkVHSU5fREVDTFMKICAqIGFwcGxpY2F0aW9uIGNvbXBpbGUgdGltZSwgcmF0aGVy IHRoYW4gZnJvbSB0aGUgbGlicmFyeSBsaW5rZWQKICAqIGFnYWluc3QgYXQgYXBwbGljYXRpb24g cnVuIHRpbWUuCiAgKi8KLSNkZWZpbmUgV0VCS0lUX01JQ1JPX1ZFUlNJT04gKEBXRUJLSVRfTUlD Uk9fVkVSU0lPTkApCisjZGVmaW5lIFdFQktJVF9NSUNST19WRVJTSU9OIChAUFJPSkVDVF9WRVJT SU9OX1BBVENIQCkKIAogLyoqCiAgKiBXRUJLSVRfQ0hFQ0tfVkVSU0lPTjoKZGlmZiAtLWdpdCBh L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UKaW5kZXggZmRhMWQ2MDk0ZGQ2MmJmYmZjODRkNzE4NzFhMTBjYmQ0OTFkZWU0NS4uZjc2 MTFiZDM5ZGZiZTI5MjMwZTgwM2ViMDkxMTI0OTNhM2U4NjAzYiAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKQEAgLTE1LDE2ICsxNSw2IEBAIENBTENVTEFURV9MSUJSQVJZX1ZFUlNJT05TX0ZST01fTElC VE9PTF9UUklQTEUoV0VCS0lUIDIyIDAgMjIpCiBDQUxDVUxBVEVfTElCUkFSWV9WRVJTSU9OU19G Uk9NX0xJQlRPT0xfVFJJUExFKFdFQktJVDIgMzIgMCA3KQogQ0FMQ1VMQVRFX0xJQlJBUllfVkVS U0lPTlNfRlJPTV9MSUJUT09MX1RSSVBMRShKQVZBU0NSSVBUQ09SRSAxNiAyIDE2KQogCi0jIFRo aXMgaXMgYSBsaXR0bGUgY29uZnVzaW5nOiBXRUJLSVRfTUlDUk9fVkVSU0lPTiBhbmQgZnJpZW5k cyBhcmUgdXNlZCBhcwotIyBtYWNyb3MgaW4gZmlsZXMgbGlrZSBXZWJLaXRWZXJzaW9uLmguaW4g dG8gZXhwb3NlIHRoZSBwcm9qZWN0IHZlcnNpb24gdG8KLSMgdGhlIEFQSS4gTWVhbndoaWxlIFdF QktJVF9WRVJTSU9OX01JQ1JPIChub3RlIHRoZSB0cmFuc3Bvc2VkIHdvcmRzKSBpcyB1c2VkCi0j IGJ5IHRoZSBDTWFrZSBmaWxlcyB0byBob2xkIHRoZSAqbGlicmFyeSogdmVyc2lvbiBudW1iZXIs IHdoaWNoIHdlIGNhbGN1bGF0ZWQKLSMgZnJvbSB0aGUgbGlidG9vbCB0cmlwbGUgYWJvdmUuIFdl IHNob3VsZCBjb25zaWRlciBkaXRjaGluZyB0aGVzZSBiZWxvdwotIyBhbmQgdXNpbmcgUFJPSkVD VF9WRVJTSU9OXyogZGlyZWN0bHkuCi1zZXQoV0VCS0lUX01JQ1JPX1ZFUlNJT04gJHtQUk9KRUNU X1ZFUlNJT05fUEFUQ0h9KQotc2V0KFdFQktJVF9NSU5PUl9WRVJTSU9OICR7UFJPSkVDVF9WRVJT SU9OX01JTk9SfSkKLXNldChXRUJLSVRfTUFKT1JfVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTl9N QUpPUn0pCi0KIHNldChVU0VfR1RLMiBPRkYgQ0FDSEUgQk9PTCAiV2hldGhlciBvciBub3QgdG8g dXNlIEdUSysgMi4gV2ViS2l0MiBvbmx5IHN1cHBvcnRzIEdUSysgMy4iKQogc2V0KEVOQUJMRV9D UkVERU5USUFMX1NUT1JBR0UgT04gQ0FDSEUgQk9PTCAiV2hldGhlciBvciBub3QgdG8gZW5hYmxl IHN1cHBvcnQgZm9yIGNyZWRlbnRpYWwgc3RvcmFnZSB1c2luZyBsaWJzZWNyZXQuIikKIApkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDM4YzUzNTE1NjQwYzQ4ZmJhN2Jj YmMxN2M3N2ViNDcyOGIzYmY3NzEuLjNkZDM3MTcwNjAzODk4MDAzZmRjZTgxNmVkNmQzOWQ4OWMy MmQ2YTggMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MiBAQAorMjAxNC0wMy0yOSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gVXNlIFBST0pFQ1RfVkVSU0lPTl8qIGluc3RlYWQgb2YgV0VCS0lU XypfVkVSU0lPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTMwOTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZTogTm8gbG9uZ2VyIGVtdWxhdGUgdGhl IEF1dG90b29scyBtYWNybyBuYW1lcy4KKwogMjAxNC0wMy0yOCAgR3l1eW91bmcgS2ltICA8Z3l1 eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEJ1bXAgZ2xpYiB2ZXJzaW9u IGZyb20gMi4zNiB0byAyLjM4IAo=