130934 2014-03-29 13:52:55 -0700 Subpixel rendering: Simple line layout should not round to integral position while painting. 2014-03-29 15:37:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 995603 0 zalan 2014-03-29 13:52:55 -0700 It could push content off by a device pixel compared to when RenderLayer is injected and hides the subpixel position. 995606 1 228117 zalan 2014-03-29 14:03:39 -0700 Created attachment 228117 Patch 995607 2 228117 simon.fraser 2014-03-29 14:05:12 -0700 Comment on attachment 228117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228117&action=review > Source/WebCore/ChangeLog:17 > + Without RenderLayer: > + Renderer's layout position (10.5px, 10.5px) -> rounded and painted at (11px, 11px) > + > + With RenderLayer: > + Rendere's layout position (10.5px, 10.5px) -> RenderLayer position (10.5px, 10.5px) -> > + renderer's relative pos (0px, 0px) -> rounded and painted at (0px, 0p) which > + translates to (10.5px, 10.5px) (vs. (11px, 11px) I don't think it's necessary to include the math in the changelog. If you want to preserve this info for the future, put it in the bugzilla bug. 995617 3 zalan 2014-03-29 15:22:06 -0700 Without RenderLayer: Renderer's layout position (10.5px, 10.5px) -> rounded and painted at (11px, 11px) With RenderLayer: Rendere's layout position (10.5px, 10.5px) -> RenderLayer position (10.5px, 10.5px) -> renderer's relative pos (0px, 0px) -> rounded and painted at (0px, 0p) which translates to (10.5px, 10.5px) (vs. (11px, 11px) 995620 4 zalan 2014-03-29 15:37:10 -0700 Committed r166456: <http://trac.webkit.org/changeset/166456> 228117 2014-03-29 14:03:39 -0700 2014-03-29 14:05:11 -0700 Patch bug-130934-20140329140320.patch text/plain 5560 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2I5NTZhZmIwNzk5MWUy MTlkMmM5NWNmYTVlMWJiYjhiNzJhZmM2Mi4uOWZhMWJkYWQ5ZjllNjhjNzYyNzdiMjk1YWEwZGRh NDk0Zjg4NmI3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTAzLTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBTaW1wbGUgbGluZSBsYXlvdXQgc2hvdWxkIG5vdCByb3VuZCB0byBpbnRlZ3JhbCBwb3NpdGlv biB3aGlsZSBwYWludGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMDkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSByb3VuZGluZyB0byBpbnRlZ3JhbCBwb3NpdGlvbi4gV2hlbiBSZW5k ZXJMYXllciBpcyBpbmplY3RlZCBhbmQgaGlkZXMgc3VicGl4ZWwgcG9zaXRpb25zLAorICAgICAg ICBpbnRlZ3JhbCByb3VuZGluZyBwcm9kdWNlcyBkaWZmZXJlbnQgcGFpbnQgcG9zaXRpb24uCisK KyAgICAgICAgV2l0aG91dCBSZW5kZXJMYXllcjoKKyAgICAgICAgUmVuZGVyZXIncyBsYXlvdXQg cG9zaXRpb24gKDEwLjVweCwgMTAuNXB4KSAtPiByb3VuZGVkIGFuZCBwYWludGVkIGF0ICgxMXB4 LCAxMXB4KQorCisgICAgICAgIFdpdGggUmVuZGVyTGF5ZXI6CisgICAgICAgIFJlbmRlcmUncyBs YXlvdXQgcG9zaXRpb24gKDEwLjVweCwgMTAuNXB4KSAtPiBSZW5kZXJMYXllciBwb3NpdGlvbiAo MTAuNXB4LCAxMC41cHgpIC0+CisgICAgICAgIHJlbmRlcmVyJ3MgcmVsYXRpdmUgcG9zICgwcHgs IDBweCkgLT4gcm91bmRlZCBhbmQgcGFpbnRlZCBhdCAoMHB4LCAwcCkgd2hpY2gKKyAgICAgICAg dHJhbnNsYXRlcyB0byAoMTAuNXB4LCAxMC41cHgpICh2cy4gKDExcHgsIDExcHgpCisKKyAgICAg ICAgVGVzdDogZmFzdC9mbGV4Ym94L2hpZHBpLXNpbXBsZS1saW5lLWxheW91dC13aXRoLWZsZXhi b3gtYW5kLXRyYW5zaXRpb24uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXRGdW5jdGlvbnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6 cGFpbnRGbG93KToKKwogMjAxNC0wMy0yOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjE2NjQ0MSBhbmQg cjE2NjQ0My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5l TGF5b3V0RnVuY3Rpb25zLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5l TGF5b3V0RnVuY3Rpb25zLmNwcAppbmRleCAzY2ZjZmZkMjk4Mjc4NDc2ZmM1YWJiZGQ3NDdlMTQ3 ZmEyM2NkMDU1Li5kNDU0YmZhYWE1ZWZiODIxYmI1YTU5ZGZiNzUzOWU5N2Y5YTY5M2IwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dEZ1bmN0aW9u cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXRGdW5j dGlvbnMuY3BwCkBAIC03OSw3ICs3OSw3IEBAIHZvaWQgcGFpbnRGbG93KGNvbnN0IFJlbmRlckJs b2NrRmxvdyYgZmxvdywgY29uc3QgTGF5b3V0JiBsYXlvdXQsIFBhaW50SW5mbyYgcGFpCiAgICAg R3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGNvbnRleHQsIHRleHRQYWludFN0 eWxlLnN0cm9rZVdpZHRoID4gMCk7CiAKICAgICB1cGRhdGVHcmFwaGljc0NvbnRleHQoY29udGV4 dCwgdGV4dFBhaW50U3R5bGUpOwotICAgIExheW91dFBvaW50IGFkanVzdGVkUGFpbnRPZmZzZXQg PSByb3VuZGVkSW50UG9pbnQocGFpbnRPZmZzZXQpOworICAgIExheW91dFBvaW50IGFkanVzdGVk UGFpbnRPZmZzZXQgPSBMYXlvdXRQb2ludChyb3VuZGVkRm9yUGFpbnRpbmcocGFpbnRPZmZzZXQs IGZsb3cuZG9jdW1lbnQoKS5kZXZpY2VTY2FsZUZhY3RvcigpKSk7CiAKICAgICBMYXlvdXRSZWN0 IHBhaW50UmVjdCA9IHBhaW50SW5mby5yZWN0OwogICAgIHBhaW50UmVjdC5tb3ZlQnkoLWFkanVz dGVkUGFpbnRPZmZzZXQpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGNmMGU1YjdhMzk2NDY3M2YzYmUwMGI4ZTY0ZmI3MTk3 YTMxZGZkM2MuLjMwNTQ5MThlNDBjYzc1MDY0OTU5OTEwMGUwYzhjNTFhNGY4OWJlYmYgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyNCBAQAorMjAxNC0wMy0yOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu Y29tPgorCisgICAgICAgIFN1YnBpeGVsIHJlbmRlcmluZzogU2ltcGxlIGxpbmUgbGF5b3V0IHNo b3VsZCBub3Qgcm91bmQgdG8gaW50ZWdyYWwgcG9zaXRpb24gd2hpbGUgcGFpbnRpbmcuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA5MzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcm91bmRp bmcgdG8gaW50ZWdyYWwgcG9zaXRpb24uIFdoZW4gUmVuZGVyTGF5ZXIgaXMgaW5qZWN0ZWQgYW5k IGhpZGVzIHN1YnBpeGVsIHBvc2l0aW9ucywKKyAgICAgICAgaW50ZWdyYWwgcm91bmRpbmcgcHJv ZHVjZXMgZGlmZmVyZW50IHBhaW50IHBvc2l0aW9uLgorCisgICAgICAgIFdpdGhvdXQgUmVuZGVy TGF5ZXI6CisgICAgICAgIFJlbmRlcmVyJ3MgbGF5b3V0IHBvc2l0aW9uICgxMC41cHgsIDEwLjVw eCkgLT4gcm91bmRlZCBhbmQgcGFpbnRlZCBhdCAoMTFweCwgMTFweCkKKworICAgICAgICBXaXRo IFJlbmRlckxheWVyOgorICAgICAgICBSZW5kZXJlJ3MgbGF5b3V0IHBvc2l0aW9uICgxMC41cHgs IDEwLjVweCkgLT4gUmVuZGVyTGF5ZXIgcG9zaXRpb24gKDEwLjVweCwgMTAuNXB4KSAtPgorICAg ICAgICByZW5kZXJlcidzIHJlbGF0aXZlIHBvcyAoMHB4LCAwcHgpIC0+IHJvdW5kZWQgYW5kIHBh aW50ZWQgYXQgKDBweCwgMHApIHdoaWNoCisgICAgICAgIHRyYW5zbGF0ZXMgdG8gKDEwLjVweCwg MTAuNXB4KSAodnMuICgxMXB4LCAxMXB4KQorCisgICAgICAgICogZmFzdC9mbGV4Ym94L2hpZHBp LXNpbXBsZS1saW5lLWxheW91dC13aXRoLWZsZXhib3gtYW5kLXRyYW5zaXRpb24tZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mbGV4Ym94L2hpZHBpLXNpbXBsZS1saW5lLWxh eW91dC13aXRoLWZsZXhib3gtYW5kLXRyYW5zaXRpb24uaHRtbDogQWRkZWQuCisKIDIwMTQtMDMt MjggIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFuZGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg W0NTUyBHcmlkIExheW91dF0gVGhlICdhdXRvJyBoZWlnaHQgbXVzdCBiZSBhZGFwdGVkIHRvIHRo ZSBpdGVtJ3MgbWFyZ2luLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mbGV4Ym94L2hp ZHBpLXNpbXBsZS1saW5lLWxheW91dC13aXRoLWZsZXhib3gtYW5kLXRyYW5zaXRpb24tZXhwZWN0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9oaWRwaS1zaW1wbGUtbGluZS1sYXlv dXQtd2l0aC1mbGV4Ym94LWFuZC10cmFuc2l0aW9uLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ODg3NThmZmY2NDg2YWU2YTZkM2UxMWY5YmIzZWQ2OTk3YWM3ZDNjMwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9oaWRwaS1zaW1wbGUtbGluZS1sYXlvdXQtd2l0 aC1mbGV4Ym94LWFuZC10cmFuc2l0aW9uLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwyNiBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPlRoaXMgdGVzdHMgdGhhdCBz aW1wbGUgbGluZSBsYXlvdXQgcGFpbnRzIGF0IHRoZSBzYW1lIHBvc2l0aW9uIHdoZW4gdHJhbnNp dGlvbiBpcyBwcmVzZW50L25vdCBwcmVzZW50LjwvdGl0bGU+Cis8c3R5bGU+CisgIC5vdXRlcnsK KyAgICAtd2Via2l0LWFsaWduLWl0ZW1zOiBjZW50ZXI7CisgICAgYm94LXNpemluZzogYm9yZGVy LWJveDsKKyAgICBwYWRkaW5nLXRvcDogMXB4OworICAgIG1pbi1oZWlnaHQ6IDI1cHg7CisgICAg ZGlzcGxheTogLXdlYmtpdC1mbGV4OworICB9CisKKyAgLmlubmVyIHsKKyAgICBmb250OiAtd2Vi a2l0LXNtYWxsLWNvbnRyb2w7CisgICAgZm9udC1zaXplOiAyMHB4OworICB9Cis8L3N0eWxlPgor PC9oZWFkPgorPGJvZHk+CisgIDxkaXYgY2xhc3M9b3V0ZXI+CisgICAgPGRpdiBjbGFzcz1pbm5l cj5UaGlzIHRleHQgc2hvdWxkIG5vdCBtb3ZlLjwvZGl2PgorICA8L2Rpdj4KKyAgPHNjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9o aWRwaS1zaW1wbGUtbGluZS1sYXlvdXQtd2l0aC1mbGV4Ym94LWFuZC10cmFuc2l0aW9uLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvaGlkcGktc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgt ZmxleGJveC1hbmQtdHJhbnNpdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ0YzkyNWJiOTI5ZWQ1OTg4 YWU1NWFkYmE1ZDg4NWU0NDUzMjU3NmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2ZsZXhib3gvaGlkcGktc2ltcGxlLWxpbmUtbGF5b3V0LXdpdGgtZmxleGJveC1hbmQtdHJh bnNpdGlvbi5odG1sCkBAIC0wLDAgKzEsMjcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgc2ltcGxlIGxpbmUgbGF5b3V0IHBhaW50cyBh dCB0aGUgc2FtZSBwb3NpdGlvbiB3aGVuIHRyYW5zaXRpb24gaXMgcHJlc2VudC9ub3QgcHJlc2Vu dC48L3RpdGxlPgorPHN0eWxlPgorICAub3V0ZXJ7CisgICAgLXdlYmtpdC1hbGlnbi1pdGVtczog Y2VudGVyOworICAgIGJveC1zaXppbmc6IGJvcmRlci1ib3g7CisgICAgcGFkZGluZy10b3A6IDFw eDsKKyAgICBtaW4taGVpZ2h0OiAyNXB4OworICAgIGRpc3BsYXk6IC13ZWJraXQtZmxleDsKKyAg fQorCisgIC5pbm5lciB7CisgICAgZm9udDogLXdlYmtpdC1zbWFsbC1jb250cm9sOworICAgIGZv bnQtc2l6ZTogMjBweDsKKyAgICAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgwKTsKKyAg fQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorICA8ZGl2IGNsYXNzPW91dGVyPgorICAgIDxk aXYgY2xhc3M9aW5uZXI+VGhpcyB0ZXh0IHNob3VsZCBub3QgbW92ZS48L2Rpdj4KKyAgPC9kaXY+ CisgIDxzY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==