130923 2014-03-28 17:34:28 -0700 Uncaught NSExceptions should crash the web process 2014-03-29 10:19:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca mitz webkit-bug-importer oldest_to_newest 995521 0 andersca 2014-03-28 17:34:28 -0700 Uncatched NSExceptions should crash the web process 995522 1 webkit-bug-importer 2014-03-28 17:35:04 -0700 <rdar://problem/16463751> 995523 2 228101 andersca 2014-03-28 17:37:18 -0700 Created attachment 228101 Patch 995526 3 228101 mitz 2014-03-28 17:40:21 -0700 Comment on attachment 228101 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228101&action=review > Source/WebKit2/ChangeLog:3 > + Uncatched NSExceptions should crash the web process Uncaught > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:191 > + [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }]; What is the behavior in the non-AppKit configuration? Does it already crash on exceptions? Can we make it crash on exceptions? 995575 4 andersca 2014-03-29 09:12:42 -0700 (In reply to comment #3) > (From update of attachment 228101 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228101&action=review > > > Source/WebKit2/ChangeLog:3 > > + Uncatched NSExceptions should crash the web process > > Uncaught > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:191 > > + [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }]; > > What is the behavior in the non-AppKit configuration? Does it already crash on exceptions? Can we make it crash on exceptions? I think we can use std::set_terminate to set the exception handler, but I'm not sure if it's possible to get the exception (or stack trace) from there. 995576 5 andersca 2014-03-29 09:15:08 -0700 Committed r166452: <http://trac.webkit.org/changeset/166452> 995582 6 mitz 2014-03-29 10:19:42 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 228101 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=228101&action=review > > > > > Source/WebKit2/ChangeLog:3 > > > + Uncatched NSExceptions should crash the web process > > > > Uncaught > > > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:191 > > > + [[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"NSApplicationCrashOnExceptions" : @YES }]; > > > > What is the behavior in the non-AppKit configuration? Does it already crash on exceptions? Can we make it crash on exceptions? > > I think we can use std::set_terminate to set the exception handler, but I'm not sure if it's possible to get the exception (or stack trace) from there. I was thinking along the lines of using NSSetUncaughtExceptionHandler(). 228101 2014-03-28 17:37:18 -0700 2014-03-28 17:40:20 -0700 Patch bug-130923-20140328173658.patch text/plain 1705 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWVkM2RjNDhmNmYyNzIy OTcyMzljMzk2ZTU0OGE2ZGM5ZDlmMTgwNy4uMGZiMWUzYzYwMWMwMDIwZjhiYTQ1NjdkOWM0ZjRl Y2Q5Njc3YzAyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTI4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVW5jYXRjaGVkIE5T RXhjZXB0aW9ucyBzaG91bGQgY3Jhc2ggdGhlIHdlYiBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA5MjMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE2NDYzNzUxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAg IChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOgorCiAy MDE0LTAzLTI4ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBS ZXBsYXk6IGFkZCBwYWdlLWxldmVsIHNldHRpbmcgdG8gYnlwYXNzIHRoZSBNZW1vcnlDYWNoZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29j b2EubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5t bQppbmRleCA1ODY1ZmM0YWI1ZjE3NGZkY2E4M2YxMDRlNTFmM2FkNzk1NDRkYzAyLi40YzdlM2Ux ZTFiNDU3NDM1NWVkYzUxYjc0MDUxNmMxMjZhYjAzZDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtMTg4LDYgKzE4OCw4 IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBX ZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzCiAgICAgc2V0RW5oYW5jZWRBY2Nlc3NpYmlsaXR5 KHBhcmFtZXRlcnMuYWNjZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUVuYWJsZWQpOwog CiAjaWYgVVNFKEFQUEtJVCkKKyAgICBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1 bHRzXSByZWdpc3RlckRlZmF1bHRzOkB7IEAiTlNBcHBsaWNhdGlvbkNyYXNoT25FeGNlcHRpb25z IiA6IEBZRVMgfV07CisKICAgICAvLyByZGFyOi8vOTExODYzOSBhY2Nlc3NpYmlsaXR5Rm9jdXNl ZFVJRWxlbWVudCBpbiBOU0FwcGxpY2F0aW9uIGRlZmF1bHRzIHRvIHVzZSB0aGUga2V5V2luZG93 LiBTaW5jZSB0aGVyZSdzCiAgICAgLy8gbm8gd2luZG93IGluIFdLMiwgTlNBcHBsaWNhdGlvbiBu ZWVkcyB0byB1c2UgdGhlIGZvY3VzZWQgcGFnZSdzIGZvY3VzZWQgZWxlbWVudC4KICAgICBNZXRo b2QgbWV0aG9kVG9QYXRjaCA9IGNsYXNzX2dldEluc3RhbmNlTWV0aG9kKFtOU0FwcGxpY2F0aW9u IGNsYXNzXSwgQHNlbGVjdG9yKGFjY2Vzc2liaWxpdHlGb2N1c2VkVUlFbGVtZW50KSk7Cg==