130921 2014-03-28 17:16:23 -0700 Web Inspector: console.warn is showing as error instead of warning 2014-03-28 17:31:07 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue ggaren graouts joepeck mark.lam timothy webkit-bug-importer oldest_to_newest 995508 0 joepeck 2014-03-28 17:16:23 -0700 I regressed this when I moved console to JavaScriptCore. We are accidentally reporting console.warn as MessageLevel::Error instead of MessageLevel::Warning. Take this opportunity to add a test, and update the fronted to use our enums instead of raw strings. 995511 1 webkit-bug-importer 2014-03-28 17:18:43 -0700 <rdar://problem/16463548> 995512 2 228098 joepeck 2014-03-28 17:19:05 -0700 Created attachment 228098 [PATCH] Proposed Fix 995519 3 228098 commit-queue 2014-03-28 17:31:05 -0700 Comment on attachment 228098 [PATCH] Proposed Fix Clearing flags on attachment: 228098 Committed r166439: <http://trac.webkit.org/changeset/166439> 995520 4 commit-queue 2014-03-28 17:31:07 -0700 All reviewed patches have been landed. Closing bug. 228098 2014-03-28 17:19:05 -0700 2014-03-28 17:31:04 -0700 [PATCH] Proposed Fix warn.patch text/plain 6447 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNWJjNDQ3Li4zY2E1YTEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDMt MjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBjb25zb2xlLndhcm4gaXMgc2hvd2luZyBhcyBlcnJvciBpbnN0ZWFkIG9mIHdh cm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MDkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBhIHRlc3QgZm9yIGNvbnNvbGUubG9nLCB3YXJuLCBlcnJvciwgZXRjIHRvIG1ha2Ugc3VyZSB0 aGV5IGdldAorICAgICAgICB0byB0aGUgZnJvbnRlbmQgd2l0aCB0aGUgZXhwZWN0ZWQgc291cmNl IGFuZCBsZXZlbC4KKworICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9jb25zb2xlL2NvbnNv bGUtbWVzc2FnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci1wcm90 b2NvbC9jb25zb2xlL2NvbnNvbGUtbWVzc2FnZS5odG1sOiBBZGRlZC4KKwogMjAxNC0wMy0yNyAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYSBjcmFz aCBjYXVzZWQgYnkgdHJhY2sgaW5zZXJ0aW9uIGFmdGVyIGxvYWQoKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2NvbnNvbGUvY29uc29sZS1tZXNzYWdlLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9jb25zb2xlL2NvbnNvbGUt bWVzc2FnZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u OGM3N2ViZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2Nv bC9jb25zb2xlL2NvbnNvbGUtbWVzc2FnZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMiBAQAor Q09OU09MRSBNRVNTQUdFOiBsaW5lIDc6IGxvZworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDg6IGlu Zm8KK0NPTlNPTEUgTUVTU0FHRTogbGluZSA5OiB3YXJuCitDT05TT0xFIE1FU1NBR0U6IGxpbmUg MTA6IGVycm9yCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTE6IGRlYnVnCitUZXN0cyB0aGF0IGNv bnNvbGUgbG9nIG1lc3NhZ2VzIG1ha2UgaXQgdG8gdGhlIGZyb250ZW5kIGFuZCBoYXZlIGV4cGVj dGVkIHNvdXJjZSwgdHlwZSwgYW5kIGxldmVscy4KK3sic291cmNlIjoiY29uc29sZS1hcGkiLCJs ZXZlbCI6ImxvZyIsInRleHQiOiJsb2ciLCJsb2NhdGlvbiI6ImNvbnNvbGUtbWVzc2FnZS5odG1s Ojc6MTYiLCJwYXJhbWV0ZXJzIjpbeyJ0eXBlIjoic3RyaW5nIn1dfQoreyJzb3VyY2UiOiJjb25z b2xlLWFwaSIsImxldmVsIjoibG9nIiwidGV4dCI6ImluZm8iLCJsb2NhdGlvbiI6ImNvbnNvbGUt bWVzc2FnZS5odG1sOjg6MTciLCJwYXJhbWV0ZXJzIjpbeyJ0eXBlIjoic3RyaW5nIn1dfQoreyJz b3VyY2UiOiJjb25zb2xlLWFwaSIsImxldmVsIjoid2FybmluZyIsInRleHQiOiJ3YXJuIiwibG9j YXRpb24iOiJjb25zb2xlLW1lc3NhZ2UuaHRtbDo5OjE3IiwicGFyYW1ldGVycyI6W3sidHlwZSI6 InN0cmluZyJ9XX0KK3sic291cmNlIjoiY29uc29sZS1hcGkiLCJsZXZlbCI6ImVycm9yIiwidGV4 dCI6ImVycm9yIiwibG9jYXRpb24iOiJjb25zb2xlLW1lc3NhZ2UuaHRtbDoxMDoxOCIsInBhcmFt ZXRlcnMiOlt7InR5cGUiOiJzdHJpbmcifV19Cit7InNvdXJjZSI6ImNvbnNvbGUtYXBpIiwibGV2 ZWwiOiJkZWJ1ZyIsInRleHQiOiJkZWJ1ZyIsImxvY2F0aW9uIjoiY29uc29sZS1tZXNzYWdlLmh0 bWw6MTE6MTgiLCJwYXJhbWV0ZXJzIjpbeyJ0eXBlIjoic3RyaW5nIn1dfQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvY29uc29sZS9jb25zb2xlLW1lc3NhZ2Uu aHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9jb25zb2xlL2NvbnNvbGUtbWVz c2FnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjFiODIwNmQKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvY29uc29sZS9j b25zb2xlLW1lc3NhZ2UuaHRtbApAQCAtMCwwICsxLDQwIEBACis8aHRtbD4KKzxoZWFkPgorPHNj cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0 b3ItcHJvdG9jb2wvcmVzb3VyY2VzL3Byb3RvY29sLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlw dD4KK2Z1bmN0aW9uIGdlbmVyYXRlU2ltcGxlQ29uc29sZU1lc3NhZ2VzKCkKK3sKKyAgICBjb25z b2xlLmxvZygibG9nIik7CisgICAgY29uc29sZS5pbmZvKCJpbmZvIik7IC8vIEFsaWFzIG9mIGxv Zy4KKyAgICBjb25zb2xlLndhcm4oIndhcm4iKTsKKyAgICBjb25zb2xlLmVycm9yKCJlcnJvciIp OworICAgIGNvbnNvbGUuZGVidWcoImRlYnVnIik7Cit9CisKK2Z1bmN0aW9uIHRlc3QoKQorewor ICAgIEluc3BlY3RvclRlc3QuaW1wb3J0U2NyaXB0KCIuLi8uLi8uLi8uLi9pbnNwZWN0b3ItcHJv dG9jb2wvcmVzb3VyY2VzL2NvbnNvbGUtaGVscGVyLmpzIik7CisKKyAgICBJbnNwZWN0b3JUZXN0 LnNlbmRDb21tYW5kKCJDb25zb2xlLmVuYWJsZSIsIHt9KTsKKyAgICBJbnNwZWN0b3JUZXN0LnNl bmRDb21tYW5kKCJSdW50aW1lLmV2YWx1YXRlIiwge2V4cHJlc3Npb246ICJnZW5lcmF0ZVNpbXBs ZUNvbnNvbGVNZXNzYWdlcygpIn0pOworCisgICAgdmFyIGNvbnNvbGVNZXNzYWdlQ291bnQgPSAw OworICAgIGNvbnN0IGV4cGVjdGVkQ29uc29sZU1lc3NhZ2VzID0gNTsKKworICAgIEluc3BlY3Rv clRlc3QuZXZlbnRIYW5kbGVyWyJDb25zb2xlLm1lc3NhZ2VBZGRlZCJdID0gZnVuY3Rpb24obWVz c2FnZU9iamVjdCkKKyAgICB7CisgICAgICAgIHZhciBzaW1wbGlmaWVkTWVzc2FnZSA9IENvbnNv bGVIZWxwZXIuc2ltcGxpZmllZENvbnNvbGVNZXNzYWdlKG1lc3NhZ2VPYmplY3QpOworICAgICAg ICBJbnNwZWN0b3JUZXN0LmxvZyhKU09OLnN0cmluZ2lmeShzaW1wbGlmaWVkTWVzc2FnZSkpOwor CisgICAgICAgIGlmICgrK2NvbnNvbGVNZXNzYWdlQ291bnQgPT09IGV4cGVjdGVkQ29uc29sZU1l c3NhZ2VzKQorICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICB9 Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgor VGVzdHMgdGhhdCBjb25zb2xlIGxvZyBtZXNzYWdlcyBtYWtlIGl0IHRvIHRoZSBmcm9udGVuZCBh bmQgaGF2ZSBleHBlY3RlZCBzb3VyY2UsIHR5cGUsIGFuZCBsZXZlbHMuPGJyPgorPC9wPgorPC9i b2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMzBmODU3YS4uNDgzMjc4 ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDMtMjgg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBjb25zb2xlLndhcm4gaXMgc2hvd2luZyBhcyBlcnJvciBpbnN0ZWFkIG9mIHdhcm5p bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDky MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVu dGltZS9Db25zb2xlUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6Y29uc29sZVByb3RvRnVu Y1dhcm4pOgorICAgICAgICBjb25zb2xlLndhcm4gc2hvdWxkIGJlIE1lc3NhZ2VMZXZlbCBXYXJu aW5nLCBub3QgRXJyb3IuCisKIDIwMTQtMDMtMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBFbmFibGUgTExWTSBzdGFja21hcCBsaXZlT3V0cyBjb21wdXRhdGlv bgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZVByb3Rv dHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25zb2xlUHJvdG90eXBl LmNwcAppbmRleCBjNTE5Zjk1Li5hMWMyODY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9Db25zb2xlUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9Db25zb2xlUHJvdG90eXBlLmNwcApAQCAtMTI5LDcgKzEyOSw3IEBAIHN0 YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnNvbGVQcm90b0Z1bmNMb2coRXhl Y1N0YXRlKiBleGVjKQogCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25z b2xlUHJvdG9GdW5jV2FybihFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0dXJuIGNvbnNvbGVM b2dXaXRoTGV2ZWwoZXhlYywgTWVzc2FnZUxldmVsOjpFcnJvcik7CisgICAgcmV0dXJuIGNvbnNv bGVMb2dXaXRoTGV2ZWwoZXhlYywgTWVzc2FnZUxldmVsOjpXYXJuaW5nKTsKIH0KIAogc3RhdGlj IEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY29uc29sZVByb3RvRnVuY0NsZWFyKEV4ZWNT dGF0ZSogZXhlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk5ZDMwNjQuLmI4OTFhYWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTI4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogY29uc29sZS53YXJuIGlzIHNob3dpbmcgYXMgZXJyb3IgaW5zdGVhZCBvZiB3YXJuaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA5MjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvTW9kZWxzL0RlZmF1bHREYXNoYm9hcmQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuRGVmYXVsdERhc2hib2FyZC5wcm90b3R5cGUuX2luY3JlbWVudENvbnNvbGVNZXNzYWdlVHlw ZSk6CisgICAgICAgIFVzZSBvdXIgZW51bXMgaW5zdGVhZCBvZiBoYXJkY29kZWQgc3RyaW5ncy4K KwogMjAxNC0wMy0yNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2luXSBDb3JyZWN0IGhhbmRsaW5nIG9mIGF1dG9nZW5lcmF0ZWQgV2ViSW5zcGVjdG9y VUkgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9EZWZhdWx0RGFzaGJvYXJkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL0RlZmF1bHREYXNoYm9hcmQuanMKaW5kZXggMzU3ZTg1ZC4uNDIzYzdl OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0RlZmF1bHREYXNoYm9hcmQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0RlZmF1bHREYXNoYm9hcmQuanMKQEAgLTI0OSwxMyArMjQ5LDEzIEBAIFdl Ykluc3BlY3Rvci5EZWZhdWx0RGFzaGJvYXJkLnByb3RvdHlwZSA9IHsKICAgICBfaW5jcmVtZW50 Q29uc29sZU1lc3NhZ2VUeXBlOiBmdW5jdGlvbih0eXBlLCBpbmNyZW1lbnQpCiAgICAgewogICAg ICAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICAgICAgY2FzZSAibG9nIjoKKyAgICAgICAgY2FzZSBX ZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkxvZzoKICAgICAgICAgICAg IHRoaXMubG9ncyArPSBpbmNyZW1lbnQ7CiAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2Fz ZSAid2FybmluZyI6CisgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1l c3NhZ2VMZXZlbC5XYXJuaW5nOgogICAgICAgICAgICAgdGhpcy5pc3N1ZXMgKz0gaW5jcmVtZW50 OwogICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgImVycm9yIjoKKyAgICAgICAgY2Fz ZSBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkVycm9yOgogICAgICAg ICAgICAgdGhpcy5lcnJvcnMgKz0gaW5jcmVtZW50OwogICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIH0K