130912 2014-03-28 15:36:34 -0700 Web Inspector: Really drop all locks in nested run loop on iOS if WebThread is enabled 2014-03-28 16:32:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck mark.lam mhahnenberg timothy webkit-bug-importer oldest_to_newest 995468 0 joepeck 2014-03-28 15:36:34 -0700 On iOS we were not dropping all locks as we expected because of scoping. We should drop the JSLock if running the nested run loop on the WebThread. <rdar://problem/15835877> 995469 1 228087 joepeck 2014-03-28 15:40:21 -0700 Created attachment 228087 [PATCH] Proposed Fix 995475 2 228087 ggaren 2014-03-28 15:56:21 -0700 Comment on attachment 228087 [PATCH] Proposed Fix r=me 995486 3 228087 commit-queue 2014-03-28 16:32:05 -0700 Comment on attachment 228087 [PATCH] Proposed Fix Clearing flags on attachment: 228087 Committed r166436: <http://trac.webkit.org/changeset/166436> 995487 4 commit-queue 2014-03-28 16:32:08 -0700 All reviewed patches have been landed. Closing bug. 228087 2014-03-28 15:40:21 -0700 2014-03-28 16:32:05 -0700 [PATCH] Proposed Fix dropalllocks.patch text/plain 3188 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZGViMWI5Li45MzM2MTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDMtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWFsbHkgZHJvcCBhbGwgbG9ja3MgaW4gbmVzdGVkIHJ1 biBsb29wIG9uIGlPUyBpZiBXZWJUaHJlYWQgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwOTEyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJldmlvdXNseSB3ZSB3ZXJlIGNhbGxpbmcg RHJvcEFsbExvY2tzIGluc2lkZSBvZiBhIHNpbmdsZSBsaW5lIGlmIHN0YXRlbWVudCwKKyAgICAg ICAgc28gdGhlIEpTTG9jayB3YXMgZ2V0dGluZyByZWFxdWlyZWQgdmVyeSBxdWlja2x5LiBXZSBy ZWFsbHkgd2FudCB0byBEcm9wQWxsTG9ja3MKKyAgICAgICAgZm9yIHRoZSBkdXJhdGlvbiBvZiBy dW5uaW5nIHRoZSBuZXN0ZWQgcnVuIGxvb3Agb24gaU9TIGlmIHRoZXJlIGlzIGEgV2ViVGhyZWFk LgorCisgICAgICAgICogYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmg6CisgICAg ICAgICogYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBhZ2VTY3JpcHREZWJ1Z1NlcnZlcjo6cnVuRXZlbnRMb29wV2hpbGVQYXVzZWQpOgor ICAgICAgICAoV2ViQ29yZTo6UGFnZVNjcmlwdERlYnVnU2VydmVyOjpydW5FdmVudExvb3BXaGls ZVBhdXNlZEludGVybmFsKToKKwogMjAxNC0wMy0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgTG9jYWxlTWFjOjpjcmVhdGUg bWV0aG9kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0 RGVidWdTZXJ2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUGFnZVNjcmlwdERl YnVnU2VydmVyLmNwcAppbmRleCBmZjYxMDQ5Li43NGI5MzNiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5jcHAKQEAgLTE4Nywy NCArMTg3LDI5IEBAIHZvaWQgUGFnZVNjcmlwdERlYnVnU2VydmVyOjpydW5FdmVudExvb3BXaGls ZVBhdXNlZCgpCiAgICAgLy8gT24gaU9TLCBydW5uaW5nIGFuIEV2ZW50TG9vcCBjYXVzZXMgdXMg dG8gcnVuIGEgbmVzdGVkIFdlYlJ1bkxvb3AuCiAgICAgLy8gU2luY2UgdGhlIFdlYlRocmVhZCBp cyBhdXRvcmVsZWFzZWQgYXQgdGhlIGVuZCBvZiBydW4gbG9vcCBpdGVyYXRpb25zCiAgICAgLy8g d2UgbmVlZCB0byBncmFjZWZ1bGx5IGhhbmRsZSByZWxlYXNpbmcgYW5kIHJlYWNxdWlyaW5nIHRo ZSBsb2NrLgotICAgIEFTU0VSVChXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJsZWQoKSk7Ci0gICAg ewotICAgICAgICBpZiAoV2ViVGhyZWFkSXNFbmFibGVkKCkpCi0gICAgICAgICAgICBKU0M6OkpT TG9jazo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhXZWJDb3JlOjpKU0RPTVdpbmRvd0Jhc2U6 OmNvbW1vblZNKCkpOworICAgIGlmIChXZWJUaHJlYWRJc0VuYWJsZWQoKSkgeworICAgICAgICBB U1NFUlQoV2ViVGhyZWFkSXNMb2NrZWRPckRpc2FibGVkKCkpOworICAgICAgICBKU0M6OkpTTG9j azo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhXZWJDb3JlOjpKU0RPTVdpbmRvd0Jhc2U6OmNv bW1vblZNKCkpOwogICAgICAgICBXZWJSdW5Mb29wRW5hYmxlTmVzdGVkKCk7CisKKyAgICAgICAg cnVuRXZlbnRMb29wV2hpbGVQYXVzZWRJbnRlcm5hbCgpOworCisgICAgICAgIFdlYlJ1bkxvb3BE aXNhYmxlTmVzdGVkKCk7CisgICAgICAgIEFTU0VSVChXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJs ZWQoKSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAjZW5kaWYKIAorICAgIHJ1bkV2ZW50TG9v cFdoaWxlUGF1c2VkSW50ZXJuYWwoKTsKK30KKwordm9pZCBQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6 OnJ1bkV2ZW50TG9vcFdoaWxlUGF1c2VkSW50ZXJuYWwoKQorewogICAgIFRpbWVyQmFzZTo6Zmly ZVRpbWVyc0luTmVzdGVkRXZlbnRMb29wKCk7CiAKICAgICBFdmVudExvb3AgbG9vcDsKICAgICB3 aGlsZSAoIW1fZG9uZVByb2Nlc3NpbmdEZWJ1Z2dlckV2ZW50cyAmJiAhbG9vcC5lbmRlZCgpKQog ICAgICAgICBsb29wLmN5Y2xlKCk7Ci0KLSNpZiBQTEFURk9STShJT1MpCi0gICAgICAgIFdlYlJ1 bkxvb3BEaXNhYmxlTmVzdGVkKCk7Ci0gICAgfQotICAgIEFTU0VSVChXZWJUaHJlYWRJc0xvY2tl ZE9yRGlzYWJsZWQoKSk7Ci0jZW5kaWYKIH0KIAogYm9vbCBQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6 OmlzQ29udGVudFNjcmlwdChFeGVjU3RhdGUqIGV4ZWMpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5oCmluZGV4IDkwZjhjYmMu LmU5ZDY4ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3Jp cHREZWJ1Z1NlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3Jp cHREZWJ1Z1NlcnZlci5oCkBAIC02Niw2ICs2Niw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBi b29sIGlzQ29udGVudFNjcmlwdChKU0M6OkV4ZWNTdGF0ZSopIGNvbnN0IG92ZXJyaWRlOwogICAg IHZpcnR1YWwgdm9pZCByZXBvcnRFeGNlcHRpb24oSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFs dWUpIGNvbnN0IG92ZXJyaWRlOwogCisgICAgdm9pZCBydW5FdmVudExvb3BXaGlsZVBhdXNlZElu dGVybmFsKCk7CiAKICAgICB2b2lkIGRpZEFkZEZpcnN0TGlzdGVuZXIoUGFnZSopOwogICAgIHZv aWQgZGlkUmVtb3ZlTGFzdExpc3RlbmVyKFBhZ2UqLCBib29sIHNraXBSZWNvbXBpbGUpOwo=