130909 2014-03-28 12:24:31 -0700 [iOS] Don't cancel composition on selection change 2014-03-28 15:06:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue enrica oldest_to_newest 995422 0 ap 2014-03-28 12:24:31 -0700 In bug 130727, I made it WebProcess responsibility to cancel composition on selection change. I thought that this didn't change iOS behavior, because we had this under PLATFORM(COCOA) in WebPageProxy. But turns out that WebPageProxy::cancelComposition had a no-op implementation on iOS, unlike of the new WebProcess one. 995423 1 228076 ap 2014-03-28 12:26:35 -0700 Created attachment 228076 proposed fix 995461 2 228076 commit-queue 2014-03-28 15:06:34 -0700 Comment on attachment 228076 proposed fix Clearing flags on attachment: 228076 Committed r166430: <http://trac.webkit.org/changeset/166430> 995462 3 commit-queue 2014-03-28 15:06:41 -0700 All reviewed patches have been landed. Closing bug. 228076 2014-03-28 12:26:35 -0700 2014-03-28 15:06:33 -0700 proposed fix NoCancelIOS.txt text/plain 1607 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjQyMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTI4ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIERvbid0IGNhbmNl bCBjb21wb3NpdGlvbiBvbiBzZWxlY3Rpb24gY2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA5MDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcgYSByZWNlbnQgcmVncmVzc2lvbiBmcm9t IGJ1ZyAxMzA3MjcuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6 IChXZWJLaXQ6OldlYlBhZ2U6OmRpZENoYW5nZVNlbGVjdGlvbik6CisKIDIwMTQtMDMtMjggIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgRWxpbWluYXRlIGEg c3luYyBjYW5jZWxDb21wb3NpdGlvbiBjYWxsIGluIFdlYlBhZ2VQcm94eTo6ZWRpdG9yU3RhdGVD aGFuZ2VkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCShyZXZpc2lvbiAxNjY0MjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxMDksNyArNDEwOSw3IEBAIHZv aWQgV2ViUGFnZTo6Y2FuY2VsQ29tcG9zaXRpb24oKQogCiB2b2lkIFdlYlBhZ2U6OmRpZENoYW5n ZVNlbGVjdGlvbigpCiB7Ci0jaWYgKFBMQVRGT1JNKE1BQykgJiYgVVNFKEFTWU5DX05TVEVYVElO UFVUQ0xJRU5UKSkgfHwgUExBVEZPUk0oSU9TKQorI2lmIChQTEFURk9STShNQUMpICYmIFVTRShB U1lOQ19OU1RFWFRJTlBVVENMSUVOVCkpCiAgICAgRnJhbWUmIGZyYW1lID0gbV9wYWdlLT5mb2N1 c0NvbnRyb2xsZXIoKS5mb2N1c2VkT3JNYWluRnJhbWUoKTsKICAgICAvLyBBYmFuZG9uIHRoZSBj dXJyZW50IGlubGluZSBpbnB1dCBzZXNzaW9uIGlmIHNlbGVjdGlvbiBjaGFuZ2VkIGZvciBhbnkg b3RoZXIgcmVhc29uIGJ1dCBhbiBpbnB1dCBtZXRob2QgZGlyZWN0IGFjdGlvbi4KICAgICAvLyBG SVhNRTogTWFueSBjaGFuZ2VzIHRoYXQgYWZmZWN0IGNvbXBvc2l0aW9uIG5vZGUgZG8gbm90IGdv IHRocm91Z2ggZGlkQ2hhbmdlU2VsZWN0aW9uKCkuIFdlIG5lZWQgdG8gZG8gc29tZXRoaW5nIHdo ZW4gRE9NIG1hbmlwdWxhdGlvbiBhZmZlY3RzIHRoZSBjb21wb3NpdGlvbiwgYmVjYXVzZSBvdGhl cndpc2UgaW5wdXQgbWV0aG9kJ3MgaWRlYSBhYm91dCBpdCB3aWxsIGJlIGRpZmZlcmVudCBmcm9t IEVkaXRvcidzLgo=