130887 2014-03-27 22:21:45 -0700 REGRESSION(r166376): This was a misguided optimization. (Requested by kling on #webkit). 2014-03-28 06:59:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130857 1 commit-queue commit-queue kling mhahnenberg oldest_to_newest 995240 0 commit-queue 2014-03-27 22:21:45 -0700 http://trac.webkit.org/changeset/166376 broke the build: This was a misguided optimization. (Requested by kling on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 995243 1 228025 commit-queue 2014-03-27 22:22:06 -0700 Created attachment 228025 ROLLOUT of r166376 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 995244 2 228025 commit-queue 2014-03-27 22:29:03 -0700 Comment on attachment 228025 ROLLOUT of r166376 Clearing flags on attachment: 228025 Committed r166397: <http://trac.webkit.org/changeset/166397> 995245 3 commit-queue 2014-03-27 22:29:06 -0700 All reviewed patches have been landed. Closing bug. 995313 4 mhahnenberg 2014-03-28 06:59:35 -0700 Why? I thought at least the change from structure -> newStructure in the second part of the patch made the code more readable. 228025 2014-03-27 22:22:06 -0700 2014-03-27 22:29:03 -0700 ROLLOUT of r166376 bug-130887-20140327222146.patch text/plain 4088 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YThiZjA4OWJiZDZiNzcwMzJlMDk4OWNhODg5NzEwNjE2NTYxZGRiLi5jYjNhZTIxYzAxZjFiOTQ2 MTMxNmNhZjQ5ZmQ1ZDU2N2EyZmYyNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNC0wMy0yNyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE2NjM3Ni4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg4NworCisgICAg ICAgIFRoaXMgd2FzIGEgbWlzZ3VpZGVkIG9wdGltaXphdGlvbi4gKFJlcXVlc3RlZCBieSBrbGlu ZyBvbgorICAgICAgICAjd2Via2l0KS4KKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisK KyAgICAgICAgIkF2b2lkIGZldGNoaW5nIEpTT2JqZWN0OjpzdHJ1Y3R1cmUoKSByZXBlYXRlZGx5 IGluCisgICAgICAgIHB1dERpcmVjdEludGVybmFsLiIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg1NworICAgICAgICBodHRwOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC8xNjYzNzYKKwogMjAxNC0wMy0yNyAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgc3ByZWFkIG9wZXJhbmQgaW4gfG5ld3wg ZXhwcmVzc2lvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCmluZGV4 IGY0MmQzODAxNjdmZjYzNzYwMDBlZTdkZDFkYzMwNzJlYjlmMzA1NTAuLjI4NjZmYTU1NjY3Y2Rm NTA0ZWI2ZTUyNjk3MzRhNTY5YzkxOTg5MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNPYmplY3QuaApAQCAtMTMyNSwzNSArMTMyNSwzNSBAQCBpbmxpbmUgYm9vbCBKU09iamVj dDo6cHV0RGlyZWN0SW50ZXJuYWwoVk0mIHZtLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBK U1ZhbAogCiAgICAgICAgIERlZmVyR0MgZGVmZXJHQyh2bS5oZWFwKTsKICAgICAgICAgQnV0dGVy Zmx5KiBuZXdCdXR0ZXJmbHkgPSBidXR0ZXJmbHkoKTsKLSAgICAgICAgaWYgKHN0cnVjdHVyZS0+ cHV0V2lsbEdyb3dPdXRPZkxpbmVTdG9yYWdlKCkpCi0gICAgICAgICAgICBuZXdCdXR0ZXJmbHkg PSBncm93T3V0T2ZMaW5lU3RvcmFnZSh2bSwgc3RydWN0dXJlLT5vdXRPZkxpbmVDYXBhY2l0eSgp LCBzdHJ1Y3R1cmUtPnN1Z2dlc3RlZE5ld091dE9mTGluZVN0b3JhZ2VDYXBhY2l0eSgpKTsKLSAg ICAgICAgb2Zmc2V0ID0gc3RydWN0dXJlLT5hZGRQcm9wZXJ0eVdpdGhvdXRUcmFuc2l0aW9uKHZt LCBwcm9wZXJ0eU5hbWUsIGF0dHJpYnV0ZXMsIHNwZWNpZmljRnVuY3Rpb24pOwotICAgICAgICBz ZXRTdHJ1Y3R1cmVBbmRCdXR0ZXJmbHkodm0sIHN0cnVjdHVyZSwgbmV3QnV0dGVyZmx5KTsKKyAg ICAgICAgaWYgKHRoaXMtPnN0cnVjdHVyZSgpLT5wdXRXaWxsR3Jvd091dE9mTGluZVN0b3JhZ2Uo KSkKKyAgICAgICAgICAgIG5ld0J1dHRlcmZseSA9IGdyb3dPdXRPZkxpbmVTdG9yYWdlKHZtLCB0 aGlzLT5zdHJ1Y3R1cmUoKS0+b3V0T2ZMaW5lQ2FwYWNpdHkoKSwgdGhpcy0+c3RydWN0dXJlKCkt PnN1Z2dlc3RlZE5ld091dE9mTGluZVN0b3JhZ2VDYXBhY2l0eSgpKTsKKyAgICAgICAgb2Zmc2V0 ID0gdGhpcy0+c3RydWN0dXJlKCktPmFkZFByb3BlcnR5V2l0aG91dFRyYW5zaXRpb24odm0sIHBy b3BlcnR5TmFtZSwgYXR0cmlidXRlcywgc3BlY2lmaWNGdW5jdGlvbik7CisgICAgICAgIHNldFN0 cnVjdHVyZUFuZEJ1dHRlcmZseSh2bSwgdGhpcy0+c3RydWN0dXJlKCksIG5ld0J1dHRlcmZseSk7 CiAKICAgICAgICAgdmFsaWRhdGVPZmZzZXQob2Zmc2V0KTsKLSAgICAgICAgQVNTRVJUKHN0cnVj dHVyZS0+aXNWYWxpZE9mZnNldChvZmZzZXQpKTsKKyAgICAgICAgQVNTRVJUKHRoaXMtPnN0cnVj dHVyZSgpLT5pc1ZhbGlkT2Zmc2V0KG9mZnNldCkpOwogICAgICAgICBwdXREaXJlY3Qodm0sIG9m ZnNldCwgdmFsdWUpOwogICAgICAgICAvLyBTZWUgY29tbWVudCBvbiBzZXROZXdQcm9wZXJ0eSBj YWxsIGJlbG93LgogICAgICAgICBpZiAoIXNwZWNpZmljRnVuY3Rpb24pCiAgICAgICAgICAgICBz bG90LnNldE5ld1Byb3BlcnR5KHRoaXMsIG9mZnNldCk7CiAgICAgICAgIGlmIChhdHRyaWJ1dGVz ICYgUmVhZE9ubHkpCi0gICAgICAgICAgICBzdHJ1Y3R1cmUtPnNldENvbnRhaW5zUmVhZE9ubHlQ cm9wZXJ0aWVzKCk7CisgICAgICAgICAgICB0aGlzLT5zdHJ1Y3R1cmUoKS0+c2V0Q29udGFpbnNS ZWFkT25seVByb3BlcnRpZXMoKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCiAgICAg UHJvcGVydHlPZmZzZXQgb2Zmc2V0OwotICAgIHNpemVfdCBjdXJyZW50Q2FwYWNpdHkgPSBzdHJ1 Y3R1cmUtPm91dE9mTGluZUNhcGFjaXR5KCk7Ci0gICAgaWYgKFN0cnVjdHVyZSogbmV3U3RydWN0 dXJlID0gU3RydWN0dXJlOjphZGRQcm9wZXJ0eVRyYW5zaXRpb25Ub0V4aXN0aW5nU3RydWN0dXJl KHN0cnVjdHVyZSwgcHJvcGVydHlOYW1lLCBhdHRyaWJ1dGVzLCBzcGVjaWZpY0Z1bmN0aW9uLCBv ZmZzZXQpKSB7CisgICAgc2l6ZV90IGN1cnJlbnRDYXBhY2l0eSA9IHRoaXMtPnN0cnVjdHVyZSgp LT5vdXRPZkxpbmVDYXBhY2l0eSgpOworICAgIGlmIChTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IFN0 cnVjdHVyZTo6YWRkUHJvcGVydHlUcmFuc2l0aW9uVG9FeGlzdGluZ1N0cnVjdHVyZSh0aGlzLT5z dHJ1Y3R1cmUoKSwgcHJvcGVydHlOYW1lLCBhdHRyaWJ1dGVzLCBzcGVjaWZpY0Z1bmN0aW9uLCBv ZmZzZXQpKSB7CiAgICAgICAgIERlZmVyR0MgZGVmZXJHQyh2bS5oZWFwKTsKICAgICAgICAgQnV0 dGVyZmx5KiBuZXdCdXR0ZXJmbHkgPSBidXR0ZXJmbHkoKTsKLSAgICAgICAgaWYgKGN1cnJlbnRD YXBhY2l0eSAhPSBuZXdTdHJ1Y3R1cmUtPm91dE9mTGluZUNhcGFjaXR5KCkpIHsKLSAgICAgICAg ICAgIEFTU0VSVChuZXdTdHJ1Y3R1cmUgIT0gc3RydWN0dXJlKTsKLSAgICAgICAgICAgIG5ld0J1 dHRlcmZseSA9IGdyb3dPdXRPZkxpbmVTdG9yYWdlKHZtLCBjdXJyZW50Q2FwYWNpdHksIG5ld1N0 cnVjdHVyZS0+b3V0T2ZMaW5lQ2FwYWNpdHkoKSk7CisgICAgICAgIGlmIChjdXJyZW50Q2FwYWNp dHkgIT0gc3RydWN0dXJlLT5vdXRPZkxpbmVDYXBhY2l0eSgpKSB7CisgICAgICAgICAgICBBU1NF UlQoc3RydWN0dXJlICE9IHRoaXMtPnN0cnVjdHVyZSgpKTsKKyAgICAgICAgICAgIG5ld0J1dHRl cmZseSA9IGdyb3dPdXRPZkxpbmVTdG9yYWdlKHZtLCBjdXJyZW50Q2FwYWNpdHksIHN0cnVjdHVy ZS0+b3V0T2ZMaW5lQ2FwYWNpdHkoKSk7CiAgICAgICAgIH0KIAogICAgICAgICB2YWxpZGF0ZU9m ZnNldChvZmZzZXQpOwotICAgICAgICBBU1NFUlQobmV3U3RydWN0dXJlLT5pc1ZhbGlkT2Zmc2V0 KG9mZnNldCkpOwotICAgICAgICBzZXRTdHJ1Y3R1cmVBbmRCdXR0ZXJmbHkodm0sIG5ld1N0cnVj dHVyZSwgbmV3QnV0dGVyZmx5KTsKKyAgICAgICAgQVNTRVJUKHN0cnVjdHVyZS0+aXNWYWxpZE9m ZnNldChvZmZzZXQpKTsKKyAgICAgICAgc2V0U3RydWN0dXJlQW5kQnV0dGVyZmx5KHZtLCBzdHJ1 Y3R1cmUsIG5ld0J1dHRlcmZseSk7CiAgICAgICAgIHB1dERpcmVjdCh2bSwgb2Zmc2V0LCB2YWx1 ZSk7CiAgICAgICAgIC8vIFRoaXMgaXMgYSBuZXcgcHJvcGVydHk7IHRyYW5zaXRpb25zIHdpdGgg c3BlY2lmaWMgdmFsdWVzIGFyZSBub3QgY3VycmVudGx5IGNhY2hhYmxlLAogICAgICAgICAvLyBz byBsZWF2ZSB0aGUgc2xvdCBpbiBhbiB1bmNhY2hhYmxlIHN0YXRlLgo=