130884 2014-03-27 19:50:50 -0700 [iOS][WK2] Adjust the tile coverage on the scrollview's edges 2014-03-27 20:51:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 995215 0 benjamin 2014-03-27 19:50:50 -0700 [iOS][WK2] Adjust the tile coverage on the scrollview's edges 995216 1 228020 benjamin 2014-03-27 19:53:12 -0700 Created attachment 228020 Patch 995218 2 228020 mitz 2014-03-27 20:06:25 -0700 Comment on attachment 228020 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228020&action=review > Source/WebCore/platform/ios/ScrollViewIOS.mm:168 > + IntSize contentSize = contentsSize(); > + if (futureRect.maxX() > contentSize.width()) > + futureRect.setX(contentSize.width() - futureRect.width()); > + if (futureRect.maxY() > contentSize.height()) > + futureRect.setY(contentSize.height() - futureRect.height()); > + if (futureRect.x() < 0) > + futureRect.setX(0); > + if (futureRect.y() < 0) > + futureRect.setY(0); > + Can’t this be written more concisely as intersecting futureRect with the rect { FloatPoint(), contentSize() }? 995223 3 228020 benjamin 2014-03-27 20:51:10 -0700 Comment on attachment 228020 Patch Clearing flags on attachment: 228020 Committed r166394: <http://trac.webkit.org/changeset/166394> 995224 4 benjamin 2014-03-27 20:51:11 -0700 All reviewed patches have been landed. Closing bug. 228020 2014-03-27 19:53:12 -0700 2014-03-27 20:51:09 -0700 Patch bug-130884-20140327195251.patch text/plain 2832 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkwNDk4OGEwYTdmYTM0 ZTkyMGIzODIxZmU5M2NhNjEwNjA2NGI1MS4uNzA4NDQyODc3NWEyNWE4MTU1NTYwYWRkNDIwZDMx MjYyOTE4NGQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTI3ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g QWRqdXN0IHRoZSB0aWxlIGNvdmVyYWdlIG9uIHRoZSBzY3JvbGx2aWV3J3MgZWRnZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg4NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW9z L1Njcm9sbFZpZXdJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojpjb21wdXRl Q292ZXJhZ2VSZWN0KToKKyAgICAgICAgUHVsbCBiYWNrIHRoZSBmdXR1cmUgcmVjdCBpbnNpZGUg dGhlIGNvbnRlbnRSZWN0IGlmIGl0IGdvZXMgb3V0c2lkZS4KKyAgICAgICAgVGhlcmUgaXMgbm8g cG9pbnQgaW4gcmV0aWxpbmcgZm9yIHJ1YmJlcmJhbmRpbmcgYW5kIHRoZSBleHRyYSB0aWxlcyBz aG91bGQgYmUgYWx3YXlzIGJlCisgICAgICAgIG9uIHRoZSBvcHBvc2l0ZSBzaWRlIHRvIHRoZSBl ZGdlcy4KKwogMjAxNC0wMy0yNyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE2NjM2NC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9TY3JvbGxWaWV3SU9TLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW9zL1Njcm9sbFZpZXdJT1MubW0KaW5kZXggMjFhMzJiY2EzOTkz ZmMzZWNlNGFkMzEwZmNjOTYwZWIyZjU5OWNhZS4uYTIzNWNkMTMzNGIwYWNjOThhZWFmOTVjZDFk ZWI5NGEwYzYzMmE3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1Nj cm9sbFZpZXdJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1Njcm9sbFZp ZXdJT1MubW0KQEAgLTE0MCwyMiArMTQwLDMyIEBAIEZsb2F0UmVjdCBTY3JvbGxWaWV3Ojpjb21w dXRlQ292ZXJhZ2VSZWN0KGRvdWJsZSBob3Jpem9udGFsTWFyZ2luLCBkb3VibGUgdmVydGljCiAg ICAgaWYgKG1faG9yaXpvbnRhbFZlbG9jaXR5KSB7CiAgICAgICAgIGZ1dHVyZVJlY3Quc2V0V2lk dGgoZnV0dXJlUmVjdC53aWR0aCgpICsgaG9yaXpvbnRhbE1hcmdpbik7CiAgICAgICAgIGlmICht X2hvcml6b250YWxWZWxvY2l0eSA8IDApCi0gICAgICAgICAgICBmdXR1cmVSZWN0LnNldFgoc3Rk OjptYXgoZnV0dXJlUmVjdC54KCkgLSBob3Jpem9udGFsTWFyZ2luLCAwLikpOworICAgICAgICAg ICAgZnV0dXJlUmVjdC5zZXRYKGZ1dHVyZVJlY3QueCgpIC0gaG9yaXpvbnRhbE1hcmdpbik7CiAg ICAgfQogCiAgICAgaWYgKG1fdmVydGljYWxWZWxvY2l0eSkgewogICAgICAgICBmdXR1cmVSZWN0 LnNldEhlaWdodChmdXR1cmVSZWN0LmhlaWdodCgpICsgdmVydGljYWxNYXJnaW4pOwogICAgICAg ICBpZiAobV92ZXJ0aWNhbFZlbG9jaXR5IDwgMCkKLSAgICAgICAgICAgIGZ1dHVyZVJlY3Quc2V0 WShzdGQ6Om1heChmdXR1cmVSZWN0LnkoKSAtIHZlcnRpY2FsTWFyZ2luLCAwLikpOworICAgICAg ICAgICAgZnV0dXJlUmVjdC5zZXRZKGZ1dHVyZVJlY3QueSgpIC0gdmVydGljYWxNYXJnaW4pOwog ICAgIH0KIAogICAgIGlmIChtX3NjYWxlQ2hhbmdlUmF0ZSA8PSAwICYmICFtX2hvcml6b250YWxW ZWxvY2l0eSAmJiAhbV92ZXJ0aWNhbFZlbG9jaXR5KSB7CiAgICAgICAgIGZ1dHVyZVJlY3Quc2V0 V2lkdGgoZnV0dXJlUmVjdC53aWR0aCgpICsgaG9yaXpvbnRhbE1hcmdpbik7CiAgICAgICAgIGZ1 dHVyZVJlY3Quc2V0SGVpZ2h0KGZ1dHVyZVJlY3QuaGVpZ2h0KCkgKyB2ZXJ0aWNhbE1hcmdpbik7 Ci0gICAgICAgIGZ1dHVyZVJlY3Quc2V0WChzdGQ6Om1heChmdXR1cmVSZWN0LngoKSAtIGhvcml6 b250YWxNYXJnaW4gLyAyLCAwLikpOwotICAgICAgICBmdXR1cmVSZWN0LnNldFkoc3RkOjptYXgo ZnV0dXJlUmVjdC55KCkgLSB2ZXJ0aWNhbE1hcmdpbiAvIDIsIDAuKSk7CisgICAgICAgIGZ1dHVy ZVJlY3Quc2V0WChmdXR1cmVSZWN0LngoKSAtIGhvcml6b250YWxNYXJnaW4gLyAyKTsKKyAgICAg ICAgZnV0dXJlUmVjdC5zZXRZKGZ1dHVyZVJlY3QueSgpIC0gdmVydGljYWxNYXJnaW4gLyAyKTsK ICAgICB9CiAKKyAgICBJbnRTaXplIGNvbnRlbnRTaXplID0gY29udGVudHNTaXplKCk7CisgICAg aWYgKGZ1dHVyZVJlY3QubWF4WCgpID4gY29udGVudFNpemUud2lkdGgoKSkKKyAgICAgICAgZnV0 dXJlUmVjdC5zZXRYKGNvbnRlbnRTaXplLndpZHRoKCkgLSBmdXR1cmVSZWN0LndpZHRoKCkpOwor ICAgIGlmIChmdXR1cmVSZWN0Lm1heFkoKSA+IGNvbnRlbnRTaXplLmhlaWdodCgpKQorICAgICAg ICBmdXR1cmVSZWN0LnNldFkoY29udGVudFNpemUuaGVpZ2h0KCkgLSBmdXR1cmVSZWN0LmhlaWdo dCgpKTsKKyAgICBpZiAoZnV0dXJlUmVjdC54KCkgPCAwKQorICAgICAgICBmdXR1cmVSZWN0LnNl dFgoMCk7CisgICAgaWYgKGZ1dHVyZVJlY3QueSgpIDwgMCkKKyAgICAgICAgZnV0dXJlUmVjdC5z ZXRZKDApOworCiAgICAgcmV0dXJuIGZ1dHVyZVJlY3Q7CiB9CiAK