13088 2007-03-15 13:49:19 -0700 REGRESSION(r19761-19779): Copy image no longer includes image address 2007-03-16 00:05:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac (Intel) OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 denis bdakin bdakin dev+webkit oldest_to_newest 18344 0 denis 2007-03-15 13:49:19 -0700 When I copy an image to the clipboard with webkit the image is there but not the URL. When I do the same in Safari there is the image AND the URL. This is a REGRESSION! 18347 1 dev+webkit 2007-03-15 14:26:34 -0700 1. Load http://webkit.org/images/icon-gold.png 2. In ToT, right click and choose "Copy Image" 3. Open a new tab/window and paste into the address bar - nothing 4. Repeat in Safari 2.0.4 - the image address is pasted fine. Viewing the clipboard with Clipboard Viewer (in the Developer Tools) shows a bunch of differences between what's copied from ToT and Safari 2.0.4. Both have identical contents for NeXT TIFF v4.0 pasteboard type. ToT includes a NeXT RTFD pasteboard type that shipping Safari does not. For everything else (WebURLsWithTitlesPboardType, Apple URL pasteboard type, 'url', 'urln', NSStringPboardType, NeXT plain ascii pasteboard type, Apple PICT pasteboard type), ToT has nothing while shipping Safari fills all those in. 18351 2 denis 2007-03-15 19:08:54 -0700 in Webkit r19761 it works like in Safari but in Webkit r19779 it does not. 18354 3 dev+webkit 2007-03-15 19:18:48 -0700 Thanks for regressing that Denis! http://trac.webkit.org/projects/webkit/changeset/19764 looks to me to be the culprit. 18363 4 mrowe 2007-03-15 22:21:34 -0700 <rdar://problem/5067927> 18364 5 13655 bdakin 2007-03-15 23:27:28 -0700 Created attachment 13655 Declare types only once 18365 6 13656 bdakin 2007-03-15 23:46:34 -0700 Created attachment 13656 Actually this one is better 18366 7 13656 bdakin 2007-03-15 23:51:36 -0700 Comment on attachment 13656 Actually this one is better Geoff reviewed this. 18368 8 bdakin 2007-03-16 00:05:16 -0700 Fixed in r20233. 13655 2007-03-15 23:27:28 -0700 2007-03-15 23:46:34 -0700 Declare types only once copyImageURL.txt text/plain 1151 bdakin SW5kZXg6IHBsYXRmb3JtL21hYy9QYXN0ZWJvYXJkTWFjLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRm b3JtL21hYy9QYXN0ZWJvYXJkTWFjLm1tCShyZXZpc2lvbiAyMDIyNykKKysrIHBsYXRmb3JtL21h Yy9QYXN0ZWJvYXJkTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yODYsOCArMjg2LDYgQEAKICAg ICBGcmFtZSogZnJhbWUgPSBub2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpOwogCiAgICAgd3JpdGVV UkwoVVJMLCB0aXRsZSwgZnJhbWUsIHRydWUpOwotICAgIE5TQXJyYXkgKnR5cGVzID0gW21fcGFz dGVib2FyZCB0eXBlc107Ci0gICAgW21fcGFzdGVib2FyZCBkZWNsYXJlVHlwZXM6dHlwZXMgb3du ZXI6bmlsXTsKIAogICAgIEltYWdlKiBjb3JlSW1hZ2UgPSByZXN1bHQuaW1hZ2UoKTsKICAgICBB U1NFUlQoY29yZUltYWdlKTsKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VM b2cJKHJldmlzaW9uIDIwMjMxKQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMDctMDMtMTUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwODggUkVHUkVTU0lPTgorICAg ICAgICAocjE5NzYxLTE5Nzc5KTogQ29weSBpbWFnZSBubyBsb25nZXIgaW5jbHVkZXMgaW1hZ2Ug YWRkcmVzcyAKKyAgICAgICAgKHJkYXI6Ly81MDY3OTI3KQorCisgICAgICAgICogcGxhdGZvcm0v bWFjL1Bhc3RlYm9hcmRNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjp3cml0 ZUltYWdlKTogQ2FsbGluZyB3cml0ZVVSTCgpIHRha2VzIGNhcmUgb2YgCisgICAgICAgIGRlY2xh cmluZyB0aGUgdHlwZXMuIERvaW5nIGl0IHR3aWNlIGJyZWFrcyB0aGluZ3MuCisKIDIwMDctMDMt MTUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9saXZlcgo= 13656 2007-03-15 23:46:34 -0700 2007-03-15 23:51:36 -0700 Actually this one is better copyImageURL.txt text/plain 3965 bdakin SW5kZXg6IHBsYXRmb3JtL1Bhc3RlYm9hcmQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9QYXN0 ZWJvYXJkLmgJKHJldmlzaW9uIDIwMjI3KQorKysgcGxhdGZvcm0vUGFzdGVib2FyZC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC02OCwxMiArNjgsMTIgQEAKICNpZiBQTEFURk9STShNQUMpCiAgICAgLy9I ZWxwZXIgZnVuY3Rpb25zIHRvIGFsbG93IENsaXBib2FyZCB0byBzaGFyZSBjb2RlCiAgICAgc3Rh dGljIHZvaWQgd3JpdGVTZWxlY3Rpb24oTlNQYXN0ZWJvYXJkKiBwYXN0ZWJvYXJkLCBSYW5nZSog c2VsZWN0ZWRSYW5nZSwgYm9vbCBjYW5TbWFydENvcHlPckRlbGV0ZSwgRnJhbWUqIGZyYW1lKTsK LSAgICBzdGF0aWMgdm9pZCB3cml0ZVVSTChOU1Bhc3RlYm9hcmQqIHBhc3RlYm9hcmQsIE5TQXJy YXkqIHR5cGVzLCBjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGVTdHIsIEZyYW1l KiBmcmFtZSwgYm9vbCBpc0ltYWdlID0gZmFsc2UpOworICAgIHN0YXRpYyB2b2lkIHdyaXRlVVJM KE5TUGFzdGVib2FyZCogcGFzdGVib2FyZCwgTlNBcnJheSogdHlwZXMsIGNvbnN0IEtVUkwmIHVy bCwgY29uc3QgU3RyaW5nJiB0aXRsZVN0ciwgRnJhbWUqIGZyYW1lKTsKICNlbmRpZgogICAgIAog ICAgIHN0YXRpYyBQYXN0ZWJvYXJkKiBnZW5lcmFsUGFzdGVib2FyZCgpOwogICAgIHZvaWQgd3Jp dGVTZWxlY3Rpb24oUmFuZ2UqLCBib29sIGNhblNtYXJ0Q29weU9yRGVsZXRlLCBGcmFtZSopOwot ICAgIHZvaWQgd3JpdGVVUkwoY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYsIEZyYW1lKiA9IDAs IGJvb2wgaXNJbWFnZSA9IGZhbHNlKTsKKyAgICB2b2lkIHdyaXRlVVJMKGNvbnN0IEtVUkwmLCBj b25zdCBTdHJpbmcmLCBGcmFtZSogPSAwKTsKICAgICB2b2lkIHdyaXRlSW1hZ2UoY29uc3QgSGl0 VGVzdFJlc3VsdCYpOwogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2b2lkIHdyaXRlRmlsZVdyYXBw ZXJBc1JURkRBdHRhY2htZW50KE5TRmlsZVdyYXBwZXIqKTsKSW5kZXg6IHBsYXRmb3JtL21hYy9Q YXN0ZWJvYXJkTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL21hYy9QYXN0ZWJvYXJkTWFj Lm1tCShyZXZpc2lvbiAyMDIyNykKKysrIHBsYXRmb3JtL21hYy9QYXN0ZWJvYXJkTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0yMDAsMTYgKzIwMCwxMyBAQAogICAgIFBhc3RlYm9hcmQ6OndyaXRl U2VsZWN0aW9uKG1fcGFzdGVib2FyZCwgc2VsZWN0ZWRSYW5nZSwgY2FuU21hcnRDb3B5T3JEZWxl dGUsIGZyYW1lKTsKIH0KIAotdm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVVSTChOU1Bhc3RlYm9hcmQq IHBhc3RlYm9hcmQsIE5TQXJyYXkqIHR5cGVzLCBjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmlu ZyYgdGl0bGVTdHIsIEZyYW1lKiBmcmFtZSwgYm9vbCBpc0ltYWdlKQordm9pZCBQYXN0ZWJvYXJk Ojp3cml0ZVVSTChOU1Bhc3RlYm9hcmQqIHBhc3RlYm9hcmQsIE5TQXJyYXkqIHR5cGVzLCBjb25z dCBLVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGVTdHIsIEZyYW1lKiBmcmFtZSkKIHsKICAg ICBpZiAoV2ViQXJjaGl2ZVBib2FyZFR5cGUgPT0gbmlsKQogICAgICAgICBQYXN0ZWJvYXJkOjpn ZW5lcmFsUGFzdGVib2FyZCgpOyAvL0luaXRpYWxpc2VzIHBhc3RlYm9hcmQgdHlwZXMKICAgIAog ICAgIGlmICh0eXBlcyA9PSBuaWwpIHsKLSAgICAgICAgaWYgKGlzSW1hZ2UpCi0gICAgICAgICAg ICB0eXBlcyA9IHdyaXRhYmxlVHlwZXNGb3JJbWFnZSgpOwotICAgICAgICBlbHNlCi0gICAgICAg ICAgICB0eXBlcyA9IHdyaXRhYmxlVHlwZXNGb3JVUkwoKTsKKyAgICAgICAgdHlwZXMgPSB3cml0 YWJsZVR5cGVzRm9yVVJMKCk7CiAgICAgICAgIFtwYXN0ZWJvYXJkIGRlY2xhcmVUeXBlczp0eXBl cyBvd25lcjpuaWxdOwogICAgIH0KICAgICAKQEAgLTI0MCw5ICsyMzcsOSBAQAogICAgICAgICBb cGFzdGVib2FyZCBzZXRTdHJpbmc6dXNlclZpc2libGVTdHJpbmcgZm9yVHlwZTpOU1N0cmluZ1Bi b2FyZFR5cGVdOwogfQogICAgIAotdm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVVSTChjb25zdCBLVVJM JiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGVTdHIsIEZyYW1lKiBmcmFtZSwgYm9vbCBpc0ltYWdl KQordm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVVSTChjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmlu ZyYgdGl0bGVTdHIsIEZyYW1lKiBmcmFtZSkKIHsKLSAgICBQYXN0ZWJvYXJkOjp3cml0ZVVSTCht X3Bhc3RlYm9hcmQsIG5pbCwgdXJsLCB0aXRsZVN0ciwgZnJhbWUsIGlzSW1hZ2UpOworICAgIFBh c3RlYm9hcmQ6OndyaXRlVVJMKG1fcGFzdGVib2FyZCwgbmlsLCB1cmwsIHRpdGxlU3RyLCBmcmFt ZSk7CiB9CiAKIHN0YXRpYyBOU0ZpbGVXcmFwcGVyKiBmaWxlV3JhcHBlckZvckltYWdlKENhY2hl ZFJlc291cmNlKiByZXNvdXJjZSwgTlNVUkwgKlVSTCkKQEAgLTI4NSw5ICsyODIsOSBAQAogICAg IE5TU3RyaW5nICp0aXRsZSA9IHJlc3VsdC5hbHREaXNwbGF5U3RyaW5nKCkuaXNOdWxsKCkgPyBu aWwgOiAoTlNTdHJpbmcqKShyZXN1bHQuYWx0RGlzcGxheVN0cmluZygpKTsKICAgICBGcmFtZSog ZnJhbWUgPSBub2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpOwogCi0gICAgd3JpdGVVUkwoVVJMLCB0 aXRsZSwgZnJhbWUsIHRydWUpOwotICAgIE5TQXJyYXkgKnR5cGVzID0gW21fcGFzdGVib2FyZCB0 eXBlc107CisgICAgTlNBcnJheSogdHlwZXMgPSB3cml0YWJsZVR5cGVzRm9ySW1hZ2UoKTsKICAg ICBbbV9wYXN0ZWJvYXJkIGRlY2xhcmVUeXBlczp0eXBlcyBvd25lcjpuaWxdOworICAgIHdyaXRl VVJMKG1fcGFzdGVib2FyZCwgdHlwZXMsIFVSTCwgdGl0bGUsIGZyYW1lKTsKIAogICAgIEltYWdl KiBjb3JlSW1hZ2UgPSByZXN1bHQuaW1hZ2UoKTsKICAgICBBU1NFUlQoY29yZUltYWdlKTsKSW5k ZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMjMyKQor KysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDctMDMtMTUg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTMwODggUkVHUkVTU0lPTgorICAgICAgICAocjE5NzYxLTE5Nzc5KTog Q29weSBpbWFnZSBubyBsb25nZXIgaW5jbHVkZXMgaW1hZ2UgYWRkcmVzcyAKKyAgICAgICAgKHJk YXI6Ly81MDY3OTI3KQorCisgICAgICAgIHdyaXRlVVJMKCkgZG9lcyBub3QgbmVlZCBhbiBpc0lt YWdlIHBhcmFtZXRlci4gTm93IHRoYXQgaXQgYWNjZXB0cyAKKyAgICAgICAgdGhlIHR5cGVzIGFz IGEgcGFyYW1ldGVyLCB3ZSBjYW4ganVzdCBkZWNsYXJlIHRoZSBhcHByb3ByaWF0ZSBpbWFnZSAK KyAgICAgICAgdHlwZXMgd2l0aGluIHdyaXRlSW1hZ2UgYW5kIHNlbmQgdGhlbSB0byB3cml0ZVVS TCgpLiBBbHNvLCAKKyAgICAgICAgZGVjbGFyaW5nIHRoZSB0eXBlcyB0d2ljZSBpcyB3aGF0IGJy b2tlIHRoaXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9QYXN0ZWJvYXJkLmg6CisgICAgICAgICog cGxhdGZvcm0vbWFjL1Bhc3RlYm9hcmRNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJv YXJkOjp3cml0ZVVSTCk6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjp3cml0ZUltYWdl KToKKwogMjAwNy0wMy0xNSAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2V2aW4gRGVja2VyLgo=