130874 2014-03-27 16:37:16 -0700 A TrailingObject's endpoint might get decremented twice 2014-03-28 10:33:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino esprehn+autocc glenn hyatt jonlee kondapallykalyan simon.fraser thorton webkit-bug-importer oldest_to_newest 995142 0 mmaxfield 2014-03-27 16:37:16 -0700 A TrailingObject's endpoint might get decremented twice 995145 1 228006 mmaxfield 2014-03-27 16:40:31 -0700 Created attachment 228006 Patch 995146 2 228006 mmaxfield 2014-03-27 16:41:31 -0700 Comment on attachment 228006 Patch This is probably the worse ChangeLog that I have ever written. 995153 3 228007 mmaxfield 2014-03-27 16:49:42 -0700 Created attachment 228007 Patch 995158 4 228007 thorton 2014-03-27 16:54:53 -0700 Comment on attachment 228007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:9 > + 1. When we have both an ending position and it's accompanying starting its :| 995159 5 228007 mmaxfield 2014-03-27 16:55:37 -0700 Comment on attachment 228007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:8 > + There are two places where we decrement a TrailingObject's ending position. There are more than two, but these are the two that I am interested in. 995166 6 mmaxfield 2014-03-27 17:07:28 -0700 <rdar://problem/16432098> 995270 7 228007 darin 2014-03-28 01:05:32 -0700 Comment on attachment 228007 Patch Code change looks fine. Not sure what the point is of writing such a long change log. If this is really hard to understand, then I think we would need a comment instead of a change log entry. Next time you find you are writing a log this long, I suggest talking to another WebKit contributor in person. Together you can probably come up with a shorter explanation. I find that the process of talking through it out loud helps. 995378 8 mmaxfield 2014-03-28 10:33:01 -0700 http://trac.webkit.org/changeset/166412 228006 2014-03-27 16:40:31 -0700 2014-03-27 16:49:40 -0700 Patch bug-130874-20140327164010.patch text/plain 3088 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAwNzcxMTA3NTNhMmI0 ODkyNjQ3OGQwYzdlNjczMjI1MDllNzE3Mi4uNjI0ZTA3NDViNDFiYWQ2ZDI3ODM5MDUzYjU1ZTA3 YjgyY2EzYzRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQSBUcmFpbGlu Z09iamVjdCdzIGVuZHBvaW50IG1pZ2h0IGdldCBkZWNyZW1lbnRlZCB0d2ljZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwODc0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgZmFzdC9ibG9jay91 cGRhdGUtbWlkcG9pbnRzLWZvci10cmFpbGluZy1ib3hlcy1jcmFzaC5odG1sLgorCisgICAgICAg ICogcmVuZGVyaW5nL2xpbmUvQnJlYWtpbmdDb250ZXh0SW5saW5lSGVhZGVycy5oOgorICAgICAg ICAoV2ViQ29yZTo6Y2hlY2tNaWRwb2ludHMpOgorICAgICAgICAoV2ViQ29yZTo6QnJlYWtpbmdD b250ZXh0OjpoYW5kbGVFbmRPZkxpbmUpOgorCiAyMDE0LTAzLTI3ICBBZGVuaWxzb24gQ2F2YWxj YW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KIAogICAgICAgICBSZW1vdmUgY29tbWVudCBm cm9tIEZpbHRlci5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9C cmVha2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv bGluZS9CcmVha2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmgKaW5kZXggMjVhY2IyOGYyYjAwZjJh YmEyZWQzOTUxZTIxMGFjOWFkNzViMDZjYi4uODNhYzdhMDIzMDIyMjYxZWRhNmY0ZTIxNzQ3ZjVj N2NiMDUyZTZlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL2xpbmUvQnJl YWtpbmdDb250ZXh0SW5saW5lSGVhZGVycy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9saW5lL0JyZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaApAQCAtMTAwMSw3ICsxMDAxLDcg QEAgaW5saW5lIHZvaWQgQnJlYWtpbmdDb250ZXh0Ojpjb21taXRBbmRVcGRhdGVMaW5lQnJlYWtJ Zk5lZWRlZCgpCiAgICAgfQogfQogCi1pbmxpbmUgdm9pZCBjaGVja01pZHBvaW50cyhMaW5lTWlk cG9pbnRTdGF0ZSYgbGluZU1pZHBvaW50U3RhdGUsIElubGluZUl0ZXJhdG9yJiBsQnJlYWspCitp bmxpbmUgVHJhaWxpbmdPYmplY3RzOjpDb2xsYXBzZUZpcnN0U3BhY2VPck5vdCBjaGVja01pZHBv aW50cyhMaW5lTWlkcG9pbnRTdGF0ZSYgbGluZU1pZHBvaW50U3RhdGUsIElubGluZUl0ZXJhdG9y JiBsQnJlYWspCiB7CiAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIG91ciBsYXN0IG1pZHBvaW50IGlz IGEgc3RhcnQgcG9pbnQgYmV5b25kIHRoZSBsaW5lIGJyZWFrLiBJZiBzbywKICAgICAvLyBzaGF2 ZSBpdCBvZmYgdGhlIGxpc3QsIGFuZCBzaGF2ZSBvZmYgYSB0cmFpbGluZyBzcGFjZSBpZiB0aGUg cHJldmlvdXMgZW5kIHBvaW50IGRvZXNuJ3QKQEAgLTEwMTYsMTAgKzEwMTYsMTMgQEAgaW5saW5l IHZvaWQgY2hlY2tNaWRwb2ludHMoTGluZU1pZHBvaW50U3RhdGUmIGxpbmVNaWRwb2ludFN0YXRl LCBJbmxpbmVJdGVyYXRvciYKICAgICAgICAgaWYgKGN1cnJwb2ludCA9PSBsQnJlYWspIHsKICAg ICAgICAgICAgIC8vIFdlIGhpdCB0aGUgbGluZSBicmVhayBiZWZvcmUgdGhlIHN0YXJ0IHBvaW50 LiBTaGF2ZSBvZmYgdGhlIHN0YXJ0IHBvaW50LgogICAgICAgICAgICAgbGluZU1pZHBvaW50U3Rh dGUuZGVjcmVhc2VOdW1NaWRwb2ludHMoKTsKLSAgICAgICAgICAgIGlmIChlbmRwb2ludC5yZW5k ZXJlcigpLT5zdHlsZSgpLmNvbGxhcHNlV2hpdGVTcGFjZSgpICYmIGVuZHBvaW50LnJlbmRlcmVy KCktPmlzVGV4dCgpKQorICAgICAgICAgICAgaWYgKGVuZHBvaW50LnJlbmRlcmVyKCktPnN0eWxl KCkuY29sbGFwc2VXaGl0ZVNwYWNlKCkgJiYgZW5kcG9pbnQucmVuZGVyZXIoKS0+aXNUZXh0KCkp IHsKICAgICAgICAgICAgICAgICBlbmRwb2ludC5mYXN0RGVjcmVtZW50KCk7CisgICAgICAgICAg ICAgICAgcmV0dXJuIFRyYWlsaW5nT2JqZWN0czo6RG9Ob3RDb2xsYXBzZUZpcnN0U3BhY2U7Cisg ICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CisgICAgcmV0dXJuIFRyYWlsaW5nT2JqZWN0 czo6Q29sbGFwc2VGaXJzdFNwYWNlOwogfQogCiBpbmxpbmUgSW5saW5lSXRlcmF0b3IgQnJlYWtp bmdDb250ZXh0OjpoYW5kbGVFbmRPZkxpbmUoKQpAQCAtMTA0OCw5ICsxMDUxLDkgQEAgaW5saW5l IElubGluZUl0ZXJhdG9yIEJyZWFraW5nQ29udGV4dDo6aGFuZGxlRW5kT2ZMaW5lKCkKICAgICB9 CiAKICAgICAvLyBTYW5pdHkgY2hlY2sgb3VyIG1pZHBvaW50cy4KLSAgICBjaGVja01pZHBvaW50 cyhtX2xpbmVNaWRwb2ludFN0YXRlLCBtX2xpbmVCcmVhayk7CisgICAgVHJhaWxpbmdPYmplY3Rz OjpDb2xsYXBzZUZpcnN0U3BhY2VPck5vdCBjb2xsYXBzZWQgPSBjaGVja01pZHBvaW50cyhtX2xp bmVNaWRwb2ludFN0YXRlLCBtX2xpbmVCcmVhayk7CiAKLSAgICBtX3RyYWlsaW5nT2JqZWN0cy51 cGRhdGVNaWRwb2ludHNGb3JUcmFpbGluZ0JveGVzKG1fbGluZU1pZHBvaW50U3RhdGUsIG1fbGlu ZUJyZWFrLCBUcmFpbGluZ09iamVjdHM6OkNvbGxhcHNlRmlyc3RTcGFjZSk7CisgICAgbV90cmFp bGluZ09iamVjdHMudXBkYXRlTWlkcG9pbnRzRm9yVHJhaWxpbmdCb3hlcyhtX2xpbmVNaWRwb2lu dFN0YXRlLCBtX2xpbmVCcmVhaywgY29sbGFwc2VkKTsKIAogICAgIC8vIFdlIG1pZ2h0IGhhdmUg bWFkZSBsaW5lQnJlYWsgYW4gaXRlcmF0b3IgdGhhdCBwb2ludHMgcGFzdCB0aGUgZW5kCiAgICAg Ly8gb2YgdGhlIG9iamVjdC4gRG8gdGhpcyBhZGp1c3RtZW50IHRvIG1ha2UgaXQgcG9pbnQgdG8g dGhlIHN0YXJ0Cg== 228007 2014-03-27 16:49:42 -0700 2014-03-28 01:05:31 -0700 Patch bug-130874-20140327164921.patch text/plain 4113 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAwNzcxMTA3NTNhMmI0 ODkyNjQ3OGQwYzdlNjczMjI1MDllNzE3Mi4uZWFhZDU0OTZhYmUxZGIwNDM1NmQyYjg5Yjg2NDA2 NjIwODU2MTQyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTAzLTI3ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQSBUcmFpbGlu Z09iamVjdCdzIGVuZHBvaW50IG1pZ2h0IGdldCBkZWNyZW1lbnRlZCB0d2ljZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwODc0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHR3byBwbGFj ZXMgd2hlcmUgd2UgZGVjcmVtZW50IGEgVHJhaWxpbmdPYmplY3QncyBlbmRpbmcgcG9zaXRpb24u CisgICAgICAgIDEuIFdoZW4gd2UgaGF2ZSBib3RoIGFuIGVuZGluZyBwb3NpdGlvbiBhbmQgaXQn cyBhY2NvbXBhbnlpbmcgc3RhcnRpbmcKKyAgICAgICAgcG9zaXRpb24sIGJ1dCB0aGUgbGluZSBi cmVhayBpcyBiZXR3ZWVuIHRoZSB0d28uIEluIHRoaXMgY2FzZSwgd2UgZGVzdHJveQorICAgICAg ICB0aGUgc3RhcnRpbmcgcG9zaXRpb24gKGJlY2F1c2UgaXQgY29tZXMgYWZ0ZXIgdGhlIGxpbmUg YnJlYWspIGFuZCBkZWNyZW1lbnQKKyAgICAgICAgdGhlIGVuZGluZyBwb3NpdGlvbiAoc28gYXMg dG8gbm90IGhhdmUgYSB0cmFpbGluZyBzcGFjZSBhdCB0aGUgZW5kIG9mIGEgbGluZSkuCisgICAg ICAgIDIuIEFmdGVyd2FyZHMsIHdoZW4gd2UgaGF2ZSBhbiBlbmRpbmcgcG9zaXRpb24gYW5kIG5v IGFjY29tcGFueWluZyBzdGFydGluZworICAgICAgICBwb3NpdGlvbi4gSW4gdGhpcyBjYXNlLCB3 ZSBrbm93IHRoYXQgdGhlIGxpbmUgYnJlYWsgY29tZXMgYWZ0ZXIgdGhlIGVuZGluZworICAgICAg ICBwb3NpdGlvbiwgYW5kIHdlIGtub3cgdGhhdCB0aGUgY2hhcmFjdGVyIHRoZSBlbmRpbmcgcG9z aXRpb24gaXMgcG9pbnRpbmcgdG8KKyAgICAgICAgaXMgd2hpdGVzcGFjZS4gVGhlcmVmb3JlLCB3 ZSBkZWNyZW1lbnQgdGhlIGVuZGluZyBwb3NpdGlvbiBmb3IgdGhlIHNhbWUKKyAgICAgICAgcmVh c29uLgorCisgICAgICAgIEl0IGlzIHBvc3NpYmxlIHRvIHRyaWdnZXIgYm90aCBvZiB0aGVzZSBj b2RlcGF0aHMgd2l0aCB0aGUgc2FtZSBsaW5lLCBjYXVzaW5nCisgICAgICAgIHVzIHRvICJzaGF2 ZSBvZmYgdGhlIHRyYWlsaW5nIHNwYWNlIiB0d2ljZS4gSW5zdGVhZCwgd2Ugc2hvdWxkIG9ubHkg dHJpZ2dlcgorICAgICAgICB0aGUgc2Vjb25kIGRlY3JlbWVudCBpZiB0aGUgZmlyc3Qgb25lIGRp ZCBub3Qgb2NjdXIuCisKKyAgICAgICAgRml4ZXMgZmFzdC9ibG9jay91cGRhdGUtbWlkcG9pbnRz LWZvci10cmFpbGluZy1ib3hlcy1jcmFzaC5odG1sIGFmdGVyIHIxNjYyNDUuCisKKyAgICAgICAg KiByZW5kZXJpbmcvbGluZS9CcmVha2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmg6CisgICAgICAg IChXZWJDb3JlOjpjaGVja01pZHBvaW50cyk6CisgICAgICAgIChXZWJDb3JlOjpCcmVha2luZ0Nv bnRleHQ6OmhhbmRsZUVuZE9mTGluZSk6CisKIDIwMTQtMDMtMjcgIEFkZW5pbHNvbiBDYXZhbGNh bnRpICA8Y2F2YWxjYW50aWlAZ21haWwuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb21tZW50IGZy b20gRmlsdGVyLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0Jy ZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9s aW5lL0JyZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaAppbmRleCAyNWFjYjI4ZjJiMDBmMmFi YTJlZDM5NTFlMjEwYWM5YWQ3NWIwNmNiLi44M2FjN2EwMjMwMjIyNjFlZGE2ZjRlMjE3NDdmNWM3 Y2IwNTJlNmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbGluZS9CcmVh a2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L2xpbmUvQnJlYWtpbmdDb250ZXh0SW5saW5lSGVhZGVycy5oCkBAIC0xMDAxLDcgKzEwMDEsNyBA QCBpbmxpbmUgdm9pZCBCcmVha2luZ0NvbnRleHQ6OmNvbW1pdEFuZFVwZGF0ZUxpbmVCcmVha0lm TmVlZGVkKCkKICAgICB9CiB9CiAKLWlubGluZSB2b2lkIGNoZWNrTWlkcG9pbnRzKExpbmVNaWRw b2ludFN0YXRlJiBsaW5lTWlkcG9pbnRTdGF0ZSwgSW5saW5lSXRlcmF0b3ImIGxCcmVhaykKK2lu bGluZSBUcmFpbGluZ09iamVjdHM6OkNvbGxhcHNlRmlyc3RTcGFjZU9yTm90IGNoZWNrTWlkcG9p bnRzKExpbmVNaWRwb2ludFN0YXRlJiBsaW5lTWlkcG9pbnRTdGF0ZSwgSW5saW5lSXRlcmF0b3Im IGxCcmVhaykKIHsKICAgICAvLyBDaGVjayB0byBzZWUgaWYgb3VyIGxhc3QgbWlkcG9pbnQgaXMg YSBzdGFydCBwb2ludCBiZXlvbmQgdGhlIGxpbmUgYnJlYWsuIElmIHNvLAogICAgIC8vIHNoYXZl IGl0IG9mZiB0aGUgbGlzdCwgYW5kIHNoYXZlIG9mZiBhIHRyYWlsaW5nIHNwYWNlIGlmIHRoZSBw cmV2aW91cyBlbmQgcG9pbnQgZG9lc24ndApAQCAtMTAxNiwxMCArMTAxNiwxMyBAQCBpbmxpbmUg dm9pZCBjaGVja01pZHBvaW50cyhMaW5lTWlkcG9pbnRTdGF0ZSYgbGluZU1pZHBvaW50U3RhdGUs IElubGluZUl0ZXJhdG9yJgogICAgICAgICBpZiAoY3VycnBvaW50ID09IGxCcmVhaykgewogICAg ICAgICAgICAgLy8gV2UgaGl0IHRoZSBsaW5lIGJyZWFrIGJlZm9yZSB0aGUgc3RhcnQgcG9pbnQu IFNoYXZlIG9mZiB0aGUgc3RhcnQgcG9pbnQuCiAgICAgICAgICAgICBsaW5lTWlkcG9pbnRTdGF0 ZS5kZWNyZWFzZU51bU1pZHBvaW50cygpOwotICAgICAgICAgICAgaWYgKGVuZHBvaW50LnJlbmRl cmVyKCktPnN0eWxlKCkuY29sbGFwc2VXaGl0ZVNwYWNlKCkgJiYgZW5kcG9pbnQucmVuZGVyZXIo KS0+aXNUZXh0KCkpCisgICAgICAgICAgICBpZiAoZW5kcG9pbnQucmVuZGVyZXIoKS0+c3R5bGUo KS5jb2xsYXBzZVdoaXRlU3BhY2UoKSAmJiBlbmRwb2ludC5yZW5kZXJlcigpLT5pc1RleHQoKSkg ewogICAgICAgICAgICAgICAgIGVuZHBvaW50LmZhc3REZWNyZW1lbnQoKTsKKyAgICAgICAgICAg ICAgICByZXR1cm4gVHJhaWxpbmdPYmplY3RzOjpEb05vdENvbGxhcHNlRmlyc3RTcGFjZTsKKyAg ICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KKyAgICByZXR1cm4gVHJhaWxpbmdPYmplY3Rz OjpDb2xsYXBzZUZpcnN0U3BhY2U7CiB9CiAKIGlubGluZSBJbmxpbmVJdGVyYXRvciBCcmVha2lu Z0NvbnRleHQ6OmhhbmRsZUVuZE9mTGluZSgpCkBAIC0xMDQ4LDkgKzEwNTEsOSBAQCBpbmxpbmUg SW5saW5lSXRlcmF0b3IgQnJlYWtpbmdDb250ZXh0OjpoYW5kbGVFbmRPZkxpbmUoKQogICAgIH0K IAogICAgIC8vIFNhbml0eSBjaGVjayBvdXIgbWlkcG9pbnRzLgotICAgIGNoZWNrTWlkcG9pbnRz KG1fbGluZU1pZHBvaW50U3RhdGUsIG1fbGluZUJyZWFrKTsKKyAgICBUcmFpbGluZ09iamVjdHM6 OkNvbGxhcHNlRmlyc3RTcGFjZU9yTm90IGNvbGxhcHNlZCA9IGNoZWNrTWlkcG9pbnRzKG1fbGlu ZU1pZHBvaW50U3RhdGUsIG1fbGluZUJyZWFrKTsKIAotICAgIG1fdHJhaWxpbmdPYmplY3RzLnVw ZGF0ZU1pZHBvaW50c0ZvclRyYWlsaW5nQm94ZXMobV9saW5lTWlkcG9pbnRTdGF0ZSwgbV9saW5l QnJlYWssIFRyYWlsaW5nT2JqZWN0czo6Q29sbGFwc2VGaXJzdFNwYWNlKTsKKyAgICBtX3RyYWls aW5nT2JqZWN0cy51cGRhdGVNaWRwb2ludHNGb3JUcmFpbGluZ0JveGVzKG1fbGluZU1pZHBvaW50 U3RhdGUsIG1fbGluZUJyZWFrLCBjb2xsYXBzZWQpOwogCiAgICAgLy8gV2UgbWlnaHQgaGF2ZSBt YWRlIGxpbmVCcmVhayBhbiBpdGVyYXRvciB0aGF0IHBvaW50cyBwYXN0IHRoZSBlbmQKICAgICAv LyBvZiB0aGUgb2JqZWN0LiBEbyB0aGlzIGFkanVzdG1lbnQgdG8gbWFrZSBpdCBwb2ludCB0byB0 aGUgc3RhcnQK