13087 2007-03-15 13:19:23 -0700 REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominoes) 2007-03-19 17:46:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.dominos.com HasReduction, InRadar, Regression P1 Normal --- 1 bdakin adele oldest_to_newest 18339 0 bdakin 2007-03-15 13:19:23 -0700 1. Go to http://www01.order.dominos.com/olo/faces/order/step2_choose_pizza.jsp 2. Enter an address. (This part is tricky, some addresses don't provide the pizza store that repros the bug. One that does is 218 Broadway, Revere, MA 02151) 2. Confirm the address and nearest store by clicking "Next" 3. Click "Choose size and crust" under "Build your own pizza" 4. At any given time, one of the radio buttons in the "Hand-tossed," "Deep-dish," "Thin," or "Brooklyn" column should be selected, but as you select them, the button never turns blue. The selection registers in that the view changes, but the button never looks pressed, and it isn't actually pressed. This bug prevents ordering a pizza since this generates an error when you try to add the pizza, saying that you have not selected a size or crust. 18340 1 bdakin 2007-03-15 13:19:46 -0700 <rdar://problem/5064316> 18341 2 bdakin 2007-03-15 13:21:36 -0700 Does this automatically cc me? I can never remember... 18352 3 ddkilzer 2007-03-15 19:13:14 -0700 (In reply to comment #2) > Does this automatically cc me? I can never remember... Yes, it should, but what email you get depends on your settings. (For example, if you don't care when people just add a Cc: address, you won't get email.) 18357 4 13654 bdakin 2007-03-15 21:56:54 -0700 Created attachment 13654 reduction: self-closing input tag Here is a reduction. Looks like we used to allow self-closing input tags but don't anymore. Firefox allows them too. 18358 5 bdakin 2007-03-15 21:57:31 -0700 Thanks, Dave! 18359 6 bdakin 2007-03-15 22:06:24 -0700 I take that back. repros without self-closing as well. 18360 7 bdakin 2007-03-15 22:09:50 -0700 It's the name attribute. Adding a name attribute makes it work. 18396 8 13654 bdakin 2007-03-16 11:08:44 -0700 Comment on attachment 13654 reduction: self-closing input tag Okay, it turns out this reduction is not valid. Our behavior here matches IE, and we made the change intentionally. There is some other JavaScript at the site that makes the radio button still click in IE. I am working on another reduction. 18142 9 13711 adele 2007-03-19 17:30:49 -0700 Created attachment 13711 patch 18144 10 adele 2007-03-19 17:40:12 -0700 We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior. 18146 11 13711 bdakin 2007-03-19 17:43:23 -0700 Comment on attachment 13711 patch yay! r=me! 18147 12 adele 2007-03-19 17:46:15 -0700 Committed revision 20333. 13654 2007-03-15 21:56:54 -0700 2007-03-16 11:08:44 -0700 reduction: self-closing input tag test.html text/html 32 bdakin PGlucHV0IHR5cGU9J3JhZGlvJy8+SGFuZC10b3NzZWQ= 13711 2007-03-19 17:30:49 -0700 2007-03-19 17:43:23 -0700 patch patch_radio_dominos.txt text/plain 8826 adele SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMzMwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMTkgIEFkZWxlIFBldGVyc29uICA8 YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMDg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDY0MzE2PiBSRUdSRVNTSU9OOiBBbGxv dyBzZXR0aW5nIHRoZSBjaGVja2VkIGF0dHJpYnV0ZSBpbiBqcyBhbmQgaW4gbWFya3VwIGZvciB1 bm5hbWVkIHJhZGlvIGJ1dHRvbnMgKGRvbWlub3MuY29tKQorCisgICAgICAgICogZmFzdC9mb3Jt cy9yYWRpb19jaGVja2VkX25hbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2Zvcm1zL3JhZGlvX2NoZWNrZWRfbmFtZS5odG1sOiBBZGRlZC4KKwogMjAwNy0wMy0xOSAgSnVz dGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IGRhcmluCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvX2NoZWNrZWRfbmFt ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYWRp b19jaGVja2VkX25hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9yYWRpb19jaGVja2VkX25hbWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDExIEBACitUaGVyZSBpcyBhIFdpbklFIHF1aXJrIHRoYXQgZG9lcyBub3QgYWxs b3cgYSB1c2VyIHRvIHNlbGVjdCByYWRpbyBidXR0b25zIHRoYXQgZG9uJ3QgaGF2ZSBuYW1lcy4g VGhpcyB0ZXN0cyB0aGF0IHdlIG9ubHkgaG9ub3IgdGhhdCBxdWlyaworaW4gcmVzcG9uc2UgdG8g bW91c2UgYW5kIGtleWJvYXJkIGV2ZW50cy4gSWYgdGhlIGNoZWNrZWQgYXR0cmlidXRlIGlzIHNl dCBvbiB0aGUgZWxlbWVudCBpbiB0aGUgbWFya3VwLCBvciBpbiBqYXZhc2NyaXB0LCB3ZSBzaG91 bGQgaWdub3JlIHRoZSBxdWlyay4KKyAgICAKK1Bhc3MKK1Bhc3MKK1Bhc3MKK1Bhc3MKK1Bhc3MK K1Bhc3MKK1Bhc3MKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYWRpb19jaGVja2Vk X25hbWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvX2No ZWNrZWRfbmFtZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9y YWRpb19jaGVja2VkX25hbWUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2MiBAQAorPGh0 bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgIGZ1bmN0aW9uIHRlc3Qo KSB7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAg ICAgICAKKyAgICAgICAgICAgIHZhciByMSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyMScp OworICAgICAgICAgICAgdmVyaWZ5Q2hlY2tlZFN0YXRlKHIxLCB0cnVlKTsKKyAgICAgICAgICAg IHIxLmNoZWNrZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIHZlcmlmeUNoZWNrZWRTdGF0ZShyMSwg ZmFsc2UpOworICAgICAgICAgICAgcjEuY2hlY2tlZCA9IHRydWU7CisgICAgICAgICAgICB2ZXJp ZnlDaGVja2VkU3RhdGUocjEsIHRydWUpOworICAgICAgICAgICAgcjEuY2hlY2tlZCA9IGZhbHNl OworICAgICAgICAgICAgdmVyaWZ5Q2hlY2tlZFN0YXRlKHIxLCBmYWxzZSk7CisgICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZnInKS5yZXNldCgpOworICAgICAgICAgICAgdmVy aWZ5Q2hlY2tlZFN0YXRlKHIxLCB0cnVlKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgdmFy IHIyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3IyJyk7CisgICAgICAgICAgICAKKyAgICAg ICAgICAgIC8vIEF0dGVtcHQgdG8gY2hlY2sgd2l0aCB0aGUgc3BhY2ViYXIKKyAgICAgICAgICAg IHIyLmZvY3VzKCk7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KSB7CisgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bignICcpOworICAgICAgICAg ICAgfQorICAgICAgICAgICAgdmVyaWZ5Q2hlY2tlZFN0YXRlKHIyLCBmYWxzZSk7CisgICAgICAg ICAgICAgICAgICAgCisgICAgICAgICAgICB2YXIgcjMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgncjMnKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAg ICAgIC8vIEF0dGVtcHQgdG8gY2hlY2sgd2l0aCB0aGUgbW91c2UKKyAgICAgICAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgICAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbyhyMy5vZmZzZXRMZWZ0ICsgNywgcjMub2Zmc2V0VG9wICsgNyk7CisgICAg ICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICAgICAgZXZl bnRTZW5kZXIubW91c2VVcCgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgdmVyaWZ5Q2hl Y2tlZFN0YXRlKHIzLCBmYWxzZSk7CisKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgZnVu Y3Rpb24gdmVyaWZ5Q2hlY2tlZFN0YXRlKHJhZCwgZXhwZWN0ZWQpIHsKKyAgICAgICAgICAgIGlm IChyYWQuY2hlY2tlZCA9PSBleHBlY3RlZCkKKyAgICAgICAgICAgICAgICBsb2coIlBhc3MiKTsK KyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBsb2coIkZhaWwiKTsKKyAgICAgICAg fQorICAgICAgICBmdW5jdGlvbiBsb2cobXNnKSB7CisgICAgICAgICAgICB2YXIgY29uc29sZSA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25zb2xlJyk7CisgICAgICAgICAgICBjb25zb2xl LmlubmVySFRNTCA9IGNvbnNvbGUuaW5uZXJIVE1MICsgbXNnICsgIjxicj4iOworICAgICAgICB9 CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keSBvbmxvYWQ9InRlc3Qo KSI+CisgICAgICAgIFRoZXJlIGlzIGEgV2luSUUgcXVpcmsgdGhhdCBkb2VzIG5vdCBhbGxvdyBh IHVzZXIgdG8gc2VsZWN0IHJhZGlvIGJ1dHRvbnMgdGhhdCBkb24ndCBoYXZlIG5hbWVzLiAgVGhp cyB0ZXN0cyB0aGF0IHdlIG9ubHkgaG9ub3IgdGhhdCBxdWlyazxicj4KKyAgICAgICAgaW4gcmVz cG9uc2UgdG8gbW91c2UgYW5kIGtleWJvYXJkIGV2ZW50cy4gIElmIHRoZSBjaGVja2VkIGF0dHJp YnV0ZSBpcyBzZXQgb24gdGhlIGVsZW1lbnQgaW4gdGhlIG1hcmt1cCwgb3IgaW4gamF2YXNjcmlw dCwgd2Ugc2hvdWxkIGlnbm9yZSB0aGUgcXVpcmsuPGJyPgorICAgICAgICA8Zm9ybSBpZD0iZnIi PgorICAgICAgICAgICAgPGlucHV0IHR5cGU9InJhZGlvIiBpZD0icjEiIGNoZWNrZWQ+CisgICAg ICAgICAgICA8aW5wdXQgdHlwZT0icmFkaW8iIGlkPSJyMiI+CisgICAgICAgICAgICA8aW5wdXQg dHlwZT0icmFkaW8iIGlkPSJyMyI+CisgICAgICAgIDwvZm9ybT4KKyAgICAgICAgPGRpdiBpZD0n Y29uc29sZSc+PC9kaXY+CisgICAgPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzMwKQor KysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAw Ny0wMy0xOSAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGZvciBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NTA2NDMxNj4gUkVHUkVTU0lPTjogQWxsb3cgc2V0dGluZyB0aGUgY2hlY2tlZCBhdHRyaWJ1dGUg aW4ganMgYW5kIGluIG1hcmt1cCBmb3IgdW5uYW1lZCByYWRpbyBidXR0b25zIChkb21pbm9zLmNv bSkKKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3JhZGlvX2NoZWNrZWRfbmFtZS5odG1sCisK KyAgICAgICAgV2Ugd2VyZSBtYXRjaGluZyBhIFdpbklFIHF1aXJrIHRoYXQgZG9lcyBub3QgYWxs b3cgYSB1c2VyIHRvIGNoZWNrIGFuZCB1bmNoZWNrIGFuIHVubmFtZWQgcmFkaW8gYnV0dG9uLiAg QnV0IHRoZXkgc3RpbGwKKyAgICAgICAgYWxsb3cgdGhlIGNoZWNrZWQgYXR0cmlidXRlIHRvIGJl IHNldCBpbiBodG1sLCBhbmQgY2hhbmdlZCBpbiBqYXZhc2NyaXB0LiAgU28gdGhpcyBjaGFuZ2Ug bWF0Y2hlcyB0aGF0IGJlaGF2aW9yLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0 cmlidXRlKTogV2Ugbm8gbG9uZ2VyIG5lZWQgYSBzcGVjaWFsIGNhbGwgdG8gc2V0Q2hlY2tlZCB3 aGVuIHBhcnNpbmcgdGhlIG5hbWUKKyAgICAgICAgIGF0dHJpYnV0ZSwgc2luY2Ugd2Ugc2V0Q2hl Y2tlZCB3aWxsIG5vdyB3b3JrIHdpdGggdW5uYW1lZCByYWRpbyBidXR0b25zLgorICAgICAgICAo V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cHJlRGlzcGF0Y2hFdmVudEhhbmRsZXIpOiBBZGRl ZCBjb21tZW50LgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0Q2hlY2tl ZCk6IERvbid0IGNoZWNrIGZvciB0aGUgdW5uYW1lZCByYWRpbyBidXR0b24gY2FzZSBoZXJlLgor ICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cG9zdERpc3BhdGNoRXZlbnRIYW5k bGVyKTogRG9uJ3QgY2FsbCBzZXRDaGVja2VkIGZvciB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMuCisg ICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKTog ZGl0dG8uCisKIDIwMDctMDMtMTkgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBkYXJpbgpJbmRleDogV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcAkocmV2aXNpb24gMjAzMjUpCisrKyBXZWJDb3JlL2h0bWwvSFRNTElucHV0RWxl bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4NCw5ICs1ODQsNiBAQCB2b2lkIEhUTUxJbnB1 dEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmliCiAgICAgICAgIG1fbmFtZSA9IGF0dHItPnZhbHVl KCk7CiAgICAgICAgIAogICAgICAgICBpZiAoaW5wdXRUeXBlKCkgPT0gUkFESU8pIHsKLSAgICAg ICAgICAgIC8vIEluIGNhc2Ugd2UgcGFyc2VkIHRoZSBjaGVja2VkIGF0dHJpYnV0ZSBmaXJzdCwg Y2FsbCBzZXRDaGVja2VkIGlmIHRoZSBlbGVtZW50IGlzIGNoZWNrZWQgYnkgZGVmYXVsdC4KLSAg ICAgICAgICAgIGlmIChtX3VzZURlZmF1bHRDaGVja2VkKQotICAgICAgICAgICAgICAgIHNldENo ZWNrZWQobV9kZWZhdWx0Q2hlY2tlZCk7CiAgICAgICAgICAgICAvLyBBZGQgdGhlIGJ1dHRvbiB0 byBpdHMgbmV3IGdyb3VwLgogICAgICAgICAgICAgaWYgKGNoZWNrZWQoKSkKICAgICAgICAgICAg ICAgICBkb2N1bWVudCgpLT5yYWRpb0J1dHRvbkNoZWNrZWQodGhpcywgZm9ybSgpKTsKQEAgLTg3 OSw4ICs4NzYsNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnJlc2V0KCkKIAogdm9pZCBIVE1M SW5wdXRFbGVtZW50OjpzZXRDaGVja2VkKGJvb2wgbm93Q2hlY2tlZCwgYm9vbCBzZW5kQ2hhbmdl RXZlbnQpCiB7Ci0gICAgLy8gV2UgbWltaWMgV2luSUUgYW5kIGRvbid0IGFsbG93IHVubmFtZWQg cmFkaW8gYnV0dG9ucyB0byBiZSBjaGVja2VkLgotICAgIGlmIChjaGVja2VkKCkgPT0gbm93Q2hl Y2tlZCB8fCAoaW5wdXRUeXBlKCkgPT0gUkFESU8gJiYgbmFtZSgpLmlzRW1wdHkoKSkpCisgICAg aWYgKGNoZWNrZWQoKSA9PSBub3dDaGVja2VkKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAo aW5wdXRUeXBlKCkgPT0gUkFESU8gJiYgbm93Q2hlY2tlZCkKQEAgLTEwNTksNyArMTA1NSw4IEBA IHZvaWQqIEhUTUxJbnB1dEVsZW1lbnQ6OnByZURpc3BhdGNoRXZlbnQKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIC8vIEZvciByYWRpbyBidXR0b25zLCBzdG9yZSB0aGUgY3VycmVudCBz ZWxlY3RlZCByYWRpbyBvYmplY3QuCiAgICAgICAgICAgICBpZiAobmFtZSgpLmlzRW1wdHkoKSB8 fCBjaGVja2VkKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIDA7IC8vIFVubmFtZWQgcmFkaW8g YnV0dG9ucyBkb250IGdldCBjaGVja2VkLiBDaGVja2VkIGJ1dHRvbnMganVzdCBzdGF5IGNoZWNr ZWQuCisgICAgICAgICAgICAgICAgcmV0dXJuIDA7IC8vIE1hdGNoIFdpbklFIGFuZCBkb24ndCBh bGxvdyB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgLy8gQ2hlY2tlZCBidXR0b25zIGp1c3Qgc3RheSBjaGVja2VkLgogICAgICAg ICAgICAgICAgICAgICAgICAgICAvLyBGSVhNRTogTmVlZCB0byBsZWFybiB0byB3b3JrIHdpdGhv dXQgYSBmb3JtLgogCiAgICAgICAgICAgICAvLyBXZSByZWFsbHkgd2FudCByYWRpbyBncm91cHMg dG8gZW5kIHVwIGluIHNhbmUgc3RhdGVzLCBpLmUuLCB0byBoYXZlIHNvbWV0aGluZyBjaGVja2Vk LgpAQCAtMTA5Niw3ICsxMDkzLDkgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50Ojpwb3N0RGlzcGF0 Y2hFdmVudAogICAgICAgICAgICAgICAgIC8vIFJlc3RvcmUgdGhlIG9yaWdpbmFsIHNlbGVjdGVk IHJhZGlvIGJ1dHRvbiBpZiBwb3NzaWJsZS4KICAgICAgICAgICAgICAgICAvLyBNYWtlIHN1cmUg aXQgaXMgc3RpbGwgYSByYWRpbyBidXR0b24gYW5kIG9ubHkgZG8gdGhlIHJlc3RvcmF0aW9uIGlm IGl0IHN0aWxsCiAgICAgICAgICAgICAgICAgLy8gYmVsb25ncyB0byBvdXIgZ3JvdXAuCi0gICAg ICAgICAgICAgICAgaWYgKGlucHV0LT5mb3JtKCkgPT0gZm9ybSgpICYmIGlucHV0LT5pbnB1dFR5 cGUoKSA9PSBSQURJTyAmJiBpbnB1dC0+bmFtZSgpID09IG5hbWUoKSkgeworCisgICAgICAgICAg ICAgICAgLy8gTWF0Y2ggV2luSUUgYW5kIGRvbid0IGFsbG93IHVubmFtZWQgcmFkaW8gYnV0dG9u cyB0byBiZSBjaGVja2VkLgorICAgICAgICAgICAgICAgIGlmIChpbnB1dC0+Zm9ybSgpID09IGZv cm0oKSAmJiBpbnB1dC0+aW5wdXRUeXBlKCkgPT0gUkFESU8gJiYgIW5hbWUoKS5pc0VtcHR5KCkg JiYgaW5wdXQtPm5hbWUoKSA9PSBuYW1lKCkpIHsKICAgICAgICAgICAgICAgICAgICAgLy8gT2ss IHRoZSBvbGQgcmFkaW8gYnV0dG9uIGlzIHN0aWxsIGluIG91ciBmb3JtIGFuZCBpbiBvdXIgZ3Jv dXAgYW5kIGlzIHN0aWxsIGEgCiAgICAgICAgICAgICAgICAgICAgIC8vIHJhZGlvIGJ1dHRvbiwg c28gaXQncyBzYWZlIHRvIHJlc3RvcmUgc2VsZWN0aW9uIHRvIGl0LgogICAgICAgICAgICAgICAg ICAgICBpbnB1dC0+c2V0Q2hlY2tlZCh0cnVlKTsKQEAgLTEyNTIsOSArMTI1MSw5IEBAIHZvaWQg SFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAgICAgICAgICAgICAgICAgICAg aWYgKGVsdC0+Zm9ybSgpICE9IGZvcm0oKSkKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgICAgICBpZiAobi0+aGFzVGFnTmFtZShpbnB1dFRhZykpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIC8vIE1hdGNoIFdpbklFIGFuZCBkb24ndCBhbGxvdyB1bm5h bWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KICAgICAgICAgICAgICAgICAgICAgICAg IEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0RWx0ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVu dCo+KG4pOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlucHV0RWx0LT5pbnB1dFR5cGUo KSA9PSBSQURJTyAmJiBpbnB1dEVsdC0+bmFtZSgpID09IG5hbWUoKSAmJgotICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGlucHV0RWx0LT5pc0ZvY3VzYWJsZSgpKSB7CisgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoaW5wdXRFbHQtPmlucHV0VHlwZSgpID09IFJBRElPICYmICFuYW1lKCku aXNFbXB0eSgpICYmIGlucHV0RWx0LT5uYW1lKCkgPT0gbmFtZSgpICYmIGlucHV0RWx0LT5pc0Zv Y3VzYWJsZSgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW5wdXRFbHQtPnNldENo ZWNrZWQodHJ1ZSk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQoKS0+c2V0 Rm9jdXNlZE5vZGUoaW5wdXRFbHQpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlucHV0 RWx0LT5kaXNwYXRjaFNpbXVsYXRlZENsaWNrKGV2dCwgZmFsc2UsIGZhbHNlKTsK