130863 2014-03-27 14:56:57 -0700 Support dynamic layer hosting context changes 2014-03-27 15:31:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 995071 0 sam 2014-03-27 14:56:57 -0700 Support dynamic layer hosting context changes 995074 1 227986 sam 2014-03-27 14:58:41 -0700 Created attachment 227986 Patch 995096 2 227986 andersca 2014-03-27 15:23:12 -0700 Comment on attachment 227986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227986&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:1060 > + if (m_layerHostingMode != layerHostingMode) { Use an early return here. 995100 3 sam 2014-03-27 15:31:21 -0700 Committed r166374: <http://trac.webkit.org/changeset/166374> 227986 2014-03-27 14:58:41 -0700 2014-03-27 15:23:12 -0700 Patch bug-130863-20140327145820.patch text/plain 4779 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjM3MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAzLTI3ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3VwcG9ydCBkeW5hbWljIGxheWVyIGhv c3RpbmcgY29udGV4dCBjaGFuZ2VzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjI3ODAxOT4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg2Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgYWRkV2luZG93T2JzZXJ2 ZXJzRm9yV2luZG93Ol0pOgorICAgICAgICAoLVtXS1ZpZXcgcmVtb3ZlV2luZG93T2JzZXJ2ZXJz XSk6CisgICAgICAgICgtW1dLVmlldyBfd2luZG93RGlkQ2hhbmdlTGF5ZXJIb3N0aW5nOl0pOgor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OmxheWVySG9zdGluZ01vZGVEaWRDaGFuZ2UpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaDoKKwogMjAxNC0wMy0yNyAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCByZWxvYWQgYW5kIHJlbG9hZEZyb21Pcmln aW4gYXMgQVBJCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAkocmV2aXNpb24gMTY2MzY4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNTQsNiArMTA1NCwxNSBAQCB2b2lkIFdlYlBh Z2VQcm94eTo6dmlld1N0YXRlRGlkQ2hhbmdlKFZpCiAgICAgdXBkYXRlQmFja2luZ1N0b3JlRGlz Y2FyZGFibGVTdGF0ZSgpOwogfQogCit2b2lkIFdlYlBhZ2VQcm94eTo6bGF5ZXJIb3N0aW5nTW9k ZURpZENoYW5nZSgpCit7CisgICAgTGF5ZXJIb3N0aW5nTW9kZSBsYXllckhvc3RpbmdNb2RlID0g bV9wYWdlQ2xpZW50LnZpZXdMYXllckhvc3RpbmdNb2RlKCk7CisgICAgaWYgKG1fbGF5ZXJIb3N0 aW5nTW9kZSAhPSBsYXllckhvc3RpbmdNb2RlKSB7CisgICAgICAgIG1fbGF5ZXJIb3N0aW5nTW9k ZSA9IGxheWVySG9zdGluZ01vZGU7CisgICAgICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6 V2ViUGFnZTo6U2V0TGF5ZXJIb3N0aW5nTW9kZShzdGF0aWNfY2FzdDx1bnNpZ25lZD4obGF5ZXJI b3N0aW5nTW9kZSkpLCBtX3BhZ2VJRCk7CisgICAgfQorfQorCiB2b2lkIFdlYlBhZ2VQcm94eTo6 d2FpdEZvckRpZFVwZGF0ZVZpZXdTdGF0ZSgpCiB7CiAgICAgLy8gSWYgd2UgaGF2ZSBwcmV2aW91 c2x5IHRpbWVkIG91dCB3aXRoIG5vIHJlc3BvbnNlIGZyb20gdGhlIFdlYlByb2Nlc3MsIGRvbid0 IGJsb2NrIHRoZSBVSVByb2Nlc3MgYWdhaW4gdW50aWwgaXQgc3RhcnRzIHJlc3BvbmRpbmcuCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAxNjYz NjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHdvcmtpbmcg Y29weSkKQEAgLTU1NCw3ICs1NTQsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCB2aWV3U3RhdGVEaWRD aGFuZ2UoV2ViQ29yZTo6Vmlld1N0YXRlOjpGbGFncyBtYXlIYXZlQ2hhbmdlZCwgV2FudHNSZXBs eU9yTm90ID0gV2FudHNSZXBseU9yTm90OjpEb2VzTm90V2FudFJlcGx5KTsKICAgICBib29sIGlz SW5XaW5kb3coKSBjb25zdCB7IHJldHVybiBtX3ZpZXdTdGF0ZSAmIFdlYkNvcmU6OlZpZXdTdGF0 ZTo6SXNJbldpbmRvdzsgfQogICAgIHZvaWQgd2FpdEZvckRpZFVwZGF0ZVZpZXdTdGF0ZSgpOwot CisgICAgICAgIAorICAgIHZvaWQgbGF5ZXJIb3N0aW5nTW9kZURpZENoYW5nZSgpOworICAgICAg ICAKICAgICBXZWJDb3JlOjpJbnRTaXplIHZpZXdTaXplKCkgY29uc3Q7CiAgICAgYm9vbCBpc1Zp ZXdWaXNpYmxlKCkgY29uc3QgeyByZXR1cm4gbV92aWV3U3RhdGUgJiBXZWJDb3JlOjpWaWV3U3Rh dGU6OklzVmlzaWJsZTsgfQogICAgIGJvb2wgaXNWaWV3V2luZG93QWN0aXZlKCkgY29uc3Q7Cklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lv biAxNjYzNjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0J KHdvcmtpbmcgY29weSkKQEAgLTIzNzMsNiArMjM3Myw4IEBAIC0gKHZvaWQpYWRkV2luZG93T2Jz ZXJ2ZXJzRm9yV2luZG93OihOU1cKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbmFtZTpOU1dpbmRvd0RpZENoYW5nZUJhY2tpbmdQcm9wZXJ0aWVz Tm90aWZpY2F0aW9uIG9iamVjdDp3aW5kb3ddOwogICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2Vu dGVyIGRlZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKF93 aW5kb3dEaWRDaGFuZ2VTY3JlZW46KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBuYW1lOk5TV2luZG93RGlkQ2hhbmdlU2NyZWVuTm90aWZpY2F0 aW9uIG9iamVjdDp3aW5kb3ddOworICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1 bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKF93aW5kb3dEaWRD aGFuZ2VMYXllckhvc3Rpbmc6KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBuYW1lOkAiX05TV2luZG93RGlkQ2hhbmdlQ29udGVudHNIb3N0ZWRJ bkxheWVyU3VyZmFjZU5vdGlmaWNhdGlvbiIgb2JqZWN0OndpbmRvd107CiAjaWYgX19NQUNfT1Nf WF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCiAgICAgICAgIFtbTlNOb3RpZmljYXRpb25D ZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3Io X3dpbmRvd0RpZENoYW5nZU9jY2x1c2lvblN0YXRlOikKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmFtZTpOU1dpbmRvd0RpZENoYW5nZU9jY2x1 c2lvblN0YXRlTm90aWZpY2F0aW9uIG9iamVjdDp3aW5kb3ddOwpAQCAtMjM5Nyw2ICsyMzk5LDcg QEAgLSAodm9pZClyZW1vdmVXaW5kb3dPYnNlcnZlcnMKICAgICBbW05TTm90aWZpY2F0aW9uQ2Vu dGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGYgbmFtZTpAIl9OU1dpbmRvd0Rp ZEJlY29tZVZpc2libGUiIG9iamVjdDp3aW5kb3ddOwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50 ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2ZXI6c2VsZiBuYW1lOk5TV2luZG93RGlkQ2hh bmdlQmFja2luZ1Byb3BlcnRpZXNOb3RpZmljYXRpb24gb2JqZWN0OndpbmRvd107CiAgICAgW1tO U05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjpzZWxmIG5h bWU6TlNXaW5kb3dEaWRDaGFuZ2VTY3JlZW5Ob3RpZmljYXRpb24gb2JqZWN0OndpbmRvd107Cisg ICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjpz ZWxmIG5hbWU6QCJfTlNXaW5kb3dEaWRDaGFuZ2VDb250ZW50c0hvc3RlZEluTGF5ZXJTdXJmYWNl Tm90aWZpY2F0aW9uIiBvYmplY3Q6d2luZG93XTsKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwOTAKICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50 ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGYgbmFtZTpOU1dpbmRvd0RpZENoYW5nZU9jY2x1c2lvblN0 YXRlTm90aWZpY2F0aW9uIG9iamVjdDp3aW5kb3ddOwogI2VuZGlmCkBAIC0yNDcyLDYgKzI0NzUs MTEgQEAgLSAodm9pZClfd2luZG93RGlkQ2hhbmdlU2NyZWVuOihOU05vdGlmaQogICAgIFtzZWxm IGRvV2luZG93RGlkQ2hhbmdlU2NyZWVuXTsKIH0KIAorLSAodm9pZClfd2luZG93RGlkQ2hhbmdl TGF5ZXJIb3N0aW5nOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgoreworICAgIF9kYXRh LT5fcGFnZS0+bGF5ZXJIb3N0aW5nTW9kZURpZENoYW5nZSgpOworfQorCiAtICh2b2lkKV93aW5k b3dEaWRSZXNpZ25LZXk6KE5TTm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiB7CiAgICAgTlNX aW5kb3cgKmZvcm1lcktleVdpbmRvdyA9IFtub3RpZmljYXRpb24gb2JqZWN0XTsK