130862 2014-03-27 14:56:35 -0700 [iOS WebKit2] Don't pass disk cache directory path on iOS 2014-03-27 17:27:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ap commit-queue psolanki oldest_to_newest 995070 0 psolanki 2014-03-27 14:56:35 -0700 The underlying CFNetwork call behaves differently on iOS so just pass nil for now. 995076 1 227987 psolanki 2014-03-27 14:59:58 -0700 Created attachment 227987 Patch 995081 2 227989 psolanki 2014-03-27 15:06:47 -0700 Created attachment 227989 Patch 995097 3 psolanki 2014-03-27 15:25:25 -0700 Patch won't apply cleanly because it depends on my changes in bug 130861. 995171 4 227989 commit-queue 2014-03-27 17:27:54 -0700 Comment on attachment 227989 Patch Clearing flags on attachment: 227989 Committed r166387: <http://trac.webkit.org/changeset/166387> 995172 5 commit-queue 2014-03-27 17:27:56 -0700 All reviewed patches have been landed. Closing bug. 227987 2014-03-27 14:59:58 -0700 2014-03-27 15:06:45 -0700 Patch bug-130862-20140327145938.patch text/plain 3318 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGIwMWJlNDBmMWU5M2I3 ZDY4NWQ3NzJkNTFmYjY3OTUxZGI4MWM3Ny4uZTczY2YyY2VjM2NjN2YyNTQwMjRjN2E0YzBlODBm NGNmNGI0YTg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTAzLTI3ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TIFdlYktpdDJd IERvbid0IHBhc3MgZGlzayBjYWNoZSBkaXJlY3RvcnkgcGF0aCBvbiBpT1MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg2MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB1bmRlcmx5aW5nIENGTmV0 d29yayBjYWxsIGJlaGF2ZXMgZGlmZmVyZW50bHkgb24gaU9TIGFuZCBpcyBub3QgdmVyeSBoYXBw eSB3aXRoIHRoZSBmdWxsCisgICAgICAgIHBhdGggdG8gdGhlIGRpc2sgY2FjaGUgZGlyZWN0b3J5 IHRoYXQgd2UgcGFzcyBvbiBNYWMuIEp1c3QgcGFzcyBuaWwgZm9yIG5vdyB1bnRpbCB3ZSBzb3J0 CisgICAgICAgIG91dCB0aGUgQVBJLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2Ev TmV0d29ya1Byb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6 OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzQ29jb2EpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j ZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToKKworMjAxNC0wMy0yNyAgUHJhdGlr IFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5jb20+CisKICAgICAgICAgW2lPUyBXZWJLaXQyXSBT aGFyZSBuZXR3b3JrIHByb2Nlc3MgY29kZSBiZXR3ZWVuIGlPUyBhbmQgTWFjCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4NjEKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2Nv YS5tbSBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNz Q29jb2EubW0KaW5kZXggNTc2ZWY2YjhkMjZlODliNTM4NmE0Mzg5OTNmMjIwYjFhZWNhNmNkMS4u ODNlOGM0Y2YyYTlhZmY3ZjFiYWE1Y2ZiZmQ2ZTQ1OTZjYWZkMmNjYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0Nv Y29hLm1tCkBAIC01NiwxMCArNTYsMTUgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1J bml0aWFsaXplTmV0d29ya1Byb2Nlc3NDb2NvYShjb25zdCBOZXR3b3JrUHJvY2Vzc0MKIAogICAg IGlmICghbV9kaXNrQ2FjaGVEaXJlY3RvcnkuaXNOdWxsKCkpIHsKICAgICAgICAgU2FuZGJveEV4 dGVuc2lvbjo6Y29uc3VtZVBlcm1hbmVudGx5KHBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5 RXh0ZW5zaW9uSGFuZGxlKTsKKyNpZiBQTEFURk9STShJT1MpCisgICAgICAgIE5TU3RyaW5nICpk aXNrQ2FjaGVQYXRoID0gbmlsOworI2Vsc2UKKyAgICAgICAgTlNTdHJpbmcgKmRpc2tDYWNoZVBh dGggPSBwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeTsKKyNlbmRpZgogICAgICAgICBbTlNV UkxDYWNoZSBzZXRTaGFyZWRVUkxDYWNoZTphZG9wdE5TKFtbTlNVUkxDYWNoZSBhbGxvY10KICAg ICAgICAgICAgIGluaXRXaXRoTWVtb3J5Q2FwYWNpdHk6cGFyYW1ldGVycy5uc1VSTENhY2hlTWVt b3J5Q2FwYWNpdHkKICAgICAgICAgICAgIGRpc2tDYXBhY2l0eTpwYXJhbWV0ZXJzLm5zVVJMQ2Fj aGVEaXNrQ2FwYWNpdHkKLSAgICAgICAgICAgIGRpc2tQYXRoOnBhcmFtZXRlcnMuZGlza0NhY2hl RGlyZWN0b3J5XSkuZ2V0KCldOworICAgICAgICAgICAgZGlza1BhdGg6ZGlza0NhY2hlUGF0aF0p LmdldCgpXTsKICAgICB9CiAKICNpZiBQTEFURk9STShJT1MpIHx8IF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTA5MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCA0MGQwNGZlMzliMWJkY2M1OWYxYjc1ZmM3 NTU0ZTQyYzk2NDdhYjIzLi41ODY1ZmM0YWI1ZjE3NGZkY2E4M2YxMDRlNTFmM2FkNzk1NDRkYzAy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND b2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND b2NvYS5tbQpAQCAtMTY1LDEwICsxNjUsMTUgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUlu aXRpYWxpemVXZWJQcm9jZXNzKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMKICAg ICAvLyBOU1VSTENhY2hlLCB3aGljaCBpdCBjYW4gZGlzYWJsZSB0byBzYXZlIG1lbW9yeS4KICAg ICBpZiAoIXVzZXNOZXR3b3JrUHJvY2VzcygpKSB7CiAgICAgICAgIGlmICghcGFyYW1ldGVycy5k aXNrQ2FjaGVEaXJlY3RvcnkuaXNOdWxsKCkpIHsKKyNpZiBQTEFURk9STShJT1MpCisgICAgICAg ICAgICBOU1N0cmluZyAqZGlza0NhY2hlUGF0aCA9IG5pbDsKKyNlbHNlCisgICAgICAgICAgICBO U1N0cmluZyAqZGlza0NhY2hlUGF0aCA9IHBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5Owor I2VuZGlmCiAgICAgICAgICAgICBbTlNVUkxDYWNoZSBzZXRTaGFyZWRVUkxDYWNoZTphZG9wdE5T KFtbTlNVUkxDYWNoZSBhbGxvY10KICAgICAgICAgICAgICAgICBpbml0V2l0aE1lbW9yeUNhcGFj aXR5OnBhcmFtZXRlcnMubnNVUkxDYWNoZU1lbW9yeUNhcGFjaXR5CiAgICAgICAgICAgICAgICAg ZGlza0NhcGFjaXR5OnBhcmFtZXRlcnMubnNVUkxDYWNoZURpc2tDYXBhY2l0eQotICAgICAgICAg ICAgICAgIGRpc2tQYXRoOnBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0b3J5XSkuZ2V0KCldOwor ICAgICAgICAgICAgICAgIGRpc2tQYXRoOmRpc2tDYWNoZVBhdGhdKS5nZXQoKV07CiAgICAgICAg IH0KICAgICB9CiAK 227989 2014-03-27 15:06:47 -0700 2014-03-27 17:27:54 -0700 Patch bug-130862-20140327150627.patch text/plain 3247 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGIwMWJlNDBmMWU5M2I3 ZDY4NWQ3NzJkNTFmYjY3OTUxZGI4MWM3Ny4uZThiOTJkOTU0NTllOWY2ODhiZWViZTM2NDhmMmE0 Mzk3ZGMyNWQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTAzLTI3ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAorICAgICAgICBbaU9TIFdlYktpdDJd IERvbid0IHBhc3MgZGlzayBjYWNoZSBkaXJlY3RvcnkgcGF0aCBvbiBpT1MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg2MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkaXNrUGF0aCBwYXNzZWQg dG8gTlNVUkxDYWNoZSBpbml0aWFsaXplciBpcyB0cmVhdGVkIGRpZmZlcmVudGx5IG9uIE1hYyBh bmQgaU9TLiBKdXN0CisgICAgICAgIHBhc3MgbmlsIGZvciBub3cgdW50aWwgd2Ugc29ydCBvdXQg dGhlIEFQSS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNz Q29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUluaXRp YWxpemVOZXR3b3JrUHJvY2Vzc0NvY29hKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1J bml0aWFsaXplV2ViUHJvY2Vzcyk6CisKKzIwMTQtMDMtMjcgIFByYXRpayBTb2xhbmtpICA8cHNv bGFua2lAYXBwbGUuY29tPgorCiAgICAgICAgIFtpT1MgV2ViS2l0Ml0gU2hhcmUgbmV0d29yayBw cm9jZXNzIGNvZGUgYmV0d2VlbiBpT1MgYW5kIE1hYwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwODYxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCmluZGV4 IDU3NmVmNmI4ZDI2ZTg5YjUzODZhNDM4OTkzZjIyMGIxYWVjYTZjZDEuLjgzZThjNGNmMmE5YWZm N2YxYmFhNWNmYmZkNmU0NTk2Y2FmZDJjY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQpAQCAtNTYs MTAgKzU2LDE1IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdv cmtQcm9jZXNzQ29jb2EoY29uc3QgTmV0d29ya1Byb2Nlc3NDCiAKICAgICBpZiAoIW1fZGlza0Nh Y2hlRGlyZWN0b3J5LmlzTnVsbCgpKSB7CiAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OmNvbnN1 bWVQZXJtYW5lbnRseShwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeUV4dGVuc2lvbkhhbmRs ZSk7CisjaWYgUExBVEZPUk0oSU9TKQorICAgICAgICBOU1N0cmluZyAqZGlza0NhY2hlUGF0aCA9 IG5pbDsKKyNlbHNlCisgICAgICAgIE5TU3RyaW5nICpkaXNrQ2FjaGVQYXRoID0gcGFyYW1ldGVy cy5kaXNrQ2FjaGVEaXJlY3Rvcnk7CisjZW5kaWYKICAgICAgICAgW05TVVJMQ2FjaGUgc2V0U2hh cmVkVVJMQ2FjaGU6YWRvcHROUyhbW05TVVJMQ2FjaGUgYWxsb2NdCiAgICAgICAgICAgICBpbml0 V2l0aE1lbW9yeUNhcGFjaXR5OnBhcmFtZXRlcnMubnNVUkxDYWNoZU1lbW9yeUNhcGFjaXR5CiAg ICAgICAgICAgICBkaXNrQ2FwYWNpdHk6cGFyYW1ldGVycy5uc1VSTENhY2hlRGlza0NhcGFjaXR5 Ci0gICAgICAgICAgICBkaXNrUGF0aDpwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeV0pLmdl dCgpXTsKKyAgICAgICAgICAgIGRpc2tQYXRoOmRpc2tDYWNoZVBhdGhdKS5nZXQoKV07CiAgICAg fQogCiAjaWYgUExBVEZPUk0oSU9TKSB8fCBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwOTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29jb2EvV2Vi UHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9j ZXNzQ29jb2EubW0KaW5kZXggNDBkMDRmZTM5YjFiZGNjNTlmMWI3NWZjNzU1NGU0MmM5NjQ3YWIy My4uNTg2NWZjNGFiNWYxNzRmZGNhODNmMTA0ZTUxZjNhZDc5NTQ0ZGMwMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTE2 NSwxMCArMTY1LDE1IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJv Y2Vzcyhjb25zdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzCiAgICAgLy8gTlNVUkxDYWNo ZSwgd2hpY2ggaXQgY2FuIGRpc2FibGUgdG8gc2F2ZSBtZW1vcnkuCiAgICAgaWYgKCF1c2VzTmV0 d29ya1Byb2Nlc3MoKSkgewogICAgICAgICBpZiAoIXBhcmFtZXRlcnMuZGlza0NhY2hlRGlyZWN0 b3J5LmlzTnVsbCgpKSB7CisjaWYgUExBVEZPUk0oSU9TKQorICAgICAgICAgICAgTlNTdHJpbmcg KmRpc2tDYWNoZVBhdGggPSBuaWw7CisjZWxzZQorICAgICAgICAgICAgTlNTdHJpbmcgKmRpc2tD YWNoZVBhdGggPSBwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeTsKKyNlbmRpZgogICAgICAg ICAgICAgW05TVVJMQ2FjaGUgc2V0U2hhcmVkVVJMQ2FjaGU6YWRvcHROUyhbW05TVVJMQ2FjaGUg YWxsb2NdCiAgICAgICAgICAgICAgICAgaW5pdFdpdGhNZW1vcnlDYXBhY2l0eTpwYXJhbWV0ZXJz Lm5zVVJMQ2FjaGVNZW1vcnlDYXBhY2l0eQogICAgICAgICAgICAgICAgIGRpc2tDYXBhY2l0eTpw YXJhbWV0ZXJzLm5zVVJMQ2FjaGVEaXNrQ2FwYWNpdHkKLSAgICAgICAgICAgICAgICBkaXNrUGF0 aDpwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeV0pLmdldCgpXTsKKyAgICAgICAgICAgICAg ICBkaXNrUGF0aDpkaXNrQ2FjaGVQYXRoXSkuZ2V0KCldOwogICAgICAgICB9CiAgICAgfQogCg==