130860 2014-03-27 14:33:54 -0700 Check the remembered set bit faster 2014-03-27 15:34:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 995057 0 mhahnenberg 2014-03-27 14:33:54 -0700 Currently we look up the remembered set bit in the MarkedBlock in C++ code, but that bit is also stored in the object. We should look it up there whenever possible. 995063 1 227983 mhahnenberg 2014-03-27 14:42:09 -0700 Created attachment 227983 Patch 995065 2 mhahnenberg 2014-03-27 14:44:16 -0700 (In reply to comment #1) > Created an attachment (id=227983) [details] > Patch This appears to be performance neutral on the benchmarks we track. 995102 3 227983 commit-queue 2014-03-27 15:34:49 -0700 Comment on attachment 227983 Patch Clearing flags on attachment: 227983 Committed r166375: <http://trac.webkit.org/changeset/166375> 995103 4 commit-queue 2014-03-27 15:34:51 -0700 All reviewed patches have been landed. Closing bug. 227983 2014-03-27 14:42:09 -0700 2014-03-27 15:34:49 -0700 Patch bug-130860-20140327144148.patch text/plain 4535 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MzcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE0LTAzLTI3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ2hlY2sgdGhlIHJlbWVtYmVyZWQgc2V0IGJpdCBmYXN0ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDg2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSB3ZSBsb29rIHVw IHRoZSByZW1lbWJlcmVkIHNldCBiaXQgaW4gdGhlIE1hcmtlZEJsb2NrIGluIEMrKyBjb2RlLCBi dXQgCisgICAgICAgIHRoYXQgYml0IGlzIGFsc28gc3RvcmVkIGluIHRoZSBvYmplY3QuIFdlIHNo b3VsZCBsb29rIGl0IHVwIHRoZXJlIHdoZW5ldmVyIHBvc3NpYmxlLgorCisgICAgICAgICogaGVh cC9Db3BpZWRCbG9ja0lubGluZXMuaDoKKyAgICAgICAgKEpTQzo6Q29waWVkQmxvY2s6OnNob3Vs ZFJlcG9ydExpdmVCeXRlcyk6CisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpT Qzo6SGVhcDo6YWRkVG9SZW1lbWJlcmVkU2V0KToKKyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAg ICAgICAgKiBoZWFwL0hlYXBJbmxpbmVzLmg6IFJlbW92ZWQuCisgICAgICAgICogaGVhcC9TbG90 VmlzaXRvcklubGluZXMuaDoKKyAgICAgICAgKEpTQzo6U2xvdFZpc2l0b3I6OnJlcG9ydEV4dHJh TWVtb3J5VXNhZ2UpOgorCiAyMDE0LTAzLTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvdmlkZSBTUEkgdG8gZGlzYWxs b3cgcmVtb3RlIGluc3BlY3Rpb24gb2YgYSBKU0NvbnRleHQKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL0NvcGllZEJsb2NrSW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZEJsb2NrSW5saW5lcy5oCShyZXZpc2lvbiAxNjYzNzAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9ja0lubGluZXMuaAkod29y a2luZyBjb3B5KQpAQCAtNDAsOCArNDAsNyBAQCBpbmxpbmUgYm9vbCBDb3BpZWRCbG9jazo6c2hv dWxkUmVwb3J0TGl2CiAgICAgLy8gSWYgd2UgYWx3YXlzIGFkZGVkIGxpdmUgYnl0ZXMgd2Ugd291 bGQgZG91YmxlIGNvdW50IGZvciBlbGVtZW50cyBpbiB0aGUgcmVtZW1iZXJlZAogICAgIC8vIHNl dCBhY3Jvc3MgY29sbGVjdGlvbnMuIAogICAgIC8vIElmIHdlIGRpZG4ndCBhbHdheXMgYWRkIGxp dmUgYnl0ZXMgdG8gbmV3IGJsb2Nrcywgd2UnZCBnZXQgdG9vIGZldy4KLSAgICBib29sIG93bmVy SXNSZW1lbWJlcmVkID0gTWFya2VkQmxvY2s6OmJsb2NrRm9yKG93bmVyKS0+aXNSZW1lbWJlcmVk KG93bmVyKTsKLSAgICByZXR1cm4gIW93bmVySXNSZW1lbWJlcmVkIHx8ICFtX2lzT2xkOworICAg IHJldHVybiAhSGVhcDo6aXNSZW1lbWJlcmVkKG93bmVyKSB8fCAhbV9pc09sZDsKIH0KIAogaW5s aW5lIHZvaWQgQ29waWVkQmxvY2s6OnJlcG9ydExpdmVCeXRlcyhTcGluTG9ja0hvbGRlciYsIEpT Q2VsbCogb3duZXIsIENvcHlUb2tlbiB0b2tlbiwgdW5zaWduZWQgYnl0ZXMpCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTY2MzcwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1MCw3ICs4NTAs NyBAQCB2b2lkIEhlYXA6OmFkZFRvUmVtZW1iZXJlZFNldChjb25zdCBKU0NlCiB7CiAgICAgQVNT RVJUKGNlbGwpOwogICAgIEFTU0VSVCghT3B0aW9uczo6ZW5hYmxlQ29uY3VycmVudEpJVCgpIHx8 ICFpc0NvbXBpbGF0aW9uVGhyZWFkKCkpOwotICAgIGlmIChpc0luUmVtZW1iZXJlZFNldChjZWxs KSkKKyAgICBpZiAoaXNSZW1lbWJlcmVkKGNlbGwpKQogICAgICAgICByZXR1cm47CiAgICAgTWFy a2VkQmxvY2s6OmJsb2NrRm9yKGNlbGwpLT5zZXRSZW1lbWJlcmVkKGNlbGwpOwogICAgIGNvbnN0 X2Nhc3Q8SlNDZWxsKj4oY2VsbCktPnNldFJlbWVtYmVyZWQodHJ1ZSk7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5oCShyZXZpc2lvbiAxNjYzNzApCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9IZWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTk5LDcgKzk5LDYgQEAgcHVibGlj OgogICAgIHN0YXRpYyBib29sIGlzUmVtZW1iZXJlZChjb25zdCB2b2lkKik7CiAKICAgICBKU19F WFBPUlRfUFJJVkFURSB2b2lkIGFkZFRvUmVtZW1iZXJlZFNldChjb25zdCBKU0NlbGwqKTsKLSAg ICBib29sIGlzSW5SZW1lbWJlcmVkU2V0KGNvbnN0IEpTQ2VsbCopIGNvbnN0OwogICAgIHN0YXRp YyBib29sIGlzV3JpdGVCYXJyaWVyRW5hYmxlZCgpOwogICAgIEpTX0VYUE9SVF9QUklWQVRFIHZv aWQgd3JpdGVCYXJyaWVyKGNvbnN0IEpTQ2VsbCopOwogICAgIHZvaWQgd3JpdGVCYXJyaWVyKGNv bnN0IEpTQ2VsbCosIEpTVmFsdWUpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcElubGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwSW5saW5lcy5oCShyZXZpc2lvbiAxNjYzNzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwSW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMSArNjcsMTMgQEAgaW5s aW5lIGJvb2wgSGVhcDo6aXNMaXZlKGNvbnN0IHZvaWQqIGNlbAogICAgIHJldHVybiBNYXJrZWRC bG9jazo6YmxvY2tGb3IoY2VsbCktPmlzTGl2ZUNlbGwoY2VsbCk7CiB9CiAKLWlubGluZSBib29s IEhlYXA6OmlzSW5SZW1lbWJlcmVkU2V0KGNvbnN0IEpTQ2VsbCogY2VsbCkgY29uc3QKK2lubGlu ZSBib29sIEhlYXA6OmlzUmVtZW1iZXJlZChjb25zdCB2b2lkKiBwdHIpCiB7CisgICAgY29uc3Qg SlNDZWxsKiBjZWxsID0gc3RhdGljX2Nhc3Q8Y29uc3QgSlNDZWxsKj4ocHRyKTsKICAgICBBU1NF UlQoY2VsbCk7CiAgICAgQVNTRVJUKCFPcHRpb25zOjplbmFibGVDb25jdXJyZW50SklUKCkgfHwg IWlzQ29tcGlsYXRpb25UaHJlYWQoKSk7Ci0gICAgcmV0dXJuIE1hcmtlZEJsb2NrOjpibG9ja0Zv cihjZWxsKS0+aXNSZW1lbWJlcmVkKGNlbGwpOworICAgIEFTU0VSVChNYXJrZWRCbG9jazo6Ymxv Y2tGb3IoY2VsbCktPmlzUmVtZW1iZXJlZChjZWxsKSA9PSBjZWxsLT5pc1JlbWVtYmVyZWQoKSk7 CisgICAgcmV0dXJuIGNlbGwtPmlzUmVtZW1iZXJlZCgpOwogfQogCiBpbmxpbmUgYm9vbCBIZWFw Ojppc01hcmtlZChjb25zdCB2b2lkKiBjZWxsKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvU2xvdFZpc2l0b3JJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvU2xvdFZpc2l0b3JJbmxpbmVzLmgJKHJldmlzaW9uIDE2NjM3MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9ySW5saW5lcy5oCSh3b3JraW5nIGNv cHkpCkBAIC0yNTgsNyArMjU4LDcgQEAgaW5saW5lIHZvaWQgU2xvdFZpc2l0b3I6OnJlcG9ydEV4 dHJhTWVtbwogewogI2lmIEVOQUJMRShHR0MpCiAgICAgLy8gV2UgZG9uJ3Qgd2FudCB0byBkb3Vi bGUtY291bnQgdGhlIGV4dHJhIG1lbW9yeSB0aGF0IHdhcyByZXBvcnRlZCBpbiBwcmV2aW91cyBj b2xsZWN0aW9ucy4KLSAgICBpZiAoaGVhcCgpLT5vcGVyYXRpb25JblByb2dyZXNzKCkgPT0gRWRl bkNvbGxlY3Rpb24gJiYgTWFya2VkQmxvY2s6OmJsb2NrRm9yKG93bmVyKS0+aXNSZW1lbWJlcmVk KG93bmVyKSkKKyAgICBpZiAoaGVhcCgpLT5vcGVyYXRpb25JblByb2dyZXNzKCkgPT0gRWRlbkNv bGxlY3Rpb24gJiYgSGVhcDo6aXNSZW1lbWJlcmVkKG93bmVyKSkKICAgICAgICAgcmV0dXJuOwog I2Vsc2UKICAgICBVTlVTRURfUEFSQU0ob3duZXIpOwo=