130852 2014-03-27 12:14:45 -0700 Confirm composition in resignFirstResponder, don't cancel it 2014-03-27 17:36:44 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca commit-queue darin rniwa sam oldest_to_newest 995003 0 ap 2014-03-27 12:14:45 -0700 We currently have code in -[WKView resignFirstResponder] that cancels the current composition. There are some problems with it: 1. It's a sync IPC call, which I want to eliminate. 2. It doesn't actually work most of the time, because editorState tracking is broken, and we often think that there is no composition even when there is one. 3. Modern AppKit behavior appears to be that it confirms a composition when switching between text views within a window. Or maybe it's flaky too, but one way or another, confirming seems like a reasonable behavior. 995004 1 227962 ap 2014-03-27 12:16:26 -0700 Created attachment 227962 proposed patch The same probably makes sense for old code path too, but I don't want to touch it unless absolutely necessary. 995175 2 227962 commit-queue 2014-03-27 17:36:41 -0700 Comment on attachment 227962 proposed patch Clearing flags on attachment: 227962 Committed r166388: <http://trac.webkit.org/changeset/166388> 995176 3 commit-queue 2014-03-27 17:36:44 -0700 All reviewed patches have been landed. Closing bug. 227962 2014-03-27 12:16:26 -0700 2014-03-27 17:36:41 -0700 proposed patch ResignFirstResponder.txt text/plain 1272 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjM2NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAzLTI3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIENvbmZpcm0gY29tcG9zaXRp b24gaW4gcmVzaWduRmlyc3RSZXNwb25kZXIsIGRvbid0IGNhbmNlbCBpdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwODUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1ZpZXcubW06ICgtW1dLVmlldyByZXNpZ25GaXJzdFJlc3BvbmRlcl0pOgorCiAyMDE0LTAzLTI3 ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1l IFdLRnJhbWVIYW5kbGUgdG8gX1dLRnJhbWVIYW5kbGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDE2NjI0MCkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzcw LDggKzM3MCwxMiBAQCAtIChCT09MKXJlc2lnbkZpcnN0UmVzcG9uZGVyCiB7CiAgICAgX2RhdGEt Pl9pblJlc2lnbkZpcnN0UmVzcG9uZGVyID0gdHJ1ZTsKIAorI2lmIFVTRShBU1lOQ19OU1RFWFRJ TlBVVENMSUVOVCkKKyAgICBfZGF0YS0+X3BhZ2UtPmNvbmZpcm1Db21wb3NpdGlvbkFzeW5jKCk7 CisjZWxzZQogICAgIGlmIChfZGF0YS0+X3BhZ2UtPmVkaXRvclN0YXRlKCkuaGFzQ29tcG9zaXRp b24gJiYgIV9kYXRhLT5fcGFnZS0+ZWRpdG9yU3RhdGUoKS5zaG91bGRJZ25vcmVDb21wb3NpdGlv blNlbGVjdGlvbkNoYW5nZSkKICAgICAgICAgX2RhdGEtPl9wYWdlLT5jYW5jZWxDb21wb3NpdGlv bigpOworI2VuZGlmCiAKICAgICBbc2VsZiBfbm90aWZ5SW5wdXRDb250ZXh0QWJvdXREaXNjYXJk ZWRDb21wb3NpdGlvbl07CiAK