130845 2014-03-27 10:07:59 -0700 Clean up questionable style in ScriptExecutable::prepareForExecutionImpl 2014-03-27 12:19:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 994955 0 mhahnenberg 2014-03-27 10:07:59 -0700 There was a hack added to make sure C Loop LLInt worked which included overriding the global Options::useLLInt setting, which makes no sense to do here. We should factor all of the crazy ifdefs into a separate shouldUseLLInt helper function and we should get rid of the global override. 994956 1 227954 mhahnenberg 2014-03-27 10:12:53 -0700 Created attachment 227954 patch 994959 2 227955 mhahnenberg 2014-03-27 10:25:11 -0700 Created attachment 227955 patch 995005 3 227955 commit-queue 2014-03-27 12:19:55 -0700 Comment on attachment 227955 patch Clearing flags on attachment: 227955 Committed r166366: <http://trac.webkit.org/changeset/166366> 995006 4 commit-queue 2014-03-27 12:19:57 -0700 All reviewed patches have been landed. Closing bug. 227954 2014-03-27 10:12:53 -0700 2014-03-27 10:25:11 -0700 patch the.patch text/plain 2303 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MzYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTAzLTI3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ2xlYW4gdXAgcXVlc3Rpb25hYmxlIHN0eWxlIGluIFNjcmlwdEV4ZWN1dGFibGU6 OnByZXBhcmVGb3JFeGVjdXRpb25JbXBsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzA4NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVyZSB3YXMgYSBoYWNrIGFkZGVkIHRvIG1ha2Ugc3VyZSBDIExv b3AgTExJbnQgd29ya2VkIHdoaWNoIGluY2x1ZGVkIG92ZXJyaWRpbmcgdGhlIAorICAgICAgICBn bG9iYWwgT3B0aW9uczo6dXNlTExJbnQgc2V0dGluZywgd2hpY2ggbWFrZXMgbm8gc2Vuc2UgdG8g ZG8gaGVyZS4gV2Ugc2hvdWxkIGZhY3RvciAKKyAgICAgICAgYWxsIG9mIHRoZSBjcmF6eSBpZmRl ZnMgaW50byBhIHNlcGFyYXRlIHNob3VsZFVzZUxMSW50IGhlbHBlciBmdW5jdGlvbiBhbmQgd2Ug c2hvdWxkIAorICAgICAgICBnZXQgcmlkIG9mIHRoZSBnbG9iYWwgb3ZlcnJpZGUuCisKKyAgICAg ICAgKiBydW50aW1lL0V4ZWN1dGFibGUuY3BwOgorICAgICAgICAoSlNDOjpzaG91bGRVc2VMTElu dCk6CisgICAgICAgIChKU0M6OlNjcmlwdEV4ZWN1dGFibGU6OnByZXBhcmVGb3JFeGVjdXRpb25J bXBsKToKKwogMjAxNC0wMy0yNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg ICAgICAgIEVuYWJsZSBMTFZNIHN0YWNrbWFwIGxpdmVPdXRzIGNvbXB1dGF0aW9uCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAkocmV2aXNpb24g MTY2MzYwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTMwMiw2ICszMDIsMTggQEAgc3RhdGljIHZvaWQgc2V0dXBKSVQo Vk0mIHZtLCBDb2RlQmxvY2sqIAogI2VuZGlmCiB9CiAKK3N0YXRpYyBib29sIHNob3VsZFVzZUxM SW50KCkKK3sKKyNpZiBFTkFCTEUoSklUKSAmJiBFTkFCTEUoTExJTlQpCisgICAgcmV0dXJuIE9w dGlvbnM6OnVzZUxMSW50KCk7CisjZWxpZiBFTkFCTEUoSklUKQorICAgIHJldHVybiBmYWxzZTsK KyNlbHNlCisgICAgLy8gTm8gSklUIGltcGxpZXMgdXNlIG9mIHRoZSBDIExvb3AgTExJTlQuCisg ICAgcmV0dXJuIHRydWU7CisjZW5kaWYKK30KKwogSlNPYmplY3QqIFNjcmlwdEV4ZWN1dGFibGU6 OnByZXBhcmVGb3JFeGVjdXRpb25JbXBsKAogICAgIEV4ZWNTdGF0ZSogZXhlYywgSlNGdW5jdGlv biogZnVuY3Rpb24sIEpTU2NvcGUqKiBzY29wZSwgQ29kZVNwZWNpYWxpemF0aW9uS2luZCBraW5k KQogewpAQCAtMzE4LDE4ICszMzAsNyBAQCBKU09iamVjdCogU2NyaXB0RXhlY3V0YWJsZTo6cHJl cGFyZUZvckV4CiAgICAgaWYgKE9wdGlvbnM6OnZhbGlkYXRlQnl0ZWNvZGUoKSkKICAgICAgICAg Y29kZUJsb2NrLT52YWxpZGF0ZSgpOwogICAgIAotICAgIGJvb2wgc2hvdWxkVXNlTExJbnQ7Ci0j aWYgIUVOQUJMRShKSVQpCi0gICAgLy8gTm8gSklUIGltcGxpZXMgdXNlIG9mIHRoZSBDIExvb3Ag TExJTlQuIE92ZXJyaWRlIHRoZSBvcHRpb25zIHRvIHJlZmxlY3QgdGhpcy4gCi0gICAgT3B0aW9u czo6dXNlTExJbnQoKSA9IHRydWU7Ci0gICAgc2hvdWxkVXNlTExJbnQgPSB0cnVlOwotI2VsaWYg RU5BQkxFKExMSU5UKQotICAgIHNob3VsZFVzZUxMSW50ID0gT3B0aW9uczo6dXNlTExJbnQoKTsK LSNlbHNlCi0gICAgc2hvdWxkVXNlTExJbnQgPSBmYWxzZTsKLSNlbmRpZgotICAgIAotICAgIGlm IChzaG91bGRVc2VMTEludCkKKyAgICBpZiAoc2hvdWxkVXNlTExJbnQoKSkKICAgICAgICAgc2V0 dXBMTEludCh2bSwgY29kZUJsb2NrLmdldCgpKTsKICAgICBlbHNlCiAgICAgICAgIHNldHVwSklU KHZtLCBjb2RlQmxvY2suZ2V0KCkpOwo= 227955 2014-03-27 10:25:11 -0700 2014-03-27 12:19:54 -0700 patch the.patch text/plain 2540 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2MzYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTAzLTI3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ2xlYW4gdXAgcXVlc3Rpb25hYmxlIHN0eWxlIGluIFNjcmlwdEV4ZWN1dGFibGU6 OnByZXBhcmVGb3JFeGVjdXRpb25JbXBsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzA4NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVyZSB3YXMgYSBoYWNrIGFkZGVkIHRvIG1ha2Ugc3VyZSBDIExv b3AgTExJbnQgd29ya2VkIHdoaWNoIGluY2x1ZGVkIG92ZXJyaWRpbmcgdGhlIAorICAgICAgICBn bG9iYWwgT3B0aW9uczo6dXNlTExJbnQgc2V0dGluZywgd2hpY2ggbWFrZXMgbm8gc2Vuc2UgdG8g ZG8gaGVyZS4gV2Ugc2hvdWxkIHB1dCB0aGUgCisgICAgICAgIHVwZGF0ZSBvZiB0aGUgZ2xvYmFs IHNldHRpbmcgaW4gT3B0aW9uczo6cmVjb21wdXRlRGVwZW5kZW50T3B0aW9ucyBhbG9uZyB3aXRo IHRoZSBvdGhlciAKKyAgICAgICAgZXhlY3V0aW9uIGVuZ2luZSBmbGFncy4KKworICAgICAgICAq IHJ1bnRpbWUvRXhlY3V0YWJsZS5jcHA6CisgICAgICAgIChKU0M6OlNjcmlwdEV4ZWN1dGFibGU6 OnByZXBhcmVGb3JFeGVjdXRpb25JbXBsKToKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuY3Bw OgorICAgICAgICAoSlNDOjpyZWNvbXB1dGVEZXBlbmRlbnRPcHRpb25zKToKKwogMjAxNC0wMy0y NiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBMTFZN IHN0YWNrbWFwIGxpdmVPdXRzIGNvbXB1dGF0aW9uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAkocmV2aXNpb24gMTY2MzYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTMxOCwxOCArMzE4LDcgQEAgSlNPYmplY3QqIFNjcmlwdEV4ZWN1dGFibGU6OnByZXBhcmVGb3JF eAogICAgIGlmIChPcHRpb25zOjp2YWxpZGF0ZUJ5dGVjb2RlKCkpCiAgICAgICAgIGNvZGVCbG9j ay0+dmFsaWRhdGUoKTsKICAgICAKLSAgICBib29sIHNob3VsZFVzZUxMSW50OwotI2lmICFFTkFC TEUoSklUKQotICAgIC8vIE5vIEpJVCBpbXBsaWVzIHVzZSBvZiB0aGUgQyBMb29wIExMSU5ULiBP dmVycmlkZSB0aGUgb3B0aW9ucyB0byByZWZsZWN0IHRoaXMuIAotICAgIE9wdGlvbnM6OnVzZUxM SW50KCkgPSB0cnVlOwotICAgIHNob3VsZFVzZUxMSW50ID0gdHJ1ZTsKLSNlbGlmIEVOQUJMRShM TElOVCkKLSAgICBzaG91bGRVc2VMTEludCA9IE9wdGlvbnM6OnVzZUxMSW50KCk7Ci0jZWxzZQot ICAgIHNob3VsZFVzZUxMSW50ID0gZmFsc2U7Ci0jZW5kaWYKLSAgICAKLSAgICBpZiAoc2hvdWxk VXNlTExJbnQpCisgICAgaWYgKE9wdGlvbnM6OnVzZUxMSW50KCkpCiAgICAgICAgIHNldHVwTExJ bnQodm0sIGNvZGVCbG9jay5nZXQoKSk7CiAgICAgZWxzZQogICAgICAgICBzZXR1cEpJVCh2bSwg Y29kZUJsb2NrLmdldCgpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnMuY3BwCShyZXZpc2lvbiAxNjYzNjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg1LDEwICsxODUsMTQgQEAgY29u c3QgT3B0aW9uczo6RW50cnlJbmZvIE9wdGlvbnM6OnNfb3B0aQogc3RhdGljIHZvaWQgcmVjb21w dXRlRGVwZW5kZW50T3B0aW9ucygpCiB7CiAjaWYgIUVOQUJMRShKSVQpCisgICAgT3B0aW9uczo6 dXNlTExJbnQoKSA9IHRydWU7CiAgICAgT3B0aW9uczo6dXNlSklUKCkgPSBmYWxzZTsKICAgICBP cHRpb25zOjp1c2VERkdKSVQoKSA9IGZhbHNlOwogICAgIE9wdGlvbnM6OnVzZUZUTEpJVCgpID0g ZmFsc2U7CiAjZW5kaWYKKyNpZiAhRU5BQkxFKExMSU5UKQorICAgIE9wdGlvbnM6OnVzZUxMSW50 KCkgPSBmYWxzZTsKKyNlbmRpZgogI2lmICFFTkFCTEUoWUFSUl9KSVQpCiAgICAgT3B0aW9uczo6 dXNlUmVnRXhwSklUKCkgPSBmYWxzZTsKICNlbmRpZgo=