130837 2014-03-27 06:29:03 -0700 Webkit2 doesnt build on powerpc 32 bits 2014-11-24 06:49:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 landry webkit-unassigned ajacoutot ajacoutot berto casaxa commit-queue gnome oldest_to_newest 994907 0 landry 2014-03-27 06:29:03 -0700 With a variety of patches i can build webkit1 on ppc 32 bits (it blows at runtime but that's another story), but webkit2 fails with: webkit-2.4.0-gtk3/webkitgtk-2.4.0/.libs/libWebKit2Platform.a(libWebKit2Platform_l a-Connection.o)(.gnu.linkonce.t._ZNSt13__atomic_baseIyEppEv+0x2c): In function `_ZNSt13__atomic_baseIyEppEv': : undefined reference to `__atomic_fetch_add_8' This is most probably due to the fact that ppc 32 bits cant have atomic ops on a 8-bytes value. The func is std::__atomic_base<unsigned long long>::operator++(), and i'm pretty sure this comes from http://trac.webkit.org/browser/trunk/Source/WebKit2/Platform/IPC/Connection.h#L216 the ++ operator being called in http://trac.webkit.org/browser/trunk/Source/WebKit2/Platform/IPC/Connection.cpp#L341. The std::atomic<> template was added in http://trac.webkit.org/browser/trunk/Source/WebKit2/Platform/CoreIPC/Connection.h?annotate=blame&rev=159724#file11 and i fail to see the reasoning for it. 995083 1 landry 2014-03-27 15:09:36 -0700 Note that there's another std::atomic<int64_t> in Source/WebKit2/UIProcess/StatisticsRequest.cpp, and apparently one more in git master/svn head. A workaround is to #if out the std::atomic template for 64-bits types on ppc, but a better real solution would be welcome. Cf http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_Platform_IPC_Connection_h?rev=1.1 and http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_UIProcess_StatisticsRequest_cpp?rev=1.3 +#if CPU(PPC) + static int64_t uniqueRequestID; +#else static std::atomic<int64_t> uniqueRequestID; +#endif sunset:~/src/WebKit/ $git grep std::atomic | grep 64 Source/WebKit2/Platform/IPC/Connection.h: std::atomic<uint64_t> m_syncRequestID; Source/WebKit2/Shared/mac/SecItemShim.cpp: static std::atomic<int64_t> uniqueSecItemRequestID; Source/WebKit2/UIProcess/StatisticsRequest.cpp: static std::atomic<int64_t> uniqueRequestID; 1034249 2 berto 2014-09-10 01:58:11 -0700 (In reply to comment #0) > With a variety of patches i can build webkit1 on ppc 32 bits (it blows at runtime but that's another story), but webkit2 fails with: > > webkit-2.4.0-gtk3/webkitgtk-2.4.0/.libs/libWebKit2Platform.a(libWebKit2Platform_l > a-Connection.o)(.gnu.linkonce.t._ZNSt13__atomic_baseIyEppEv+0x2c): In function `_ZNSt13__atomic_baseIyEppEv': > : undefined reference to `__atomic_fetch_add_8' Did you try adding -latomic to the linker flags? 1049318 3 casaxa 2014-11-17 14:23:04 -0800 Hi I don't know if this is in some way related to this bug, but I'm trying to compile this from 2.5.90 up to 2.6.3 ending always at make install phase with the same error. sasa@slack141-314:/tmp/DLG/logs/webkitgtk-2.6.3-2$ cat makeinstall.txt [ 0%] Built target WebKit2-forwarding-headers [ 1%] Built target WTF [ 1%] Built target LLIntOffsetsExtractor [ 12%] Built target JavaScriptCore [ 13%] Built target ANGLESupport [ 76%] Built target WebCore [ 77%] Built target WebCorePlatformGTK [ 78%] Built target fake-generated-webkitdom-headers [ 84%] Built target GObjectDOMBindings [ 84%] Built target WebKit2-fake-api-headers Linking CXX shared library ../../lib/libwebkit2gtk-4.0.so CMakeFiles/WebKit2.dir/Platform/IPC/Connection.cpp.o: In function `IPC::Connection::createSyncMessageEncoder(IPC::StringReference, IPC::StringReference, unsigned long long, unsigned long long&)': Connection.cpp:(.text+0x20f): undefined reference to `__atomic_fetch_add_8' CMakeFiles/WebKit2.dir/UIProcess/StatisticsRequest.cpp.o: In function `WebKit::StatisticsRequest::addOutstandingRequest()': StatisticsRequest.cpp:(.text+0xac3): undefined reference to `__atomic_fetch_add_8' collect2: error: ld returned 1 exit status make[2]: *** [lib/libwebkit2gtk-4.0.so.37.2.4] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 sasa@slack141-314:/tmp/DLG/logs/webkitgtk-2.6.3-2$ I have build without problems the same versions on my x86-64 machines. Both x86-64 and i686 have slackware-14.1 linux os. I tried also adding -latomic to the cxxflags but have not helped out. Any comments appreciated. 1049414 4 berto 2014-11-17 23:49:05 -0800 (In reply to comment #3) > Hi I don't know if this is in some way related to this bug, but I'm > trying to compile this from 2.5.90 up to 2.6.3 ending always at make > install phase with the same error. This is how we are doing it in Debian: http://anonscm.debian.org/cgit/pkg-webkit/webkit.git/tree/debian/patches/atomic_build_fix.patch?id=debian/2.6.2%2bdfsg1-2 It should be fixed in WebKit in a nicer way. 1049430 5 241773 berto 2014-11-18 02:31:24 -0800 Created attachment 241773 Patch Can you try to build it with this patch? Thanks! 1049434 6 casaxa 2014-11-18 02:43:30 -0800 @ Alberto, many thanks, I have used a wrong patch last night , the one from gentoo but its only specific to PPC, so after that I saw the debian patch pointed out by you here. I will retry the build tonight with your latest patch. 1049683 7 casaxa 2014-11-18 17:48:53 -0800 Hello Alberto, this is what I get with your patch: sasa@slack141-314:/tmp/DLG/logs/webkitgtk-2.6.3-3$ cat makeinstall.txt [ 0%] Built target WebKit2-forwarding-headers [ 1%] Built target WTF [ 1%] Built target LLIntOffsetsExtractor [ 12%] Built target JavaScriptCore [ 13%] Built target ANGLESupport [ 76%] Built target WebCore [ 77%] Built target WebCorePlatformGTK [ 78%] Built target fake-generated-webkitdom-headers [ 84%] Built target GObjectDOMBindings [ 84%] Built target WebKit2-fake-api-headers [ 97%] Built target WebKit2 [ 97%] Built target WebKit2WebExtension-4-gir [ 97%] Built target JavaScriptCore-4-gir [ 97%] Built target WebKit2-4-gir [ 97%] Built target gir [ 97%] Built target jsc [ 98%] Built target WebCorePlatformGTK2 [ 98%] Built target WebCoreTestSupport [ 98%] Built target NetworkProcess [ 98%] Built target PluginProcess Linking CXX executable ../../bin/WebKitPluginProcess2 CMakeFiles/WebKitPluginProcess2.dir/Platform/IPC/Connection.cpp.o: In function `IPC::Connection::createSyncMessageEncoder(IPC::StringReference, IPC::StringReference, unsigned long long, unsigned long long&)': Connection.cpp:(.text+0x324): undefined reference to `__atomic_fetch_add_8' collect2: error: ld returned 1 exit status make[2]: *** [bin/WebKitPluginProcess2] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKitPluginProcess2.dir/all] Error 2 make: *** [all] Error 2 sasa@slack141-314:/tmp/DLG/logs/webkitgtk-2.6.3-3$ I will try to apply also the debian atomic_build_fix.patch to see if with it it builds. 1049746 8 241850 berto 2014-11-19 01:19:50 -0800 Created attachment 241850 Patch (In reply to comment #7) > Linking CXX executable ../../bin/WebKitPluginProcess2 > CMakeFiles/WebKitPluginProcess2.dir/Platform/IPC/Connection.cpp.o: In > function `IPC::Connection::createSyncMessageEncoder(IPC::StringReference, > IPC::StringReference, unsigned long long, unsigned long long&)': > Connection.cpp:(.text+0x324): undefined reference to `__atomic_fetch_add_8' > collect2: error: ld returned 1 exit status Yeah, I think my previous patch was wrong, try this new one. 1049871 9 casaxa 2014-11-19 12:37:39 -0800 @Alberto, many thanks, the build went through with the latest patch. 1050110 10 241940 berto 2014-11-20 04:33:11 -0800 Created attachment 241940 Patch (In reply to comment #9) > @Alberto, many thanks, the build went through with the latest patch. Thanks for confirming it. I reworked it a bit, instead of checking whether libatomic is available, this new patch checks if we actually need it. 1050176 11 casaxa 2014-11-20 10:39:35 -0800 Ok seems reasonable to me. I will try to apply this patch in the next build I do and will advise you if it went through ok. 1050437 12 ajacoutot 2014-11-21 05:38:54 -0800 (In reply to comment #10) > Created attachment 241940 [details] > Patch > > (In reply to comment #9) > > @Alberto, many thanks, the build went through with the latest patch. > > Thanks for confirming it. > > I reworked it a bit, instead of checking whether libatomic is > available, this new patch checks if we actually need it. Hi Alberto. FWIW I tried this patch on OpenBSD/powerpc and it worked great. Thanks. 1050574 13 berto 2014-11-21 15:00:54 -0800 (In reply to comment #12) > Hi Alberto. FWIW I tried this patch on OpenBSD/powerpc and it worked > great. Thanks. Thanks for testing it! 1050845 14 241940 commit-queue 2014-11-24 06:49:24 -0800 Comment on attachment 241940 Patch Clearing flags on attachment: 241940 Committed r176519: <http://trac.webkit.org/changeset/176519> 1050846 15 commit-queue 2014-11-24 06:49:27 -0800 All reviewed patches have been landed. Closing bug. 241773 2014-11-18 02:31:24 -0800 2014-11-19 01:19:50 -0800 Patch atomic.diff text/plain 573 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggOTU0YWEwZS4uZDM5ZWM0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm1HVEsuY21ha2UKQEAgLTQ3Niw2ICs0NzYsMTAgQEAgbGlzdChBUFBFTkQgV2ViS2l0 Ml9MSUJSQVJJRVMKICAgICBXZWJDb3JlUGxhdGZvcm1HVEsKICAgICAke0dUS19VTklYX1BSSU5U X0xJQlJBUklFU30KICkKK2NoZWNrX2xpYnJhcnlfZXhpc3RzKGF0b21pYyBfX2F0b21pY19mZXRj aF9hZGRfOCAiIiBIQVZFX0xJQkFUT01JQykKK2lmIChIQVZFX0xJQkFUT01JQykKKyAgbGlzdChB UFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMgYXRvbWljKQorZW5kaWYoKQogQUREX1dIT0xFX0FSQ0hJ VkVfVE9fTElCUkFSSUVTKFdlYktpdDJfTElCUkFSSUVTKQogCiBzZXQoV2ViS2l0Ml9NQVJTSEFM X0xJU1QgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9ndGsvd2Via2l0Mm1hcnNoYWwubGlz dCkK 241850 2014-11-19 01:19:50 -0800 2014-11-20 04:33:11 -0800 Patch atomic.diff text/plain 508 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dl YktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggOTU0YWEwZS4uM2ViZDU4ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm1HVEsuY21ha2UKQEAgLTQ2Nyw2ICs0NjcsMTEgQEAgbGlzdChBUFBFTkQgTmV0d29y a1Byb2Nlc3NfU09VUkNFUwogICAgIE5ldHdvcmtQcm9jZXNzL0VudHJ5UG9pbnQvdW5peC9OZXR3 b3JrUHJvY2Vzc01haW4uY3BwCiApCiAKK2NoZWNrX2xpYnJhcnlfZXhpc3RzKGF0b21pYyBfX2F0 b21pY19mZXRjaF9hZGRfOCAiIiBIQVZFX0xJQkFUT01JQykKK2lmIChIQVZFX0xJQkFUT01JQykK KyAgbGlzdChBUFBFTkQgV2ViS2l0Ml9MSUJSQVJJRVMgYXRvbWljKQorZW5kaWYoKQorCiBzZXQo U2hhcmVkV2ViS2l0MkxpYnJhcmllcwogICAgICR7V2ViS2l0Ml9MSUJSQVJJRVN9CiApCg== 241940 2014-11-20 04:33:11 -0800 2014-11-24 06:49:24 -0800 Patch 130837.diff text/plain 1355 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyNzU2YWJmLi5hMjRhNDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMTEtMjAgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBXZWJraXQyIGRvZXNudCBidWlsZCBvbiBwb3dlcnBjIDMyIGJpdHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDgzNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIGlmIGxpYmF0b21pYyBp cyBuZWVkZWQgaW4gb3JkZXIgdG8gdXNlIHN0ZDo6YXRvbWljLCBhbmQgYWRkCisgICAgICAgIGl0 IHRvIHRoZSBsaXN0IG9mIFdlYktpdDIgbGlicmFyaWVzLgorCisgICAgICAgICogUGxhdGZvcm1H VEsuY21ha2U6CisKIDIwMTQtMTEtMjAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbR1RLXSBVUlRCRiBhZnRlciByMTc2MzYzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bUdUSy5jbWFrZQppbmRleCA5NTRhYTBlLi4yOThlYzdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdUSy5j bWFrZQpAQCAtNDY3LDYgKzQ2NywxNSBAQCBsaXN0KEFQUEVORCBOZXR3b3JrUHJvY2Vzc19TT1VS Q0VTCiAgICAgTmV0d29ya1Byb2Nlc3MvRW50cnlQb2ludC91bml4L05ldHdvcmtQcm9jZXNzTWFp bi5jcHAKICkKIAorZmlsZShXUklURSAke0NNQUtFX0JJTkFSWV9ESVJ9L3Rlc3RfYXRvbWljLmNw cAorICAgICAiI2luY2x1ZGUgPGF0b21pYz5cbiIKKyAgICAgImludCBtYWluKCkgeyBzdGQ6OmF0 b21pYzxpbnQ2NF90PiBpKDApOyBpKys7IHJldHVybiAwOyB9XG4iKQordHJ5X2NvbXBpbGUoQVRP TUlDX0JVSUxEX1NVQ0NFRURFRCAke0NNQUtFX0JJTkFSWV9ESVJ9ICR7Q01BS0VfQklOQVJZX0RJ Un0vdGVzdF9hdG9taWMuY3BwKQoraWYgKE5PVCBBVE9NSUNfQlVJTERfU1VDQ0VFREVEKQorICAg IGxpc3QoQVBQRU5EIFdlYktpdDJfTElCUkFSSUVTIGF0b21pYykKK2VuZGlmICgpCitmaWxlKFJF TU9WRSAke0NNQUtFX0JJTkFSWV9ESVJ9L3Rlc3RfYXRvbWljLmNwcCkKKwogc2V0KFNoYXJlZFdl YktpdDJMaWJyYXJpZXMKICAgICAke1dlYktpdDJfTElCUkFSSUVTfQogKQo=