130835 2014-03-27 06:17:16 -0700 AX: Returns const reference to static string. 2014-03-27 08:19:44 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 k.czech k.czech aboxhall apinheiro cfleizach commit-queue dmazzoni eric.carlson glenn jcraig jdiggs jer.noble mario philipj samuel_white sergio webkit-bug-importer oldest_to_newest 994902 0 k.czech 2014-03-27 06:17:16 -0700 Avoiding unnecessary copies by returning const reference to static string. 994903 1 webkit-bug-importer 2014-03-27 06:17:39 -0700 <rdar://problem/16443548> 994904 2 227942 k.czech 2014-03-27 06:24:50 -0700 Created attachment 227942 patch 994916 3 227942 commit-queue 2014-03-27 08:05:31 -0700 Comment on attachment 227942 patch Rejecting attachment 227942 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227942, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4872726934192128 994923 4 k.czech 2014-03-27 08:19:44 -0700 Committed r166358: <http://trac.webkit.org/changeset/166358> 227942 2014-03-27 06:24:50 -0700 2014-03-27 08:05:30 -0700 patch a11y-const-reference-to-static-string.patch text/plain 3254 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjI5ZmUxLi43YzZhNzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDMtMjcgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgQVg6IFJldHVybnMgY29uc3QgcmVmZXJlbmNlIHRvIHN0YXRpYyBzdHJpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4MzUKKwor ICAgICAgICBBdm9pZGluZyBzb21lIHVubmVjZXNzYXJ5IGNvcGllcyBieSByZXR1cm5pbmcgY29u c3QgcmVmZXJlbmNlIHRvIHN0YXRpYyBzdHJpbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO byBiZWhhdmlvdXIgY2hhbmdlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5TWVkaWFDb250cm9scy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5TWVk aWFDb250cm9sOjpjb250cm9sVHlwZU5hbWUpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJp bGl0eU1lZGlhQ29udHJvbHNDb250YWluZXI6OmVsZW1lbnRUeXBlTmFtZSk6CisgICAgICAgICog YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVkaWFDb250cm9scy5oOgorCiAyMDE0LTAzLTI2 ICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtd IFV0aWxpemUgbmV3IEF0a1ZhbHVlIGludGVyZmFjZSBjb21pbmcgaW4gQVRLIDIuMTEuOTIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lZGlh Q29udHJvbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 TWVkaWFDb250cm9scy5jcHAKaW5kZXggMDQxN2ExMi4uYTA3MzViNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVkaWFDb250cm9scy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVkaWFDb250 cm9scy5jcHAKQEAgLTgxLDcgKzgxLDcgQEAgTWVkaWFDb250cm9sRWxlbWVudFR5cGUgQWNjZXNz aWJpbGl0eU1lZGlhQ29udHJvbDo6Y29udHJvbFR5cGUoKSBjb25zdAogICAgIHJldHVybiBtZWRp YUNvbnRyb2xFbGVtZW50VHlwZShyZW5kZXJlcigpLT5ub2RlKCkpOwogfQogCi1TdHJpbmcgQWNj ZXNzaWJpbGl0eU1lZGlhQ29udHJvbDo6Y29udHJvbFR5cGVOYW1lKCkgY29uc3QKK2NvbnN0IFN0 cmluZyYgQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbDo6Y29udHJvbFR5cGVOYW1lKCkgY29uc3QK IHsKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiBtZWRpYUVudGVyRnVs bHNjcmVlbkJ1dHRvbk5hbWUoQVNDSUlMaXRlcmFsKCJFbnRlckZ1bGxzY3JlZW5CdXR0b24iKSk7 CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmluZz4gbWVkaWFFeGl0RnVsbHNj cmVlbkJ1dHRvbk5hbWUoQVNDSUlMaXRlcmFsKCJFeGl0RnVsbHNjcmVlbkJ1dHRvbiIpKTsKQEAg LTEzNSw3ICsxMzUsNyBAQCBTdHJpbmcgQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbDo6Y29udHJv bFR5cGVOYW1lKCkgY29uc3QKICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0gICAgcmV0dXJuIFN0 cmluZygpOworICAgIHJldHVybiBudWxsQXRvbTsKIH0KIAogdm9pZCBBY2Nlc3NpYmlsaXR5TWVk aWFDb250cm9sOjphY2Nlc3NpYmlsaXR5VGV4dChWZWN0b3I8QWNjZXNzaWJpbGl0eVRleHQ+JiB0 ZXh0T3JkZXIpCkBAIC0yNDMsNyArMjQzLDcgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5TWVkaWFDb250 cm9sc0NvbnRhaW5lcjo6Y29udHJvbGxpbmdWaWRlb0VsZW1lbnQoKSBjb25zdAogICAgIHJldHVy biAhZWxlbWVudCB8fCBlbGVtZW50LT5pc1ZpZGVvKCk7CiB9CiAKLWNvbnN0IFN0cmluZyBBY2Nl c3NpYmlsaXR5TWVkaWFDb250cm9sc0NvbnRhaW5lcjo6ZWxlbWVudFR5cGVOYW1lKCkgY29uc3QK K2NvbnN0IFN0cmluZyYgQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbHNDb250YWluZXI6OmVsZW1l bnRUeXBlTmFtZSgpIGNvbnN0CiB7CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0 cmluZz4gdmlkZW9FbGVtZW50KEFTQ0lJTGl0ZXJhbCgiVmlkZW9FbGVtZW50IikpOwogICAgIHN0 YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IGF1ZGlvRWxlbWVudChBU0NJSUxpdGVy YWwoIkF1ZGlvRWxlbWVudCIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbHMuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbHMuaAppbmRleCAzMTM2MjhjLi5kMjhm ZmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlNZWRpYUNvbnRyb2xzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5TWVkaWFDb250cm9scy5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKIHByb3Rl Y3RlZDoKICAgICBleHBsaWNpdCBBY2Nlc3NpYmlsaXR5TWVkaWFDb250cm9sKFJlbmRlck9iamVj dCopOwogICAgIE1lZGlhQ29udHJvbEVsZW1lbnRUeXBlIGNvbnRyb2xUeXBlKCkgY29uc3Q7Ci0g ICAgU3RyaW5nIGNvbnRyb2xUeXBlTmFtZSgpIGNvbnN0OworICAgIGNvbnN0IFN0cmluZyYgY29u dHJvbFR5cGVOYW1lKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGNvbXB1dGVBY2Nlc3NpYmls aXR5SXNJZ25vcmVkKCkgY29uc3Qgb3ZlcnJpZGU7CiAKIHByaXZhdGU6CkBAIC05MSw3ICs5MSw3 IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZXhwbGljaXQgQWNjZXNzaWJpbGl0eU1lZGlhQ29u dHJvbHNDb250YWluZXIoUmVuZGVyT2JqZWN0Kik7CiAgICAgYm9vbCBjb250cm9sbGluZ1ZpZGVv RWxlbWVudCgpIGNvbnN0OwotICAgIGNvbnN0IFN0cmluZyBlbGVtZW50VHlwZU5hbWUoKSBjb25z dDsKKyAgICBjb25zdCBTdHJpbmcmIGVsZW1lbnRUeXBlTmFtZSgpIGNvbnN0OwogICAgIHZpcnR1 YWwgYm9vbCBjb21wdXRlQWNjZXNzaWJpbGl0eUlzSWdub3JlZCgpIGNvbnN0IG92ZXJyaWRlOwog fTsKIAo=