130814 2014-03-26 19:28:11 -0700 Rename a delegate method to -webView:didFinishNavigation: 2014-03-26 20:46:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 994793 0 andersca 2014-03-26 19:28:11 -0700 Rename a delegate method to -webView:didFinishNavigation: 994794 1 227911 andersca 2014-03-26 19:28:45 -0700 Created attachment 227911 Patch 994806 2 andersca 2014-03-26 20:46:32 -0700 Committed r166338: <http://trac.webkit.org/changeset/166338> 227911 2014-03-26 19:28:45 -0700 2014-03-26 20:34:01 -0700 Patch bug-130814-20140326192824.patch text/plain 6991 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGEzMDRjOTViNjY1NjIw OTI3NGQzNTNjZDVhOTY3NGJkZjg1YTdlNi4uODRjNzViNDRlNzkwNDQ4MWEzNDMxNzNiMzg4NTNk NzFlOTlkYzNhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAzLTI2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVuYW1lIGEgZGVs ZWdhdGUgbWV0aG9kIHRvIC13ZWJWaWV3OmRpZEZpbmlzaE5hdmlnYXRpb246CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4MTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvV0tOYXZpZ2F0aW9uRGVsZWdhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2 aWdhdGlvblN0YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0 ZS5tbToKKyAgICAgICAgKFdlYktpdDo6TmF2aWdhdGlvblN0YXRlOjpzZXROYXZpZ2F0aW9uRGVs ZWdhdGUpOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6OkxvYWRlckNsaWVudDo6 ZGlkRmluaXNoTG9hZEZvckZyYW1lKToKKworMjAxNC0wMy0yNiAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCAtW1dLV2ViVmlldyBzdG9wTG9hZGlu Z10KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDgx MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2 aWdhdGlvbkRlbGVnYXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL TmF2aWdhdGlvbkRlbGVnYXRlLmgKaW5kZXggNzZmMmY4ZjYzMDJhYzdkYjIyYjg0OTk3YWRkNzdk NDg3MDE0YzZhZS4uNjNlYzUwMzhlNzk5MGMzMDc3OWNjMTM4MzExZWRjMjFmYzFkNDUyMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25E ZWxlZ2F0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZp Z2F0aW9uRGVsZWdhdGUuaApAQCAtNTcsNyArNTcsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRl Z2VyLCBXS05hdmlnYXRpb25SZXNwb25zZVBvbGljeURlY2lzaW9uKSB7CiAKIC0gKHZvaWQpd2Vi VmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRGYWlsUHJvdmlzaW9uYWxOYXZpZ2F0aW9uOihX S05hdmlnYXRpb24gKiluYXZpZ2F0aW9uIHdpdGhFcnJvcjooTlNFcnJvciAqKWVycm9yOwogLSAo dm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZENvbW1pdE5hdmlnYXRpb246KFdL TmF2aWdhdGlvbiAqKW5hdmlnYXRpb247Ci0tICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdl YlZpZXcgZGlkRmluaXNoTG9hZGluZ05hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAqKW5hdmlnYXRp b247CistICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkRmluaXNoTmF2aWdh dGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbjsKIC0gKHZvaWQpd2ViVmlldzooV0tXZWJW aWV3ICopd2ViVmlldyBkaWRGYWlsTmF2aWdhdGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlv biB3aXRoRXJyb3I6KE5TRXJyb3IgKillcnJvcjsKIAogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5oCmluZGV4IGM5NmUzNTM0ZWJlYjc2 MTI0YWM1ZTgwNDdjNmQ5NzQ5Zjk2NDg5N2UuLjA4YWY4NmYwMjZjY2Y3MzBiMjY5MjdiZjUxNWYw M2EwMDY1NmUyY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9O YXZpZ2F0aW9uU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2 aWdhdGlvblN0YXRlLmgKQEAgLTQyLDYgKzQyLDEwIEBACiBAcHJvdG9jb2wgV0tIaXN0b3J5RGVs ZWdhdGVQcml2YXRlOwogQHByb3RvY29sIFdLTmF2aWdhdGlvbkRlbGVnYXRlOwogCitAaW50ZXJm YWNlIE5TT2JqZWN0IChXS05hdmlnYXRpb25EZWxlZ2F0ZVRvQmVSZW1vdmVkKQorLSAodm9pZCl3 ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZEZpbmlzaExvYWRpbmdOYXZpZ2F0aW9uOihX S05hdmlnYXRpb24gKiluYXZpZ2F0aW9uOworQGVuZAorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAog c3RydWN0IFdlYk5hdmlnYXRpb25EYXRhU3RvcmU7CkBAIC0xMjksMTMgKzEzMywxNiBAQCBwcml2 YXRlOgogICAgICAgICBib29sIHdlYlZpZXdEaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQcm92 aXNpb25hbE5hdmlnYXRpb24gOiAxOwogICAgICAgICBib29sIHdlYlZpZXdEaWRGYWlsUHJvdmlz aW9uYWxOYXZpZ2F0aW9uV2l0aEVycm9yIDogMTsKICAgICAgICAgYm9vbCB3ZWJWaWV3RGlkQ29t bWl0TmF2aWdhdGlvbiA6IDE7Ci0gICAgICAgIGJvb2wgd2ViVmlld0RpZEZpbmlzaExvYWRpbmdO YXZpZ2F0aW9uIDogMTsKKyAgICAgICAgYm9vbCB3ZWJWaWV3RGlkRmluaXNoTmF2aWdhdGlvbiA6 IDE7CiAgICAgICAgIGJvb2wgd2ViVmlld0RpZEZhaWxOYXZpZ2F0aW9uV2l0aEVycm9yIDogMTsK IAogICAgICAgICBib29sIHdlYlZpZXdSZW5kZXJpbmdQcm9ncmVzc0RpZENoYW5nZSA6IDE7CiAg ICAgICAgIGJvb2wgd2ViVmlld0NhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2Ug OiAxOwogICAgICAgICBib29sIHdlYlZpZXdEaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVu Z2UgOiAxOwogICAgICAgICBib29sIHdlYlZpZXdXZWJQcm9jZXNzRGlkQ3Jhc2ggOiAxOworCisg ICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBvbmNlIG5vIGNsaWVudHMgZGVwZW5kIG9uIGl0 IGJlaW5nIGNhbGxlZC4KKyAgICAgICAgYm9vbCB3ZWJWaWV3RGlkRmluaXNoTG9hZGluZ05hdmln YXRpb24gOiAxOwogICAgIH0gbV9uYXZpZ2F0aW9uRGVsZWdhdGVNZXRob2RzOwogCiAgICAgSGFz aE1hcDx1aW50NjRfdCwgUmV0YWluUHRyPFdLTmF2aWdhdGlvbj4+IG1fbmF2aWdhdGlvbnM7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRl Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQpp bmRleCAxNGNlYmQwNzQ2Mzc3ZjZhMWRjMzU5NmYyZGE3MzM4MDEzZjM4ODYxLi5jYzZmNjEzNGYy MjhhMGJlMzM0NDFiYzBmNTcyOGFmMDE3MzhkNGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0KQEAgLTExMiwxMyArMTEyLDE2IEBA IHZvaWQgTmF2aWdhdGlvblN0YXRlOjpzZXROYXZpZ2F0aW9uRGVsZWdhdGUoaWQgPFdLTmF2aWdh dGlvbkRlbGVnYXRlPiBkZWxlZ2F0ZSkKICAgICBtX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMu d2ViVmlld0RpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZvclByb3Zpc2lvbmFsTmF2aWdhdGlvbiA9 IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHdlYlZpZXc6ZGlkUmVjZWl2 ZVNlcnZlclJlZGlyZWN0Rm9yUHJvdmlzaW9uYWxOYXZpZ2F0aW9uOildOwogICAgIG1fbmF2aWdh dGlvbkRlbGVnYXRlTWV0aG9kcy53ZWJWaWV3RGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlvbldp dGhFcnJvciA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHdlYlZpZXc6 ZGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlvbjp3aXRoRXJyb3I6KV07CiAgICAgbV9uYXZpZ2F0 aW9uRGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWRDb21taXROYXZpZ2F0aW9uID0gW2RlbGVnYXRl IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Iod2ViVmlldzpkaWRDb21taXROYXZpZ2F0aW9u OildOwotICAgIG1fbmF2aWdhdGlvbkRlbGVnYXRlTWV0aG9kcy53ZWJWaWV3RGlkRmluaXNoTG9h ZGluZ05hdmlnYXRpb24gPSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcih3 ZWJWaWV3OmRpZEZpbmlzaExvYWRpbmdOYXZpZ2F0aW9uOildOworICAgIG1fbmF2aWdhdGlvbkRl bGVnYXRlTWV0aG9kcy53ZWJWaWV3RGlkRmluaXNoTmF2aWdhdGlvbiA9IFtkZWxlZ2F0ZSByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHdlYlZpZXc6ZGlkRmluaXNoTmF2aWdhdGlvbjopXTsK ICAgICBtX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RpZEZhaWxOYXZpZ2F0aW9u V2l0aEVycm9yID0gW2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Iod2ViVmll dzpkaWRGYWlsTmF2aWdhdGlvbjp3aXRoRXJyb3I6KV07CiAKICAgICBtX25hdmlnYXRpb25EZWxl Z2F0ZU1ldGhvZHMud2ViVmlld1JlbmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdlID0gW2RlbGVnYXRl IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6cmVuZGVyaW5nUHJvZ3Jlc3NE aWRDaGFuZ2U6KV07CiAgICAgbV9uYXZpZ2F0aW9uRGVsZWdhdGVNZXRob2RzLndlYlZpZXdDYW5B dXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlID0gW2RlbGVnYXRlIHJlc3BvbmRzVG9T ZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6Y2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rp b25TcGFjZTopXTsKICAgICBtX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RpZFJl Y2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0 b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTop XTsKICAgICBtX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMud2ViVmlld1dlYlByb2Nlc3NEaWRD cmFzaCA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3V2Vi UHJvY2Vzc0RpZENyYXNoOildOworCisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ugbm8g Y2xpZW50cyBkZXBlbmQgb24gaXQgYmVpbmcgY2FsbGVkLgorICAgIG1fbmF2aWdhdGlvbkRlbGVn YXRlTWV0aG9kcy53ZWJWaWV3RGlkRmluaXNoTG9hZGluZ05hdmlnYXRpb24gPSBbZGVsZWdhdGUg cmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcih3ZWJWaWV3OmRpZEZpbmlzaExvYWRpbmdOYXZp Z2F0aW9uOildOwogfQogCiBSZXRhaW5QdHI8aWQgPFdLSGlzdG9yeURlbGVnYXRlUHJpdmF0ZT4g PiBOYXZpZ2F0aW9uU3RhdGU6Omhpc3RvcnlEZWxlZ2F0ZSgpCkBAIC00MTAsNyArNDEzLDcgQEAg dm9pZCBOYXZpZ2F0aW9uU3RhdGU6OkxvYWRlckNsaWVudDo6ZGlkRmluaXNoTG9hZEZvckZyYW1l KFdlYlBhZ2VQcm94eSosIFdlYkZyYW0KICAgICBpZiAoIXdlYkZyYW1lUHJveHktPmlzTWFpbkZy YW1lKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghbV9uYXZpZ2F0aW9uU3RhdGUubV9u YXZpZ2F0aW9uRGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWRGaW5pc2hMb2FkaW5nTmF2aWdhdGlv bikKKyAgICBpZiAoIW1fbmF2aWdhdGlvblN0YXRlLm1fbmF2aWdhdGlvbkRlbGVnYXRlTWV0aG9k cy53ZWJWaWV3RGlkRmluaXNoTmF2aWdhdGlvbiAmJiAhbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZp Z2F0aW9uRGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWRGaW5pc2hMb2FkaW5nTmF2aWdhdGlvbikK ICAgICAgICAgcmV0dXJuOwogCiAgICAgYXV0byBuYXZpZ2F0aW9uRGVsZWdhdGUgPSBtX25hdmln YXRpb25TdGF0ZS5tX25hdmlnYXRpb25EZWxlZ2F0ZS5nZXQoKTsKQEAgLTQyMiw3ICs0MjUsMTMg QEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6OkxvYWRlckNsaWVudDo6ZGlkRmluaXNoTG9hZEZvckZy YW1lKFdlYlBhZ2VQcm94eSosIFdlYkZyYW0KICAgICBpZiAobmF2aWdhdGlvbklEKQogICAgICAg ICBuYXZpZ2F0aW9uID0gbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9ucy5nZXQobmF2aWdh dGlvbklEKS5nZXQoKTsKIAotICAgIFtuYXZpZ2F0aW9uRGVsZWdhdGUgd2ViVmlldzptX25hdmln YXRpb25TdGF0ZS5tX3dlYlZpZXcgZGlkRmluaXNoTG9hZGluZ05hdmlnYXRpb246bmF2aWdhdGlv bl07CisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ugbm8gY2xpZW50cyBkZXBlbmQgb24g aXQgYmVpbmcgY2FsbGVkLgorICAgIGlmIChtX25hdmlnYXRpb25TdGF0ZS5tX25hdmlnYXRpb25E ZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RpZEZpbmlzaExvYWRpbmdOYXZpZ2F0aW9uKSB7CisgICAg ICAgIFtzdGF0aWNfY2FzdDxpZD4obmF2aWdhdGlvbkRlbGVnYXRlKSB3ZWJWaWV3Om1fbmF2aWdh dGlvblN0YXRlLm1fd2ViVmlldyBkaWRGaW5pc2hMb2FkaW5nTmF2aWdhdGlvbjpuYXZpZ2F0aW9u XTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIFtuYXZpZ2F0aW9uRGVsZWdhdGUgd2Vi VmlldzptX25hdmlnYXRpb25TdGF0ZS5tX3dlYlZpZXcgZGlkRmluaXNoTmF2aWdhdGlvbjpuYXZp Z2F0aW9uXTsKIH0KIAogdm9pZCBOYXZpZ2F0aW9uU3RhdGU6OkxvYWRlckNsaWVudDo6ZGlkRmFp bExvYWRXaXRoRXJyb3JGb3JGcmFtZShXZWJQYWdlUHJveHkqLCBXZWJGcmFtZVByb3h5KiB3ZWJG cmFtZVByb3h5LCB1aW50NjRfdCBuYXZpZ2F0aW9uSUQsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNl RXJyb3ImIGVycm9yLCBBUEk6Ok9iamVjdCogdXNlckRhdGEpCg==