130810 2014-03-26 18:35:10 -0700 Assertion failure in RemoteLayerBackingStore::flush 2014-03-26 18:49:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton mark.lam simon.fraser oldest_to_newest 994776 0 thorton 2014-03-26 18:35:10 -0700 We don't always have backing store to flush, if platformCALayerDrawsContent() is false. We also can't assert that we have a back surface, because the very first paint will not. <rdar://problem/16439276> 994777 1 227906 thorton 2014-03-26 18:37:29 -0700 Created attachment 227906 patch needs testing before landing, though (waiting for debug build) 994784 2 thorton 2014-03-26 18:49:04 -0700 http://trac.webkit.org/changeset/166331 227906 2014-03-26 18:37:29 -0700 2014-03-26 18:39:21 -0700 patch flush2.diff text/plain 2124 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NjlkYTVlLi4wMzY4MzAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDMtMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmU6OmZs dXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4 MTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NDM5Mjc2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL21hYy9SZW1vdGVMYXllckJh Y2tpbmdTdG9yZS5tbToKKyAgICAgICAgKFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjpmbHVzaCk6 CisgICAgICAgIFdlIGRvbid0IGFsd2F5cyBoYXZlIGJhY2tpbmcgc3RvcmUgdG8gZmx1c2gsIGlm IHBsYXRmb3JtQ0FMYXllckRyYXdzQ29udGVudCgpIGlzIGZhbHNlLgorICAgICAgICBXZSBhbHNv IGNhbid0IGFzc2VydCB0aGF0IHdlIGhhdmUgYSBiYWNrIHN1cmZhY2UsIGJlY2F1c2UgdGhlIHZl cnkgZmlyc3QgcGFpbnQgd2lsbCBub3QuCisKIDIwMTQtMDMtMjYgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgY3VzdG9tIGJlaGF2aW9yIGZs YWcgdG8gR3JhcGhpY3NMYXllciwgcGlwZWQgZG93biB0byBQbGF0Zm9ybUNBTGF5ZXIsIGZvciBz Y3JvbGxpbmcgbGF5ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1Jl bW90ZUxheWVyQmFja2luZ1N0b3JlLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1v dGVMYXllckJhY2tpbmdTdG9yZS5tbQppbmRleCBhZTc0ZmU5Li40ZTljMjRhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1JlbW90ZUxheWVyQmFja2luZ1N0b3JlLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmUubW0K QEAgLTMzMSwxNyArMzMxLDIwIEBAIHZvaWQgUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmU6OmZsdXNo KCkKIHsKICNpZiBVU0UoSU9TVVJGQUNFKQogICAgIGlmIChhY2NlbGVyYXRlc0RyYXdpbmcoKSkg ewotICAgICAgICBDR0NvbnRleHRSZWYgcGxhdGZvcm1Db250ZXh0ID0gbV9mcm9udFN1cmZhY2Ut PnBsYXRmb3JtQ29udGV4dCgpOwotICAgICAgICBBU1NFUlQocGxhdGZvcm1Db250ZXh0KTsKLSAg ICAgICAgQVNTRVJUKG1fYmFja1N1cmZhY2VQZW5kaW5nRmx1c2gpOwotICAgICAgICBDR0NvbnRl eHRGbHVzaChwbGF0Zm9ybUNvbnRleHQpOwotICAgICAgICBtX2JhY2tTdXJmYWNlUGVuZGluZ0Zs dXNoID0gbnVsbHB0cjsKKyAgICAgICAgaWYgKG1fZnJvbnRTdXJmYWNlKSB7CisgICAgICAgICAg ICBDR0NvbnRleHRSZWYgcGxhdGZvcm1Db250ZXh0ID0gbV9mcm9udFN1cmZhY2UtPnBsYXRmb3Jt Q29udGV4dCgpOworICAgICAgICAgICAgQVNTRVJUKHBsYXRmb3JtQ29udGV4dCk7CisgICAgICAg ICAgICBDR0NvbnRleHRGbHVzaChwbGF0Zm9ybUNvbnRleHQpOworICAgICAgICAgICAgbV9iYWNr U3VyZmFjZVBlbmRpbmdGbHVzaCA9IG51bGxwdHI7CisgICAgICAgIH0KICAgICAgICAgcmV0dXJu OwogICAgIH0KICNlbmRpZgogCiAgICAgQVNTRVJUKCFhY2NlbGVyYXRlc0RyYXdpbmcoKSk7Ci0g ICAgQVNTRVJUKG1fYnVmZmVyQ29udGV4dFBlbmRpbmdGbHVzaCk7Ci0gICAgQ0dDb250ZXh0Rmx1 c2gobV9idWZmZXJDb250ZXh0UGVuZGluZ0ZsdXNoLmdldCgpKTsKLSAgICBtX2J1ZmZlckNvbnRl eHRQZW5kaW5nRmx1c2ggPSBudWxscHRyOworCisgICAgaWYgKG1fYnVmZmVyQ29udGV4dFBlbmRp bmdGbHVzaCkgeworICAgICAgICBDR0NvbnRleHRGbHVzaChtX2J1ZmZlckNvbnRleHRQZW5kaW5n Rmx1c2guZ2V0KCkpOworICAgICAgICBtX2J1ZmZlckNvbnRleHRQZW5kaW5nRmx1c2ggPSBudWxs cHRyOworICAgIH0KIH0K