130804 2014-03-26 16:11:10 -0700 -[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values 2014-03-26 16:36:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 cjk webkit-unassigned commit-queue oldest_to_newest 994738 0 cjk 2014-03-26 16:11:10 -0700 -[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values. The existing implementations of these methods are mis-cased ("HTMLInputELementIsUserEdited" and "HTMLTextAreaELementIsUserEdited" — note the "EL" in both cases). This results in us getting auto-synthesized getters for the HTMLInputElementIsUserEdited and HTMLTextAreaElementIsUserEdited properties, which will return NO unconditionally. 994739 1 227895 cjk 2014-03-26 16:15:08 -0700 Created attachment 227895 patch 994742 2 227895 commit-queue 2014-03-26 16:36:06 -0700 Comment on attachment 227895 patch Clearing flags on attachment: 227895 Committed r166326: <http://trac.webkit.org/changeset/166326> 994743 3 commit-queue 2014-03-26 16:36:08 -0700 All reviewed patches have been landed. Closing bug. 227895 2014-03-26 16:15:08 -0700 2014-03-26 16:36:06 -0700 patch 0001-WKWebProcessPlugInNodeHandle-HTMLInputElementIsUserE.patch text/plain 3181 cjk RnJvbSBiMjM2NmJlZWI0OWFlZmY2YWY1ZjY4ZTBhMTVmYjI1YjJlNzBmZmM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDb2R5IEtyaWVnZXIgPGNqa0BhcHBsZS5jb20+CkRhdGU6IFdl ZCwgMjYgTWFyIDIwMTQgMTU6NDk6MDEgLTA3MDAKU3ViamVjdDogW1BBVENIXSAtW1dLV2ViUHJv Y2Vzc1BsdWdJbk5vZGVIYW5kbGUgSFRNTElucHV0RWxlbWVudElzVXNlckVkaXRlZF0KIGFuZCAt SFRNTFRleHRBcmVhRWxlbWVudElzVXNlckVkaXRlZCBkbyBub3QgcmV0dXJuIHRoZSBjb3JyZWN0 IHZhbHVlcy4KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCmh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA4MDQKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKVGhlIGV4aXN0aW5nIGltcGxlbWVudGF0aW9ucyBvZiB0aGVzZSBtZXRob2RzIGFyZSBt aXMtY2FzZWQKKCJIVE1MSW5wdXRFTGVtZW50SXNVc2VyRWRpdGVkIiBhbmQgIkhUTUxUZXh0QXJl YUVMZW1lbnRJc1VzZXJFZGl0ZWQiIOKAlApub3RlIHRoZSAiRUwiIGluIGJvdGggY2FzZXMpLiBU aGlzIHJlc3VsdHMgaW4gdXMgZ2V0dGluZwphdXRvLXN5bnRoZXNpemVkIGdldHRlcnMgZm9yIHRo ZSBIVE1MSW5wdXRFbGVtZW50SXNVc2VyRWRpdGVkIGFuZApIVE1MVGV4dEFyZWFFbGVtZW50SXNV c2VyRWRpdGVkIHByb3BlcnRpZXMsIHdoaWNoIHdpbGwgcmV0dXJuIE5PCnVuY29uZGl0aW9uYWxs eS4KCiogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1 Z0luTm9kZUhhbmRsZS5tbToKRml4IHRoZSBjYXBpdGFsaXphdGlvbiBvZiAtSFRNTElucHV0RWxl bWVudElzVXNlckVkaXRlZCBhbmQKLUhUTUxUZXh0QXJlYUVsZW1lbnRJc1VzZXJFZGl0ZWQuCi0t LQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAxOSArKysrKysrKysrKysrKysrKysrCiAuLi4vQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJ bk5vZGVIYW5kbGUubW0gICAgICAgICB8ICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQyNmY4MS4uZDQwZWI2 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAzLTI2ICBDb2R5IEtyaWVnZXIg IDxjamtAYXBwbGUuY29tPgorCisgICAgICAgIC1bV0tXZWJQcm9jZXNzUGx1Z0luTm9kZUhhbmRs ZSBIVE1MSW5wdXRFbGVtZW50SXNVc2VyRWRpdGVkXSBhbmQgLUhUTUxUZXh0QXJlYUVsZW1lbnRJ c1VzZXJFZGl0ZWQgZG8gbm90IHJldHVybiB0aGUgY29ycmVjdCB2YWx1ZXMuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDgwNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBleGlzdGluZyBpbXBs ZW1lbnRhdGlvbnMgb2YgdGhlc2UgbWV0aG9kcyBhcmUgbWlzLWNhc2VkCisgICAgICAgICgiSFRN TElucHV0RUxlbWVudElzVXNlckVkaXRlZCIgYW5kICJIVE1MVGV4dEFyZWFFTGVtZW50SXNVc2Vy RWRpdGVkIiDigJQKKyAgICAgICAgbm90ZSB0aGUgIkVMIiBpbiBib3RoIGNhc2VzKS4gVGhpcyBy ZXN1bHRzIGluIHVzIGdldHRpbmcKKyAgICAgICAgYXV0by1zeW50aGVzaXplZCBnZXR0ZXJzIGZv ciB0aGUgSFRNTElucHV0RWxlbWVudElzVXNlckVkaXRlZCBhbmQKKyAgICAgICAgSFRNTFRleHRB cmVhRWxlbWVudElzVXNlckVkaXRlZCBwcm9wZXJ0aWVzLCB3aGljaCB3aWxsIHJldHVybiBOTwor ICAgICAgICB1bmNvbmRpdGlvbmFsbHkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVk QnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5Ob2RlSGFuZGxlLm1tOgorICAgICAg ICBGaXggdGhlIGNhcGl0YWxpemF0aW9uIG9mIC1IVE1MSW5wdXRFbGVtZW50SXNVc2VyRWRpdGVk IGFuZAorICAgICAgICAtSFRNTFRleHRBcmVhRWxlbWVudElzVXNlckVkaXRlZC4KKwogMjAxNC0w My0yNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBF eHBvc2UgRG93bmxvYWRQcm94eTo6Y2FuY2VsKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbk5v ZGVIYW5kbGUubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ SS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5Ob2RlSGFuZGxlLm1tCmluZGV4IGYzOTk5Y2QuLjFi M2Q1YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUubW0KKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNz UGx1Z0luTm9kZUhhbmRsZS5tbQpAQCAtNzgsMTIgKzc4LDEyIEBAIC0gKHZvaWQpc2V0SFRNTElu cHV0RWxlbWVudElzQXV0b0ZpbGxlZDooQk9PTClpc0F1dG9GaWxsZWQKICAgICBfbm9kZUhhbmRs ZS0+c2V0SFRNTElucHV0RWxlbWVudEF1dG9maWxsZWQoaXNBdXRvRmlsbGVkKTsKIH0KIAotLSAo Qk9PTClIVE1MSW5wdXRFTGVtZW50SXNVc2VyRWRpdGVkCistIChCT09MKUhUTUxJbnB1dEVsZW1l bnRJc1VzZXJFZGl0ZWQKIHsKICAgICByZXR1cm4gX25vZGVIYW5kbGUtPmh0bWxJbnB1dEVsZW1l bnRMYXN0Q2hhbmdlV2FzVXNlckVkaXQoKTsKIH0KIAotLSAoQk9PTClIVE1MVGV4dEFyZWFFTGVt ZW50SXNVc2VyRWRpdGVkCistIChCT09MKUhUTUxUZXh0QXJlYUVsZW1lbnRJc1VzZXJFZGl0ZWQK IHsKICAgICByZXR1cm4gX25vZGVIYW5kbGUtPmh0bWxUZXh0QXJlYUVsZW1lbnRMYXN0Q2hhbmdl V2FzVXNlckVkaXQoKTsKIH0KLS0gCjEuOC41LjIgKEFwcGxlIEdpdC00OCkKCg==