<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>130798</bug_id>
          
          <creation_ts>2014-03-26 14:15:14 -0700</creation_ts>
          <short_desc>Device scale factor should always be greater than 0.</short_desc>
          <delta_ts>2014-03-26 15:43:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="alan">zalan</reporter>
          <assigned_to name="alan">zalan</assigned_to>
          <cc>ddkilzer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>994707</commentid>
    <comment_count>0</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2014-03-26 14:15:14 -0700</bug_when>
    <thetext>Scale factor values in general can go 0 or even to negative, but device scale factor is about device pixel/CSS pixel ratio. It makes hardly any sense to have that as 0 or negative.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994729</commentid>
    <comment_count>1</comment_count>
      <attachid>227892</attachid>
    <who name="alan">zalan</who>
    <bug_when>2014-03-26 15:33:48 -0700</bug_when>
    <thetext>Created attachment 227892
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994730</commentid>
    <comment_count>2</comment_count>
      <attachid>227892</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2014-03-26 15:36:01 -0700</bug_when>
    <thetext>Comment on attachment 227892
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994731</commentid>
    <comment_count>3</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2014-03-26 15:36:38 -0700</bug_when>
    <thetext>&lt;rdar://problem/16293570&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>994735</commentid>
    <comment_count>4</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2014-03-26 15:43:46 -0700</bug_when>
    <thetext>Committed r166323: &lt;http://trac.webkit.org/changeset/166323&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227892</attachid>
            <date>2014-03-26 15:33:48 -0700</date>
            <delta_ts>2014-03-26 15:36:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-130798-20140326153328.patch</filename>
            <type>text/plain</type>
            <size>1406</size>
            <attacher name="alan">zalan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBlMTE4MWNiM2MyNjgz
NmJhYzA2Y2E2YmMyZDgzM2U5MzMyODE5Zi4uMGJkM2I0NDJlNzAxYmZjODk1MDY2MzQ5YzJjNTdk
ODYxNTgxNTUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAzLTI2ICBaYWxh
biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgRGV2aWNlIHNjYWxlIGZhY3Rv
ciBzaG91bGQgYWx3YXlzIGJlIGdyZWF0ZXIgdGhhbiAwLgorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyaW5nIGNvbnRleHQgcmVxdWlyZXMgYSBk
ZXZpY2Ugc2NhbGUgZmFjdG9yID4gMCBzbyB0aGF0IHdlIGNhbiBtYXAgQ1NTIHBpeGVscworICAg
ICAgICB0byBkZXZpY2UgcGl4ZWxzIHByb3Blcmx5LiBOZWl0aGVyIDAgbm9yIGEgbmVnYXRpdmUg
ZGV2aWNlIHBpeGVsIHJhdGlvIGFyZSBjb25zaWRlcmVkIHRvIGJlIHZhbGlkLgorCisgICAgICAg
ICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNldERldmljZVNjYWxl
RmFjdG9yKToKKwogMjAxNC0wMy0yNiAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+
CiAKICAgICAgICAgSW1wbGVtZW50IGhhc0xpdmVTdHJlYW1pbmdDb250ZW50IHByb3BlcnR5IGlu
IFdlYkFWUGxheWVyQ29udHJvbGxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Q
YWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggYjNiMTU4OThlNTg1
OTFkYjMxZmZmZDZkMDE5NzBkYWJjZTZlMGYzZC4uZjgzY2IxNDJhNjZhYTgwZmYzYmVkNGNiOTEx
M2IzMDgwNjc2ZTUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC03MzQsNiArNzM0LDEwIEBAIHZv
aWQgUGFnZTo6c2V0UGFnZVNjYWxlRmFjdG9yKGZsb2F0IHNjYWxlLCBjb25zdCBJbnRQb2ludCYg
b3JpZ2luKQogCiB2b2lkIFBhZ2U6OnNldERldmljZVNjYWxlRmFjdG9yKGZsb2F0IHNjYWxlRmFj
dG9yKQogeworICAgIEFTU0VSVChzY2FsZUZhY3RvciA+IDApOworICAgIGlmIChzY2FsZUZhY3Rv
ciA8PSAwKQorICAgICAgICByZXR1cm47CisgICAgCiAgICAgaWYgKG1fZGV2aWNlU2NhbGVGYWN0
b3IgPT0gc2NhbGVGYWN0b3IpCiAgICAgICAgIHJldHVybjsKIAo=
</data>
<flag name="review"
          id="252141"
          type_id="1"
          status="+"
          setter="ddkilzer"
    />
          </attachment>
      

    </bug>

</bugzilla>