130787 2014-03-26 12:02:23 -0700 Adopt DTPerformanceSession logging for WebKit2 IPC messages 2014-03-26 12:04:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 thorton webkit-unassigned andersca sam simon.fraser oldest_to_newest 994661 0 thorton 2014-03-26 12:02:23 -0700 To allow them to show up as flags (for sent messages) and flagged ranges (for dispatch of incoming messages) in Instruments, which can be useful for a variety of reasons (quickly noticing unneeded or expensive messages, making sense of profiles, etc.) No idea how to do this in a good way, but I hacked up a POC quickly. 994664 1 227870 thorton 2014-03-26 12:04:15 -0700 Created attachment 227870 hacky poc 227870 2014-03-26 12:04:15 -0700 2014-03-26 12:04:15 -0700 hacky poc logging.diff text/plain 4107 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL0Jhc2VUYXJnZXQueGNj b25maWcgYi9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9CYXNlVGFyZ2V0LnhjY29uZmln CmluZGV4IGNhNDNmOTAuLjM1MzMxZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NvbmZp Z3VyYXRpb25zL0Jhc2VUYXJnZXQueGNjb25maWcKKysrIGIvU291cmNlL1dlYktpdDIvQ29uZmln dXJhdGlvbnMvQmFzZVRhcmdldC54Y2NvbmZpZwpAQCAtMjQsNyArMjQsNyBAQAogI2luY2x1ZGUg IkZlYXR1cmVEZWZpbmVzLnhjY29uZmlnIgogI2luY2x1ZGUgIlZlcnNpb24ueGNjb25maWciCiAK LUZSQU1FV09SS19TRUFSQ0hfUEFUSFMgPSAkKFVNQlJFTExBX0ZSQU1FV09SS1NfRElSKSAkKEZS QU1FV09SS19TRUFSQ0hfUEFUSFMpOworRlJBTUVXT1JLX1NFQVJDSF9QQVRIUyA9ICQoVU1CUkVM TEFfRlJBTUVXT1JLU19ESVIpIC9BcHBsaWNhdGlvbnMvWGNvZGUuYXBwL0NvbnRlbnRzL0RldmVs b3Blci9MaWJyYXJ5L0ZyYW1ld29ya3MgJChGUkFNRVdPUktfU0VBUkNIX1BBVEhTKTsKIEdDQ19Q UkVGSVhfSEVBREVSID0gV2ViS2l0MlByZWZpeC5oOwogR0NDX1BSRVBST0NFU1NPUl9ERUZJTklU SU9OUyA9ICQoREVCVUdfREVGSU5FUykgJChGRUFUVVJFX0RFRklORVMpIEZSQU1FV09SS19OQU1F PVdlYktpdDIKIEhFQURFUl9TRUFSQ0hfUEFUSFMgPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikvdXNy L2xvY2FsL2luY2x1ZGUgJChXRUJDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIpL0ZvcndhcmRpbmdI ZWFkZXJzICQoV0VCQ09SRV9QUklWQVRFX0hFQURFUlNfRElSKS9pY3UgJChCVUlMVF9QUk9EVUNU U19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdDIgJChIRUFERVJfU0VBUkNIX1BBVEhTKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcAppbmRleCA3NGRjOTgwLi40 ZjMyOGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlv bi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCkBA IC0zMyw2ICszMyw4IEBACiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAjaW5jbHVk ZSA8d3RmL3RocmVhZHMvQmluYXJ5U2VtYXBob3JlLmg+CiAKKyNpbmNsdWRlIDxEVFBlcmZvcm1h bmNlU2Vzc2lvbi9EVFNpZ25hbEZsYWcuaD4KKwogbmFtZXNwYWNlIElQQyB7CiAKIGNsYXNzIENv bm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGUgOiBwdWJsaWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8 Q29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZT4gewpAQCAtMzU0LDExICszNTYsMTcgQEAgYm9v bCBDb25uZWN0aW9uOjpzZW5kTWVzc2FnZShzdGQ6OnVuaXF1ZV9wdHI8TWVzc2FnZUVuY29kZXI+ IGVuY29kZXIsIHVuc2lnbmVkIG0KICAgICAgICAgICAgIHx8IG1faW5EaXNwYXRjaE1lc3NhZ2VN YXJrZWREaXNwYXRjaFdoZW5XYWl0aW5nRm9yU3luY1JlcGx5Q291bnQpKQogICAgICAgICBlbmNv ZGVyLT5zZXRTaG91bGREaXNwYXRjaE1lc3NhZ2VXaGVuV2FpdGluZ0ZvclN5bmNSZXBseSh0cnVl KTsKIAorICAgIGlmIChlbmNvZGVyICYmIGVuY29kZXItPm1lc3NhZ2VOYW1lKCkpCisgICAgICAg IERUU2VuZFNpZ25hbEZsYWcoZW5jb2Rlci0+bWVzc2FnZU5hbWUoKSwgRFRfUE9JTlRfU0lHTkFM LCB0cnVlKTsKKyAgICBlbHNlCisgICAgICAgIERUU2VuZFNpZ25hbEZsYWcoInVubmFtZWQgbWVz c2FnZSIsIERUX1BPSU5UX1NJR05BTCwgdHJ1ZSk7CisKKwogICAgIHsKICAgICAgICAgTXV0ZXhM b2NrZXIgbG9ja2VyKG1fb3V0Z29pbmdNZXNzYWdlc0xvY2spOwogICAgICAgICBtX291dGdvaW5n TWVzc2FnZXMuYXBwZW5kKHN0ZDo6bW92ZShlbmNvZGVyKSk7CiAgICAgfQotICAgIAorCiAgICAg Ly8gRklYTUU6IFdlIHNob3VsZCBhZGQgYSBib29sZWFuIGZsYWcgc28gd2UgZG9uJ3QgY2FsbCB0 aGlzIHdoZW4gd29yayBoYXMgYWxyZWFkeSBiZWVuIHNjaGVkdWxlZC4KICAgICBtX2Nvbm5lY3Rp b25RdWV1ZS0+ZGlzcGF0Y2goV1RGOjpiaW5kKCZDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNz YWdlcywgdGhpcykpOwogICAgIHJldHVybiB0cnVlOwpAQCAtNzY3LDcgKzc3NSw5IEBAIHZvaWQg Q29ubmVjdGlvbjo6ZW5xdWV1ZUluY29taW5nTWVzc2FnZShzdGQ6OnVuaXF1ZV9wdHI8TWVzc2Fn ZURlY29kZXI+IGluY29taW5nCiAKIHZvaWQgQ29ubmVjdGlvbjo6ZGlzcGF0Y2hNZXNzYWdlKE1l c3NhZ2VEZWNvZGVyJiBkZWNvZGVyKQogeworICAgIERUU2VuZFNpZ25hbEZsYWcoZGVjb2Rlci5t ZXNzYWdlTmFtZSgpLmRhdGEoKSwgRFRfU1RBUlRfU0lHTkFMLCB0cnVlKTsKICAgICBtX2NsaWVu dC0+ZGlkUmVjZWl2ZU1lc3NhZ2UodGhpcywgZGVjb2Rlcik7CisgICAgRFRTZW5kU2lnbmFsRmxh ZyhkZWNvZGVyLm1lc3NhZ2VOYW1lKCkuZGF0YSgpLCBEVF9FTkRfU0lHTkFMLCB0cnVlKTsKIH0K IAogdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1lc3Nh Z2VEZWNvZGVyPiBtZXNzYWdlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v SVBDL01lc3NhZ2VFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9NZXNz YWdlRW5jb2Rlci5jcHAKaW5kZXggZDJlNGVmZS4uZDk2MWIyYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vSVBDL01lc3NhZ2VFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9JUEMvTWVzc2FnZUVuY29kZXIuY3BwCkBAIC0zOCw2ICszOCw4IEBAIE1l c3NhZ2VFbmNvZGVyOjpNZXNzYWdlRW5jb2RlcihTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZVJlY2Vp dmVyTmFtZSwgU3RyaW5nUmVmZXJlCiB7CiAgICAgQVNTRVJUKCFtZXNzYWdlUmVjZWl2ZXJOYW1l LmlzRW1wdHkoKSk7CiAKKyAgICBtX21lc3NhZ2VOYW1lID0gc3RyZHVwKG1lc3NhZ2VOYW1lLmRh dGEoKSk7IC8vIG9idmlvdXNseSBsZWFrczsgd2UgY2FuIHNhdmUgdGhlIFN0cmluZ1JlZmVyZW5j ZSwgSSBqdXN0IG1hZGUgYSBtaXN0YWtlIGFuZCB0aG91Z2h0IHdlIGNvdWxkbid0CisKICAgICAq dGhpcyA8PCBkZWZhdWx0TWVzc2FnZUZsYWdzOwogICAgICp0aGlzIDw8IG1lc3NhZ2VSZWNlaXZl ck5hbWU7CiAgICAgKnRoaXMgPDwgbWVzc2FnZU5hbWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9JUEMvTWVzc2FnZUVuY29kZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0lQQy9NZXNzYWdlRW5jb2Rlci5oCmluZGV4IDUyNGU1ZTEuLmIwNzg5OTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9NZXNzYWdlRW5jb2Rlci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9NZXNzYWdlRW5jb2Rlci5oCkBAIC0yOCwxMSArMjgs MTAgQEAKIAogI2luY2x1ZGUgIkFyZ3VtZW50RW5jb2Rlci5oIgogI2luY2x1ZGUgPHd0Zi9Gb3J3 YXJkLmg+CisjaW5jbHVkZSAiU3RyaW5nUmVmZXJlbmNlLmgiCiAKIG5hbWVzcGFjZSBJUEMgewog Ci1jbGFzcyBTdHJpbmdSZWZlcmVuY2U7Ci0KIGNsYXNzIE1lc3NhZ2VFbmNvZGVyIDogcHVibGlj IEFyZ3VtZW50RW5jb2RlciB7CiBwdWJsaWM6CiAgICAgTWVzc2FnZUVuY29kZXIoU3RyaW5nUmVm ZXJlbmNlIG1lc3NhZ2VSZWNlaXZlck5hbWUsIFN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlTmFtZSwg dWludDY0X3QgZGVzdGluYXRpb25JRCk7CkBAIC00MCw2ICszOSwxMSBAQCBwdWJsaWM6CiAKICAg ICB2b2lkIHNldElzU3luY01lc3NhZ2UoYm9vbCk7CiAgICAgdm9pZCBzZXRTaG91bGREaXNwYXRj aE1lc3NhZ2VXaGVuV2FpdGluZ0ZvclN5bmNSZXBseShib29sKTsKKworICAgIGNvbnN0IGNoYXIq IG1lc3NhZ2VOYW1lKCkgY29uc3QgeyByZXR1cm4gbV9tZXNzYWdlTmFtZTsgfQorCitwcml2YXRl OgorICAgIGNvbnN0IGNoYXIqIG1fbWVzc2FnZU5hbWU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBJ UEMK