130777 2014-03-26 09:25:39 -0700 Fix a crash caused by track insertion after load() 2014-03-27 10:51:25 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 994594 0 bfulgham 2014-03-26 09:25:39 -0700 Merge the following Blink change: Fix a crash caused by track insertion after load(). This patch fixes a crash caused by stale LoadMediaResource flag in m_pendingActionFlags when load() is explicitly called on a media element. The insertion of a <track> element triggers the crash by triggering the scheduling of the m_loadTimer, which ends up using the stale flag data when the timer fires. The fix is to clear the LoadMediaResource flag from m_pendingActionFlags when a new load is initiated. BUG=356352 TEST=LayoutTests/media/track/track-insert-after-load-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170003 994596 1 227853 bfulgham 2014-03-26 09:41:07 -0700 Created attachment 227853 Patch 994971 2 227853 commit-queue 2014-03-27 10:51:20 -0700 Comment on attachment 227853 Patch Clearing flags on attachment: 227853 Committed r166362: <http://trac.webkit.org/changeset/166362> 994972 3 commit-queue 2014-03-27 10:51:25 -0700 All reviewed patches have been landed. Closing bug. 227853 2014-03-26 09:41:07 -0700 2014-03-27 10:51:20 -0700 Patch bug-130777-20140326094046.patch text/plain 3855 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjI5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTI2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBhIGNyYXNoIGNhdXNl ZCBieSB0cmFjayBpbnNlcnRpb24gYWZ0ZXIgbG9hZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA3NzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBtZWRpYS90cmFjay90cmFjay1pbnNlcnQt YWZ0ZXItbG9hZC1jcmFzaC5odG1sCisKKyAgICAgICAgQmFzZWQgb24gdGhlIEJsaW5rIGNoYW5n ZSAocGF0Y2ggYnkgYWNvbHdlbGxAY2hyb21pdW0ub3JnKToKKyAgICAgICAgaHR0cHM6Ly9jb2Rl cmV2aWV3LmNocm9taXVtLm9yZy8yMTEzNzMwMDkvCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6cGFyc2VB dHRyaWJ1dGUpOiBSZW1vdmUgc3RhbGUgTG9hZE1lZGlhUmVzb3VyY2UgZmxhZyBhZnRlciBleHBs aWNpdCBsb2FkLgorCiAyMDE0LTAzLTI2ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1MgV2ViS2l0Ml0gRmx1c2ggYWxsIHN1cmZhY2VzIGFmdGVy IHBhaW50aW5nIGludG8gYWxsIG9mIHRoZW0sIGluc3RlYWQgb2YgYWZ0ZXIgcGFpbnRpbmcgaW50 byBlYWNoIG9uZQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CShyZXZpc2lvbiAxNjYyNTApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDEsNiArOTQxLDggQEAgdm9pZCBIVE1MTWVkaWFF bGVtZW50OjpwcmVwYXJlRm9yTG9hZCgpCiAgICAgLy8gUGVyZm9ybSB0aGUgY2xlYW51cCByZXF1 aXJlZCBmb3IgdGhlIHJlc291cmNlIGxvYWQgYWxnb3JpdGhtIHRvIHJ1bi4KICAgICBzdG9wUGVy aW9kaWNUaW1lcnMoKTsKICAgICBtX2xvYWRUaW1lci5zdG9wKCk7CisgICAgLy8gRklYTUU6IEZp Z3VyZSBvdXQgYXBwcm9wcmlhdGUgcGxhY2UgdG8gcmVzZXQgTG9hZFRleHRUcmFja1Jlc291cmNl IGlmIG5lY2Vzc2FyeSBhbmQgc2V0IG1fcGVuZGluZ0FjdGlvbkZsYWdzIHRvIDAgaGVyZS4KKyAg ICBtX3BlbmRpbmdBY3Rpb25GbGFncyAmPSB+TG9hZE1lZGlhUmVzb3VyY2U7CiAgICAgbV9zZW50 RW5kRXZlbnQgPSBmYWxzZTsKICAgICBtX3NlbnRTdGFsbGVkRXZlbnQgPSBmYWxzZTsKICAgICBt X2hhdmVGaXJlZExvYWRlZERhdGEgPSBmYWxzZTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjI5NykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAzLTI2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBhIGNyYXNoIGNhdXNlZCBieSB0cmFjayBpbnNlcnRpb24gYWZ0ZXIgbG9hZCgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzA3NzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBtZWRp YS90cmFjay90cmFjay1pbnNlcnQtYWZ0ZXItbG9hZC1jcmFzaC5odG1sCisKKyAgICAgICAgQmFz ZWQgb24gdGhlIEJsaW5rIGNoYW5nZSAocGF0Y2ggYnkgYWNvbHdlbGxAY2hyb21pdW0ub3JnKToK KyAgICAgICAgaHR0cHM6Ly9jb2RlcmV2aWV3LmNocm9taXVtLm9yZy8yMTEzNzMwMDkvCisKKyAg ICAgICAgKiBtZWRpYS90cmFjay90cmFjay1pbnNlcnQtYWZ0ZXItbG9hZC1jcmFzaC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNrLWluc2VydC1hZnRlci1s b2FkLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAzLTI2ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgTGF5b3V0VGVzdHMgdG8gZGVwZW5kIG9uIGxv YWQgZXZlbnRzIHJhdGhlciB0aGFuIG9uIHN0YXJ0aW5nIGxvYWRzIHN5bmNocm9ub3VzbHkKSW5k ZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWluc2VydC1hZnRlci1sb2FkLWNyYXNo LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFj ay1pbnNlcnQtYWZ0ZXItbG9hZC1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1pbnNlcnQtYWZ0ZXItbG9hZC1jcmFzaC1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1IEBACitUZXN0cyB0aGF0IGluc2Vy dGluZyBhIDx0cmFjaz4gZWxlbWVudCBpbW1lZGlhdGVseSBhZnRlciBhIGxvYWQoKSBkb2Vzbid0 IGNyYXNoLgorCisKK0VORCBPRiBURVNUCisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLWluc2VydC1hZnRlci1sb2FkLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svdHJhY2staW5zZXJ0LWFmdGVyLWxvYWQtY3Jhc2guaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWluc2VydC1hZnRlci1s b2FkLWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxOCBAQAorPCFET0NUWVBF ICBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSIuLi9tZWRp YS1maWxlLmpzIj48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii4uL3ZpZGVvLXRlc3Qu anMiPjwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgIDxwPlRlc3RzIHRo YXQgaW5zZXJ0aW5nIGEgJmx0O3RyYWNrJmd0OyBlbGVtZW50IGltbWVkaWF0ZWx5IGFmdGVyIGEg bG9hZCgpIGRvZXNuJ3QgY3Jhc2guPC9wPgorICAgICAgPHZpZGVvIGlkPSJ2Ij48L3ZpZGVvPgor ICAgICAgPHNjcmlwdD4KKyAgICAgICAgdmFyIHYgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCcj dicpOworICAgICAgICB2LnNyYyA9IGZpbmRNZWRpYUZpbGUoJ3ZpZGVvJywgJy4uL2NvbnRlbnQv dGVzdCcpOworICAgICAgICB2LmxvYWQoKTsKKyAgICAgICAgdi5hcHBlbmRDaGlsZChkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCd0cmFjaycpKTsKKyAgICAgICAgdi5hZGRFdmVudExpc3RlbmVyKCds b2FkZWRtZXRhZGF0YScsIGVuZFRlc3QpOworICAgICAgPC9zY3JpcHQ+CisgICAgPC9ib2R5Pgor PC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK